summaryrefslogtreecommitdiff
path: root/sc/inc
AgeCommit message (Collapse)Author
2019-08-12Fix typosAndrea Gelmini
Change-Id: I94d0e85c731801b8b0ec844ae2a8f268b2f1022e Reviewed-on: https://gerrit.libreoffice.org/77256 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-08-07tdf#126673 Auto-fit column and auto-fit row don't work with line breakNoel Grandin
Revert "tdf#94677 Calc is slow opening large CSV, avoid reset SetUpdateMode" This reverts commit c47d0174f2c6c3ebcb3b33276d0277e7aceac330. Change-Id: I38e065d44dfb9d08498176b8231aff14ff51d91c Reviewed-on: https://gerrit.libreoffice.org/77109 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-31Improved loplugin:stringconstant (now that GCC 7 supports it): scStephan Bergmann
Change-Id: I1bfd2bb623aac5ac457a0b719da64ab393ccd0ba Reviewed-on: https://gerrit.libreoffice.org/76654 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-07-29Drop ScDataPilotFieldObj::HasStringArkadiy Illarionov
Use comphelper::findValue instead Change-Id: I59a3ef2781643dfdb7ecbfe578fb9e1faebb0c42 Reviewed-on: https://gerrit.libreoffice.org/76502 Tested-by: Jenkins Reviewed-by: Arkadiy Illarionov <qarkai@gmail.com>
2019-07-29revert bits of "loplugin:sequentialassign"Noel Grandin
from commit 0d36b32755ac662299e6a8165e9fa57311b74a2f Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Sun Jul 28 12:03:35 2019 +0200 loplugin:sequentialassign which were false positives and not meant to be committed Change-Id: I6f2f185bd3564c9329f5a0c78c9020f3ddb52d34 Reviewed-on: https://gerrit.libreoffice.org/76518 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-29loplugin:sequentialassignNoel Grandin
Change-Id: I56a9bf698b60bd278c71cc632aacef2bd2f4c13f Reviewed-on: https://gerrit.libreoffice.org/76501 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-27cid#1401328 Uncaught exceptionCaolán McNamara
Change-Id: I1c4bdd4afec30d7d52054d8c9bd4958191c480f8 Reviewed-on: https://gerrit.libreoffice.org/76470 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-26cid#1401334 Uncaught exceptionCaolán McNamara
Change-Id: I6eaf41e5a2761c7c2d9f44c908720bebc53178a5 Reviewed-on: https://gerrit.libreoffice.org/76353 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-24Fix typoAndrea Gelmini
"an URI", to complete: https://gerrit.libreoffice.org/#/c/75985/ Change-Id: I57489b05117fd12ae6aa22544437ab5bc6b5154f Reviewed-on: https://gerrit.libreoffice.org/76037 Tested-by: Jenkins Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>
2019-07-24convert AreaOverlapType to scoped enumNoel Grandin
and remove unused AreaPartialOverlap Change-Id: I21e94d8d15c59485c1287e99dcc6558e0570a8eb Reviewed-on: https://gerrit.libreoffice.org/76234 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-23close some more holes in structuresNoel Grandin
and improve the pahole script so I can just run it once over the whole codebase Change-Id: I7e1775974a3a61f8c0e40646158f01163ace60cc Reviewed-on: https://gerrit.libreoffice.org/76122 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-22cid#1401328 Uncaught exceptionCaolán McNamara
Change-Id: I7b038954fbe6b4a5d463c543313a424c4a6aabdc Reviewed-on: https://gerrit.libreoffice.org/76090 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-20cid#1448465 Uncaught exceptionCaolán McNamara
Change-Id: Ic70f0926b4e26f82045a791eadf6af1e9d7949a9 Reviewed-on: https://gerrit.libreoffice.org/76009 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-17tdf#121039 "Open hyperlink" from context menu does not workSamuel Mehrbrodt
Change-Id: I802a4a64d48befa9c41b7095416f165082a155f2 Reviewed-on: https://gerrit.libreoffice.org/75778 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-07-17tdf#126393 Select cell even when clicking on a hyperlinkSamuel Mehrbrodt
and the hyperlink isn't being opened anyway (no ctrl clicked e.g.) Change-Id: Ic0c0df9b91000a8e661075901e8bfdb7167081f9 Reviewed-on: https://gerrit.libreoffice.org/75730 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-07-17tdf#126315 - Tooltip for drop-down widget in Formula barHeiko Tietze
Change-Id: If2379ab939f6f9bffeddfab64ac2c6da927e841b Reviewed-on: https://gerrit.libreoffice.org/75691 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2019-07-11Deduplicate URL tooltip creationSamuel Mehrbrodt
Change-Id: I94eb40ff4d727029ad764a381df300beee90481c Reviewed-on: https://gerrit.libreoffice.org/75409 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-07-09tdf#42949 Fix IWYU warnings in sc/incGabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. New IWYU and recent developments in f-u-i helped to identify some non self contained files, those were fixed too. Change-Id: I3b33b0dee7d7c9afc136510898039cab53990ddf Reviewed-on: https://gerrit.libreoffice.org/74980 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-07-08tdf#126192 (Related) Translate automatic chart axis labels in xlsGabor Kelemen
Automatic axis labels in xls format are created on a different code path than the ones in OOXML, translate these too Change-Id: Id1e8a10accf765d40d71c4fcdfec2c1acee832a2 Reviewed-on: https://gerrit.libreoffice.org/75202 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2019-07-08tdf#124840 Text for confirming updating external links should beRoman Kuznetsov
"Allow updating" instead "Enable Content" Change-Id: Ife53dafc1b72ebe8665a5c74a75e422a54f56136 Reviewed-on: https://gerrit.libreoffice.org/75081 Tested-by: Jenkins Reviewed-by: Roman Kuznetsov <antilibreoffice@gmail.com>
2019-07-08sc: the type is not Data, but DateTakeshi Abe
Change-Id: I32105e1f40ddb0c206d62f30f66054b7dbe803d0 Reviewed-on: https://gerrit.libreoffice.org/74594 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2019-07-04tdf#42949 Fix IWYU warnings in sc/source/ui/unoobj/*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I9b4111f2b4ccea71a491f2412f0d02ce5a7f64f7 Reviewed-on: https://gerrit.libreoffice.org/74570 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-06-28tdf#126030 (related) Translate automatic chart title in XLS chartsGabor Kelemen
The same string for XLS format is on a different code path localize it too, just in case Change-Id: Iacaf59080cc320498867680fc13836edbe9afe49 Reviewed-on: https://gerrit.libreoffice.org/74820 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2019-06-26tdf#113112 insert a new sheet slowNoel Grandin
We were spending vast amounts of time in ScColumn::EndListening calling set_empty on the mdds_vector, which moved the block data around. So walk backwards through the data, which means we will delete from the end, and largely avoid any expensive moving around. Change-Id: I78cbecedf137972fb2a1b7042635f4e7b03d77ff Reviewed-on: https://gerrit.libreoffice.org/74738 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-25tdf#94677 Calc is slow opening large CSV, avoid reset SetUpdateModeNoel Grandin
Avoid resetting SetUpdateMode in CreateFieldEditEngine while calculating row height. This takes the time from 1m25 to 49s for me. Change-Id: If406eac1a8b031f1734d9c2376c413dfa22d89f8 Reviewed-on: https://gerrit.libreoffice.org/74630 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-21reference childwins are all weldedCaolán McNamara
Change-Id: I050b4bdff4eaa645316538725c69e83bee4a90c5 Reviewed-on: https://gerrit.libreoffice.org/74526 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-06-18tdf#39593 Remove ScModelObj::getImplementationArkadiy Illarionov
Replace with comphelper::getUnoTunnelImplementation. Change-Id: I06a8db37b5c5c38c52a15a76e6e2df3b431a2040 Reviewed-on: https://gerrit.libreoffice.org/74237 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-06-08loplugin:unusedmethodsNoel Grandin
Change-Id: I52efd8d843d0e4cc7a6adefb0eb95aa50469af38 Reviewed-on: https://gerrit.libreoffice.org/73693 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-07lok: re-factor getTextSelection.Michael Meeks
Change-Id: I2c27c213ee980e19d6020e9599b2b72115e7f28e Reviewed-on: https://gerrit.libreoffice.org/73626 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2019-06-04Resolves: tdf#123752 allow group separator in formula values if possibleEike Rathke
If possible here means if it can't be an operator (is not an ASCII value) and is not any other separator. This restores the "working by chance" behaviour for some locales that use NO-BREAK SPACE as group separator. It never worked for locales that use one of the "ordinary" comma or dot or apostrophe group separator and will not. Change-Id: I8b7ba1b502b6b7367ffb2199d2f3922ab605a659 Reviewed-on: https://gerrit.libreoffice.org/73422 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2019-06-03tdf#39593 use UNO3_GETIMPLEMENTATION* macrosArkadiy Illarionov
Change-Id: I4e9af3b43a5baf19e100f42b3f37a2ade89ada5d Reviewed-on: https://gerrit.libreoffice.org/73320 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-05-20tdf#99938 : Allow batch of formula-cells to be written...Dennis Francis
using a single undo document from ScMovingAverageDialog rather than write tons of formula-cells to the document one by one thus creating that many number of undo docs unnecessarily. Change-Id: I2528e0ab47f83e0c5ea40c73d00db5af14f656e0 Reviewed-on: https://gerrit.libreoffice.org/71823 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2019-05-20cache mdds positions during ScDocument::CopyBlockFromClip() (tdf#112000)Luboš Luňák
Make RefUpdateContext and ScColumn::UpdateReferenceOnCopy() use the same sc::ColumnBlockPositionSet that CopyFromClipContext uses. Without it pathological cases like in tdf#112000 trigger quadratic cost because of repeated mdds searches from the start. Includes also an mdds patch that allows it to search backwards from a position hint. Without it, this would be very difficult to fix otherwise, as CopyFromClip() in ScDocument::CopyBlockFromClip() moves the position hint past the area that UpdateReferenceOnCopy() would use. It also just plain makes sense to try to go backwards in an std::vector. Change-Id: I985e3a40e4abf1a824e55c76d82579882fa75cc2 Reviewed-on: https://gerrit.libreoffice.org/72424 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-05-18tdf#125254 Performance: A spreadsheet opens too slow, part2Noel Grandin
Optimise bulk construction of ScMarkArray. This takes the opening time from 46s to 40.5s for me. Change-Id: I3955fe9b2c3113dac2ae3cda97d692de1975e762 Reviewed-on: https://gerrit.libreoffice.org/72418 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-05-18Adapt AutoFormatHelper to std::unique_ptrArmin Le Grand
Change-Id: I3087a7e95e73dbcda798ca62705f7941a6466ccb Reviewed-on: https://gerrit.libreoffice.org/72401 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2019-05-17Resolves tdf#87965 - Make 'Search Results' dialog optionalheiko tietze
* Option introduced at Tools > Options > Calc > View (Windows) * Convenience checkbox added to the dialog Change-Id: Ic30fb302e61e77b0eefacd504f61f955bcf6e595 Reviewed-on: https://gerrit.libreoffice.org/71910 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
2019-05-16document ScMarkArray a littleNoel Grandin
because it took a loooong time staring at the code to figure it out Change-Id: Ia8f3b835cd7d18737e4b0ffe1aa67ad001822d82 Reviewed-on: https://gerrit.libreoffice.org/72395 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-05-16optimize ScHTMLExport::WriteTables() with large columnsLuboš Luňák
Again, unless given a hint, mdds always starts a search from the beginning of the container, so iterating over a column becomes quadratic. Shows when selecting (the title of) a large column with different value types, e.g. in tdf#120558, which triggers setting the selection from VclQt5Clipboard::setContents(), which calls this. Change-Id: Ida009c5ddf18ccdc8dff88c15530cc7e33ce80e7 Reviewed-on: https://gerrit.libreoffice.org/72366 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-05-16cache mdds access in ScTable::ValidQuery() (tdf#80853)Luboš Luňák
Once more, mdds always searches from the start of the container, so iterating is quadratic. Change-Id: I8f8f3b5aad5c3342a10c21df3ad2d0d3fcaea8ad Reviewed-on: https://gerrit.libreoffice.org/72368 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-05-15cache cell positions when opening standard filter in calc (tdf#80853)Luboš Luňák
Part of the performance problem in the bugreport. Mdds otherwise always starts a search from the beginning of the contaier. Change-Id: Ic5c542220b7a8dc3aec0cfa93a0888997435fbfe Reviewed-on: https://gerrit.libreoffice.org/72347 Tested-by: Jenkins Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
2019-05-15tdf#123762 Cell anchored object is deleted if cell is deletedIlhan Yesil
If an object is anchored to a cell, then it is expected that this object belongs to this cell and it's survive after a deletion of the cell makes no sense. So the anchored object will be deleted together with the cell. Objects anchored to the page are not affected. Change-Id: I91f24bf92ab5329aba1d053b3cf5fba77bf16e4f Reviewed-on: https://gerrit.libreoffice.org/69390 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2019-05-14cache cell positions when searching in calc (tdf#108347)Luboš Luňák
The document has a large number of rows, and mdds normally always searches from the first item when looking up the container position, which leads to a quadratic cost when searching the entire sheet. GetCellValue() already has a variant that caches the last position, so just use it (and make sure to invalidate if it's search&replace and something changes). Change-Id: I26da60cebf641e10ed92e548fe5f9016900d3cf0 Reviewed-on: https://gerrit.libreoffice.org/72290 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-05-13Make it more obvious that there are no named rangesKatarina Behrens
and thus the selected doc can't be used as the source of external data for this sheet. In other words, help the user figure out why is OK button disabled Change-Id: Ie1b999c9c3640397e9f6f6ee321d3a5a5d63fa3b Reviewed-on: https://gerrit.libreoffice.org/72075 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2019-05-12regenerate PCH headersLuboš Luňák
Change-Id: I4894023e42cbfa32916ee3ddfb2cfb5426cfc69f Reviewed-on: https://gerrit.libreoffice.org/72195 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-05-12weld ScDataFormDlgCaolán McNamara
Change-Id: I656a11f5f9c55913cede710cf48543384132129d Reviewed-on: https://gerrit.libreoffice.org/72199 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-12Use hasElements to check Sequence emptiness in sax..sdextArkadiy Illarionov
Similar to clang-tidy readability-container-size-empty Change-Id: If6a567708d3c59355d54933fad23c85195846624 Reviewed-on: https://gerrit.libreoffice.org/71763 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-05-11weld ScCondFormatManagerDlgCaolán McNamara
Change-Id: Iccf2657f2c8fe98b4e975936fb75d56fc9523b5a Reviewed-on: https://gerrit.libreoffice.org/72162 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-11weld conditional formattingCaolán McNamara
Change-Id: Ia9c99a17d5a95d67a412cfde959192c99caa70be Reviewed-on: https://gerrit.libreoffice.org/71956 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-10an uno -> a unoCaolán McNamara
Change-Id: I538db88f8477dd2d2ad25c372928fec6c11d979d Reviewed-on: https://gerrit.libreoffice.org/72105 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-10tdf#62699 Drop pass-through header file include/svx/svdattr.hxxGabor Kelemen
Change-Id: I04289589196ac69b31f75989d9252c79d03c890f Reviewed-on: https://gerrit.libreoffice.org/71633 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
generated by cgit (git 2.34.1) at 2025-01-01 16:35:39 +0000