summaryrefslogtreecommitdiff
path: root/sc/inc
AgeCommit message (Collapse)Author
30 hoursUBSan apparently needs ScDatabaseRangeObj RTTI nowStephan Bergmann
...as CppunitTest_sc_dataprovider started to fail with > [_RUN_____] ScDataProvidersTest::testCSVImport > warn:sal.osl:2875534:2875534:sal/osl/unx/module.cxx:103: dlopen(/home/sberg/lo/core/instdir/program/libscfiltlo.so, 1): /home/sberg/lo/core/instdir/program/libscfiltlo.so: undefined symbol: _ZTI18ScDatabaseRangeObj Change-Id: I4c75c770951dd7ed6506ecd35fd574c28c41381d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182995 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2 daysMove code applying functor to selection from ScColumnData to ScTableMike Kaganski
Helps in a following optimization work. Change-Id: I303432fe783ec2c7eb29196a5f6704cde24c8c1d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182930 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
3 daystdf#48140 Replace XDatabaseRange with ScDatabaseRangeObjDeepanshu Sharma
Co-authored-by: Oromidayo Owolabi <owolabioromidayo16@gmail.com> Change-Id: Idcea0e26edad071cb7af05c89022f477564136ca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182858 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
5 daysAdd a test case for importing autofilter from Excel 2003 XMLKohei Yoshida
Change-Id: If5479128219ebc846ab2255dbaaff51a2edf5ac9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182848 Tested-by: Jenkins Reviewed-by: Kohei Yoshida <kohei@libreoffice.org>
7 dayscrashtesting: crash on reimport of xlsx output of forum-pl-2758.odsCaolán McNamara
also seen as a leak as nothing is erased by: maRegisteredCellAttributes.erase(&rCandidate); once the style names are changed and the std::set isn't ordered according to its predicate anymore. Easiest thing to do here seems to run the rename of a cell style through CellAttributeHelper so it can reinsert the affected ScPatternAttrs Change-Id: I13486701f378228792baa2b378709b7d530c3770 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182743 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
10 daysImport autofilter via orcus interfaceKohei Yoshida
This should address tdf#154311. Change-Id: I84401ad7a9982eaa868e68d7ae612debf09ecf9e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182606 Tested-by: Jenkins Reviewed-by: Kohei Yoshida <kohei@libreoffice.org>
10 daysuse more concrete UNO in scNoel Grandin
Change-Id: Id339156cd7f9b74985575a200ed3946c6d3e5d8c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182622 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
10 dayscool#11258 move Language into the cache keyCaolán McNamara
setMisspellRanges complicates things somewhat, so return the cell language from getMisspellRanges and propogate that along with the misspelled range so SetAutoSpellData can transport the Language back to setMisspellRanges Presumably we can assume that the cell language in ScInputHandler::EnterHandler2 is that of the EditEngine for the case of freshly created MisspellRanges. https://github.com/CollaboraOnline/online/issues/11258 Change-Id: I93bb869eacbab8ebec875e891d1ed42512cdf9a7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182627 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
13 daysmake consistent parameter names and descriptions of Calc functionsStanislav Horacek
that have been added recently Change-Id: I29e2878ef268126dd97ed31381ecaa328a9001c6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182499 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2025-02-27tdf#90293 switch draw selection to rotate modeOliver Specht
Clicking a draw object(selection) switches to rotate mode and back in Calc/Writer like it is done in Draw/Impress already. By default this function is off an can be activated in via toolbar Drawing Change-Id: I4a11d008e7df97c5278cae987d5c47fa50cddf14 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181169 Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de> Tested-by: Jenkins Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
2025-02-26simplify the SearchMode enumsNoel Grandin
there only needs to be one enum, not two Change-Id: Idb8c0c37737505cf6c28f26c0024c3c21a19fbb9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182202 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2025-02-26speed up display of XLSX with lots of conditional formattingNoel Grandin
The biggest win here is the call to ShrinkToUsedDataArea, because otherwise, we end up iterating over 16384 columns, most of which are empty Change-Id: I92f90b82b66b3a3997890cb22432482e10f7f960 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182178 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2025-02-20Make the char tables referenced from ScCompiler::Convention constexprMike Kaganski
Change-Id: Ifd569145acbde2925c71b9969fee1ebd6eb1bde6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181702 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2025-02-12tdf#165119 Also fix # of param for VSTACK, HSTACKOlivier Hallot
+ based on https://gerrit.libreoffice.org/c/core/+/181439 Change-Id: I86c7e534bda881d84b47e81c9f36fd1cafbf59d9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181506 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2025-02-11tdf#165119: fix number of parameters in CHOOSECOLS/CHOOSEROWSXisco Fauli
Change-Id: I39fee81e0fc8aaa33265a3539bd4e6dff5d9d2e8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181439 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2025-02-10Improve description of new Calc array function argumentsOlivier Hallot
Change-Id: Idc93a820563601e763595cd5d3f34fd6889669e8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181276 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2025-02-08Upgrade mdds to 3.0.0 and liborcus to 0.20.0Kohei Yoshida
The portion of this change related to the mdds upgrade has been done by Xisco Fauli via https://gerrit.libreoffice.org/c/core/+/180862 mdds 3.0.0 * external/mdds/0001-cid-1546160-COPY_INSTEAD_OF_MOVE.patch.1 is fixed upstream * external/mdds/use-after-free.patch is fixed upstream Downloaded from https://gitlab.com/api/v4/projects/mdds%2Fmdds/packages/generic/source/3.0.0/mdds-3.0.0.tar.xz liborcus 0.20.0 * Pick up superscript and subscript text attributes. * Update the import of the font underline attributes as well as the strikethrough attributes applied to the cells. * Pick up the underline and strikethrough attributes in rich text strings. * Implementation for the previous auto filter interface has been removed for now. Downloaded from https://gitlab.com/api/v4/projects/orcus%2Forcus/packages/generic/source/0.20.0/liborcus-0.20.0.tar.xz Change-Id: I93f6e5ab961d707a2bae03a4eca1466c541f086e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181282 Tested-by: Jenkins Reviewed-by: Kohei Yoshida <kohei@libreoffice.org>
2025-02-04make calc Display config listen for changesCaolán McNamara
Change-Id: I36a9118f8a29ccd543da9510e9ecf11ebf02b2f5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181131 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2025-02-04tdf#150867: Add support for VSTACK functionXisco Fauli
Change-Id: I76e3267f45a0d035f6a79af934b9ce2c606b4b89 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181120 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins
2025-02-04tdf#150868: Add support for HSTACK functionXisco Fauli
Change-Id: I105ffabc8dd1fa58bf3acec4a81c3217061d3a26 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181100 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins
2025-02-04No longer use std::optional for SfxModule::CreateStyleFamiliesMichael Weghorn
Just return an empty std::vector instead of a std::optional that contains no value in the default implementation, and adjust the type of the local variables and class members that contain the result and their use accordingly. Change-Id: I4e25b3cbd96c6eb9f06b0ae44b36675bb11ab38a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181024 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2025-02-01tdf#151000: Add support for CHOOSECOLS functionXisco Fauli
Change-Id: Id183f79a148080adebe652f63e29716910c638b2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180992 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2025-01-30tdf#150999: Add support for CHOOSEROWS functionXisco Fauli
Change-Id: If7de1b243a6040424a5712ba28017176b7e36101 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180955 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2025-01-29tdf#164900 table text in different columns no longer lined upNoel Grandin
Revert "tdf#161846 use unordered_map in SfxItemPropertyMap" This reverts commit c39978f41dccbeb2e973c919a67d9b1d974f8f3c. Change-Id: I26cadb32b426fd3b48179b67c677213a78b4999c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180903 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2025-01-25Resolves: tdf#164853 find_if causing copyCaolán McNamara
the pred param of: const std::pair<QueryKey, QueryCriteriaAndResult>& doesn't exactly match what the arg should be, which is const std::pair<const QueryKey, QueryCriteriaAndResult>& so an unecessary copy is silently created, add and use some typedefs to make this more straightforward. seen with: perf record -e mem_load_l3_hit_retired.xsnp_fwd -e mem_load_l3_hit_retired.xsnp_miss on profiling specifically for contested accesses, see tma_contested_accesses in perf -v Change-Id: I1d1a57e49a0f2af8bc57ca22ac4572c0246c719b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180753 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2025-01-24tdf#151001: Add support for EXPAND functionXisco Fauli
Change-Id: I4eabd526d656c13da7792d3c195f036ce78bd0d9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180706 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2025-01-24tdf#150998: Add support for DROP functionXisco Fauli
Change-Id: Id84cbf25e655410c3fac655cd88f1d74dc98defd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180673 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2025-01-23tdf#150997: Add support for TAKE functionXisco Fauli
Change-Id: I2e7d223707941d31db0330282f783e845497130b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180622 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2025-01-22tdf#150880: Add support for WRAPROWS functionXisco Fauli
Change-Id: I44341835403c068a61cfb79185aeabe6daf32f70 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180598 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2025-01-22Introduce ScConditionalFormatList::Clone and use it to simplifyMike Kaganski
Potentialy could also return a unique_ptr, would need to change the methods where the result is passed. Change-Id: I9cbd876e446094b93e2d6f72b16aefe58327e7d2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180572 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2025-01-22tdf#150881: Add support for WRAPCOLS functionXisco Fauli
Change-Id: Ie152a83dcb7bf16f7a92ab55fd801270658a2e9e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180365 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2025-01-21cid#1465236 Uncaught exceptionCaolán McNamara
and drop coverity workarounds Change-Id: If9ffc607999285b2f5b63e85c51b0289fb05750f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180531 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2025-01-18cid#1640473 COPY_INSTEAD_OF_MOVECaolán McNamara
Change-Id: Id8e440ea08e2d6a853e870dc0161d30e63b75cc9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180436 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2025-01-17sc: make data validy error dialog async (invalid value error)Pranam Lashkari
Change-Id: Icd077776b26e21b226b4dee5beb1a5ff6dcf301a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179509 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> (cherry picked from commit 495be2dcb34d22af59a2028d3a686a0d48774166) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180286 Tested-by: Jenkins Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
2025-01-16tdf#150878: Add support for TOROW functionXisco Fauli
Change-Id: Ic1acb5c2fd08ecab7c3ee059888cf44aa45ee287 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180308 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2025-01-15tdf#150879: Add support for TOCOL functionXisco Fauli
Change-Id: I0c8bfdd8f9b806a1260cceace1ced4be2b046abb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180245 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de> Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins
2025-01-10ITEM: Refactor ItemTypeArmin Le Grand (Collabora)
ItemType is useful and faster than RTTI. Until now it was implemented by a 16-bit member in the base class, plus (potentially) all constructors having to hand a value in at item construction type (of type SfxItemType) to get that member set correctly. This works, but there is no reliable way to guarantee coverage, and there have already been cases with missing SfxItemType - these fallback to '0' and thus all Items with ItemType() == 0 are assumed equal and might be static_cast'ed to the wrong classes. Note that I identified *35* Items that had no correct ItemType set/implemented actually. It also uses 16-bit per incarnated Item at runtime. I thought and realized now a more systematic approach to do that with a pure virtual function at the Item itself. That can also be secured by a clang compiler plugin in the future to keep it working. It uses one virtual function per derived class, no longer space in incarnated Items. Also the constructors will get more simple again. But the main aspect is security - we cannot afford Items potentially being held as equal if they are not. Unfortunately C++ does not offer something like a 'strict pure virtual function' that would force to be overloaded in every derivation, but the used methotology and adding a clang test is reasonably safe. Have now done the cleanup of previous method. Change-Id: I04768285f1e9b73d64b0bb87df401944b5d35678 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180017 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2025-01-09tdf#162286 Add a category to store favorite functions in FWAhmedHamed
Change-Id: Iec0d169570ba3d29501a4917d8858a9e9438f608 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171828 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2025-01-03Drop unneeded forward declarations from include/Gabor Kelemen
test drive the new bin/find-unneeded-includes --fwdecl mode Change-Id: I507fa2b172ec9e348d1d91066ea241f02187b5ed Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179321 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2024-12-23optimise ScBoundsProvider::GetIndexTowardsNoel Grandin
Especially when laying out rows in sheets with thousands of rows. By pushing the work down to a new GetRowForHeightPixels method, we can do the work in only a couple of iterations of the loop, because row heights are normally represented by only a few spans. Change-Id: If3f62a131a3e7a0794d7352d7c6c1a5de0ef2df0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179086 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-12-23tdf#42989: don't set fake ATTR_VALUE_FORMAT for multi-format selectionMike Kaganski
Change-Id: Iaed133b19c4d870ff85fd9d2dd69db36318bb28e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179190 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-12-19tdf#152299 - Remove unused define(s) from C/C++ filesBogdan Buzea
Change-Id: I9834c891e4b15c650c5a2600435283516ca7b2c6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177148 Reviewed-by: David Gilbert <freedesktop@treblig.org> Tested-by: Jenkins
2024-12-19tdf#152299 - Remove unused define(s) from C/C++ filesBogdan Buzea
Change-Id: If16e686ce726f6f05d84224ef30fc95813600791 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177146 Tested-by: Jenkins Reviewed-by: David Gilbert <freedesktop@treblig.org>
2024-12-19tdf#152299 - Remove unused define(s) from C/C++ filesBogdan Buzea
Change-Id: Ibdda74f8a779097ab189f77a62adff7a12330bd2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177145 Tested-by: Jenkins Reviewed-by: David Gilbert <freedesktop@treblig.org>
2024-12-10Silence -Werror,-Wunused-private-fieldStephan Bergmann
...in DBG_UTIL-only code introduced in 2e1f9da8a6359c8909e087a92239aefd4851b116 "Decouple ScPatternAttr from SfxItemPool", which only started to generate a warning now with Clang 20 trunk, presumably since <https://github.com/llvm/llvm-project/commit/d457100a8152cc2ebf8cd219caae92cc0f591156> "[Clang] Fix -Wunused-private-field false negative with defaulted comparison operators (#116871)" (and only warns about m_nSerialNumber, which is only written to in the ctor, but not about m_bDeleted, which is also written to in the dtor, even though neither of them appears to ever be read) Change-Id: Id7fb1cc1e082464d4c5b935bdd194edf92704505 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178202 Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de> Tested-by: Jenkins
2024-12-09tdf#157747 Add tooltip to Calc select all rowsAdesola Samuel
Added a tooltip that says "Click here to select all cells" to calc select all rows corner. The report shows a tooltip will suffice instead of an added icon Change-Id: I33f9bcb48f9185267be760219f58b196e4d5874d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178092 Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Tested-by: Jenkins
2024-12-08Simplify ScCellRangesBase and descendantsMike Kaganski
Change-Id: I2416ab8a9263bd7858e0d62055067b3c6132e0b7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178093 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-12-03Revert "sc: manage conditional format with simpler dialog"Pranam Lashkari
This reverts commit 58c3f70c514ef4ce0de5419ab7daa3bebfb96f37. Change-Id: I500a96508684547c158cdd1814540a4b24f667d9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177290 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177341 Tested-by: Jenkins
2024-12-03Revert "sc: added date condition option in conditional format manage dialog"Pranam Lashkari
This reverts commit 9928f1fa147d4ff838cbf6fcfe0d976ecef97cef. Change-Id: Ieb7dfdeccaffed4ad81ff9b5b0eb3b3b49fd8d05 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177289 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177340 Tested-by: Pranam Lashkari <lpranam@collabora.com>
2024-12-03Revert "sc: now formula conditions can be managedPranam Lashkari
...from condition format manager" This reverts commit 8374dd472cb4a2e2edab969a73ca88ffeaadbcd8. Change-Id: I532c17596adccfa5c88baaf2df897f3ffbee0fe6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177288 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177339 Tested-by: Pranam Lashkari <lpranam@collabora.com>
generated by cgit (git 2.34.1) at 2025-03-17 18:22:13 +0000