summaryrefslogtreecommitdiff
path: root/sc/inc
AgeCommit message (Collapse)Author
2 daysScQueryItem: no need to store a ScViewData pointerXisco Fauli
it can be passed by reference, like the other dialogs do Change-Id: I79abd717835012af8bcf8d4e135bd7e79f36ac35 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184783 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins
3 dayscool#11739 lok: sc: change dialog units per userJaume Pujantell
On lok different users might have different locales so they need different field units in their dialogues. Right now the metric used is always the one stored in the ScModule's AppOptions for all users. With this change, for lok SfxModule::GetFieldUnit is used because it already has the correct metric per lok user. Change-Id: If2b047874a26deecc7c43936ab267b75eae101e3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184567 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com> (cherry picked from commit d01737cb12654f488bb88235cdc562d3cf68d7db) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184741 Reviewed-by: Jaume Pujantell <jaume.pujantell@collabora.com> Tested-by: Jenkins
5 daysRemove obsolete fw declarations from sc/Gabor Kelemen
found with bin/find-unneeded-includes --fwdecl Change-Id: I04083a33ce1e7d85980da91f72c2dd85777b594d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183897 Tested-by: Jenkins Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
13 daystdf#163872 speed up IfJump operationNoel Grandin
shaves 10% off the load time here by moving the loop of the operation down into the matrix code where we can iterate direcltly over the data. Change-Id: I88f66d0ab3c7fc9e09ccffb96c0fd335daf62169 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184343 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2025-04-10tdf#162126 reduce allocation in hot pathNoel Grandin
Change-Id: Ib4184d496dc07ea2a0790b9c5ecdd269f7c84cb7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183954 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2025-04-06tdf#151876 shave some time off chart load (3)Noel Grandin
reduce the number of times we acquire/release the solarmutex in the hottest part of the load. Change-Id: I840e4b1bdb489319c6b03d9bfa69e761eb448831 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183756 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2025-04-06tdf#151876 shave some time off chart loadNoel Grandin
reduce the number of temporary UNO objects we create Change-Id: Ia429282e516610fd9ee2677bb930da9e02f6e43a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183750 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2025-04-06use more concrete UNO in scNoel Grandin
as a prelude to doing some optimisation Change-Id: Ia92f4c2f7a440c39c3180b262cde4ef83db7622a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183749 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2025-04-03tdf#74580 Simplify passing "Edit Filter Settings" to Filter DialogShardul Vikram Singh
Simplify passing the checkbox state of "Edit Filter Settings" to the Filter Dialog via ContextLayer. Change-Id: I6dd581a530de9e8634d515295d2dab978b1c8f8b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183646 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2025-04-01loplugin:unusedmethodsNoel Grandin
Change-Id: I07b1acf3d01bc0ceb6e5b2a6db260e6e7874379e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183571 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2025-03-28tdf#65872 Remove import dialog for normal paste in CalcShardul Vikram Singh
Remove the import dialog when performing a normal paste. Show the dialog only for Paste Special to avoid unnecessary interruptions. For normal paste, use the last selected preferences from Paste Special. Change-Id: Idfc985b9c13cb3b995c91e947e815d1789e6f041 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181225 Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Tested-by: Jenkins
2025-03-28[API CHANGE] tdf#74580 Add option to skip filter settings dialogShardul Vikram Singh
Introduce a new set of setting under org.openoffice.Office.UI/FilePicker to control whether the settings dialogs of filters always appears. Add an "Edit Filter Settings" checkbox to the File Open dialog, using the new API constant FILEOPEN_READONLY_VERSION_FILTEROPTIONS (TemplateDescription.idl) to show additional controls: "Read Only", "Filter Options", and "Version" listbox. Modify the Calc's Text Import filter settings dialog to include an "Always Show on Import" checkbox. Co-authored-by: Mike Kaganski <mike.kaganski@collabora.com> Change-Id: Ic7bea0036ae2db8f8ab223f48499fb0cc8b18425 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183055 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2025-03-28tdf#165658 Data Provider: Catch exception when importing CSVRafael Lima
Currently, the DataProvider parses the CSV in a separate thread. If an exception happens, LO crashes or freezes. With this patch, whenever a CSV parsing error happens, it gets caught and an error message is shown. Change-Id: Ia7e8facfe37f22d03647d94fcdf94ae0ecae10c1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182791 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2025-03-27loplugin:constparam in scNoel Grandin
Change-Id: I2aa9b016130918f15a33fadee7fb147aeba18559 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183370 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2025-03-20tdf#164322 Add "Clear AutoFilter" option in context menu of cellsUjjawal Kumar
Change-Id: Id0555f0e89e3e21010b36559bec0caefe63fe8d6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182755 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2025-03-19tdf#61313: Allow customization of conditional formatting operators in icon setsAhmedHamed3699
- Replaced the fixed >= operator with a dropdown to select different operators. - Applied the last valid condition for each cell. - Fixed an issue where importing an Excel spreadsheet with conditional formatting did not preserve conditions correctly. Change-Id: Id31522e825e51916db4870fbfb19519745e54660 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182760 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2025-03-16UBSan apparently needs ScDatabaseRangeObj RTTI nowStephan Bergmann
...as CppunitTest_sc_dataprovider started to fail with > [_RUN_____] ScDataProvidersTest::testCSVImport > warn:sal.osl:2875534:2875534:sal/osl/unx/module.cxx:103: dlopen(/home/sberg/lo/core/instdir/program/libscfiltlo.so, 1): /home/sberg/lo/core/instdir/program/libscfiltlo.so: undefined symbol: _ZTI18ScDatabaseRangeObj Change-Id: I4c75c770951dd7ed6506ecd35fd574c28c41381d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182995 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2025-03-15Move code applying functor to selection from ScColumnData to ScTableMike Kaganski
Helps in a following optimization work. Change-Id: I303432fe783ec2c7eb29196a5f6704cde24c8c1d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182930 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2025-03-14tdf#48140 Replace XDatabaseRange with ScDatabaseRangeObjDeepanshu Sharma
Co-authored-by: Oromidayo Owolabi <owolabioromidayo16@gmail.com> Change-Id: Idcea0e26edad071cb7af05c89022f477564136ca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182858 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2025-03-13Add a test case for importing autofilter from Excel 2003 XMLKohei Yoshida
Change-Id: If5479128219ebc846ab2255dbaaff51a2edf5ac9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182848 Tested-by: Jenkins Reviewed-by: Kohei Yoshida <kohei@libreoffice.org>
2025-03-10crashtesting: crash on reimport of xlsx output of forum-pl-2758.odsCaolán McNamara
also seen as a leak as nothing is erased by: maRegisteredCellAttributes.erase(&rCandidate); once the style names are changed and the std::set isn't ordered according to its predicate anymore. Easiest thing to do here seems to run the rename of a cell style through CellAttributeHelper so it can reinsert the affected ScPatternAttrs Change-Id: I13486701f378228792baa2b378709b7d530c3770 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182743 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2025-03-08Import autofilter via orcus interfaceKohei Yoshida
This should address tdf#154311. Change-Id: I84401ad7a9982eaa868e68d7ae612debf09ecf9e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182606 Tested-by: Jenkins Reviewed-by: Kohei Yoshida <kohei@libreoffice.org>
2025-03-07use more concrete UNO in scNoel Grandin
Change-Id: Id339156cd7f9b74985575a200ed3946c6d3e5d8c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182622 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2025-03-07cool#11258 move Language into the cache keyCaolán McNamara
setMisspellRanges complicates things somewhat, so return the cell language from getMisspellRanges and propogate that along with the misspelled range so SetAutoSpellData can transport the Language back to setMisspellRanges Presumably we can assume that the cell language in ScInputHandler::EnterHandler2 is that of the EditEngine for the case of freshly created MisspellRanges. https://github.com/CollaboraOnline/online/issues/11258 Change-Id: I93bb869eacbab8ebec875e891d1ed42512cdf9a7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182627 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2025-03-05make consistent parameter names and descriptions of Calc functionsStanislav Horacek
that have been added recently Change-Id: I29e2878ef268126dd97ed31381ecaa328a9001c6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182499 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2025-02-27tdf#90293 switch draw selection to rotate modeOliver Specht
Clicking a draw object(selection) switches to rotate mode and back in Calc/Writer like it is done in Draw/Impress already. By default this function is off an can be activated in via toolbar Drawing Change-Id: I4a11d008e7df97c5278cae987d5c47fa50cddf14 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181169 Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de> Tested-by: Jenkins Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
2025-02-26simplify the SearchMode enumsNoel Grandin
there only needs to be one enum, not two Change-Id: Idb8c0c37737505cf6c28f26c0024c3c21a19fbb9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182202 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2025-02-26speed up display of XLSX with lots of conditional formattingNoel Grandin
The biggest win here is the call to ShrinkToUsedDataArea, because otherwise, we end up iterating over 16384 columns, most of which are empty Change-Id: I92f90b82b66b3a3997890cb22432482e10f7f960 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182178 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2025-02-20Make the char tables referenced from ScCompiler::Convention constexprMike Kaganski
Change-Id: Ifd569145acbde2925c71b9969fee1ebd6eb1bde6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181702 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2025-02-12tdf#165119 Also fix # of param for VSTACK, HSTACKOlivier Hallot
+ based on https://gerrit.libreoffice.org/c/core/+/181439 Change-Id: I86c7e534bda881d84b47e81c9f36fd1cafbf59d9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181506 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2025-02-11tdf#165119: fix number of parameters in CHOOSECOLS/CHOOSEROWSXisco Fauli
Change-Id: I39fee81e0fc8aaa33265a3539bd4e6dff5d9d2e8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181439 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2025-02-10Improve description of new Calc array function argumentsOlivier Hallot
Change-Id: Idc93a820563601e763595cd5d3f34fd6889669e8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181276 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2025-02-08Upgrade mdds to 3.0.0 and liborcus to 0.20.0Kohei Yoshida
The portion of this change related to the mdds upgrade has been done by Xisco Fauli via https://gerrit.libreoffice.org/c/core/+/180862 mdds 3.0.0 * external/mdds/0001-cid-1546160-COPY_INSTEAD_OF_MOVE.patch.1 is fixed upstream * external/mdds/use-after-free.patch is fixed upstream Downloaded from https://gitlab.com/api/v4/projects/mdds%2Fmdds/packages/generic/source/3.0.0/mdds-3.0.0.tar.xz liborcus 0.20.0 * Pick up superscript and subscript text attributes. * Update the import of the font underline attributes as well as the strikethrough attributes applied to the cells. * Pick up the underline and strikethrough attributes in rich text strings. * Implementation for the previous auto filter interface has been removed for now. Downloaded from https://gitlab.com/api/v4/projects/orcus%2Forcus/packages/generic/source/0.20.0/liborcus-0.20.0.tar.xz Change-Id: I93f6e5ab961d707a2bae03a4eca1466c541f086e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181282 Tested-by: Jenkins Reviewed-by: Kohei Yoshida <kohei@libreoffice.org>
2025-02-04make calc Display config listen for changesCaolán McNamara
Change-Id: I36a9118f8a29ccd543da9510e9ecf11ebf02b2f5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181131 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2025-02-04tdf#150867: Add support for VSTACK functionXisco Fauli
Change-Id: I76e3267f45a0d035f6a79af934b9ce2c606b4b89 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181120 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins
2025-02-04tdf#150868: Add support for HSTACK functionXisco Fauli
Change-Id: I105ffabc8dd1fa58bf3acec4a81c3217061d3a26 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181100 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins
2025-02-04No longer use std::optional for SfxModule::CreateStyleFamiliesMichael Weghorn
Just return an empty std::vector instead of a std::optional that contains no value in the default implementation, and adjust the type of the local variables and class members that contain the result and their use accordingly. Change-Id: I4e25b3cbd96c6eb9f06b0ae44b36675bb11ab38a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181024 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2025-02-01tdf#151000: Add support for CHOOSECOLS functionXisco Fauli
Change-Id: Id183f79a148080adebe652f63e29716910c638b2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180992 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2025-01-30tdf#150999: Add support for CHOOSEROWS functionXisco Fauli
Change-Id: If7de1b243a6040424a5712ba28017176b7e36101 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180955 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2025-01-29tdf#164900 table text in different columns no longer lined upNoel Grandin
Revert "tdf#161846 use unordered_map in SfxItemPropertyMap" This reverts commit c39978f41dccbeb2e973c919a67d9b1d974f8f3c. Change-Id: I26cadb32b426fd3b48179b67c677213a78b4999c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180903 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2025-01-25Resolves: tdf#164853 find_if causing copyCaolán McNamara
the pred param of: const std::pair<QueryKey, QueryCriteriaAndResult>& doesn't exactly match what the arg should be, which is const std::pair<const QueryKey, QueryCriteriaAndResult>& so an unecessary copy is silently created, add and use some typedefs to make this more straightforward. seen with: perf record -e mem_load_l3_hit_retired.xsnp_fwd -e mem_load_l3_hit_retired.xsnp_miss on profiling specifically for contested accesses, see tma_contested_accesses in perf -v Change-Id: I1d1a57e49a0f2af8bc57ca22ac4572c0246c719b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180753 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2025-01-24tdf#151001: Add support for EXPAND functionXisco Fauli
Change-Id: I4eabd526d656c13da7792d3c195f036ce78bd0d9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180706 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2025-01-24tdf#150998: Add support for DROP functionXisco Fauli
Change-Id: Id84cbf25e655410c3fac655cd88f1d74dc98defd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180673 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2025-01-23tdf#150997: Add support for TAKE functionXisco Fauli
Change-Id: I2e7d223707941d31db0330282f783e845497130b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180622 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2025-01-22tdf#150880: Add support for WRAPROWS functionXisco Fauli
Change-Id: I44341835403c068a61cfb79185aeabe6daf32f70 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180598 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2025-01-22Introduce ScConditionalFormatList::Clone and use it to simplifyMike Kaganski
Potentialy could also return a unique_ptr, would need to change the methods where the result is passed. Change-Id: I9cbd876e446094b93e2d6f72b16aefe58327e7d2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180572 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2025-01-22tdf#150881: Add support for WRAPCOLS functionXisco Fauli
Change-Id: Ie152a83dcb7bf16f7a92ab55fd801270658a2e9e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180365 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2025-01-21cid#1465236 Uncaught exceptionCaolán McNamara
and drop coverity workarounds Change-Id: If9ffc607999285b2f5b63e85c51b0289fb05750f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180531 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2025-01-18cid#1640473 COPY_INSTEAD_OF_MOVECaolán McNamara
Change-Id: Id8e440ea08e2d6a853e870dc0161d30e63b75cc9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180436 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2025-01-17sc: make data validy error dialog async (invalid value error)Pranam Lashkari
Change-Id: Icd077776b26e21b226b4dee5beb1a5ff6dcf301a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179509 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> (cherry picked from commit 495be2dcb34d22af59a2028d3a686a0d48774166) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180286 Tested-by: Jenkins Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
generated by cgit (git 2.34.1) at 2025-05-02 03:35:56 +0000