summaryrefslogtreecommitdiff
path: root/sc/qa/extras/new_cond_format.cxx
AgeCommit message (Collapse)Author
2018-10-09Extend loplugin:redundantinline to catch inline functions w/o external linkageStephan Bergmann
...where "inline" (in its meaning of "this function can be defined in multiple translation units") thus doesn't make much sense. (As discussed in compilerplugins/clang/redundantinline.cxx, exempt such "static inline" functions in include files for now.) All the rewriting has been done automatically by the plugin, except for one instance in sw/source/ui/frmdlg/column.cxx that used to involve an #if), plus some subsequent solenv/clang-format/reformat-formatted-files. Change-Id: Ib8b996b651aeafc03bbdc8890faa05ed50517224 Reviewed-on: https://gerrit.libreoffice.org/61573 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-09-17New loplugin:externalStephan Bergmann
...warning about (for now only) functions and variables with external linkage that likely don't need it. The problems with moving entities into unnamed namespacs and breaking ADL (as alluded to in comments in compilerplugins/clang/external.cxx) are illustrated by the fact that while struct S1 { int f() { return 0; } }; int f(S1 s) { return s.f(); } namespace N { struct S2: S1 { int f() { return 1; } }; int f(S2 s) { return s.f(); } } int main() { return f(N::S2()); } returns 1, both moving just the struct S2 into an nunnamed namespace, struct S1 { int f() { return 0; } }; int f(S1 s) { return s.f(); } namespace N { namespace { struct S2: S1 { int f() { return 1; } }; } int f(S2 s) { return s.f(); } } int main() { return f(N::S2()); } as well as moving just the function f overload into an unnamed namespace, struct S1 { int f() { return 0; } }; int f(S1 s) { return s.f(); } namespace N { struct S2: S1 { int f() { return 1; } }; namespace { int f(S2 s) { return s.f(); } } } int main() { return f(N::S2()); } would each change the program to return 0 instead. Change-Id: I4d09f7ac5e8f9bcd6e6bde4712608444b642265c Reviewed-on: https://gerrit.libreoffice.org/60539 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-06-08look for unnecessary calls to Reference::is() after an UNO_QUERY_THROWNoel Grandin
Since the previous call would throw if there was nothing to be assigned to the value. Idea from tml. Used the following script to find places: git grep -A3 -n UNO_QUERY_THROW | grep -B3 -F 'is()' Change-Id: I36ba7b00bcd014bdf16c0455ab91056f82194969 Reviewed-on: https://gerrit.libreoffice.org/55417 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-03-09drop getColor() method of ColorNoel Grandin
no longer necessary Change-Id: I9e0fcea1134e8c5e27f9effbb5eb79fe5446e33d Reviewed-on: https://gerrit.libreoffice.org/50925 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-28convert COL_ constants to be of type ColorNoel Grandin
Change-Id: I0e25c8950ac26b851ff42f71e1471fcbe4770d48 Reviewed-on: https://gerrit.libreoffice.org/50373 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-01Remove shared mxComponent (test document) in new_cond_formatJens Carl
Change-Id: I4f23971186ab7c61fb6c76422f654291333ee07d Reviewed-on: https://gerrit.libreoffice.org/49067 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jens Carl <j.carl43@gmx.de>
2016-07-07loplugin:passstuffbyref also for {css::uno,rtl}::ReferenceStephan Bergmann
Change-Id: I2707d16e6dd7bc5617094963933fced147a496e8
2016-03-07tdf#65219 Fix temp files clean up in sc unit testsAleksas Pantechovskis
Change-Id: I23bf5d47c2cce31d6dd076eeac58cb2ce47b248a Reviewed-on: https://gerrit.libreoffice.org/22953 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2015-11-06loplugin:stringconstant: elide explicit ctor usage (automatic rewrite)Stephan Bergmann
Change-Id: Ief66447f04245b8ab0a4acbf097eb7283529d45d
2015-10-12Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY codeStephan Bergmann
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
2015-04-02test color scale entriesMarkus Mohrhard
Change-Id: I95b8a415e6dea108ac1401447e3c645e8a7b75ef
2015-04-02add test for remaining databar propertiesMarkus Mohrhard
Change-Id: I7188af55ebc48838ea236d482e8809a43a99ba9d
2015-04-02add a test for databar entriesMarkus Mohrhard
Change-Id: I38c025481d3135a708668cad00816f22cdd66cc8
2015-03-30WaE clang seems confused with >>= overriden operator and do not detect ↵Norbert Thiebaud
initialization or does not detect that the thing would abort should the init failed.
2015-03-30work on initial colorscale properties testsMarkus Mohrhard
Change-Id: Ifc71437b8c7dfd70bf733863713ada4ad605abad
2015-03-30the implementation is available so enable it againMarkus Mohrhard
Change-Id: Ia5974e57fd4a21897577ff25fb53f48cceb49501
2015-03-30start work on data property testsMarkus Mohrhard
Change-Id: I1f1722aa3566555816df19e68aa7eaa97e7a13d9
2015-03-30fix return typeMarkus Mohrhard
Change-Id: I581a8a0c7348a9752611b378e883ef20172d16e0
2015-03-30add XIndex interface tests for ScCondFormatObjMarkus Mohrhard
Change-Id: I55604485183057f476c636abc4d43bc9fc58711a
2015-03-30add test for XPropertySet for ScCondFormatObjMarkus Mohrhard
Change-Id: I1786a8b1bf871ccefd73efe3e0515bc3a7dda709
2015-03-30prepare test code for next testsMarkus Mohrhard
Change-Id: I38cfba16e3187a9d80b51258c85f06a829a8a76c
2015-03-30add test for one of the ScCondFormatsObj methodsMarkus Mohrhard
Change-Id: I05fc54a2153fd90d03d2575bdd9bde30a54d71c1
2015-03-30add test for conditional format list sizeMarkus Mohrhard
Change-Id: Ib7df18a5ff8f9afa00c925245eae0ae8be9e06e9
2015-03-30add first test for new conditional format APIMarkus Mohrhard
Change-Id: I85cee7b6b55ce35bb900eaf708744117208e57d7
generated by cgit (git 2.34.1) at 2024-07-10 22:27:33 +0000