summaryrefslogtreecommitdiff
path: root/sc/qa/extras
AgeCommit message (Collapse)Author
2023-06-27sc: import and prop. theme color support for cell bordersTomaž Vajngerl
Adds import for theme colors for cell borders and UNO properties for the cell border theme (complex) colors. Change-Id: I9d8dd7e71f74a623f916e19d59964058f43440bd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153502 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-06-26new loplugin:constexprliteralNoel Grandin
OUStringLiteral should be declared constexpr, to enforce that it is initialised at compile-time and not runtime. This seems to make a different at least on Visual Studio Change-Id: I1698f5fa22ddb480347c2f4d444530c2e0e88d92 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153499 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-06-21sc: add CharComplexColor and CellBackgroundComplexColor propertiesTomaž Vajngerl
Change-Id: I30153796a39b2aa3648cb107905974ed6f0f3851 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151668 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-06-09tdf#155244 filter: XHTML export: Making ODF style IDs unique for ...Svante Schubert
... HTML/CSS by adding a prefix (the @style:family with '-' as glue character) to their style name. Disabled debug output for style:family-name in XSL add text:a to text family ... and add a unit test. Change-Id: Ie846f5ea2a872872f38036aff59d29c8f530ed32 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152749 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-05-23Don't even bother to introduce unused variablesStephan Bergmann
With <https://gerrit.libreoffice.org/c/core/+/152157> "More conservative SAL_WARN_UNUSED to avoid -Werror,-Wunused-private-field", these two cases would have started to cause "unused variable declaration [loplugin:casttovoid]" (because the call to isWarnUnusedType in compilerplugins/clang/casttovoid.cxx would no longer return true). Just avoid that by not introducing the variables in the first place. Change-Id: I3d2b085082555d1765fbd32045b5157deb0af67e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152158 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-05-18CppunitTest_sc_vba_macro_test: don't concatenate the name fileXisco Fauli
Otherwise these files will be flagged as unused Change-Id: I6ae0f8327bc81f57fb63e65dde66742177fc693d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151938 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-05-09CppunitTest_sc_vba_macro_test: use CPPUNIT_TEST_FIXTURE()Xisco Fauli
Avoid the declaration/registration/definition of each test manually saves a lot of space. Change-Id: Ifbefb1950f7fe547489f279c8b229c43dac57f3d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151564 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-05-04CppunitTest_sc_macros_test: inherit from ScModelTestBaseXisco Fauli
so the code can be simplified Change-Id: Iedbb844e5f11b993d73fb32d6871d74779919e10 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151368 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-04-18tdf#154803 - Check if range is entirely mergedAndreas Heinisch
Regression from commit b9411e587586750f36ba9009b5f1e29fe461d8b5 where I missinterpreted the check to get merged cells. Regression: tdf#147122 - Return cell object when a simple selection is merged Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145378 Change-Id: I2e39599a206cf102b1da8c7fc4bb2d8c0a4b106c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150412 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2023-04-14Fix typoAndrea Gelmini
Change-Id: Ib27e0fa515eb69a56462f8571c37e314321924a1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150298 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-04-12tdf#116127 - Add EDITATTR to ALL flags to check for valid function inputsAndreas Heinisch
Otherwise, the function clearcontents does not accept the EDITATTR flag as a valid input. Change-Id: I8381014da7110d060167a814d9ea02e347d5a92b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150191 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2023-04-03tdf#89920 - Handle embedded newline in Calc's search cellAndreas Heinisch
If the replaced string contains a newline after find and replace, insert an edit cell in order to handle an embedded line correctly regardless of the content in the source cell. Change-Id: Ic8a5fc80b85546897572a228511b319cd5a8b9aa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148752 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2023-03-31CppunitTest_sc_macros_test: use CPPUNIT_TEST_FIXTURE()Xisco Fauli
This suite is large enough so that avoiding the declaration/registration/definition of each test manually saves a lot of space. Change-Id: I60792ef623f6db275bf5b1346debceaa38fd6539 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149838 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-03-28Removed executable bits on ods fileAndrea Gelmini
Change-Id: I9a43b02caaad389d8f67a2d2d43ad555d131edf7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149645 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-03-28tdf#142391 - Store method using 0x13 format only when actually neededAndreas Heinisch
Change-Id: I907d234b20be5e3c7bee0d44407f1bf4c4b49f05 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149175 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2023-03-21sc drawstyles: Implement the styles familyMaxim Monastirsky
Change-Id: I2af6072685e4c79cfe2f177c0aae27044f86d840 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149184 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2023-03-16XmlTestTools: factor out common codeXisco Fauli
Change-Id: Ie212c86c6c0ac20878be88d88ade5eb1c989942d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148935 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-02-21qa: call ProcessEventsToIdle inside dispatchCommandXisco Fauli
Change-Id: I909e6f334f4a659282141a97ccb3ffdea6ecc364 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147397 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-02-21tdf#153752: SbxObject::Execute: extra characters in Option Compatible modeMike Kaganski
Change-Id: Ib3e4bd9eb9a249123a686f2434ded7b529fb050f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147345 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-02-20Remove exec bits on xls fileAndrea Gelmini
Change-Id: I2082eb3d09ce5f85432807124a80d591e33574d8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147344 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-02-20VBA: Remove conversions in writer from OORGBTOXLRGB (XLRGB is actually BGR!)Hannah Meeks
Enum to store if document is Writer or Calc because font colors are treated differently depending on this: In writer the colors come in as RGB but in calc they are in BGR and both palettes are in RBG so we only need this conversion for calc. Includes testdoc for calc - to show this still works Change-Id: I79d9d585dbfc527c0781543ce1f1095c4db190b7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144788 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-02-19tdf#153724: make sure to retrieve the variable value before checking the typeMike Kaganski
Commit 5760c94b8847164f9a7a181f031c7c86643944af tried to avoid all cases which could set an error in SbiRuntime::PushForEach. To do that, it checked the type of xObjVar before trying to get an object from it, which otherwise could set an error. But the type of the contained value can be not known until it is retrieved (which can happen inside SbxValue::Get in a call to SbxValue::Broadcast with SfxHintId::BasicDataWanted). This happens e.g. when the container passed to 'for each' is a call to some special function, like VBA's 'Selection'. Then SbxValue::GetFullType would return SbxEMPTY prior to SbxValue::Get. Let's make sure to call SbxValue::Get first (asking for a Variant, to avoid errors on type mismatch), and only then, check the actual result data type. Change-Id: Iaa697f38285505e50504ae09f9307fbd29e09a53 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147273 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-02-18Related tdf#149786: add better unit test for vba pdf export macroBalazs Varga
Better unit test for vba pdf export. Change-Id: Ifa3dff79c457e21ca24b8d99c024bd59917bc990 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147171 Tested-by: Jenkins Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
2023-02-14tdf#149786 sc: add VBA function: ExportAsFixedFormatBalazs Varga
Add ExportAsFixedFormat VBA function for calc. Works fine with Workbook/Worksheet/Range objects Optional parameters: - Type: works but only with xlTypePDF. (xlTypeXPS not supperted by LO) - FileName: works but not clear the xlQualityStandard or xlQualityMinimum real value, so just used the lossless export in case of xlQualityStandard and 70% JPEG compression quality for xlQualityMinimum. - IncludeDocProperties: works - IgnorePrintAreas: TODO - From: works - To: works - OpenAfterPublish: works - FixedFormatExtClassPtr: TODO? Change-Id: I128fd880a82a5dd315897496c6f21bb9a7c2270b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146512 Tested-by: Jenkins Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
2023-01-16tdf#147122 - Return cell object when a simple selection is mergedAndreas Heinisch
Change-Id: I4ddd3b3a804f8300a5ec15526f4c9c77aaf45fc5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145378 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2022-12-10tdf#120190: sc_pdf_export: Add unittestXisco Fauli
Exporting to pdf is the only way I could find to test this issue Change-Id: I1f75d841b09d13807fb1e9e4418a58638d985870 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143890 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-11-23UnoApiTest: factor out createTempFileXisco Fauli
Change-Id: I8d7bb4593839d3660b6609d836b09d50b68f5712 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143141 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-11-21qa: remove duplicated operatorsXisco Fauli
it's already defined in include/tools/color.hxx Change-Id: I26eaba4a1279fadd8669e9702b695e02871052d9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142512 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-11-20tdf#126457 - Add URL and workbook name to window titlesAndreas Heinisch
The Windows object allows to activate a window using its caption. The window caption is the text shown in the title bar at the top of the window. It can be changed which does not affect the name of the workbook. In MS these captions are unique, i.e., a file with the same file name stored in a different directory can't be open. However, LibreOffice allows to open files with the same name. So in order to make it as closely to the functionality of MS, the windows activate method now works with URLs and changed window captions. It has still to be clarified what happens if two workbooks have the same caption. Change-Id: I77a8680bc64b5992191df2fa1a7d475f9a48f518 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140627 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2022-11-09UnoApiTest: factor out common codeXisco Fauli
Change-Id: I1d84d8c1e371016a4f4f068af1e9c76635f28cf4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142490 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-11-08UnoApiTest: simplify code by using tempfile memberXisco Fauli
SwModelTestBase does the same. this will help to make SwModelTestBase inherit from UnoApiTest Change-Id: If1c824cf92f0e8b70253e4d5fdeddcaa521d4632 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142287 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-11-07sc: factor out common code in make filesXisco Fauli
I had to rename some .cxx files to follow the same patterns. The renaming cause clang-format to be triggered for those files CppunitTest_sc_functionlistobj fails with xindexaccess.cxx:26:Assertion Test name: sc_apitest::ScFunctionListObj::testGetCount equality assertion failed - Expected: 395 - Actual : 508 if it doesn't use gb_CppunitTest_use_components Change-Id: I7c929512bbf05293118bc54b343a59c8bbee5538 Change-Id: I21971773f1e2d4bc7a6f33e4c392b20abf8d54de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142387 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-11-03CppunitTest_sc_html_export_test: inherit from UnoApiXmlTestXisco Fauli
Change-Id: Iee06f883704484bf62bf1d9988580d72ba40db22 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142232 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-11-03UnoApiXmlTest: add new wrapper for XmlTestTools testsXisco Fauli
Change-Id: I767f464ec666330a2e8e832b6d6f5736a6bef54d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142228 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-10-31CppunitTest_sc_macros_test: simplify code a bitXisco Fauli
Change-Id: I419f5a0c09643455be992f68b72f4903cfe98a9e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142080 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-10-25ChartTest: inherit from UnoApiTestXisco Fauli
Change-Id: Ie826b66364f61bdab555228ca3a348f86b34847f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141824 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-10-24UnoApiTest: factor out common codeXisco Fauli
Change-Id: Ia8874d65ea8d7eb26d10b18e37ba2bac1a7d756b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141730 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-10-21test: merge CalcUnoApiTest and UnoApiTest into oneXisco Fauli
Change-Id: I24ec4c2c1c6d83865ef78a6460cde68cef84fdb2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141638 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-10-21CalcUnoApiTest: work with mxComponent directlyXisco Fauli
Change-Id: If6f2104ef3136952341c9d5d59a1f9784d0fe4b0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141628 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-10-21sc: remove unused methodXisco Fauli
Change-Id: I4e98ff61d5b592df970595b7aad551a9e37b93df Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141615 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-10-20CppunitTest_sc_pdf_export: inherit from CalcUnoApiTestXisco Fauli
in order to get rid of setUp/tearDown Change-Id: I94dcb647760c71ec8bfc2bbdf50361d81f586eea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141566 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-10-20CalcUnoApiTest: factor out common codeXisco Fauli
Change-Id: I1a56f152d6c6e6bca55ef20d0d52da2d82b77a8f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141565 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-10-19sc: factor out common code in testsXisco Fauli
Change-Id: I58558dd87f235bf3699f3f65271522bb1e7a2ea0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141529 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-10-18CppunitTest_sc_anchor_test: move to slowcheckXisco Fauli
so Jenkins executes it in all platforms also move it out of 'extra' folder so we can change the inheritance to ScBootstrapFixture in a follow-up commit Change-Id: I06cb594b7f13ece2eb71c2099b6119861b4674ff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141504 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-10-17CalcUnoApiTest: factor out tearDownXisco Fauli
Change-Id: Iae1ae76c1903ff3155da2dd407f1237c29f91840 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141375 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-10-14CalcUnoApiTest: Move mxComponent to parent and use it everywhereXisco Fauli
Change-Id: Ibea7a300b7f302936f872d7133aadafeb13d6d82 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141350 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-10-14sc: inherit from CalcUnoApiTest instead of UnoApiTestXisco Fauli
like the rest of tests in sc Change-Id: I15979c6279cf9af6953f661ed8dd2f5a60f1b988 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141349 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-10-14sc: add tearDown to these test classesXisco Fauli
Same as the rest of CalcUnoApiTest tests Change-Id: I55294231fd11fd31ed6f57459b2f0292ddb23635 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141358 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-10-14CppunitTest_sc_vba_macro_test: Do not test specific file on WindowsXisco Fauli
tb39 fails now with C:/cygwin64/home/tdf/lode/jenkins/workspace/gerrit_windows/sc/qa/extras/vba-macro-test.cxx(605) : error : Assertion Test name: VBAMacroTest::testVba equality assertion failed - Expected: OK - Actual : Test Results ============ Failed: : Test change event for Range.Clear set: Failed: : Test change event for Range.ClearContents set: Failed: : Test change event for Range.Replace: Failed: : Test change event for Range.FillRight: Tests passed: 4 Tests failed: 4 - script reported failure in file Ranges-3.xls Change-Id: If226dfc201f124712abeec422cf79a675d25b9fb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141365 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-10-13CppunitTest_sc_macros_test: improve setup/teardownXisco Fauli
Similar to 8b4ac8c35d5e4efe3c0b83e15543a35213e786f2 "improve setup/teardown handling in VBAMacrosTest" Change-Id: I34b64a72f6cab1f85e6e2628b6fd07f408f62cf3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141302 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
generated by cgit (git 2.34.1) at 2025-02-14 23:09:58 +0000