Age | Commit message (Collapse) | Author |
|
Change-Id: Iacc615bf1998f224562f8f8ac08c0ea6911c80a4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171937
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Jenkins
|
|
now when a conditional format entry is edited,
instead of editing entry in the same format,
we delete entry from the origianal format and create
a new format with modified entry alone.
This way it easier to manage formats, and it also aligns
with implementation of how format manager adds new
format condition(it adds new format for each condition instead
of adding new entry to existing format)
Change-Id: Iaa92292ca67eaf90374d2af44d2402f9ebe29787
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169537
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170915
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins
|
|
format manager
Change-Id: I775f96f4cea19e8da34c2d64ac601e5ea3fc5c43
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169482
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170914
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
|
|
now we can add new conitions for formating from manage conditional formating dialog
Change-Id: I69660f108068a64e66301d62a61c485c81e8b97b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169322
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170910
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
|
|
Open <https://bugs.documentfoundation.org/attachment.cgi?id=195586>,
notice that from "bbb", the middle "b" is bold, export to PDF, none of
the "b"s are bold.
The reason for this is that by default we map form controls and content
controls to fillable PDF forms, which can only contain plain text.
Fix the problem by defaulting to not exporting form controls / content
controls to PDF forms: most users just want a PDF that is close to what
they saw in the edit window -- and the ones who want a fillable PDF form
can still opt in. Once the UI checkbox is enabled, we even remember
that.
Based on <https://gerrit.libreoffice.org/c/core/+/152622>, thanks
Justin!
Change-Id: Iddb75d1dbd969045321e139154f254c059eebf16
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171226
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
|
|
Change-Id: I6710db13549c42e9ae7231e0434a26b6357083e1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171102
Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
|
|
Change-Id: Ifd062cf25c6e930da56571e01c21bd9d2ddf6ddd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170394
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
Tested-by: Jenkins
|
|
Change-Id: I59a74e7221808308853f0d893a416fababaf2318
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170493
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
The test still fails if f7936b8ccd0ce9bea3a5e780443e4ae8f35b9da1
"tdf#125051: fix spellchecking on Calc" is reverted.
Change the test to avoid having the second dialog prompted when launching the spell dialog. The options dialog part is removed because it's not needed for testing the crash
Change-Id: I337376dd9ad0f5454534821d259589a9bd68af35
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170495
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
Change-Id: Ia18d8f91ee2d4493174255424ce7e3b7310c369d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169355
Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
Tested-by: Jenkins
|
|
Applying AutoFormat to large selections may take really long.
A warning has been added to warn users.
Additionally a progress is shown while AutoFormat is working.
Change-Id: I74909a6243748ebfe0089406ebe947bb48eb93d5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167950
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
Tested-by: Jenkins
|
|
Change-Id: Ifd7b8a92dff30fee25b1431dde0f3426b2f8bab2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169083
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
and remove duplicated test, tdf43693.py, which is
basically the same as tdf37341.py
Change-Id: Ib29638ecbc2f89e717712ad03afccc70c5aa47ba
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169079
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
formatted rounded values.
Filtered formatted values were not sorted with the rounded values
but with the original values and the duplicated values caused wrong
filter results.
Regression from commit: 2d1df9f3dccc10f13b8585ad18afce1542ebc4d1
(tdf#117276 sc: Show hidden filter elements as inactive elements)
Change-Id: I7540ba5fa98e6bbe0b014448bf2449432261d542
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168592
Tested-by: Jenkins
Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
|
|
Change-Id: Id4cce115823781e5f2a4870d38d1f456cdf417a5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168395
Tested-by: Jenkins
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
|
|
Remove special ADDNOTES flag handling and just add it to existing NOTE flag to ensure no content will be deleted. However, the check for empty cells needs to be improved.
Change-Id: I44ae75aa3997a0b1041447106bc3c07146043351
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167202
Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
Tested-by: Jenkins
|
|
After the change of tdf#139858 the comments checkbox was not remembered anymore after closing the dialog. In order to fix this issue, additionally check not only the NOTE flag but also for the ADDNOTES one.
Change-Id: I8b24d231313b57a05b7e527c0865686762e5a2b1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166762
Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
Tested-by: Jenkins
|
|
even if no content was changed after pasting special. Otherwise, the undo functionality crashes due to undoing a cell with no content where the annotation indicator will remain (unod/redo of note captions are handled via drawing undo).
Change-Id: I7007fce510d6e9896cbda11a1e14a61b5ccb34a9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166469
Tested-by: Jenkins
Reviewed-by: Stéphane Guillou <stephane.guillou@libreoffice.org>
Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
|
|
And introduce GetTextWidth / GetTextHeight variants returning double.
It allows to avoid premature rounding.
At least in one case - testTdf145111_anchor_in_Fontwork - it allowed
to make the test DPI-independent (at least in my testing on Windows,
using 125, 150, and 175% UI scaling).
Change-Id: I973d2c729ec6bb7114b4f99b9027f1ead7c1d061
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166237
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
Prior to this patch, all named ranges/expressions associated with solver models were visible by default, which clutters the UI with various names in the Manage Names dialog.
Now all such named ranges/expressions are hidden by default, thus mimicking what MSO does.
Change-Id: I79727b375c48527632c4967d174c61f99ff41050
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165621
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
|
|
Change-Id: I1bef38a21179bb725c7fb7a08fe90309d26239ee
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164616
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
|
|
Change-Id: I91d5f4572edff99deb21dd2507c3216ef0d9e4c9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164465
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
To be used in a follow-up commit
Change-Id: Ie6c74ebb0f91ec24e6ed3ec973bc47685cd9e91f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164452
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
in other columns
Regression from 89e032e9c4c51f52680c7d8bacf59ab2a34f2180
"tdf#158314: show Empty and Error entries as non-selected and inactive...
...when hidden by autofilter."
The mbHasEmpties variable was added in
9c1826d98065c30411cbf2e731560165ca2b7668
"sc-perf: do not add a million empty filter entries just to sort and
discard"
Change-Id: Ie0d81fd57f68038fac62cb6a3442e93ed547167a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162752
Tested-by: Jenkins
Reviewed-by: Kevin Suo <suokunlong@126.com>
|
|
Change-Id: Ib8bb065c5567bbe8d6f0746fc04484566a616596
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163558
Tested-by: Taichi Haradaguchi <20001722@ymail.ne.jp>
Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>
|
|
When pasting data as text, with "Skip empty cells" not checked, empty
cells in the last column of the source do not empty cells in
destination, because there is nothing anymore to paste and while loop
stops.
This commit adds a flag to check if the last cell of each line is empty,
and treat it if "Skip empty cells" is not checked.
Add UITest to Copy data with empty cells;
Paste Unformatted text, without "Skip empty cells";
Check data with empty cells in last column.
Change-Id: Idec823fb1c27b803f49c6d13d6c757ef0f41e437
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160951
Tested-by: Jenkins
Reviewed-by: Laurent Balland <laurent.balland@mailo.fr>
|
|
I tried to create this test as a Cppunittest but it fails with
Run: 1 Failure total: 2 Failures: 1 Errors: 1
warn:vcl:428912:428912:vcl/source/app/svmain.cxx:494: DeInitVCL: some top Windows are still alive
text = "" type = "14FloatingWindow", ptr = 0x5608715e49e0
text = "tdf159707.xls (read-only) — LibreOfficeDev Calc" type = "10WorkWindow", ptr = 0x5608709ab420
Change-Id: I1b9e16d57050fe07f74c632d441e3a06f49e9438
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163363
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
Based on https://gerrit.libreoffice.org/c/core/+/163021/comments/ff5eb7d3_2426919e
Change-Id: I579dce86775599dc215395b93b15bc9a2f510cb1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163243
Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
The page orientation is correct if you set it in the page style first.
However, if you change it in the Print dialog the page layout and size
refresh but the content orientation remains the same.
Change-Id: I5e494a0714e398221bee00744d7e25c419a41df7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162845
Tested-by: Jenkins
Reviewed-by: Nagy Tibor <tibor.nagy.extern@allotropia.de>
|
|
Change-Id: Ide74895508af280f4b0c129689d852635e62dbff
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160052
Tested-by: Jenkins
Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
|
|
Change-Id: Ic91b8930216b4099ed8af0265497120f9aad0917
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162672
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
|
|
Change-Id: I05ef274dd0ad5dc35b5455cfc01feabc6c0820a3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161276
Tested-by: Jenkins
Reviewed-by: Hossein <hossein@libreoffice.org>
|
|
Change default example date value from 1999-12-31 to 1999-12-01. Otherwise, certain date formats cannot be distiguished in the preview window, e.g., D MM (1 Dec / 01 Dec 99 vs. 31 Dec / 31 Dec).
Change-Id: Iebd78de8d5ef8615c4f2bf400357745e7acfb857
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162308
Tested-by: Jenkins
Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
|
|
...when hidden by autofilter.
The "show hidden filter elements as inactive" feature was added and improved by:
commit 2d1df9f3dccc10f13b8585ad18afce1542ebc4d1
(tdf#117276 sc: Show hidden filter elements as inactive elements)
commit 2085e90fe8ac129bc4dbac4612d1ea7544335dae
(FilteredRow is not a property of the column, tdf#117276 follow-up)
commit 7321db3cadc8c0e4437ca04e5dcb652734ea9c26
(Related tdf#117276 sc: Show hidden filter elements as inactive elements)
commit 19533948370dc1ccd7334dbe1a8b7fc8330b10c0
(Name FilteredRow what it is, not hidden; tdf#117276 follow-up)
Those changes correctly made normal hidden filter elements as inactive,
but failed to do so for Empty and Error entries.
This patch shows the hidden Empty and Error entries as inactive and unselected.
Also, do not show the Empty entry at the top of the list in case it is inactive.
Change-Id: Ibcd758cebc0692b04b162cdfc3e06eceb86b17da
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162166
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-by: Kevin Suo <suokunlong@126.com>
Tested-by: Kevin Suo <suokunlong@126.com>
|
|
I just realized there was already a test for tdf#104026
added in ad9336f29650dc38be06d771f5c3dbc7f0078ff1
"add tests for tdf#104026" so I don't know why I added a UItest
in a7c41f93421ddb2b48e38960b669c4e4f5413efb "tdf#104026: sc: Add UItest"
Anyway, I plan to extend this test for tdf#140330, so moving
it to CppUnittest
Change-Id: I6c4de9298877cc1c51377b099a6a4a53cf54c05b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162168
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
Change-Id: If5bb88a7c20e094332a687978662b9a93edb18bb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161876
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
Change-Id: Iaa329dff61db894e7d5fecd840e785a53a48b26f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160889
Tested-by: Jenkins
Reviewed-by: Hossein <hossein@libreoffice.org>
|
|
links changes of the drawing engine to comments as it was
done before with pictures, shapes and OLE objects
ui unit test included
Change-Id: I4fde3a82b80e73758fb3da94ed2553453d09e9ef
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160624
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
|
|
User can specify which sheets to export e.g. '2-5,7'
exports sheets 2,3,4,5,7.
Note: this is different from exporting pages as one
sheet may contain several pages worth of content.
Also fix a bug where exporting only a selected sheet
causes the next sheet to be exported. e.g.:
Sheet 1 is empty, Sheet 2 has content. Exporting Sheet 1
results in Sheet 2's content being exported
Signed-off-by: NickWingate <nick.wingate@collabora.com>
Change-Id: Iecd42188ddbbbcd70eb37bec80783e29e3cb5b19
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156255
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159686
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
|
|
f2ba17fecb60d936599efb975d96a3ea06c2a43f "disable more flakey navigator UITest",
then 0a0c5a5b0521bea6cb695731d448e62c41ed4c57 "UITest_sw_navigator: avoid
oneprocess" enabled it again, apparently in the false hopes that non-oneprocess
would magically fix this issue. But this still causes frequent failures, e.g.,
<https://ci.libreoffice.org//job/lo_ubsan/2974/> failed with
> ======================================================================
> FAIL: test_tdf134390 (navigator.navigator)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
> File "/home/tdf/lode/jenkins/workspace/lo_ubsan/sc/qa/uitest/calc_tests8/navigator.py", line 145, in test_tdf134390
> self.assertEqual(get_state_as_dict(xColumn)['Value'], '2')
> AssertionError: '1' != '2'
> - 1
> + 2
and <https://ci.libreoffice.org//job/lo_ubsan/2975/> failed with
> ======================================================================
> FAIL: test_tdf134390 (navigator.navigator)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
> File "/home/tdf/lode/jenkins/workspace/lo_ubsan/sc/qa/uitest/calc_tests8/navigator.py", line 145, in test_tdf134390
> self.assertEqual(get_state_as_dict(xColumn)['Value'], '2')
> AssertionError: '53' != '2'
> - 53
> + 2
Change-Id: I39e878c20085cca3233f7c8859b9a1d28fcc56c8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159262
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
This is just a test to see whether this is reason why
UITest_sw_navigator is failing some much recently.
if it's not the case, I'll revert this patch later on
This patch reverts
- 1775b0c25ab13dab94c5ce930d45347a25198af4 "disable unreliable navigator UITest"
- f2ba17fecb60d936599efb975d96a3ea06c2a43f "disable more flakey
navigator UITest"
- 2e49ec0eaa59b5b513ea756861ecac5482b930b2 "disable more flakey
navigator UITest"
- d09785691373009a72cef14fd67610404c8d6022 "disable more flakey
navigator test"
- 6347dcbd3ab2e0a7cb2f7de3bcb5d007e8befc09 "disable more unreliable navigator UITest"
Change-Id: I6e3dde9ad412b0769edee551f7e0ee026586bf8b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158184
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
Change-Id: I3c76c6f1e3561aaf0b4bb719a89feebecc65027a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157482
Tested-by: Jenkins
Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
|
|
add option to not popup the read-only dialog when
load and excel file.
Signed-off-by: Henry Castro <hcastro@collabora.com>
Change-Id: I5e0ac06e3e872f156f6150f4b8bead61e7986c25
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157036
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157641
Tested-by: Jenkins
|
|
Regression from commit b4554b8eddd048532269df610e89ae739c46fab7 (cui:
add UI for semi-transparent shape text, 2019-11-22), the trouble was
that even if semi-transparent text UI is meant to be opt in, we enabled
it by accident also for charts.
This happens because I assumed that we always get a SID_FLAG_TYPE, and
then we can hide the not wanted UI in case SVX_ENABLE_CHAR_TRANSPARENCY
is not in the flags, but even SID_FLAG_TYPE can be missing.
Fix the problem by assuming that in case SID_FLAG_TYPE is not provided,
that means no flags.
An alternative would be to actually add support for semi-transparent
text in chart2/, which is doable, but
chart::wrapper::ItemConverter::ApplyItemSet() assumes that each pool
item can be mapped to exactly one UNO property, which is not the case
for SvxColorItem (it would have to map to CharColor and
CharTransparence), so don't do that yet.
Change-Id: I825ca56b2e03d48c8acff93e1deadf8f86b0dcb0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157258
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
Change-Id: Ieadd35fef7f709e9eaf0f26238f7613076aa8c52
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156775
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: Icf6a28f1270fc95a4edfc81a06fc79d5d2da17df
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156720
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
this test fails here on jenkins about 30% of the time
Change-Id: Ie82f4f2621b7d05b7a74bba1b0b5c96b98314b46
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156324
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I86dbe2909b19a8a9108f3ba76529ef378c2d663e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156039
Tested-by: Julien Nabet <serval2412@yahoo.fr>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: I1f4d28f834d7e9deb09460fde978bc30d05e351e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156037
Tested-by: Julien Nabet <serval2412@yahoo.fr>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: Iab3ff5a5f9c8917d7de1d886aa331e6110b0ae4a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156040
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|