summaryrefslogtreecommitdiff
path: root/sc/qa
AgeCommit message (Collapse)Author
2017-05-11Get string also for external reference to double for operands of '&'Katarina Behrens
In a formula like ='ExtRef1' & 'ExtRef2', or ='LocalValue' & 'ExtRef1' empty string became an operand in concat operation if the referenced external cell was a non-string one. Change-Id: I7b0ac5de68349eae85afe48f377e30cab76e3fbf Reviewed-on: https://gerrit.libreoffice.org/37469 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-05-10Add unit test for non-propagation of array context, tdf#107724Eike Rathke
Change-Id: I59abfaba2866c25dac7db2b8bc5ce8c563a88240
2017-05-10fix buildNoel Grandin
after commit 4d047221945b34a9023d852bbd19a2a24a7f54c3 "loplugin:checkunusedparams in sc(part4)" Change-Id: I3d088bb73baa8c3d6e6186697c215350056c56a4
2017-05-10loplugin:checkunusedparams in sc(part4)Noel Grandin
also fix bug in ScDocShell::DBAreaDeleted which has been there ever since it's initial commit in commit 9ae5a91f7955e44d3b24a3f7741f9bca02ac7f24 Author: Jens-Heiner Rechtien <hr@openoffice.org> Date: Mon Sep 18 16:07:07 2000 +0000 initial import Change-Id: Ifc8d6dec4843c668404fdf1ca1a9e521f73132d5 Reviewed-on: https://gerrit.libreoffice.org/37459 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-05Fix typosAndrea Gelmini
To complete commit 0ef94e2b559547bc4e906e7f24e57ff5d642e108 and f12096272e684ddcd8ffa4e34dcb0a680cc594c2 Change-Id: Ie86bbfbd58dd728a013bef221e4d5c8fbcaf8e03 Reviewed-on: https://gerrit.libreoffice.org/37199 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-05-05Use the non-template variants.Kohei Yoshida
Eventually the template variants of these helper functions should be removed. Change-Id: I63edf2776efafd08908947217ce53dfc6d5e35fc Reviewed-on: https://gerrit.libreoffice.org/37269 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2017-05-05tdf#106796 Make CHITEST and CHISQ.TEST comply with ODFF1.2 and improveWinfried Donkers
interoperability with Excel. Note: the functions now don't accept empty datasets, just like Excel. This is not fully compliant with ODFF1.2. A change request to make ODFF reflect this behaviour would be appropiate. Change-Id: I70225a4dc8e20a035d25af4290137714cda95624 Reviewed-on: https://gerrit.libreoffice.org/35864 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-05-04Replace all OUString("") with OUString()Arnaud Versini
Change-Id: Ie14c4d76cb61cfbe0410103adfc1afc8ade0f3e0 Reviewed-on: https://gerrit.libreoffice.org/37146 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-04Fix build.Jan Holesovsky
Change-Id: I5638d1984cd1c40517e977ade6e3959f3595208b
2017-05-04sc lok: Unit test that painting tiles after pgdown returns actual content.Jan Holesovsky
Test based on the online.git test by Ashod Nakashian, thanks for the repro steps there! Change-Id: I225127e953b0dade0b1bd4e12c131dc984b7e3fc
2017-05-03tdf#107255: add test case for the multi-cell query method.Kohei Yoshida
This is the best we can do since the rest of the cell merge code is in ScViewFunc which cannot be unit-tested currently. Change-Id: I639f48d5cd05bff015689b0d223684f6f8d302f8 Reviewed-on: https://gerrit.libreoffice.org/37179 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2017-04-28loplugin:cppunitassertequals: scStephan Bergmann
Change-Id: Ifc250cf5bc293b4c87b9abb2d00be62078c2338a
2017-04-25tools: svstream.hxx needs only errcode.hxx & not errinf.hxxChris Sherlock
Change-Id: Ia28e35ae5af4f601e9a586a3deffbcd61702b0ca Reviewed-on: https://gerrit.libreoffice.org/36896 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-04-25tdf#107310: add unit test for this.Kohei Yoshida
I decided to add this to the filters test since it's the ods import code that sets the cells in hybrid "zero as empty string" mode. Change-Id: Icb34733e8550b655fbd70be718af5006b257a3e3 Reviewed-on: https://gerrit.libreoffice.org/36818 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2017-04-24clang-tidy readability-simplify-boolean-expr in scNoel Grandin
Change-Id: I702e52e56487f201b9e0d7af21ff8167464aa58c Reviewed-on: https://gerrit.libreoffice.org/36876 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-16tdf#90290 use custom asserter in ucalc_sort.cxxkerem
Change-Id: I61e1d5c75f5ec13291633368859441bb85732317 Reviewed-on: https://gerrit.libreoffice.org/36494 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-04-16try to fix the tests that depend on fontsMarkus Mohrhard
This should help with some of the RandomConfig tb failures. Change-Id: I83af9c2c50fa2f3044e7507a1b902807536452dd Reviewed-on: https://gerrit.libreoffice.org/36581 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-04-16coverity#1405157 Unchecked return valueCaolán McNamara
Change-Id: I6feb9004da5ca674533631b42a9e268ca7f1e7f7
2017-04-14update cppunit to 1.14.0Markus Mohrhard
Change-Id: I95fa42f4ef0580734b605df859c1660b29adb8b2 Reviewed-on: https://gerrit.libreoffice.org/36499 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-04-13add STDEVPA test caseZdeněk Crhonek
Change-Id: Ic90116cab083a193c8888c1765d0612c7ffb1855 Reviewed-on: https://gerrit.libreoffice.org/36490 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2017-04-13add ZTEST, Z.TEST test caseZdeněk Crhonek
Change-Id: Icecc7fb4d61efbc9ccd2f3da8b263384fd5858a3 Reviewed-on: https://gerrit.libreoffice.org/36489 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2017-04-13Removed duplicated includesAndrea Gelmini
No automatic tools. Manual checked and tested. Change-Id: Ife260fa4e1d786cf81f2917a901664cc54943754 Reviewed-on: https://gerrit.libreoffice.org/36371 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-04-13tdf#92650: add a unit test for this.Kohei Yoshida
Also add a modern C++11 version of checkOutput(), which should be used instead of the older variant that is a template function. Change-Id: I64706baf531c557c3631c998122515e40d555cf6 Reviewed-on: https://gerrit.libreoffice.org/36497 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2017-04-12tag ScAddress and friends with SAL_WARN_UNUSEDNoel Grandin
Change-Id: I4ed6b1e8b4225a87fbcb863a47c84e30228b5352 Reviewed-on: https://gerrit.libreoffice.org/36407 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-11add test for tdf#105245Markus Mohrhard
Change-Id: I4760ede6d14429be811fe96b28bf1c7663592678 Reviewed-on: https://gerrit.libreoffice.org/36394 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-04-10tdf#105044 match empty cells on "<> not-empty" comparisonsBernhard Widl
this affects any formula using <> over a range of cells (not only SUMIF and SUMIFS) Change-Id: I85a3c3762d72de3250def0f037a0afd96c48f35d Reviewed-on: https://gerrit.libreoffice.org/36224 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-04-09add test for tdf#106194Markus Mohrhard
Change-Id: I63ae36e0e218e7e40ed28024d91b0d7a9654e965 Reviewed-on: https://gerrit.libreoffice.org/36305 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-04-08add test for tdf#95617Markus Mohrhard
Change-Id: I8acab5af4dfc8f058eb9624abafe63e212ddb437 Reviewed-on: https://gerrit.libreoffice.org/36296 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-04-07uitest: temporarily disable failing testMarkus Mohrhard
Change-Id: If65fb4906e69030d0716998619bc6a1acd6730aa
2017-04-06unit test for CEILING and FLOOR .xlsx export, tdf#100011Bartosz Kosiorek
Change-Id: I2ce45db4ae905dedf7c3dc8fb0fd9519ace6c3aa Reviewed-on: https://gerrit.libreoffice.org/35549 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-04-06add BAHTTEXT test caseZdeněk Crhonek
Change-Id: Ib6c4781b6a0a482539dfeea81dc1044f6d56e1d9 Reviewed-on: https://gerrit.libreoffice.org/36163 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2017-04-06Improved loplugin:redundantcast, static_cast on arithmetic types: scStephan Bergmann
Change-Id: Id56d3e3d7c4485e24dc8fe6349631837101e86fe
2017-04-05loplugin:constantparamNoel Grandin
Change-Id: I1996319e5b664dff95f7a9b2346aea6092d333ec Reviewed-on: https://gerrit.libreoffice.org/36070 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-04tdf#39468 Translate German commentsJens Carl
First run of translating German comments and terms in sc/ Change-Id: I9802df334259edcea148bead95cc98a8057b91a1 Reviewed-on: https://gerrit.libreoffice.org/35994 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2017-04-03remove hack for non DBG_UTIL buildsJochen Nitschke
always use a 8bit enum for StackVar correct StackVar types for opcode opSep and opClose in unit test and test them. Change-Id: I89fac97d791eb12667ce5218ff31e798c8711e10 Reviewed-on: https://gerrit.libreoffice.org/36000 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-03use actual UNO enums in scNoel Grandin
Change-Id: I51dbe623178e3c463dc4c941f23edac04fbfe349 Reviewed-on: https://gerrit.libreoffice.org/35968 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-31LOK: Calc: unit test for invalidation on insert imageMarco Cecchetti
Change-Id: Ie7c55c3a5c366618cafa51f9f1a102fb3cb26ec5
2017-03-31tdf#82580 tools: rename Rectangle to tools::RectangleMiklos Vajna
Mostly generated using make check COMPILER_EXTERNAL_TOOL=1 CCACHE_PREFIX=clang-rename-wrapper RENAME_ARGS="-qualified-name=Rectangle -new-name=tools::Rectangle" Except some modules have their own foo::tools namespace, so there have to use ::tools::Rectangle. This commit just moves the class from the global namespace, it does not update pre/postwin.h yet. Change-Id: I42b2de3c6f769fcf28cfe086f98eb31e42a305f2 Reviewed-on: https://gerrit.libreoffice.org/35923 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-03-29LOK: Calc: limiting undo and add support for repair modeMarco Cecchetti
During collaborative editing changes can be undone regardless of who made them. This patch avoids this possibility and introduce support for repair mode, for cases where undo/redo of others' changes is intentional. Change-Id: I69fd435e96c4c675ffd1df81e936b5eae109daa0 Reviewed-on: https://gerrit.libreoffice.org/33223 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-03-28tdf#90290 use custom asserter in shared_test_impl.hxxkerem
Change-Id: I00bbd0fb3f63f5641fea75ce0cb797e5f2252fa2 Reviewed-on: https://gerrit.libreoffice.org/35669 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-03-28tdf#90290 use custom asserter in ucalc_sharedformula.cxxkerem
Change-Id: Ica0e0aed177c47e402e573d53df54ab6ea4ad15d Reviewed-on: https://gerrit.libreoffice.org/35727 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-03-28Fix typosAndrea Gelmini
Change-Id: Ibef75de246fb31884153437fe8c05e299fe5962f Reviewed-on: https://gerrit.libreoffice.org/35782 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-03-27add test for multiple row filteringMarkus Mohrhard
Change-Id: I55c898a7bf6796802ee6d04071801fec3fcf218d Reviewed-on: https://gerrit.libreoffice.org/35732 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-03-27add test for tdf#106214Markus Mohrhard
Change-Id: I9998aa40c3831a6033d4d61a6eab90d639ec5aa9 Reviewed-on: https://gerrit.libreoffice.org/35731 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-03-27improve the test by introducing sub testsMarkus Mohrhard
Change-Id: I414da64f55348973a8f60c7518d26a835385125d
2017-03-25Fix typosAndrea Gelmini
Change-Id: Ia17fe891f8a681ada69639ca579ebf6d6d781759 Reviewed-on: https://gerrit.libreoffice.org/35641 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-03-24tdf#105908: add test for this.Kohei Yoshida
Change-Id: I553c18107d469bd7dce37d673f958126455b4393 Reviewed-on: https://gerrit.libreoffice.org/35608 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2017-03-24fix tb71 buildNoel Grandin
after commit 7916487cf4d9603cdbe4c7ffbe9bb3f28b51ce4e "convert ViewShellId to o3tl::strong_int" Change-Id: Ie7b8ac51a94c3b9e6d39e397aa3dd5cb42acc6d0 Reviewed-on: https://gerrit.libreoffice.org/35623 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-24blind fix for screenshot buildNoel Grandin
after commit 88ec24a23a10af771879421360fe4330cbf174b0 "convert NAME constants to CreateNameFlags o3tl::typed_flags enum" Change-Id: I6025e2d2a1717e4741f0241ea65d4a49bb8da917
2017-03-24convert ViewShellId to o3tl::strong_intNoel Grandin
Change-Id: I45553d11d56aa8c4432aec126ca51f24bd3ead09 Reviewed-on: https://gerrit.libreoffice.org/35421 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2024-08-21 05:30:21 +0000