summaryrefslogtreecommitdiff
path: root/sc/qa
AgeCommit message (Collapse)Author
2020-11-16Instead of labs, use overloaded absStephan Bergmann
...more likely to pick an appropriate version for the involved integer types, esp. after the recent long -> tools::Long changes Change-Id: Ia91259ca35aaf74b0e907de6831fc926f30057f4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105949 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-11-16uitest: autofilter: add test for different searchesXisco Fauli
Motivated by https://bugs.documentfoundation.org/show_bug.cgi?id=122419#c21 Change-Id: I2086ed604c50b513019c7023ad4c01df9c5edb4a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105925 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-11-15tdf#71271 - add code names regardless of VBA compatibility modeAndreas Heinisch
During the save process of a document, save code names of calc sheets regardless of the VBA compatibility mode. Loading of documents with changed code names already work without checking the VBA mode. Change-Id: Ieb5297ac3b671fd39a200c34409ba2ffdad4e1f7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103589 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-11-15Avoid changing anchor on visibility change of cellRegina Henschel
This is an addition to commit 1f0b3c7a40edfa81bbc7a58d123a6a2dfd83e4ca The following scenario had produced a wrong object size: The object is anchored to cell. Some columns containing this cell were hidden and then shown again. ScDrawLayer::SetCellAnchoredFromPosition was called in this case and had produced the wrong size. When the column of the object anchor is shown, object becomes visible. This gives an 'object change' event, sent to ScDrawView::Notify, which calls adjustAnchoredPosition. That had a test pAnchor->getShapeRect() == pObj->GetSnapRect() that should prevent calling SetCellAnchoredFromPosition. But exact equality fails due to +-1 differencies because of Twips<->Hmm conversions. Change-Id: I0bd3684b7a5eda62b578275c02a5ac839ce58e2c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105802 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2020-11-13fix some tools::Long falloutNoel Grandin
Change-Id: I8c15b0ee8400c3b540154bc38c51cbf04b6c3850 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105794 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-13Fix (some of) fallouts from tools::Long change to 64 bit on _WIN64Mike Kaganski
Change-Id: I297d43c594c5d8c3378e8b7f29ad798e89e4ebaf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105776 Tested-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-11-13Force number constants to tools::Long in assertsRegina Henschel
Change-Id: I404b0edb31fb4eb797baf814136b00fd605724eb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105775 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-11-12tdf138138 Apply shape shift also to NoRotatedAnchorRegina Henschel
The 'normal' anchor (as on screen) is connected to the snap rectangle, the NoRotatedAnchor is connected to the logic rectangle. They differ, if the shape is transformed, e.g. rotated. Error was, that values of the 'normal' anchor were applied to NoRotatedAnchor instead of calculating the shift of NoRotatedAnchor independently. The error becomes only visible on save, because there the NoRotatedAnchor is used. Effected shape types are legacy shapes, text boxes and transformable OLEs. I have not tested, whether this fix would work for LO 7.0 too. Change-Id: I8ad22ca54bdd49861a16a34736860a9871d8eba0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105611 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2020-11-11Fix typosAndrea Gelmini
Change-Id: Ice850a7929c5b88ca0c4da52504aa959aacd1024 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105548 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Bjoern Kirchhoff <Bjoern.Kirchhoff@escriba.de>
2020-11-11Correction to improve 'resize with cell'Regina Henschel
Error: A vertical flipped shape lost flip on loading. The error slipped in, when I have implemented the suggestions from Jan-Marek. The object is vertical flipped, to have no flip for calculating the full sized logical rectangle. Therefore the second call to method lcl_NeedsMirrorYCorrection gives wrong result 'false'. I need to remember the result of the first call. Change-Id: Ia411fe7108be9fdcbbf748ee9de9f443e55d6ed0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105570 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2020-11-11tdf#133630: sc: Add UItestXisco Fauli
Change-Id: I044a11bd5690b063bf3bb346bf0e324c1353d478 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105561 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-11-10uitest: chartArea.py: assert changes in chartXisco Fauli
Change-Id: I8825bed89c50dcb0a9858d04a1697cb12fdd81bf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105556 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-11-10uitest: remove useless commentsXisco Fauli
Change-Id: I9990be302a2d28e6e46f8bb33cda605ba15533f1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105552 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-11-10new loplugin:reducevarscopeNoel Grandin
Change-Id: Iefe922c2e0d605114d54673d63eccc5e4abd545d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102143 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-10tdf#117948 Do not treat hidden rows as zero in ODF exportRegina Henschel
The object geometry in ODF file format has values so as if no hidden columns or rows exists. But for rendering the object geometry has to treat hidden rows and columns as zero. This patch changes the object geometry temporarily to the 'no hidden columns and rows' mode for export and restores the original geometry afterwards. The patch considers hidden columns left from the shape and hidden rows above the shape. So the object is shifted. Considering hidden columns or rows in the area, which is covered by the shape, is still missing. That would possibly require scaling. Change-Id: Icdb3f08404ca4d212d25a1967bfdc0bfc7186007 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105427 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2020-11-10tdf#136721 XLSX: add missing A6 paper formatSzabolcs Toth
Unrecognized A6 paper format was converted to the default A4/Letter previously, see Paper Format in Format->Page... Co-authored-by: Balázs Regényi Change-Id: If2ea0c4137177aa8be66cb11d4732b14cbc14455 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105392 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-11-07Fix typosAndrea Gelmini
Change-Id: I7ba612d8880833057269290212bcd9d864bb7395 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105399 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-11-06tdf#137908: uitest: Add asserts to check there is at least 1 elementXisco Fauli
Change-Id: I7e259043ad493d7e9c4ca34d64a4ca1ed1cf8db5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105391 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-11-06tdf#137614 sc: fix data circle shape size on merged cellsTibor Nagy
When we are marked invalid data using Tools->Detective-> Mark Invalid Data, only top left cell of the merged cells is circled instead of all the merged range. Note: ScDrawLayer::RecalcPos change is for resizing the circled merged cell. Co-authored-by: Regina Henschel Change-Id: Ia03c506c92ec6e1c81ef3039c20e8e7ba9e9181d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105241 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-11-06tdf#134161: sc_anchor: Add unittestXisco Fauli
Change-Id: Iff58a85b9080ebe9c0d088237acb3af7018d3f04 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105380 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-11-06tdf#134161: Revert "tdf#132137 Rename Default Style in Calc."Xisco Fauli
This reverts 4111ed76906bf6be05b704bf52fa91353dfef183 the document would also hang if define STR_STYLENAME_STANDARD NC_("STR_STYLENAME_STANDARD", "Default"); is replaced by define STR_STYLENAME_STANDARD NC_("STR_STYLENAME_STANDARD", "DefaultTest"); meaning somewhere in the code 'Default' is harcoded as git grep "\"Default\"" sc/source/ shows Reverting for now so we can backport it to libreoffice-7-0 while a better solution is provided for tdf#132137 Some other problems of the reverted commit are mentioned in comment 4 and comment 5 of tdf#134161 I'm adding a unittest in another commit so this one can be easily reverted in the future Change-Id: Ib7c4a99ff4957eba7ec0b644e989c7a08b46f2a8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105381 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-11-05tdf#137653 tdf#137624 sc: fix autofill user list sequencesAttila Szűcs
Improve FillAuto, FillAnalyse to discover the step between values of linear sequences of user list (sort list) values in 1x1 cells, and continue it. (Sort lists are special string lists with values like day names Monday, Tuesday, ... see Tools->Options...->Calc->Sort list) Note: The unit test is not language dependent, as it clears all user lists and replace it with its own list. Also fixed this in the unit test of tdf#137625. Co-authored-by: Tibor Nagy (NISZ) Change-Id: I1c8b0df9ad29f91a6080e56e5f2ebe0029a10a08 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105259 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-11-05std::set->o3tl::sorted_set in ScDPCacheNoel
Change-Id: I8d647149545d0b5ff7bb82a8db171b9410ea79b1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105337 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-05tdf#137790 calc: set minimal line width: unit testSerge Krot
Change-Id: Idac7c23e55b3c4ee94790458fca5e7a7a5522098 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105301 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-11-04Unit tests for: Improve 'resize with cell' handlingRegina Henschel
These tests belong to commit 1f0b3c7a40edfa81bbc7a58d123a6a2dfd83e4ca They cover tdf#137576, tdf#137216, tdf#137044, tdf#137020, tdf#137355 and tdf#115655. I have replaced the rectangle comparison in scshapetest.cxx with the same one as used in bugfix-test.cxx Change-Id: I71b4499077e461fe826e6d8d29f801bc66da89fa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105270 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2020-11-04uitest: reset formula syntax back to Calc A1Xisco Fauli
otherwise, it will interfere with other tests Change-Id: Ib671d0e5e0a0d47a42ed911d4f9de68b2f7fee9e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105288 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-11-03tdf#87474: sc: Add UItestXisco Fauli
Change-Id: I2c915372076228164e6322fad84643971ea4e105 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105257 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-11-03tdf#137617: sc: Add UItestXisco Fauli
Change-Id: I544a221e7b3c76bb046235768d3fdcb700805579 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105239 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-11-03tdf#137896: sc: Add UItestXisco Fauli
Change-Id: I38d2d31f28bfbabc8003a11520ad26e3df2a29a5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105199 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-11-03uitest: test creation of range names from uiXisco Fauli
Change-Id: I3897a8a4dc77b5d41b3b64a03146c121fee5c83b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105229 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-11-02tdf#67007: sc: Add UItestXisco Fauli
Change-Id: Id8e52f10943f5c28b3c28f757bd38b55f18f3384 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105189 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-11-02tdf#100818: sc_ucalc: Add unittestXisco Fauli
Change-Id: I66c98b9ccd6ab3bf8df9312aa920c83bc789d269 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105183 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-10-31Improve 'resize with cell' handlingRegina Henschel
The patch contains a larger rework of RecalcPos and connected areas and covers several bugs. Essentials in short: Move initialization from RecalcPos to own method and use it in ScXMLImport::endDocument Do not change hidden objects, which includes not setting width or height to zero, and be consistent in using object visibility. Special handling of vertical flipped customshapes. Repair anchor on import of line and measure line. ODF conformance: Create logical rectangle from anchor instead using size. Details: tdf#137044 ScDrawLayer::SetPageSize is called several times while loading a document. It includes a call to ScDrawLayer::RecalcPos for all cell anchored objects. An object gets initialized with the first call. Problem was, that the row heights were not finished at that time and anchor cells and offsets were partly calculated based on default cell height. That results in wrong height and offset of objects. The solution separates initialization from RecalcPos and puts it into an own method ScDrawLayer::InitializeCellAnchoredObj. This is then called from ScXMLImport::endDocument when row height settings are finished. The call to RecalcPos is not totally removed from SetPageSize but only excluded while loading, because it is needed for size changes after the document is loaded. tdf#137576 partly For measure lines and ordinary lines, which were anchored 'To cell (resize with cell)', LibreOffice has written wrong end-cell info to file. So reopening results in wrong lines. The geometry of lines is based on two points. Fortunatelly the combination of position of the cell, which contains the shape, and start and end points gives correct absolute position of these points. Solution is, to regenerate the initial ScDrawObjData infos from these points and do not use the stored end-cell info. For a total fix implementation of NbcSetSnapRect for SdrMeasureObj is needed, which is not included here. tdf#137020 Cell anchored shapes are contained in a cell in file. To determine size and position of the shape a rectangle is used, so defined, that after applying transformation you get the desired shape. In case of custom shapes, a vertical flip is not contained in the transformation but it is an attribute inside the shape and flip is done at the shape center and will not change the rectangle. This rectangle determines start and end addresses and offsets in ScDrawObjData in rNoRotatedAnchor. The info is used directly in XML export. It is correctly build while loading the file. But in case of vertical flipped custom shapes the logical rectangle of the shape has an additional 180deg rotation. Changing that behavior is currently out of scope. Therefore special handling of vertical flipped custom shapes was added. tdf#99549 ODF specifies that in case of existence of end-cell attribute, size attributes have to be ignored. But LO has based the logical rectangle on size. In addition it has written zero width and height in case of hidden row and cols. Result was, that objects are 'lost' on opening although they still exists in the file. With the patch the object size is recalculated from anchor on opening. tdf#137355, tdf#137044, tdf#115655 The old solution has recalculated the snap rectangle based on current state of hidden row or column. That has produced shapes of zero width or height and loss of offset in case start or end cell of the shape was hidden. In running LO it was partly offset by using cached infos in ScDrawObjData. That failed in case of save and reload. Solution is, to only change visible shapes. It is enough to adapt the shape when it becomes visible. That is introduced in RecalcPos and SetCellAnchoredFromPosition. tdf#137216 Shapes anchored to cell were not hidden, if the column of its anchor was hidden, and undo of hiding an image in a cell by hiding its column didn't work. Reason was, that the shapes were not set to hidden in the shapes geometry. Solution is to copy a similar part from SetRowHidden to SetColHidden. without bugreport, but detected while debugging LO has used a cell reference with bHiddenAsZero as true in shape export. That has resulted in wrong offsets. Unittest changes: Test::testGraphicsInGroup() ScShapeTest::testCustomShapeCellAnchoredRotatedShape() Set expected values so, that they correspond to anchor in file. ScFiltersTest::testLegacyCellAnchoredRotatedShape() FIXME is solved now and the test is adaped to reflect that. XSheetAnnotationShapeSupplier::testGetAnnotationShape() Expected value is adapted to the fact, that now annotation shape gets its position after optimal row height is applied. Change-Id: Iffee996054ebf79e04044da5520f8d1a8a48b7c1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104643 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2020-10-30tdf#137625 sc: autofill user list sequences in merged cellsAttila Szűcs
Improve FillAuto, FillAnalyse to continue linear sequences of user list values in merged cells. (User lists are special string lists with values like day names Monday, Tuesday, ...) If values are user list values, but not in linear sequence, then the autofill will just fill with FILL_SIMPLE (pattern repeat). Note: the unit test depends on English system locale settings, check it in Tools->Options->LibreOffice Calc->Sort list, otherwise extend Sort list with English day names for manual testing. Co-authored-by: Tibor Nagy (NISZ) Change-Id: I7a1da5e82a18ba8ebd24af7e4b89c7651f3ec24a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104690 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-10-30tdf#84874 XLSX export: truncate validation textTibor Nagy
Maximum length allowed in Excel is 255 characters for title and message of validation input and error, so truncate them, otherwise Excel throws away the whole message. Co-authored-by: Attila Szűcs (NISZ) Change-Id: Id4576f167ab8a39e0cd943bc07c2e465a77ba665 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104547 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-10-28tdf#tdf#137726: sc: Add UItestXisco Fauli
Change-Id: I67bcafb3155b991dc8b1515f224675906e0a5955 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104897 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-10-28Extend loplugin:elidestringvar to OStringStephan Bergmann
(In VisitVarDecl, filtering out AbstractConditionalOperator avoids an unhelpful > ~/lo/core/vcl/source/pdf/XmpMetadata.cxx:63:32: error: replace single use of literal 'rtl::OString' variable with a literal [loplugin:elidestringvar] > aXmlWriter.content(sPdfConformance); > ^~~~~~~~~~~~~~~ > ~/lo/core/vcl/source/pdf/XmpMetadata.cxx:52:21: note: literal 'rtl::OString' variable defined here [loplugin:elidestringvar] > OString sPdfConformance = (mnPDF_A == 1) ? "A" : "B"; > ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ) Change-Id: I7d0410f04827d79b4b526752917c37d33cad2671 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104911 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-10-27uitest: move all calc tests to sc/qa/uitestXisco Fauli
and remove a few duplicated ones Change-Id: I409ca78dcd7a67e993f6b3a1493ffa6fefd127b3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104864 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-10-26Clean-up of commit: 0d193c12a673fade8ece9d84cc4024fafdf52c9bAttila Szűcs
https://gerrit.libreoffice.org/c/core/+/104049 Change-Id: I9c7fd094f0301a81e8c86e10e62f4f619d6ec2f8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104533 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-10-26tdf#137621 sc: autofill bool sequences in merged cellsAttila Szűcs
Fixed FillAnalyse to not discover booleans as number sequences, rather as a pattern that can be repeated. Co-authored-by: Tibor Nagy (NISZ) Change-Id: I0a32e756461eb4101b77724129b745e23a658b1d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104655 Tested-by: Jenkins Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-10-26uitest: sc: move data folder to the root uitest folderXisco Fauli
Change-Id: I65e81bb3cc25283e882b4a63661c0959b297a76e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104802 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-10-26std::unique_ptr -> std::optionalNoel
Change-Id: I25f8b337a3f9cecb4d7785c18d91dae89ba20799 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104797 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-26tdf#129969 XLSX export: file URLs need IURI encodingTünde Tóth
External hyperlinks with # in directory name didn't work after XLSX export. Change-Id: Ibdf4fcbb65d0c580841d24c1721454164e341424 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104272 Tested-by: Jenkins Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-10-24uitest: sc: get_url_for_data_file -> pathlib.PathXisco Fauli
Change-Id: Iea16b30e74a5bbc5fe155f1265d5c05bf104995c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104729 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-10-24tdf#104378: sc: Add UItestXisco Fauli
Change-Id: I2258de72c3aae6b7d9aaa2c65c8c551384d84024 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104736 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-10-21CppunitTest_sc_subsequent_export: factor out duplicated codeXisco Fauli
Change-Id: I87381f243e71e302df92b60c6afde15e78ab7828 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104570 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-10-20use tools::Long in scNoel
Change-Id: I8f37a8d1174ed816df971b8cee036d4e88d4a7fc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104526 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-19tdf#90104 XLSX export: fix commas in data validation listTibor Nagy
Comma was exported as list separator instead of decimal separator, messing up the data validation list by breaking integer and fractional parts of a number to two integer numbers, for example the 2-item list 1,5, 2,5 to the bad 4-item list 1, 5, 2, 5. Note: for testing with numbers, it needs to set decimal separator to comma in locale settings. Co-authored-by: Attila Szűcs (NISZ) Change-Id: I6133c402b47aab8ed9f02b412762404fc520badc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104240 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-10-16fix some *printf which are using "%l" ie. long specifiersNoel
which are not portable between Linux and Windows because long is not portable. In preparation for converting long -> tools::Long Change-Id: I8bf1aa1570946ca887a6c83dd5f99c024d437336 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104374 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-14tdf#137453: sc_subsequent_filters_test: Add unittestXisco Fauli
Change-Id: Ief6559122820c490eebe256535fae5e009b5e2b7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104318 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
generated by cgit (git 2.34.1) at 2025-01-17 03:42:29 +0000