summaryrefslogtreecommitdiff
path: root/sc/qa
AgeCommit message (Collapse)Author
2022-10-13tdf#125363, tdf#123095 - Use CaseTransliteration for autofilterAndreas Heinisch
Change-Id: Ib6f1edebe26a69d3316a901e00d2bc6e0c66695f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141047 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2022-10-12sc: remove duplicated testXisco Fauli
This is already well covered by Test::testAutoFill in sc/qa/unit/ucalc.cxx Change-Id: I5d539de101e1b4dcd19191ac40d2bc0734475889 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141272 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-10-12sc: move UItest to CppUnittestXisco Fauli
Change-Id: I6543994abe337041de5a1aab16a5a49105aacfbb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141271 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-10-12tdf#151460: sc_ucalc: Add unittestXisco Fauli
Change-Id: Ib0c8d09da50a09b2715a946a1955eb5a09d83d62 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141269 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-10-12sc: qa: avoid OUStringChar for better readabilityXisco Fauli
Change-Id: Idf730e05d2ebec9003a2a4700b43b8658d858b03 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141265 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-10-12tdf#60673: sc_subsequent_filters_test2: Add unittestXisco Fauli
Change-Id: Ia36507483e5dc325431b17e9374882ae8102bfb5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141263 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-10-11Deduplicate O(U)StringConcatenationMike Kaganski
And use an overloaded helper function with a better (?) unified name to show that the result is not an O(U)String. Change-Id: I8956338b05d02bf46a6185828130ea8ef145d46b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141203 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-10-10improve setup/teardown handling in VBAMacrosTestNoel Grandin
do the same thing that the other UnoApiTest subclasses are doing, seems to fix the problem for me Change-Id: I0d5288b638a5c8d6994fae5ae5d99f2f29bcf377 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141155 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-10-06use more string_view in scNoel Grandin
Change-Id: Ic7126ac57f8cc06b37f3098603f0710602f0ab28 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140998 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-10-05tdf#36383 - sc AutoFilter: fix changing row heightAndreas Heinisch
Changing row height showed the rows hidden by AutoFilter, removing the result of the filtering. Change-Id: Iecc8eb03ed563de126e7a376dad41a4ab2434f0e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139883 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2022-10-03CppunitTest_sc_uicalc: simplify codeXisco Fauli
Change-Id: I88f6243bde37128d4afafb9a0b180964b7d5c47e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140919 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-10-02Resolves: tdf#125110 tdf#151211 Disentangle the convoluted CSV/TSV-clip importEike Rathke
The chain of fixes for #i119960# tdf#48621 tdf#125440 produced code that is suboptimal and not robust enough against some further corner cases, taking quoted field content where there shouldn't be. First, in ReadCsvLine() assume that if a generator is broken enough to start a field quoted followed by containing an unescaped embedded quote and there is no closing quote (i.e. immediately before a field delimiter) until the line end then the generator will not be clever enough to write embedded linefeeds either and the field starting quote wasn't one but to be taken literally as all other quotes until the now unquoted field end. In this case do not read a subsequent source line for the current row. Then, for individual fields of a row make a similar assumption, a quote-started field has to end with a quote before a field separator (or line end) or otherwise all quotes of that field are literal data up to the next field separator. This made it necessary to adapt two test cases of the garbage CSV import test to produce different garbage than before. Change-Id: I4424b65c87c7f9dcbe717a7e6cf207352cb613f3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140850 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2022-09-29split utl::TempFile into fast and named variantsNoel Grandin
which makes it easier to know what each variant requires to stay on it's happy path Change-Id: I3275a2543573367714bc78092e882f6535507285 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140469 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-09-26uitest: sc: check 'all' button in autofilterXisco Fauli
Change-Id: I9a64701446512178cc8deda64f94c293d939ec3f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140592 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-09-24Fix typoAndrea Gelmini
Change-Id: I7a275e86ba0c9c07144b71a1d5d7c01eb378f416 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140539 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-09-23CppunitTest_sc_uicalc: use utf-16Xisco Fauli
Change-Id: I8fcb56d42c50748b31f7737f37e1f950b83fb539 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138725 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-09-23tdf#123990 sc condformat: case insensitive begins/ends/containsJustin Luth
This is how Excel handles these. At first I was afraid that this would upset LibreOffice users, but then I realized that equals already is case insensitive, so this change ought to be more consistent, and thus there should be fewer outcrys. Change-Id: Ia3de78d5888672ba8b774866d41ecd65293397c1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140484 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2022-09-23make sure SharedString::EMPTY_STRING is interned in pools (tdf#150647)Luboš Luňák
Without this, it may not actually be there, so interning "" would use a different string instance, and then comparing with SharedString::getEmptyString() would actually compare non-equal. Change-Id: I22660f63aa321e3a8f72cfb96df1db56e08fbb84 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140402 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2022-09-22tdf#129674 "Go to Sheet" UITestLaurent BP
Add UITest to new dialog Sheet > Navigate > Go to Sheet Check search entry behavior Change-Id: I4b22328f24744ba554320c65ef95c20eb35dfe3f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135632 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-09-21tdf#75702 ODS import: send text:line-break to editengJustin Luth
A cell with a line-break specified is no longer a simple string, so send the string to editeng where it can be properly displayed. This already works fine for XLS and XLSX. This change effectively means that text:line-break will disappear, and become two separate paragraphs. Given the nature of spreadsheets, the precidence in various other patches and the failure to properly display without this, I think I'm fine with unilaterally changing one paragraph into two. Change-Id: I7abcbc6f698a4cb319aea5465a8b0393cf63f31f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140262 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2022-09-20fix opencl AND() to treat empty cell in svSingleVectorRef as core doesLuboš Luňák
Functions_Excel_2016.fods incorrectly used "=AND(Sheet2.C22;C33)" instead of the correct "=AND(Sheet2.C22:C33)" (colon vs semicolon), and C33 is an empty cell. The return however was true because empty cells get special treatment because of Excel compatibility. Change-Id: I6d0b28280059fd6fc945e77c7b5d714b5e4727a2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140224 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-09-19tdf#132519: sc_ucalc_formula: Add unittestXisco Fauli
Change-Id: Ie2ff5a8961556cf21ca75a58d46f37754e0bb61b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140183 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-09-19tdf#151046: sc_subsequent_filters: Add unittestXisco Fauli
Change-Id: I552d53f511373b170985185361621d8e149e582b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140184 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-09-19tdf#75702 sc: unit test for preserving text:line-breakJustin Luth
Change-Id: Id61e46ba4e0b3e2b534cf9f8bafe03fba10cd355 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140182 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2022-09-16tdf#103829 ods export: don't output invalid office:string-valueJustin Luth
If the formatted (i.e. \t) string was different from the raw string (i.e. \x001 EE_FEATURE_TAB marker), then export was outputing office:string-value with IsInvalidChar \x001. The impact on import is that the cell wants to display this string-value, which is missing all of the "invalid char" stuff. So, just don't export a wrong string at all. Change-Id: Ib98e58d0c6e1186d199a4dcf294b56403b710f48 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139816 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2022-09-15CppunitTest_sc_vba_macro_test: unify the way tests are setup and teardownXisco Fauli
Some tests were using mxComponent and some other tests where using their own xComponent Hopefully this will fix the CppunitTest_sc_vba_macro_test failures on windows Change-Id: I75fa51edf273582057201f50847b2c1a3ed1fcc9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139948 Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-09-15CppunitTest_sc_macros_test: simplify code a bitXisco Fauli
Change-Id: Ie0b685dbcbc3504de10372b9c0127781171f8fb8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139946 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-09-14Related: tdf#149665 Unify input of a leading ' apostrophe in non-Text cellEike Rathke
If a cell is not formatted as Text and ScSetStringParam::mbHandleApostrophe is true, all input (except one single apostrophe that otherwise would lead to an empty cell string) now is treated the same and the leading apostrophe is removed and the remainder is set as text content. The Input Line and editing a cell get an apostrophe prepended for the cases needed to generate such escaped string again. This made it necessary to adapt a unit test that exactly checked the old behaviour. Change-Id: I07b35d33f3704970784dc6de1322bda28903bb97 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139934 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2022-09-14try wait_until_property_is_updated in test_tdf134390Caolán McNamara
====================================================================== FAIL: test_tdf134390 (navigator.navigator) ---------------------------------------------------------------------- Traceback (most recent call last): File "/home/tdf/lode/jenkins/workspace/lo_gerrit/Config/linux_clang_dbgutil_64/sc/qa/uitest/calc_tests8/navigator.py", line 143, in test_tdf134390 self.assertEqual(get_state_as_dict(xColumn)['Value'], '2') AssertionError: '1' != '2' - 1 + 2 Change-Id: I7c781191facd10abbb25f895cb0d2bacb72d92ab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139933 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-09-14tdf#149551 use 'WritingMode' instead of TextPreRotateAngleRegina Henschel
Commit 7e23cbdbb6ec0247a29ed8a8f744c01e10963ea0 changed the code so, that TextPreRotateAngle is used to track ooxml vert attribute. This patch changes it so, that the style attribute WritingMode is used. Now text direction can be written in 'writing-mode' attribute in the graphic properties in ODF, same for shapes as for frames. The needed conversion from WritingMode BT-LR and TB_LR90 to TextPreRotateAngle for rendering of text in custom shapes is now in one place in class SdrObjectCustomshape. The shape edit engine cannot yet render it itself. Some unit tests are adapted to use WritingMode property instead of TextPreRotateAngle. The value text::WritingMode2::TB_RL90 is introduced, corresponding to vert='vert' and textDirection='tbRl' or ='rl' in OOXML. It is used for frames too, so that the original text direction is preserved and vert='eaVert' can be distinguished from vert='vert'. TextPreRotateAngle is currently still used in SmartArt import for 'upr' and 'grav' and in emulating 'upright' but no longer to emulate text direction. Change-Id: Idc4339bbfc3592fe90b154d75e2c404a1fa30856 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138813 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-09-13tdf#150766: sc_uicalc: Add unittestXisco Fauli
Change-Id: I4acff046167f05a576eb7320edc3c85d759f6776 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139790 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-09-13tdf#103829 ods import: parse <text:tab/>Justin Luth
regression since LO 4.1 Change-Id: I65e847a45b8b233c558bf7bc90b554ba8b4b7763 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139757 Tested-by: Justin Luth <jluth@mail.com> Reviewed-by: Justin Luth <jluth@mail.com>
2022-09-12tdf#150288: sc: Add UItestXisco Fauli
Change-Id: I3a71d37b4d0eed72f6f5fa291c9d460caadf373a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139595 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-09-12tdf#131073 - Don't show hidden rows/cols after setting optimal row/col heightAndreas Heinisch
Change-Id: I1dbe92cfc577e3425787b942415182889cda6a76 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139327 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2022-09-11ScValueIterator ScDocument& parameter is now superfluousEike Rathke
Since commit 3be1cdce9d92cbadca1b276b3193c727032ea717 ScInterpreterContext is passed that has it. Just a minor change for a const ScDocument&. Change-Id: I388ff55393056c52f85d7543fcfb6c549fc2a346 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139759 Tested-by: Eike Rathke <erack@redhat.com> Reviewed-by: Eike Rathke <erack@redhat.com>
2022-09-09always pass ScInterpreterContext to ScValueIteratorCaolán McNamara
its available at every call site Change-Id: I764962d1d2330c414e02ed215b4a0c5be2979145 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139637 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-09-09tdf#150312 unit testEike Rathke
Change-Id: I140d94b4022dafe4f54b45d3d335c881d967ea56 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139725 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2022-09-08Fix CppunitTest_sc_subsequent_filters_test2 on non-default DPIMike Kaganski
Change-Id: I940c3213dda02a73924a9f8dc6500d7ecc38ba6a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139674 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-09-08Fix CppunitTest_sc_jumbosheets_test on non-default DPIMike Kaganski
Change-Id: I067622274cfa7518462ad74015dc3942f35b6b9c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139675 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-09-07tdf#150307, tdf#150829: sc: Add UItestXisco Fauli
Change-Id: If4a7e9fc6e4d9057f880f6b8c1dba7598597031e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139583 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-09-06Removed executable permission on fileAndrea Gelmini
Change-Id: Ie9097527d66cdb6ce5c616dcaaf5e2eafd282733 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139481 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-09-06tdf#142031: sc: Add UItestXisco Fauli
Change-Id: Icfe8229a0079bbe5be8394883299b2f959a74efd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139489 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-09-06tdf#150499: sc_uicalc: Add unittestXisco Fauli
Change-Id: Id2aae130c3b9ede1fe88893d035a37b82b0964f4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139478 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-09-06fix opencl trigonometric functionsLuboš Luňák
Change-Id: Iacdae9fceff2feb198bd722e7e58e5e6dff5facc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139194 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-09-06add missing Calc test file opencl/compiler/precision.odsLuboš Luňák
Should have been included in 35ed13eba1ceb6ddab8a9a72c5ef46ab3af . Change-Id: I3cf1a6b38e9893b5ec4ec4d6ffdfc4bf0ddba065 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139477 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-09-06tdf#118247 - Correctly handle xlCellTypeConstants parameterAndreas Heinisch
Change-Id: I5cc281d6193bcf03d2da3c594d427ec340c2cfc1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139239 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2022-09-06tdf#150599: sc_filters_test: Add unittestXisco Fauli
Change-Id: Ibc6434b3505276343da0a36c52ab175aefc518ef Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139470 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-09-06tdf#147021 Use std::size() instead of SAL_N_ELEMENTS() macroRadhey Parekh
Change-Id: Ic9009eda963f922fc4d2e75a5002026eda63a7aa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138686 Tested-by: Jenkins Reviewed-by: Hossein <hossein@libreoffice.org>
2022-09-05tdf#150749 Find and replace on very large sheetNoel Grandin
This requires 2 fixes (*) First, we are deleting from the front of a block in the mdds storage, so apply a similar patch to mdds to the previous improvement, (*) Then, we end up with an O(n^2) situation in ScRangesList::Join. But we are only displaying this data, and in fact, we only display the first 1000 ranges anyway, so just clamp the list to 1000 entries, and pass a flag up to the dialog so that we can report that we stopped counting. (*) I had to tweak the testSharedStringPool unit test, since we are not actually clearing the underlying mdds storage, the reference counts do not drop until we have removed all the elements in that block of mdds storage (because then the entire block is destructed, including the not-yet destructed elements) Change-Id: I2c998f81dfb46453a48fce1254fd253d299d12b8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139400 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-09-05tdf#73845 restore Empty and NonEmpty query filter after FILEOPENChenxiong Qi
Signed-off-by: Chenxiong Qi <qcxhome@gmail.com> Change-Id: I659e0d97c44bf189f457ca04eb49248121278c10 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138919 Tested-by: Jenkins Reviewed-by: Hossein <hossein@libreoffice.org>