summaryrefslogtreecommitdiff
path: root/sc/qa
AgeCommit message (Collapse)Author
2019-01-08convert "*xxx.get()" to "*xxx"Noel Grandin
Change-Id: Ic307226591ff9702957ccdec486ccf70357eb6d9 Reviewed-on: https://gerrit.libreoffice.org/65951 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-07Resetting all fields for all dims corrupts pivot cacheKatarina Behrens
test case is exporting ooo55266-3 (contains data grouped in numerical intervals) to xlsx and without closing the document, opening filter on 1st pivot table (kaboom!) ClearGroupFields corrupts the cache bc it resets Field.mpGroup items for all dimensions, not just the one present in ScDPDimensionSaveData (all this happening in ScDPCollection::SheetCaches::getCache). Consequently, accessing or rebuilding pivot cache may crash bc mpGroup now points nowhere. I split and renamed ScDPCache::ClearGroupFields into 2 parts, one of them clears maGroupFields, the other resets mpGroup ptrs in maFields. When adding data to cache, the former is used (bc group ptrs get reset almost immediately afterwards) Change-Id: I96e8d234a17da0f3cc65c0625aa47b12284b98b8 Reviewed-on: https://gerrit.libreoffice.org/65329 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2019-01-07tdf#42949 Fix IWYU warnings in include/vcl/[v-x]*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I98f49765c6b74808dcbd692e0f375dd2848fcfd4 Reviewed-on: https://gerrit.libreoffice.org/65614 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-01-03uitest for bug tdf#99069Zdeněk Crhonek
Change-Id: Ic117937629b465227c564158b7c24270997cce78 Reviewed-on: https://gerrit.libreoffice.org/65839 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2019-01-02uitest for bug tdf#45020Zdeněk Crhonek
Change-Id: I1a177fa309e7cf20ab432f302fe9c8fb0f7cfb05 Reviewed-on: https://gerrit.libreoffice.org/65809 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2019-01-01uitest for bug tdf#44861Zdeněk Crhonek
Change-Id: I9532fc3c5a5924fbe3cc6b76a095ff28e5b15f73 Reviewed-on: https://gerrit.libreoffice.org/65770 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2019-01-01uitest for bug tdf#35020Zdeněk Crhonek
Change-Id: I2a124a124882c65bfda0d413a6f3a1cd4e46792a Reviewed-on: https://gerrit.libreoffice.org/65775 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2018-12-31uitest for bug tdf#39959Zdeněk Crhonek
Change-Id: Ibe33f5fd3e66f53815429eaeaea5d64fc4984730 Reviewed-on: https://gerrit.libreoffice.org/65774 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2018-12-31uitest for bug tdf#49531 tdf#49520Zdeněk Crhonek
Change-Id: Ief075273f6a1331ca5290e0e21386e4e6e16f54e Reviewed-on: https://gerrit.libreoffice.org/65773 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2018-12-24Fix CppunitTest_chart2_xshape failing with Display Scaling on WindowsMike Kaganski
See thread starting at https://lists.freedesktop.org/archives/libreoffice/2018-December/081589.html Regression from commit 7263d223ddf42cc39d10a501159c7b04ef48df96. That change has made unit tests DPI-aware; and then some tests started failing on systems with resolutions other than 96 DPI. It has been suggested that the proper fix would be to do for Windows what commit ada20402efa81273e03e46cbedc21f25b9daeeac did for macOS. Another approach would be to fix all the tests to be DPI-aware. I cannot do the first mentioned fix; so I have fixed testFDO74215 test in sw_ooxmlexport4; and added DPI checks to the other failing tests in chart2_xshape and sc_subsequent_filters_test to skip testing when using non-default DPI. This is not ideal, of course, and conditionally skipped tests need to be re-enabled unconditionally once a proper fix arrives. Change-Id: I5c92cfe93ae65f53a8a180fcaec49231df377b8a Reviewed-on: https://gerrit.libreoffice.org/65595 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-12-22Fix typo in codeAndrea Gelmini
It passed "make check" on Linux Change-Id: I23bb5e475c5b769e91f47bea19dc57994fbca091 Reviewed-on: https://gerrit.libreoffice.org/65565 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-12-21uitest for bug tdf#106667Zdeněk Crhonek
Change-Id: Icbcd21ed159e9e560536ff5166f82bba0d39786f Reviewed-on: https://gerrit.libreoffice.org/65556 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2018-12-21uitest for bug tdf#117276Zdeněk Crhonek
Change-Id: Ib61eee95d7ed4e6ede9455b058406eccd140e31c Reviewed-on: https://gerrit.libreoffice.org/65555 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2018-12-20tdf#42949 Fix IWYU warnings in include/vcl/[t-u]*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ib32ea54a3fa690a0722fa75ddb4121ec78c0b64f Reviewed-on: https://gerrit.libreoffice.org/65386 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2018-12-19Add XServiceInfo tests to ScTableRowsObjJens Carl
Change-Id: I9ebf0c3664c56f99a4e423c409c5d1621b8ea082 Reviewed-on: https://gerrit.libreoffice.org/65402 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-12-19Fix typo in QA pathAndrea Gelmini
Change-Id: I866611929f75dd322ce81ec54a63ec08002f55cc Reviewed-on: https://gerrit.libreoffice.org/65401 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-12-19tdf#45904 Move XTableRows Java tests to C++Jens Carl
Move XTableRows Java tests to C++ for ScTableRowsObj. Change-Id: I765d213e0a3e95a3925f1fc179a8a3f6c6611739 Reviewed-on: https://gerrit.libreoffice.org/65398 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-12-19tdf#45904 Move XEnumerationAccess Java test to C++Jens Carl
Move XEnumerationAccess Java test to C++ for ScTableRowsObj. Change-Id: Ic2d37c7b918faff3af7a682f72a1f2b04857c5d7 Reviewed-on: https://gerrit.libreoffice.org/65373 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-12-19tdf#45904 Move XElementAccess Java tests to C++Jens Carl
Move XElementAccess Java tests to C++ for ScTableRowsObj. Change-Id: Iefe5024cbde5f1583a560d8569e9aa460b68e42e Reviewed-on: https://gerrit.libreoffice.org/65372 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-12-19tdf#45904 Move XIndexAccess Java tests to C++Jens Carl
Move XIndexAccess Java tests to C++ for ScTableRowsObj. Change-Id: I90dc592ba7901dab9c402b56e9e992fe7593c71c Reviewed-on: https://gerrit.libreoffice.org/65371 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-12-18Add XServiceInfo tests to ScScenariosObjJens Carl
Change-Id: I4d8fb95af78330d488e4b782eb8cdff5b83f1cc2 Reviewed-on: https://gerrit.libreoffice.org/65369 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-12-18tdf#45904 Move XNameAccess Java tests to C++Jens Carl
Move XNameAccess Java tests to C++ for ScScenariosObj. Change-Id: I73dd65e672e1e98a6839cea03c30cfafb7da4ff4 Reviewed-on: https://gerrit.libreoffice.org/65313 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-12-18tdf#45904 Move XElementAccess Java tests to C++Jens Carl
Move XElementAccess Java tests to C++ for ScScenariosObj. Change-Id: Ic1592746f99f685375e5b96c5b51c221d48ab07f Reviewed-on: https://gerrit.libreoffice.org/65308 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-12-18tdf#45904 Move XIndexAccess Java tests to C++Jens Carl
Move XIndexAccess Java tests to C++ for ScScenariosObj. Change-Id: Idfe41c83adcec7a9cb6b29da9aafcb8c7c25c711 Reviewed-on: https://gerrit.libreoffice.org/65306 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-12-17tdf#99438: sc: support for .xltx exportVasily Melenchuk
Added support for content types for template and template with macros (.xltm, but no user interface for this yet). Fixed preferred extension for template: by default it is .xltx and not .xltm (macro-enabled), because MS Excel is very strict about matching of content-type and extension here. Fixed wrong namespace in FilterService for ExcelFilter. Change-Id: Ie717d31d72203601324860f069918d75082add4a Reviewed-on: https://gerrit.libreoffice.org/65111 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-12-16uitest for bug tdf#119954Zdeněk Crhonek
Change-Id: Id9dbd53f2902f484f9d1209953ff2ad58d77936c Reviewed-on: https://gerrit.libreoffice.org/65199 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2018-12-15Fix typoAndrea Gelmini
Change-Id: I846df107b450c966725bc1e516cec5989b8f4b08 Reviewed-on: https://gerrit.libreoffice.org/65193 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-12-15tdf#45904 Move XEnumerationAccess Java test to C++Jens Carl
Move XEnumerationAccess Java test to C++ for ScHeaderFieldsObj. Change-Id: Ibead91f6c4369bb75e218eadb99776b0d1fb7cf4 Reviewed-on: https://gerrit.libreoffice.org/64799 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-12-15tdf#45904 Move XRefreshable Java tests to C++Jens Carl
Move XRefreshable Java tests to C++ for ScHeaderFieldsObj. Change-Id: Ia922b11e93f38bfc56795cc34c150b3429fd5447 Reviewed-on: https://gerrit.libreoffice.org/64798 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-12-14avoid possible expensive repetitive formula group changes (tdf#102364)Luboš Luňák
The testcase from tdf#102364 is actually a rather pathological case, the document having a full 1M cells column with the same formula, and doing undo in this case essentially pastes the column over itself (I think a column is first deleted, which moves this column, and then ScUndoInsertCells will trigger ScMoveUndo::UndoRef(), which will paste the column in that place again. And since this is done cell by cell, removing old cell first splits the large formula group and then adding a new cell with the same formula rejoins the formula group, and setting these formula group changes for all the cells over and over actually takes a long time. Avoid that by delaying the formula grouping operation and do it just once at the end. I'm not sure if this is that good way of handling this, given the testcase is very specific, but I can imagine something similar happening in other possible cases (manual copy&paste of a large column over itself or moving it slightly up or down). Change-Id: Ie4241197103a039c232150333250f78175b1c2c7 Reviewed-on: https://gerrit.libreoffice.org/64782 Tested-by: Jenkins Reviewed-by: Kohei Yoshida <libreoffice@kohei.us> Reviewed-by: Eike Rathke <erack@redhat.com>
2018-12-13Fix sc_ddelinkobj testsMike Kaganski
Regression from commit 63ff8602c16b0c26927dc3413b12a5368fe367b0. See thread started at https://lists.freedesktop.org/archives/libreoffice/2018-December/081542.html The Application::SetName is mandatory for DDE to work; otherwise InitializeDde() in SfxApplication::SfxApplication() fails. DDE spreadsheet formula expects full name of the target spreadsheet, including path. Fixed sheet name (it's "Sheet1", not "Sheet"). Removed redundant tests (former "testRemoveRefreshListener" tests all). Change-Id: I6299a9ec03c3657a21ad42d0ff87db25cf2be905 Reviewed-on: https://gerrit.libreoffice.org/65079 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-12-13uitest for bug tdf#39650Zdeněk Crhonek
Change-Id: I1eb757939c31aafd9730715bd43a60513842e560 Reviewed-on: https://gerrit.libreoffice.org/65056 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2018-12-13uitest for bug tdf#44398Zdeněk Crhonek
Change-Id: I998784e9382866e1afdce4618a2f4acb25d3efa6 Reviewed-on: https://gerrit.libreoffice.org/65060 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2018-12-13uitest for bug tdf#39917Zdeněk Crhonek
Change-Id: I6b3c8a72cc36db802aace7aa54efc167d19c1bc9 Reviewed-on: https://gerrit.libreoffice.org/65062 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2018-12-12tdf#69569 implement proposed change to ODF1.2 part 2 §4.11.7.7Winfried Donkers
Calculating the number of days in a year in AddIn function GetDaysInYear() for basis 1 (actual/actual) gave wrong results. Now the results are correct and the same as in Excel. Extended the unit test document for function YEARFRAC and corrected the unit test document for function AMORDEGRC (verified the results with Excel). Change-Id: Ic68f108496f41dec71b3616095dff80512a64c31 Reviewed-on: https://gerrit.libreoffice.org/64837 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2018-12-11uitest for bug tdf#31805Zdeněk Crhonek
Change-Id: I21790869be9c87e923cb4d87b58b2dc4b143fb25 Reviewed-on: https://gerrit.libreoffice.org/64971 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2018-12-11OSX implement bitmap-only rendering modeJan-Marek Glogowski
Eventually OSX should also depend on SVP and SVP should just export the platform agnostic code, so we can get rid of all the IOS and ANDROID ifdefs. Since the SVP mode now also uses a default DPI value of 96, we can get rid of those "broken" adjustments to the tests in commit a4ab0c08e747 ("Row height tolerance level increase for unittest") and commit 1e55a47e89a9 ("tdf#62268: allow row height recalculation on document load"). The DPI handling on OSX seems really broken. Additionally DPI should probably a float value, as rounding results in various of-by-one errors in tests. Change-Id: I47881683a9c3d3e1b4f8e7aba1d03842da4d6652 Reviewed-on: https://gerrit.libreoffice.org/64736 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-12-10uitest for bug tdf#91425Zdeněk Crhonek
Change-Id: I95057eb6a8db1bd141bfa53ff955cd72c2b20cd4 Reviewed-on: https://gerrit.libreoffice.org/64883 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2018-12-10uitest for bug tdf#80583Zdeněk Crhonek
Change-Id: Ifcbab8c5745b86eaf2406e1fdb3ad368acbb6fe0 Reviewed-on: https://gerrit.libreoffice.org/64849 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2018-12-08tdf#45904 Move XEnumerationAccess Java test to C++Jens Carl
Move XEnumerationAccess Java test to C++ for ScCellFieldsObj. Change-Id: I09e7c6be401bb54e1314da95d6797790aedefbe1 Reviewed-on: https://gerrit.libreoffice.org/64795 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-12-08tdf#45904 Move XElementAccess Java tests to C++Jens Carl
Move XElementAccess Java tests to C++ for ScCellFieldsObj. Change-Id: I140cb1f1d5f9cbccfd4dbb43d37c9cd48b7346e8 Reviewed-on: https://gerrit.libreoffice.org/64794 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-12-08tdf#45904 Move XRefreshable Java tests to C++Jens Carl
Move XRefreshable Java tests to C++ for ScCellFieldsObj. Change-Id: Ic5679c32669b1368a702c9b132e6789fb828330f Reviewed-on: https://gerrit.libreoffice.org/64793 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-12-08Adds additional test-case for AVERAGEIFS...Dennis Francis
to ensure that the commit Find actual data area inside the main-range... 24b1827309e7fe4d77108da5732f7f4eddad3ae6 does not change results by its optimizations. Change-Id: I07113359cac9c653f692e84a7b79b06621142aaf Reviewed-on: https://gerrit.libreoffice.org/64658 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2018-12-07uitest for bug tdf#107869Zdeněk Crhonek
Change-Id: I797b13c3ba76869e67c12832402798ab2b65596a Reviewed-on: https://gerrit.libreoffice.org/64776 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2018-12-07tdf#45904 Move XIndexAccess Java tests to C++Jens Carl
Move XIndexAccess Java tests to C++ for ScUniqueCellFormatsObj. Change-Id: I2aabc835d37c5f12afacfcbafc2d7d6346619a3c Reviewed-on: https://gerrit.libreoffice.org/64666 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-12-06tdf#45904 Move XEnumerationAccess Java test to C++Jens Carl
Move XEnumerationAccess Java test to C++ for ScUniqueCellFormatsObj. Change-Id: Ia49fce123577a62e1ad60ef0dab4ac61148a1551 Reviewed-on: https://gerrit.libreoffice.org/64665 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-12-06tdf#45904 Move XElementAccess Java tests to C++Jens Carl
Move XElementAccess Java tests to C++ for ScUniqueCellFormatsObj. Change-Id: I9cec7605afa2cbfec48e5ecee22c12983c68afee Reviewed-on: https://gerrit.libreoffice.org/64664 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-12-05tdf#45904 Move XIndexAccess Java tests to C++Jens Carl
Move XIndexAccess Java tests to C++ for ScCellFormatsObj. Change-Id: I5ef1e789a535af55705c3a39f07a9396666adbed Reviewed-on: https://gerrit.libreoffice.org/64648 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-12-05tdf#45904 Move XEnumerationAccess Java test to C++Jens Carl
Move XEnumerationAccess Java test to C++ for ScCellFormatsObj. Change-Id: I68b9e0308b1959b848e8a53b143c6a6a49589bb7 Reviewed-on: https://gerrit.libreoffice.org/64647 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-12-05tdf#45904 Move XElementAccess Java tests to C++Jens Carl
Move XElementAccess Java tests to C++ for ScCellFormatsObj. Change-Id: I8c72c7eb352720f4ff40727df4823855ec8014e5 Reviewed-on: https://gerrit.libreoffice.org/64646 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
generated by cgit (git 2.34.1) at 2025-01-08 19:20:43 +0000