summaryrefslogtreecommitdiff
path: root/sc/qa
AgeCommit message (Collapse)Author
2021-01-01disable contantly failing testCaolán McNamara
Test name: sc_apitest::ScShapeTest::testTdf137576_LogicRectInDefaultMeasureline assertion failed - Expression: std::abs(rExpected.Y() - rActual.Y()) <= nTolerance - after reload Y expected 6524 actual 7079 Tolerance 1 Change-Id: Ic827acae5af559f5daf87e4fcc34affcf014d800 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108543 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-12-30Fix build - incorrect stringSzymon Kłos
Change-Id: I9270d3ce381262bb17da7e4f929fed55088e4944 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108510 Tested-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2020-12-30loplugin:stringviewparam: operator +, reduxStephan Bergmann
Change-Id: I0790e09f24512d7b205681127eb95ad7dc15a15f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108473 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2020-12-29tdf#120749 XLSX: fix "begins/ends with" conditionalTibor Nagy
formatting when using "Given text" type and cell reference. Follow-up of commit 583e2bfba2d72ac8afe7261c23f380daf5486889 (tdf#139021 XLSX export: fix "contains" conditional formatting). Co-authored-by: Attila Szűcs (NISZ) Change-Id: Idf5d46469765454a11311bd6ec1d85c85b89e26f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108058 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-12-29loplugin:stringviewparam: operator +Stephan Bergmann
Change-Id: I044dd21b63d7eb03224675584fa143009c6b6008 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108418 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-12-28tdf#137033 improve save of cell anchored shapesRegina Henschel
Error was, that rotated or sheared shapes got wrong position or size on save and reload in some cases. These situations should be correct now: A) Hide or show row/col above or before shape. It uses snap rectangle now. Previous solution failed, if hidden row/col is after snap rectangle left/top and before logic rectangle left/top. B) Repair ScShapeTest::testTdf137576_LogicRectInDefaultMeasureline() which would not have failed. SetColHidden() does only set the information, but does not trigger recalculation itself. C) Add solution for case shape is anchored 'resize with cell' and hidden row/col is covered by the shape. D) In case custom shape is anchored 'resize with cell' and mirrored horizontal, the translation value is wrong. I have not found the reason yet. So I have added a solution here for writing the xml markup correctly. It should work with correct translation values too. In all cases the solution does not consider right-to-left sheets. RTL sheets are still ToDo's. Change-Id: Ia15a05b637d12d9798bbc8ffca52f606058deb87 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108377 Reviewed-by: Regina Henschel <rb.henschel@t-online.de> Tested-by: Regina Henschel <rb.henschel@t-online.de>
2020-12-28tdf#139021 XLSX export: fix "contains" conditional formattingTibor Nagy
when using "Given text" type with cell reference instead of fixed string. Note: fix also "notContainsText", and prepare the fix for "beginsWith", "endsWith" and "expression" type conditions. Follow-up of commit 0101975f8eac650bb87c4af81157cb33a6309e0e (tdf#122102 XLSX import: fix "contains" conditional formatting). Co-authored-by: Attila Szűcs (NISZ) Change-Id: I46d80946f2b6cfaa2a9fe2438fae20e8aa9d50f4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108035 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-12-26New loplugin:stringliteralvarStephan Bergmann
See the comment at the top of compilerplugins/clang/stringliteralvar.cxx for details. (Turned some affected variables in included files into inline variables, to avoid GCC warnings about unused variables.) Change-Id: Ie77219e6adfdaaceaa8b4e590b08971f2f04c83a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108239 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-12-23More loplugin:bufferadd findingsStephan Bergmann
...after recent Clang 12 trunk <https://github.com/llvm/llvm-project/commit/ 569676c05725d79909bd8a9224bc709bd621553c> "Make Expr::HasSideEffect more precise for instantiation-dependent expressions." Change-Id: Ic22d68368f2ccfa1ae67efaff38cd4d2d2072db0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108242 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-12-23tdf#121472 XLSX export: fix external Linux pathAttila Szűcs
Removed the extra 4th '/' after 'file:///' from aData.maBasePath at exportDocument(). In Linux, the root path could start with '/'.. like /home/... in that case 'file:///'+'/home/..' resulted 'file:////home/ that is invalid. Co-authored-by: Tibor Nagy (NISZ) Change-Id: Ia37a11def80df2747578807ee021fafe38d48ec0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108131 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2020-12-22Fix typoAndrea Gelmini
Change-Id: Ia0240b8c601e75564109744bb068b7e156384429 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108121 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-12-21tdf#138710: sc_uicalc: Add unittestXisco Fauli
Change-Id: I5496637baf51035e16fe41d9036de2895d97fed2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108087 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-12-21tdf#138824 tdf#137937 XLSX export: fix parent directory pathAttila Szűcs
Parent directory paths (../) removed by XclExpHyperlink::BuildFileName() resulted broken external reference. Note: on Linux, now this fix creates a working, but still fragile path relative to the root directory. Co-authored-by: Tibor Nagy (NISZ) Change-Id: I9401d75d1fba0194d4ff509d9b7305969b8804e2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107603 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-12-19don't mention VclBuilder in the dialog tests docsCaolán McNamara
Change-Id: Id18a25e3d3310342887757fe417769f4213b8a3c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107981 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-18throw exception in SvStream when reading past end of fileNoel
to avoid chasing weird problems where we read past the end of file, which leads to random data in the variable we read into. I expect a couple of possible regressions from this change (1) memory leaks caused by non-exception-safe memory handling. Of which there should not be much because we're pretty good about using smart pointer classes these days. (2) Broken files which used to load, will no longer do so. These will have to be debugged by putting a breakpoint on the SvStreamEOFException constructor, and examining the backtrace to see where we should be catching and ignoring the exception to make the code continue to handle such broken files. Change-Id: I351be031bb083a3484a9a1b650a58892700e6fb7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105936 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-12-17tdf#138822: sc: Add UItestXisco Fauli
Change-Id: Ibb1ad62679480e51caf8b89ebb14c7fb4cb9f5ec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107868 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-12-16tdf#122102 XLSX import: fix "contains" conditional formattingTibor Nagy
when using "Given text" type and cell reference with "contains text" or "not contains text" conditions. Co-authored-by: Attila Szűcs (NISZ) Change-Id: Ifbd34ef9f7ee948b6ac42a890bd52f3fb8486aec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107791 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-12-14tdf#138851: sc: Add UItestXisco Fauli
Change-Id: Ia3197a3da56d853ba805157af25fceefa461c85e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107677 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-12-11Adapt the remaining OUString functions to std string_viewStephan Bergmann
...for LIBO_INTERNAL_ONLY. These had been missed by 1b43cceaea2084a0489db68cd0113508f34b6643 "Make many OUString functions take std::u16string_view parameters" because they did not match the multi-overload pattern that was addressed there, but they nevertheless benefit from being changed just as well (witness e.g. the various resulting changes from copy() to subView()). This showed a conversion from OStringChar to std::string_view to be missing (while the corresponding conversion form OUStringChar to std::u16string_view was already present). The improvement to loplugin:stringadd became necessary to fix > [CPT] compilerplugins/clang/test/stringadd.cxx > error: 'error' diagnostics expected but not seen: > File ~/lo/core/compilerplugins/clang/test/stringadd.cxx Line 43 (directive at ~/lo/core/compilerplugins/clang/test/stringadd.cxx:42): simplify by merging with the preceding assignment [loplugin:stringadd] > File ~/lo/core/compilerplugins/clang/test/stringadd.cxx Line 61 (directive at ~/lo/core/compilerplugins/clang/test/stringadd.cxx:60): simplify by merging with the preceding assignment [loplugin:stringadd] > 2 errors generated. Change-Id: Ie40de0616a66e60e289c1af0ca60aed6f9ecc279 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107602 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-12-11Strength-reduce some OUStringToOString("..."+...)Stephan Bergmann
...to "..."+OUStringToOString(...), in preparation of making OUStringToOString take a std::u16string_view Change-Id: Ic01ca249d4d0eb58ac959ffdf96471308a3715dc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107600 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-12-11tdf#123613 XLSX export: fix position of rotated shapesSzabolcs Toth
based on the bounding box of the custom shape. Change-Id: I63a2a4380ae0c6c0eb37d3e5e4dcbfc839b410a3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107424 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-12-09tdf#138741 XLSX export: fix crash in setSkipUnusedFileIdsAttila Szűcs
Changed size of maConvertFileIdToUsedFileId vector to the same as maSrcFiles size. Some external references was not inserted into maRefCells, that resulted a smaller maConvertFileIdToUsedFileId as was needed. This crash was caused by: tdf#87973 XLSX export: fix lost file names in modified links f85d860ccbebd99bc128218148e2992c9415f221 Co-authored-by: Tibor Nagy (NISZ) Change-Id: I1501f5222483bf3e9e41c9e921a024320231dce8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107434 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-07tdf#43003 - convert parameter to the requested typeAndreas Heinisch
In StepPARAM convert parameters to the requested type, otherwise it loses possible references which leads to an error where the results of a macro has no effect on the caller. Change-Id: I8347eab658e037a29cd04be9c00edd6a4d1b31c3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107249 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-12-04Fix typoAndrea Gelmini
Change-Id: Ic47ae69728feeec6e91a478ebcbbde7b77cb9544 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107182 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-12-04exclude some more tests for !IsDefaultDPINoel Grandin
Change-Id: Ic0eab5c2a78b3bd40caf0521ca8fb6e5cdebff51 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107186 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-12-03tdf#87973 XLSX export: fix lost file names in modified linksAttila Szűcs
Calculate new indexes for external reference files to export it to xlsx. These indexes are calculated only temporary, only for exporting. Much better solution would be to change the indexes permanently, but the original indexes are stored so many places in the code (for example it is stored in cells formula tokens converted to string). So it would be a much bigger refactoring to be able to delete an external reference permanently... even just to reorder the indexes, require to modify a lot of code. Co-authored-by: Tibor Nagy (NISZ) Change-Id: If9254f6e62ec739e2b159a066ada7efdbceb3ad8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106895 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-12-03Related: tdf#138360 Use approxFloor() in rtl_math_round()Eike Rathke
Ditch mostly but not always working correction value and use approxFloor() instead which yields better results. With this we now have one single place approxValue() in case more fine grained tuning is needed. Unfortunately all numeric spreadsheet function tests use ROUND() in a manner such that they mostly blindly do a ROUND(...;12) regardless of magnitude, sometimes effectively rounding to the 14th significant digit that may fail in cases like for 14.2040730851385 ^ where the constant (rounded) value is stored as is but the calculated value is 14.204073085138471 and the old round() yielded 14.204073085139 for both but the new round() more correctly results in 14.204073085139 and 14.204073085138 so the spreadsheet test case sources had to be changed to ROUND(...;11) in such places. Change-Id: I211bb868a4f4dc9e68f4c7dcc2a187b5e175416f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107135 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2020-12-02tdf#137576 Improve cell anchored measure line in CalcRegina Henschel
Measure lines do not always have a logic rectangle. It might be empty or the 1cm x 1cm default square. But Calc needs it to calculate NonRotatedAnchor. The latter is needed for cell anchored shapes when saving in ODF. Always generating a logic rectangle in class SdrMeasureObj is difficult (I got crashes in Draw) and not necessary. Calc now forces the calculation of the logic rectangle where it is needed by Calc. Change-Id: I8689bc95985db1619eb5e72df99901bd52086cb2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106990 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2020-12-01Simplify nullptrStephan Bergmann
With 3741b90abe478fb04db88207b496a5238df35bb8 "tdf#138483 sc: update red circles after merging cells", UBSan builds had started to fail as CppunitTest_sc_subsequent_filters_test now need ScUndoRemoveMerge RTTI: > [CUT] sc_subsequent_filters_test > DynamicLibraryManagerException: "Failed to load dynamic library: workdir/LinkTarget/CppunitTest/libtest_sc_subsequent_filters_test.so > workdir/LinkTarget/CppunitTest/libtest_sc_subsequent_filters_test.so: undefined symbol: _ZTI17ScUndoRemoveMerge" But as pUndoRemoveMerge was always empty, we can just as well remove the variable completely. (Though I do not know whether pUndoRemoveMerge being empty is what 3741b90abe478fb04db88207b496a5238df35bb8 had actually intended.) Change-Id: Ie67dfe3c600ca5a290d091af033a230c581bf3a6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106963 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-12-01Revert "Revert "tdf#138483 sc: update red circles after merging cells""László Németh
This reverts commit 210ec3ef966b2f9206e9e52781f4cb9d2ed46300. Reason for revert: Build error has been solved in commit b208621f4ac5dc1ae40cb853f8662e8b10434cdc (Missing include (for ScMergeFlagAttr)) Change-Id: Ifc82872dd6e71c106d7ded69ca17d2ae2ba251db Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106829 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2020-11-30Revert "tdf#138483 sc: update red circles after merging cells"László Németh
This reverts commit 3741b90abe478fb04db88207b496a5238df35bb8. Reason for revert: error: invalid use of incomplete type ‘const class ScMergeFlagAttr’ Change-Id: I5acb47a1edb4821c441944c879dc314156358ed9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106828 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-11-30tdf#138483 sc: update red circles after merging cellsTibor Nagy
If there are detective circles on the cells and these cells are merged, the merged cell keeps all red circles instead of removed them except the circle of merged cell. Co-authored-by: Attila Szűcs (NISZ) Change-Id: I39c76cbb7c41affb0a18e5e82923945a2d41795d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106698 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-11-27tdf#138507: sc_subsequent_filters: Add unittestXisco Fauli
Change-Id: I1b9271d03c6bc61a63436054a74e455ad78bc68a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106712 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-11-27tdf#42949 Fix new IWYU warnings in directory sc/Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I217817e2e4a42b096f5a7fb6344568c10d69aab2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106078 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-11-26Introduce BootstrapFixture::IsDefaultDPI convenience functionMike Kaganski
It should be used to conditionally disable tests that are unreliable in non-default-DPI environments. The workaround implemented by use of the function should be temporary, until a proper fix is found. Change-Id: Ie236226fcfd0ffb054149efc2b7a1727506c4ad0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106661 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-11-26Check render parameters for AutoSpellCheckingMert Tumer
Conflicts: sc/qa/unit/tiledrendering/tiledrendering.cxx sw/qa/extras/tiledrendering/tiledrendering.cxx Change-Id: Ife2551b4023461da26e70ac3de505adf9d7db1e8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106602 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-11-25loplugin:stringview (clang-cl)Stephan Bergmann
Change-Id: I47b44c80b2a5e3c9d84f5d7257efe17f138a1067 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106563 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-11-24tdf#138428: sc_uicalc: Add unittestXisco Fauli
Change-Id: I8379ced4d04efcfaf355734d50a784bf29636140 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106455 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-11-24tdf#138137 sc: remove red circle in merged cellTibor Nagy
This mark wasn't removed when valid data is entered in the merged cell. Co-authored-by: Attila Szűcs (NISZ) Change-Id: I7632abadde9c482819f80af2600ab4c58292a821 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106172 Tested-by: Jenkins Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-11-24loplugin:stringviewparam extend to comparison operatorsNoel
which means that some call sites have to change to use unicode string literals i.e. u"foo" instead of "foo" Change-Id: Ie51c3adf56d343dd1d1710777f9d2a43ee66221c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106125 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-23tdf#131455: sc_uicalc: Add unittestXisco Fauli
Change-Id: I3a4960dc8a39c6ab9061aad08e6d3cb1c5c74bce Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106403 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-11-22Added rebeccapurple to html color palettedante
Do not add any notice on release notes. We are already 7 YEARS LATE. Act as if it has always been here. Change-Id: Ibb49f636a8618eb676e7361dd60671a42f60f7f8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106218 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-22Fix typoAndrea Gelmini
Change-Id: I972dfed5e228a802df140c0cd44c026654496896 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105918 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-11-20tdf#41845 sc: delete row/column with validation circlesTibor Nagy
Red validation circles around the cells were left after deleting their rows or columns, showing invalid data on the next valid or not-validated cells. Co-authored-by: Attila Szűcs (NISZ) Change-Id: I0dcef9225696b76eda78f0ee8831a83c20f53b0e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105527 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-11-20sc: Add unittest to check size of commentsXisco Fauli
Change-Id: I267f85a2d3394e4b97e294c25cd7a16e28bf8b7f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106223 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-11-20lok: minor cleanup of ViewCallback in tiledrendering testsAshod Nakashian
Change-Id: I39b964a7aa7d181083a153283f38c1a5bc64de58 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99973 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Ashod Nakashian <ash@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106222 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2020-11-20Replace matrix translate with object MoveRegina Henschel
TR*BaseGeometry is faulty for SdrMeasureObj, fixing these methods is a larger effort and Move is simpler anyway. So I replace the translation using matrices with the Move methods for objects. Backup and restore of the geometry values in state HiddenAsZero is now done with SdrObjGeoData. That is known to work from use in Undo methods. Change-Id: Ic32e8dbc5ae5f1a2f80e428448abc4b4a530b76b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106189 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2020-11-19tdf#129410: sc_subsequent_filters: Add unittestXisco Fauli
Change-Id: Ie9bc4086559a53f83af9e2f6a6649c51a1009847 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106153 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-11-19tdf#123936 Formatting files in module sc with clang-formatPhilipp Hofer
Change-Id: I66cafda863e3e1e4559a57289c09925d68b0719c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105701 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Jenkins
2020-11-18tdf#137397: sc: Add UItestXisco Fauli
Change-Id: I53530cc74dadae79b674d98076b92489a0508680 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106057 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
generated by cgit (git 2.34.1) at 2025-01-31 14:00:35 +0000