summaryrefslogtreecommitdiff
path: root/sc/qa
AgeCommit message (Collapse)Author
2020-04-09tdf#95425 follow-up: enable "Source format" checkbox of data labelBalazs Varga
settings after file opening, if its value is true in the opened ODF or OOXML document, instead of always showing disabled state. Testing notes: double click on a data label during chart editing of unit test document testAreaChartNumberFormat.docx of commit e57d90cd4e51a1353eafc87bb29cfe6076704a7c (tdf#129173 tdf#129175 Fix number format of data labels) to see the Data Labels for Data Series... window. On the page "Data Labels...", click on the Number format... button to see the enabled checkbox "Source format" (that was disabled previously). Change-Id: I2845e6f462db273f21c47bb286bed56046f8cf21 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91038 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-04-08tdf#122331: Add unittestXisco Fauli
Change-Id: I5c104f225b0d3fd060c36db6b3cef34f46534c61 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91906 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-04-08Make SalInstance::CreateClipboard return a single instance in the non-LOK caseStephan Bergmann
I came across this when seeing UITest_calc_tests2's tdf118189.tdf118189.test_tdf118189 fail on Linux with SAL_USE_VCLPLUGIN=gen and also on Windows, see the mailing list thread starting at <https://lists.freedesktop.org/archives/libreoffice/2020-April/084822.html> "Linux SAL_USE_VCLPLUGIN=svp and the clipboard". That email thread clarified that the codified behavior of that non-LOK test was wrong. (While the LOK test ScTiledRenderingTest::testMultiViewCopyPaste in sc/qa/unit/tiledrendering/tiledrendering.cxx keeps working as intended.) I did not find documentation for what arguments CreateClipboard shall support, but things seem to work if anything but empty arguments is rejected with an IllegalArgumentException. Change-Id: I1918254cc15878ad43b8aa22aff7eb1c4bea73fe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91869 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-04-03uicalc: no need to use an empty documentXisco Fauli
Change-Id: Id1c42b7c4f0f406d2979334d7b71fc20d7ff8620 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91615 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-03-31tdf#131372: Add unittestXisco Fauli
Change-Id: I7dbed0c28206ffd6a95ecedec74fdac044fe79cc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91432 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-03-27tdf#131380: Add unittestXisco Fauli
Change-Id: I9111c82919b9e30200fbb265143e072f7f3b3363 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91205 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-03-26Fix one more get_url_for_data_fileStephan Bergmann
Change-Id: I07e11cd83443f40fd520088c18647f0992ccae82 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91139 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-03-24tdf#131296: get numeric value with its data type in StepLOADNCAndreas Heinisch
In order to load numeric values, generate SbiOpcode::NUMBER_ opcodes including the numeric value and its data type instead of SbiOpcode::CONST_. The numeric value and its data type will be restored in SbiRuntime::StepLOADNC. When the new compiled code is stored in documents, e.g. password-protected libraries, leagcy LO versions will just read up to non-numeric characters, thus correctly obtaining number value and ignoring the type, so the change is backward-compatible. To interpret legacy compiled code, old treatment of SbiRuntime::StepLOADI is restored, reverting commit 0b4f8bf571baf2ccd5a8aafdc4deb41867420be3. This change reimplements the fix for tdf#129596. Change-Id: I46ebfc77f9bea69479968950c0fb7264e4a7ab27 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90858 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-03-16uitest: chartWall.py: assert changes in chartXisco Fauli
Change-Id: I8c9f4614a76015b0032347290f6b92b2892ddd10 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90588 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-03-16tdf#129985: Add unittestXisco Fauli
Change-Id: I9a8b923da6ca20fef9a61b9e478267d8c91ace58 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90573 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-03-16tdf#130371: Add UItestXisco Fauli
Change-Id: Ia1bd884d3aa4210e777ea59aece50940d3aa6f68 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90571 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-03-14tdf#130975 replace `rtl::math::isNan` with `std::isnan`.Yukio Siraichi
Change-Id: I5d53e6369d35093445b2efd8936bbf8c6775ff47 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90451 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-03-13uitest: select child instead of moving downXisco Fauli
Change-Id: I2df86546eb617c67b889382e2e968c2476375ff8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90471 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-03-13uitest: chartDataLabels.py: assert changes in chartXisco Fauli
Also removed commented code. The new asserts also check the changes done are not overwritten after reopening the dialog Change-Id: Icc7d1950ace395b88647658b3eab1b5ec35e467c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90429 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-03-13uitest: import missing LocaleXisco Fauli
Change-Id: I5021b9b207e2cbbe402abbae69a714c813078a32 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90472 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-03-13replace tabs with spaces, and unclog clang buildbotNoel Grandin
since commit 02c9e05551d69980e0757b1b0a624692ea21a96b Date: Thu Mar 12 17:34:12 2020 +0100 tdf#131291: Add UItest Seems that only some buildbots are being strict about this and generating an error like: IndentationError: unindent does not match any outer indentation level Change-Id: Ifc8d01eefca0028cf134c8e71237fc0b59bc27d5
2020-03-12tdf#131291: Add UItestXisco Fauli
Change-Id: I65aede1899d2c509fd52f8db0657ec3a5791f681 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90430 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-03-12tdf#83901: move UItest to CppunitTestXisco Fauli
Change-Id: I0d074da097912f8abba6bae6171596076d71e998 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90345 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-03-12Revert "loplugin:constfields in sc"Noel Grandin
This reverts commit fb1d3b580763a333bbbfe115d09e1b5cd8849675. Now that we know that making fields has negative side effects like disabling assignment operator generation. Change-Id: Ib48334ffbeb2c768896dd8ced6818aa0b9910b0b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90333 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-10tdf#124815: move UItest to CppunitTestXisco Fauli
Change-Id: If6482bf6666f00c3c613315cd18d188239ea61f3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90265 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-03-10tdf#124816: move UItest to CppunitTestXisco Fauli
Change-Id: I2ad49fc599bf2c0d4be79967e935abed13e75970 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90264 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-03-10tdf#126904: Add unittestXisco Fauli
Change-Id: Ie5ec86642bcd4a8822d885d18516ee3ad6fecbfe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90250 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-03-10tdf#122232: move UItest to CppunitTestXisco Fauli
Change-Id: I6cb9019fea4b1be5af94dcc8811a4f96fc1b6d37 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90238 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-03-05Rename method setReplacementElement()Jens Carl
... to setElement() to have a uniform interface with similar classes like XNameContainer. Change-Id: I2058e3ea9f14a5792a07f23f4bd13c4708dccdfc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89784 Tested-by: Jens Carl <j.carl43@gmx.de> Reviewed-by: Jens Carl <j.carl43@gmx.de>
2020-03-02uitest: check copy in .uno:MoveXisco Fauli
Change-Id: I916d3853500705b1037aa669374511c184402313 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89822 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-03-02Add XServiceInfo tests to ScTableSheetsObjJens Carl
Change-Id: Iaaadc2554bb0ce103ef01bbf02c316d21fae51af Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89761 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2020-02-29ofz#20904 check boundsCaolán McNamara
Change-Id: I5d6d381ebd359b233b309e08131f3dda21310d80 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89620 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-27tdf#45904 Move XNameContainer Java tests to C++Jens Carl
Move missing XNameContainer Java tests to C++ for ScTableSheetsObj. Change-Id: I63a91487ab2e50b97c937edae929c43261553db9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89614 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2020-02-27tdf#45904 Move XElementAccess Java tests to C++Jens Carl
Move XElementAccess Java tests to C++ for ScTableSheetsObj. Change-Id: Ibc9d7e164e82387159a51568157c1d3b0756bf05 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89610 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2020-02-27tdf#130959: Add unittestXisco Fauli
Change-Id: Ib66a2a48b6e0d746fc54d2b1987a574c26ea1c1e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89619 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-02-27Related: tdf#130725: use strtod also in rtl::math::stringToDoubleMike Kaganski
Size of buffer on stack is 256 characters. Logging function usage in make check, of >1 100 000 invocations, the longest string was 80 characters, average being 4.6 characters. So heap allocation is unlikely in scenarios with intensive function usage. Several existing unit tests had to be fixed. Usually, the change is either minimal or getting closer to what Excel returns (for Calc tests). But in case of AMORDEGRC, I had to change rate value passed to the function from 0.3 to 0.31. It's because the closest double value for 0.3 is 0.29999999999999999, which is a bit less than 0.3; multiplied by 1.5, this gives 0.44999999999999996, and then rounding the result of multiplication of the latter by cost gave the result 1 less than before, when 0.3 was imported as 0.30000000000000004. Now the function returns a value 1 less than Excel for that set of arguments. I don't see how to fix that. Having rate slightly different gives consistent result between Calc and Excel. Change-Id: Icae5ce374fe0c31a1aa10cee815e65ef0014f382 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89422 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-02-27tdf#130725: use strtod by David M. Gay to make sure we get the nearestMike Kaganski
... representation of given decimal. Use dtoa.c from https://www.netlib.org/fp/dtoa.c to build a custom static library that doesn't use current locale (unlike strtod from stdlib.h). This is the implementation used by e.g. python and nss (search for "dtoa.c" under UnpackedTarball). To avoid name clash with the standard strtod, rename the function to strtod_nolocale. Size of buffer on stack in ImpSvNumberInputScan::StringToDouble is 256 characters. Logging function usage in make check, of ~124 600 invocations, the longest string was 14 characters, average being 2.1 characters. So heap allocation is unlikely in scenarios with intensive function usage. After std::from_chars is available in baseline compilers, external library can be dropped, and call to strtod_nolocale replaced with the standard function. The artifact at https://dev-www.libreoffice.org/src/dtoa-20180411.tgz is created with mkdir dtoa && mkdir dtoa/src && wget https://www.netlib.org/fp/dtoa.c -O dtoa/src/dtoa.c && \ printf 'd8bab255476f39ea495c8c8ed164f9077da926e6ca7afb9ad3c56d337c4484fe dtoa/src/dtoa.c' | sha256sum -c && \ tar -c --owner=0 --group=0 --mode=go=r,u=rw --mtime='Wed, 11 Apr 2018 15:59:39 GMT' dtoa/src/dtoa.c | gzip -n > dtoa-20180411.tgz && \ printf '0082d0684f7db6f62361b76c4b7faba19e0c7ce5cb8e36c4b65fea8281e711b4 dtoa-20180411.tgz' | sha256sum -c (where the date "Wed, 11 Apr 2018 15:59:39 GMT" is from `wget -S https://www.netlib.org/fp/dtoa.c` "Last-Modified: Wed, 11 Apr 2018 15:59:39 GMT" header). Change-Id: Ia61b7678e257c4bc1ff193f3f856d611aa5c1a21 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88854 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-02-27loplugin:unusedfieldsNoel Grandin
Change-Id: I0d3941ed2a6f0caadbe080ac8a6273c5ec21462c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89616 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-27tdf#45904 Move XIndexAccess Java tests to C++Jens Carl
Move XIndexAccess Java tests to C++ for ScTableSheetsObj. Change-Id: Idb130a51dc024cebbbc739d15c767f99558a69b7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89609 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2020-02-26Unit test tdf#130825 insert/delete sheet moving sheet-local namesEike Rathke
Change-Id: I1f0aed734ebb2c1035e06350d3508becb0d68b4d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89476 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2020-02-26tdf#45904 Move XNameReplace Java test to C++Jens Carl
Move XNameReplace Java test to C++ for ScTableSheetsObj. Fixes i#23594 by creating a new "com.sun.star.sheet.Spreadsheet" rather then using an existing one. Change-Id: If7058647cc5d79d11e5542a82017d5bd02f7049e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89493 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2020-02-26tdf#45904 Move XNameAccess Java tests to C++Jens Carl
Move XNameAccess Java tests to C++ for ScTableSheetsObj. Change-Id: I5fdaafe35852ea3c6e260d490200ce99e990c3b6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89408 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2020-02-25Unit test tdf#130370 cut&paste / move with sheet-local named referenceEike Rathke
Change-Id: I28473558e028012ce0a4ca881549e808bc34aad1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89391 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2020-02-24tdf#130762: Add uitestXisco Fauli
Change-Id: Iff2cedfec6e17a46f160797d32fd1a565abfe0f0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89342 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-02-21Drop o3tl::optional wrapperStephan Bergmann
...now that macOS builds are guaranteed to have std::optional since 358146bbbd1b9775c12770fb5e497b6ec5adfc51 "Bump macOS build baseline to Xcode 11.3 and macOS 10.14.4". The change is done mostly mechanically with > for i in $(git grep -Fl optional); do > sed -i -e 's:<o3tl/optional\.hxx>\|\"o3tl/optional\.hxx\":<optional>:' \ > -e 's/\<o3tl::optional\>/std::optional/g' \ > -e 's/\<o3tl::make_optional\>/std::make_optional/g' "$i" > done > for i in $(git grep -Flw o3tl::nullopt); do > sed -i -e 's/\<o3tl::nullopt\>/std::nullopt/g' "$i" > done (though that causes some of the resulting #include <optional> to appear at different places relative to other includes than if they had been added manually), plus a few manual modifications: * adapt bin/find-unneeded-includes * adapt desktop/IwyuFilter_desktop.yaml * remove include/o3tl/optional.hxx * quote resulting "<"/">" as "&lt;"/"&gt;" in officecfg/registry/cppheader.xsl * and then solenv/clang-format/reformat-formatted-files Change-Id: I68833d9f7945e57aa2bc703349cbc5a56b342273 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89165 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-02-17Fix UITest_options: changed property nameJan-Marek Glogowski
Seems the color widget was changed into a tree at some point, so the entry amount is now in "Children" instead of "EntryCount". Change-Id: Ief6e6d0ebc4a6571a7f7e978b838eb49b2e051cf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88831 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2020-02-17tdf#123971 don't clobber entire RowHeight range on updatesThorsten Behrens
Use start index from current loop variable, not full range; otherwise we're always clobbering values from (possibly higher) upper rows. Change-Id: I3add7c2358710f4ae3927e7b0a1c1ff544965a03 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88785 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-02-14tdf#121963: Add unittest (part 2)Xisco Fauli
Forgot to add the .cxx file. Thansk to Miklos for noticing Change-Id: I922680fde98f51f4339fb0e188310b0d7cc635a7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88708 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-02-14tdf#121963: Add unittestXisco Fauli
Change-Id: I33435643d1f4c0af8c846094f9f40845d6327b60 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88627 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-02-14tdf#130556: Add unittestXisco Fauli
Change-Id: Iab632cd3afe6bb1c5f90a700a452c6c4dad14261 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88617 Tested-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-02-10Remove redundant ScTabView::GetSdrViewStephan Bergmann
See the comments at <https://gerrit.libreoffice.org/c/core/+/87872> "Removed old comment" how it was presumably used in the distant past to address <https://docs.microsoft.com/en-us/cpp/error-messages/compiler-errors-1/ fatal-error-c1055?view=vs-2019> "compiler limit : out of keys". Change-Id: I168532403fe04111ce1af08d43924a426c09c42d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88379 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-02-07tdf#129789: Add unittestXisco Fauli
Extend it to cover all fill styles in shown/hidden comments Change-Id: I866d1b7f6248a5b5520348b249ed3cda4eec46dc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88122 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-31loplugin:singlevalfieldsNoel Grandin
Change-Id: I77ccf3f36363e182a644b98cdf720f1381a5cceb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87766 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-29tdf#130132, tdf#129393: Add unittestXisco Fauli
Change-Id: Ia613dca3dc8bb1aa2e45e73149932be6ac61f8cb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87691 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-01-28remove some unused local varsNoel Grandin
found by my new loplugin:unusedvariableplus Change-Id: Ic3f55f492d43a53d8850a97d44059ff127fd69a2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87573 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2025-01-24 00:52:06 +0000