summaryrefslogtreecommitdiff
path: root/sc/qa
AgeCommit message (Collapse)Author
2018-10-30sc: Fix a wrong reference in a SMALL()'s test caseTakeshi Abe
Change-Id: I6eb5491cb437745a787304bde9f5673e63892773 Reviewed-on: https://gerrit.libreoffice.org/62380 Tested-by: Jenkins Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2018-10-29uitest for bug tdf#67346Zdeněk Crhonek
Change-Id: I637a9811ac656db46e0e993343e962dc296e360b Reviewed-on: https://gerrit.libreoffice.org/62527 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2018-10-29uitest for bug tdf#54197Zdeněk Crhonek
Change-Id: Iaa6039f9ebabdd4b17e044a82b4e047506addf79 Reviewed-on: https://gerrit.libreoffice.org/62522 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2018-10-27uitest Calc signature lineZdeněk Crhonek
Change-Id: I249c843f89ed5fe1d413f17fa57671d4ef9c69b2 Reviewed-on: https://gerrit.libreoffice.org/62404 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-10-27tdf#120703 (PVS): V519 The variable is assigned values twice successivelyMike Kaganski
Change-Id: I9265425a215609ef6bf4298ba39c8399f215ce27 Reviewed-on: https://gerrit.libreoffice.org/62406 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-10-25Resolves: tdf#113977 implement REGEX() spreadsheet functionEike Rathke
REGEX( Text ; Expression [ ; Replacement ] ) Using ICU regular expressions http://userguide.icu-project.org/strings/regexp Change-Id: I4cb9b8ba77cfb5b8faab93037aa0d947609383d7 Reviewed-on: https://gerrit.libreoffice.org/62332 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2018-10-24remove more rtl::OUString and OString prefixesNoel Grandin
which seem to have snuck back in since the great rounds of removals. Change-Id: I85f7f5f4801c0b48dae8b50f51f83595b286d6a1 Reviewed-on: https://gerrit.libreoffice.org/62229 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-18add test for bug tdf#73081Zdeněk Crhonek
Change-Id: I96f56cee0cab3fa18992281e3745164377adade3 Reviewed-on: https://gerrit.libreoffice.org/61939 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2018-10-18loplugin:staticvar in scNoel Grandin
Change-Id: I9f1d66e9af454a27a341e56bbe50a558898b65a1 Reviewed-on: https://gerrit.libreoffice.org/61900 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-17clang-tidy readability-redundant-smartptr-getNoel Grandin
redundant get() call on smart pointer Change-Id: Icb5a03bbc15e79a30d3d135a507d22914d15c2bd Reviewed-on: https://gerrit.libreoffice.org/61837 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-16tdf#45904 Move _XTableChartsSupplier Java Tests to C++Rahul Gurung
Change-Id: I4cd0b25cefce60e8253df65d5136d15d690dbc38 Reviewed-on: https://gerrit.libreoffice.org/61540 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-10-16Unit test deleting shared formula group top cell, tdf#119623Eike Rathke
Change-Id: I9a497b9d9ae09c8764f62549a60c8a2a952bc9e9 Reviewed-on: https://gerrit.libreoffice.org/61822 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2018-10-16tdf#42949 Fix IWYU warnings in sc/source/ui/inc/[a-e]*Gabor Kelemen
Also files starting with capital letters. Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ia79de45524315e2aaa1283ee6e42c54c9e14a31e Reviewed-on: https://gerrit.libreoffice.org/61735 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-10-15sc: Let SKEW/SKEWP raise #!DIV/0 when < 3 numbers are givenTakeshi Abe
as ODF 1.2 mentions such constaints of these functions, and Excel's documentation also admits it with more specific remark: <https://support.office.com/en-us/article/skew-function-bdf49d86-b1ef-4804-a046-28eaea69c9fa> <https://support.office.com/en-us/article/skew-p-function-76530a5c-99b9-48a1-8392-26632d542fcb> Change-Id: If19350997ddcb6f0fb36e29e090e260c3ae3d262 Reviewed-on: https://gerrit.libreoffice.org/61130 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2018-10-15sc: Make KURT() return #DIV/0! when <4 arguments are givenTakeshi Abe
as Excel does: <https://support.office.com/en-us/article/kurt-function-bc3a265c-5da4-4dcb-b7fd-c237789095ab> Change-Id: I1059e6e5dd9f01688219492e76af6dbbe97be41a Reviewed-on: https://gerrit.libreoffice.org/61286 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2018-10-15loplugin:constfields in scNoel Grandin
Change-Id: If326175d571d15752efd1b63df45b2bc785f7541 Reviewed-on: https://gerrit.libreoffice.org/61653 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-11tdf#111980 oox optionbutton autoGroup inside GroupBoxJustin Luth
The area of a GroupBox indicates which radio buttons are considered to be part of the same group. The button needs to be fully inside of the groupbox in order to participate. This patch resolves the last worry of commit 9f969799629fe6bdf8b922d8cb922846aa646ece Change-Id: Ie6057337c63bf9eb173a0615e30c8d4e4d0c7a19 Reviewed-on: https://gerrit.libreoffice.org/61131 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-10-10ColumnSpanSet variant optimized for just one ScRangeLuboš Luňák
Since ScInterpreter::IterateParameters() iterates over just one range, there's no point to to set flags for that range and then generically walk over that range, just directly use the range. Change-Id: I13003eb09bd98f145e9ead5e485596168d9399cb Reviewed-on: https://gerrit.libreoffice.org/60866 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2018-10-09Extend loplugin:redundantinline to catch inline functions w/o external linkageStephan Bergmann
...where "inline" (in its meaning of "this function can be defined in multiple translation units") thus doesn't make much sense. (As discussed in compilerplugins/clang/redundantinline.cxx, exempt such "static inline" functions in include files for now.) All the rewriting has been done automatically by the plugin, except for one instance in sw/source/ui/frmdlg/column.cxx that used to involve an #if), plus some subsequent solenv/clang-format/reformat-formatted-files. Change-Id: Ib8b996b651aeafc03bbdc8890faa05ed50517224 Reviewed-on: https://gerrit.libreoffice.org/61573 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-10-08Added date time transformations - follow-upVikas Mahato
Change-Id: I130feda7c835b067a542736ad6fadc79cabc4f41 Reviewed-on: https://gerrit.libreoffice.org/59413 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2018-10-08use more std::unique_ptr in ScDBCollection::NamedDBsNoel Grandin
Change-Id: I5825208435fd179e9515e731a24a6e5bf1c94431 Reviewed-on: https://gerrit.libreoffice.org/61436 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-08use more std::unique_ptr in ScDPCollectionNoel Grandin
Change-Id: I7d76704ba76b0d47544456047bc699b12fa7c288 Reviewed-on: https://gerrit.libreoffice.org/61435 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-05sc: Enhance binary search for ScMarkArraySerge Krot
Change-Id: I0fe6a0b8987fb3c3229c5aabcbf056cfb365650c Reviewed-on: https://gerrit.libreoffice.org/61373 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-10-04tdf#120301 oox: lclIsWhiteSpace should return true for a spaceJustin Luth
Change-Id: I72c79c1fed4d9a91bf02024eef23cd3b1a58632e Reviewed-on: https://gerrit.libreoffice.org/61388 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2018-10-03loplugin:mergeclass merge ScFullMatrix into ScMatrixNoel Grandin
ever since commit b26f83b1cc184a79caa9e9c0ae15717ef61dde4a Date: Fri Aug 10 21:43:32 2018 +0200 loplugin:unusedmethods mostly this seems to be fallout from commit 089a4f245325a5be5cd5951d85305d791b4d9cb6 Date: Mon Aug 6 14:55:04 2018 +0200 remove Calc's software interpreter Change-Id: Id1cb89bb3d95521b7ddf7d072ee9392053e5a52b Reviewed-on: https://gerrit.libreoffice.org/61257 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-02tdf#120174 : Always copy mbValueCached flag in Assign()Dennis Francis
so that fast result return maintains correctness. Although not necessary for fixing this bug, lets take advantage of fast result return in the case of empty result token by setting mfValue to 0.0 and setting mbValueCached flag. The fast result return was implemented in :- <commit-header> commit 77f7b4768a79e5a8489b163670e0ce10fbd07c49 Author: Dennis Francis <dennis.francis@collabora.co.uk> Date: Wed Jul 11 17:19:28 2018 +0530 Allow fast result return for formula-cells with... "double" result which is a very frequent use-case. This improves overall running times in most cases, not just for the threaded path. Change-Id: I18d10ee3cea613923e2057e746a6a8187bb18647 Reviewed-on: https://gerrit.libreoffice.org/59395 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com> </commit-header> Also added a ui-test for the fix. A normal unit test would have sufficed, but I could not get it to reproduce the issue from a ucalc environment somehow. Change-Id: I9b95b571b596a7bb68768ea0de8ee4334448b540 Reviewed-on: https://gerrit.libreoffice.org/61140 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Jenkins
2018-10-01loplugin:useuniqueptr in ScCondFormatDataNoel Grandin
Change-Id: I93c906bfb84143ff101577e8e1ef8f5ffb07a0a7 Reviewed-on: https://gerrit.libreoffice.org/61114 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-29tdf#111980 sc optionbutton autoGroups different for form/activeXJustin Luth
This patch only affects calc. (Perhaps .xls* is the only format that supports non-activeX radio buttons?) Commit 9f969799629fe6bdf8b922d8cb922846aa646ece worried about form and activeX buttons sharing the autoGroup_. This patch prevents that. Change-Id: Ia57a14f1cdd6363aa5d6d991469668fcc56016ca Reviewed-on: https://gerrit.libreoffice.org/61095 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2018-09-28Added base as a data providerVikas
Change-Id: Iaf23b70f303cd05bcf6450fed1246de894285526 Reviewed-on: https://gerrit.libreoffice.org/57447 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-09-28weld ScAttrDlgCaolán McNamara
Change-Id: I11eb9001604a1997a8bfa80a144306ddcb913d93 Reviewed-on: https://gerrit.libreoffice.org/61011 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-28weld SvxNumberFormatTabPageCaolán McNamara
Change-Id: Ia6e6497d5c9b6c47e34e5cb5b3913d25e73c3a69 Reviewed-on: https://gerrit.libreoffice.org/60944 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-28tdf#111980 oox: connect empty radio groupsJustin Luth
affects doc, docx, xls, xlsx (at least). Handling optionbutton groups is new since 2017, so incremental enhancements are OK. In LO, if an option button with an empty groupName (like any form control which has no groupName option), then it stands alone, which is a ridiculous position to be in for a radio button. So, lets put them all together into an automatic group. In MSO, buttons without any explicit group stick together, so the effective group is the entire document, or entire sheet. One complication is that ActiveX radio buttons don't interact with Form radio buttons, even if all of them have no group name. That situation is not handled by this patch (and not very likely to happen since ActiveX defaults the group name to the sheet name). (A Group Box can also be used, which automatically groups all buttons fully within its area. That will be much harder to implement since every object will need to first be categorized as groupbox or optionControl - meaning that everything must first be imported. That implies a function call from every application doing the import.) Change-Id: I204adaea75ce99999a16c0cc4e9c3b8b08da9433 Reviewed-on: https://gerrit.libreoffice.org/61064 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2018-09-22tdf#45904 Move _XIndent Java Tests to C++Rahul Gurung
Change-Id: I65b594db595f0e08a50a9ea18baf44c496cf18e3 Reviewed-on: https://gerrit.libreoffice.org/60218 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-09-20Replace SAL_OVERRIDE with override in internal codeStephan Bergmann
Change-Id: Ifa446647b11fd1f1b0dc6a991b752480545634db Reviewed-on: https://gerrit.libreoffice.org/60788 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-09-18executeAction("BACKSPACE") doesn't do anythingCaolán McNamara
tests are working because of the previous ctrl+a Change-Id: Ib44351da1680484c3d4a9d0a8d6cb6ba6002d63b Reviewed-on: https://gerrit.libreoffice.org/60673 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-17Fix typoAndrea Gelmini
Change-Id: Id3f164a5b5016fd7f1e33a0cb9e94ee84c1df6e5 Reviewed-on: https://gerrit.libreoffice.org/60566 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-09-17New loplugin:externalStephan Bergmann
...warning about (for now only) functions and variables with external linkage that likely don't need it. The problems with moving entities into unnamed namespacs and breaking ADL (as alluded to in comments in compilerplugins/clang/external.cxx) are illustrated by the fact that while struct S1 { int f() { return 0; } }; int f(S1 s) { return s.f(); } namespace N { struct S2: S1 { int f() { return 1; } }; int f(S2 s) { return s.f(); } } int main() { return f(N::S2()); } returns 1, both moving just the struct S2 into an nunnamed namespace, struct S1 { int f() { return 0; } }; int f(S1 s) { return s.f(); } namespace N { namespace { struct S2: S1 { int f() { return 1; } }; } int f(S2 s) { return s.f(); } } int main() { return f(N::S2()); } as well as moving just the function f overload into an unnamed namespace, struct S1 { int f() { return 0; } }; int f(S1 s) { return s.f(); } namespace N { struct S2: S1 { int f() { return 1; } }; namespace { int f(S2 s) { return s.f(); } } } int main() { return f(N::S2()); } would each change the program to return 0 instead. Change-Id: I4d09f7ac5e8f9bcd6e6bde4712608444b642265c Reviewed-on: https://gerrit.libreoffice.org/60539 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-09-16uitest for bug tdf#105544Zdeněk Crhonek
Change-Id: I913a46d371cb537acbb29d3a4da8223d1fa98a55 Reviewed-on: https://gerrit.libreoffice.org/60554 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2018-09-16uitest for bug tdf#116996Zdeněk Crhonek
Change-Id: I679f1269c0e666859eda61ed9ac81d2755a84dc4 Reviewed-on: https://gerrit.libreoffice.org/60508 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2018-09-14weld SvxCharNamePageCaolán McNamara
Change-Id: Ia54a5ac4fe4a11b7c03508c336193bb52c616e7f
2018-09-13More temp copies of test docs in Python/UITestsStephan Bergmann
...similar to d76281864b0e83812c0edf7490b1e8271e89fff5 "Create temp copies of test docs in Python/UITests", which only fixed those places that were broken with a read-only SRCDIR. However, I now ran into a deadlock on Linux (where UITests are run with SAL_USE_VCLPLUGIN=svp) that suggests that /all/ documents from SRCDIR that are opened by those tests should better first be copied to WORKDIR sub-dirs (that are removed prior to running tests, so stale lock files cannot exists). This commit addresses just a small part of all those tests, though. I had cancelled (ctrl-c) a `make check` midway, when it happened to be in the middle of UITest_calc_tests2 and left beind a sc/qa/uitest/calc_tests/data/.~lock.stableSorting.ods# lock file (which records, among other things, the host name). I then dropped off a VPN, which caused the host name as seen by LO to switch from "alpha" to "alpha.fritz.box", then re- started the build as `make check screenshot` (which was the thing I'd originally intended, but forgotten the screenshot target). The new built hung during UITest_calc_tests2's sc/qa/uitest/calc_tests2/stableSorting.py, as loading sc/qa/uitest/calc_tests/data/stableSorting.ods found the lock file with non- matching host name in SfxMedium::LockOrigFileOnDemand, and hung in SfxMedium::ShowLockedDocumentDialog -> UUIInteractionHandler::handle -> (switch to main thread...) -> UUIInteractionHelper::handleLockedDocumentRequest -> ... -> Dialog::Execute, which just blocks in svp mode (which, unlike --headless, doesn't cause Application::IsDialogCancelEnabled). Change-Id: I999af50d6b1e5012d3978f5e476bcbfc9be6fd1d Reviewed-on: https://gerrit.libreoffice.org/60439 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-09-10tdf#45904 Move _XMergeable Java Tests to C++Rahul Gurung
Change-Id: I37dc759a64301810a7d32a3f160b9bcbf546dd01 Reviewed-on: https://gerrit.libreoffice.org/60211 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-09-10tdf#45904 Move _XChild Java tests to C++Rahul Gurung
Change-Id: Idaf883eadb95792bdb333dea487be084b1722194 Reviewed-on: https://gerrit.libreoffice.org/60146 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-09-07tdf#108691, tdf#119639 Don't print hidden objects in XLS(X)Aron Budea
In Excel hidden drawing objects aren't printed. When not hidden, printing is controlled by a separate 'Print object' setting. Only rely visibility setting for now, but properly: visible means also printed, hidden means not printed. Ie. import visible property also as printable, and only output visible property in XLS(X) formats. For the future, in XLSX format printability is controlled by attribute 'fPrintsWithSheet' of element 'clientData', don't know about XLS, there fUsefPrint/fPrint bits don't appear to be used anymore (see note in tdf#119639). Change-Id: I728107b30056f7bf073f2fefddece1bef1eb2e7a Reviewed-on: https://gerrit.libreoffice.org/59915 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-09-07tdf#116453: Add a test case for this.Kohei Yoshida
Change-Id: I280f070bf974ac2f4a889f4c98a80a87092c013a Reviewed-on: https://gerrit.libreoffice.org/60118 Tested-by: Jenkins Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2018-09-06tdf#45904 Move _XColumnRowRange Java tests to C++Rahul Gurung
Change-Id: I35b5fc2f18867c386c8c92d1d7a3a0823bd07b78 Reviewed-on: https://gerrit.libreoffice.org/59863 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-09-05tdf#117287 When saving as Xlsx, export visible flag if comment is visbleIlhan Yesil
The visible flag will be exported now, when a comment is visible and the file is saved as Xlsx. Change-Id: Id05ab5f94ea85f48db123d1043ecdc4813a64382 Reviewed-on: https://gerrit.libreoffice.org/59934 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-09-05tdf#45904 Move _XCell Java tests to C++Rahul Gurung
Change-Id: I79d8f42932f81bf8a2eb38fbd3eabbdf56c09111 Reviewed-on: https://gerrit.libreoffice.org/59901 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-08-31tdf#112454 Add tests for ScDocument::ContainsNotesInRangeMichael Weghorn
Change-Id: Ic8867c69ae537f785a5928849e247174e92ac437 Reviewed-on: https://gerrit.libreoffice.org/59816 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-08-31tdf#73078 Add/Enable test for TYPE function on empty cellMichael Weghorn
Change-Id: Idcd02a1c59447833f72bb0310912c65e082e70ef Reviewed-on: https://gerrit.libreoffice.org/59827 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins