summaryrefslogtreecommitdiff
path: root/sc/source/core
AgeCommit message (Collapse)Author
17 hourscid#1465236 Uncaught exceptionCaolán McNamara
and drop coverity workarounds Change-Id: If9ffc607999285b2f5b63e85c51b0289fb05750f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180531 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
38 hourstdf#164685 Cleanup SfxItemSetFixedrafaelhlima
Cleanup of class SfxItemSetFixed as described in the bug ticket. Change-Id: I0704ab45624217a8d00a942e0e8d6d6276934306 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180255 Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com> Tested-by: Jenkins
41 hourstidy lambda capturesCaolán McNamara
Change-Id: Ifb0a815cdf93e18a5ad10ef4cfb2b772f5032df2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180488 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
3 dayscid#1640473 COPY_INSTEAD_OF_MOVECaolán McNamara
Change-Id: Id8e440ea08e2d6a853e870dc0161d30e63b75cc9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180436 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
5 dayssc: make data validy error dialog async (invalid value error)Pranam Lashkari
Change-Id: Icd077776b26e21b226b4dee5beb1a5ff6dcf301a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179509 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> (cherry picked from commit 495be2dcb34d22af59a2028d3a686a0d48774166) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180286 Tested-by: Jenkins Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
5 dayssc: fix some checksXisco Fauli
See https://gerrit.libreoffice.org/c/core/+/180245/comment/59cd8c41_737390e6/ After commit ee05b94e713adbc7af3e29ac6018c5e825511c96 Author: Xisco Fauli <xiscofauli@libreoffice.org> Date: Tue Jan 14 16:19:06 2025 +0100 tdf#150879: Add support for TOCOL function and commit c1565b8b94548ef85508b0302ef9299f18ff09be Author: Balazs Varga <balazs.varga.extern@allotropia.de> Date: Fri May 10 17:06:39 2024 +0200 tdf#126573 Add Excel2021 array function UNIQUE to Calc Change-Id: I277cb1e998d1ef33f319beec42c990bc8effefe9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180346 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
6 daystdf#150878: Add support for TOROW functionXisco Fauli
Change-Id: Ic1acb5c2fd08ecab7c3ee059888cf44aa45ee287 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180308 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
6 daystdf#150879: Add support for TOCOL functionXisco Fauli
Change-Id: I0c8bfdd8f9b806a1260cceace1ced4be2b046abb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180245 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de> Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins
11 daysITEM: Refactor ItemTypeArmin Le Grand (Collabora)
ItemType is useful and faster than RTTI. Until now it was implemented by a 16-bit member in the base class, plus (potentially) all constructors having to hand a value in at item construction type (of type SfxItemType) to get that member set correctly. This works, but there is no reliable way to guarantee coverage, and there have already been cases with missing SfxItemType - these fallback to '0' and thus all Items with ItemType() == 0 are assumed equal and might be static_cast'ed to the wrong classes. Note that I identified *35* Items that had no correct ItemType set/implemented actually. It also uses 16-bit per incarnated Item at runtime. I thought and realized now a more systematic approach to do that with a pure virtual function at the Item itself. That can also be secured by a clang compiler plugin in the future to keep it working. It uses one virtual function per derived class, no longer space in incarnated Items. Also the constructors will get more simple again. But the main aspect is security - we cannot afford Items potentially being held as equal if they are not. Unfortunately C++ does not offer something like a 'strict pure virtual function' that would force to be overloaded in every derivation, but the used methotology and adding a clang test is reasonably safe. Have now done the cleanup of previous method. Change-Id: I04768285f1e9b73d64b0bb87df401944b5d35678 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180017 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
12 daystdf#162286 Add a category to store favorite functions in FWAhmedHamed
Change-Id: Iec0d169570ba3d29501a4917d8858a9e9438f608 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171828 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2025-01-06crashtesting: assert on reimport of forum-mso-en4-29087.odsCaolán McNamara
conversion of xlsx to ods and reload Change-Id: I8f1f10520e3601326405acd90a310ebd6163ffbe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179834 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2025-01-01tdf#114441 Convert use to sal_uLong to sal_uInt32kkasliwal
Change-Id: I26669ed7a15b27314e97ec29076d07f798a54ba0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179572 Tested-by: Jenkins Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2024-12-26cid#1636890 presumably Division by zero shouldn't arise hereCaolán McNamara
Change-Id: Id9a5267ce250143c8c7d87ad477d8fe538bb1b1b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179314 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-12-23optimise ScBoundsProvider::GetIndexTowardsNoel Grandin
Especially when laying out rows in sheets with thousands of rows. By pushing the work down to a new GetRowForHeightPixels method, we can do the work in only a couple of iterations of the loop, because row heights are normally represented by only a few spans. Change-Id: If3f62a131a3e7a0794d7352d7c6c1a5de0ef2df0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179086 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-12-23tdf#42989: don't set fake ATTR_VALUE_FORMAT for multi-format selectionMike Kaganski
Change-Id: Iaed133b19c4d870ff85fd9d2dd69db36318bb28e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179190 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-12-23Simplify a bitMike Kaganski
Change-Id: Ic02ee03a800e3e92fafd73efed5aa0fd803f454b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179195 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-12-21Re-write ScTable::GetRowForHeightNoel Grandin
Cleanup up this method, making it more organised in how it iterates over spans, and adding asserts to verify assumptions. The asserts uncovered that we are sometimes fed bad data, so now we deal with that (and not sanitising the input is possibly why the original code was a little weird). Also, now that we are returning correct data, our caller does not need to correct the return value Change-Id: I094931bb2e93a3273b7a928fc7e83eed75e3db51 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179040 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-12-18tdf#157476 tdf#150861 - sc fix autoFilter is filtering incorrectlyBalazs Varga
caused by rounding problem with duplicated values. We need to store the rounded values, based on the numberformat precision, otherwise later can cause problems at removing the duplicated values. Regression from: f6b143a57d9bd8f5d7b29febcb4e01ee1eb2ff1d Change-Id: I19f5248122ffca1e52adb96714df79dd9c64b23c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178683 Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de> Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de> Tested-by: Jenkins
2024-12-17sc: Dereference after null checkXisco Fauli
C:/cygwin64/home/tdf/jenkins/workspace/gerrit_windows/sc/source/core/data/column3.cxx(2821): error C2220: the following warning is treated as an error C:\cygwin64\home\tdf\jenkins\workspace\gerrit_windows\sc\source\core\data\column3.cxx(2752) : warning C6011: Dereferencing NULL pointer 'pPattern'. : Lines: 2723, 2726, 2727, 2728, 2730, 2731, 2732, 2733, 2734, 2735, 2736, 2737, 2738, 2739, 2740, 2742, 2744, 2745, 2747, 2751, 2752, 2753, 2754, 2756, 2762, 2763, 2766, 2791, 2809, 2811, 2814, 2819, 2740, 2742, 2744, 2745, 2747, 2751, 2752 make[1]: *** [C:/cygwin64/home/tdf/jenkins/workspace/gerrit_windows/solenv/gbuild/LinkTarget.mk:339: C:/cygwin64/home/tdf/jenkins/workspace/gerrit_windows/workdir/CxxObject/sc/source/core/data/column3.o] Error 2 After commit 2c613da01d02d45a140b94b391a142aede46e8b8 Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Wed Dec 4 11:20:01 2024 +0200 tdf#163010 inline and cache rDoc.GetCondFormat call Change-Id: If9093d5b43ae63e059b3f0597c85b326599e9ed0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178621 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-12-13tdf#163033 sc: fix crash when copying comment to another ScDocumentJustin Luth
Fixes a crash that started with 7.6.0.2 commit eec038b982b4672ac8feb030cb6bae546fa8c901 The crash occurred when comments were copied (without cloning) to another document and then the source document was closed, removing access to the (uncloned) comment. Also took the opportunity to put the (minutely) most expensive comparison at the end of the if clause. Change-Id: Ia5c1313aa17550f760d5f870c566f06b7abd598b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178394 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2024-12-04tdf#163010 inline and cache rDoc.GetCondFormat callNoel Grandin
which reduces save time to around 30s for me Change-Id: I6889312d25bd8f297f1c54f683496ef00e114d51 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177779 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-12-04tdf#163010 walk pattern by rangeNoel Grandin
which avoids a lot of lookup cost Change-Id: I9b030f3f8402f05a5c7b03c0147ff3ffc91d1cdc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177778 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-12-04tdf#163010 include GetPattern hereNoel Grandin
we are already at the column data level, no need to call via ScDocument Change-Id: Ib8b0bc0f1fd9782229dc6c5240f87c086bdc970c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177777 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-12-03Revert "sc: manage conditional format with simpler dialog"Pranam Lashkari
This reverts commit 58c3f70c514ef4ce0de5419ab7daa3bebfb96f37. Change-Id: I500a96508684547c158cdd1814540a4b24f667d9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177290 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177341 Tested-by: Jenkins
2024-12-03Revert "sc: added date condition option in conditional format manage dialog"Pranam Lashkari
This reverts commit 9928f1fa147d4ff838cbf6fcfe0d976ecef97cef. Change-Id: Ieb7dfdeccaffed4ad81ff9b5b0eb3b3b49fd8d05 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177289 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177340 Tested-by: Pranam Lashkari <lpranam@collabora.com>
2024-12-03Revert "sc: now formula conditions can be managedPranam Lashkari
...from condition format manager" This reverts commit 8374dd472cb4a2e2edab969a73ca88ffeaadbcd8. Change-Id: I532c17596adccfa5c88baaf2df897f3ffbee0fe6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177288 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177339 Tested-by: Pranam Lashkari <lpranam@collabora.com>
2024-12-03Revert "sc: now conditions can be edited from easy conditional format dialog"Pranam Lashkari
This reverts commit 8115c82f1f7f2621e2d99c93e1a3b2196279602a. Change-Id: Ie3f389561ee8f734ac76b3dec352382281f91c30 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177284 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177335 Tested-by: Pranam Lashkari <lpranam@collabora.com>
2024-12-03don't bother passing const std::[u16]string_view by referenceCaolán McNamara
Change-Id: I49477c20849dd99118d5935c0f1576429648bfca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177734 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-12-02loplugin:unusedmethodsNoel Grandin
Change-Id: I85ef1d4e9391e211c9e5e7ac6e9de875e9f5f5af Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177679 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-12-01cid#1606986 COPY_INSTEAD_OF_MOVECaolán McNamara
and cid#1556101 COPY_INSTEAD_OF_MOVE cid#1555475 COPY_INSTEAD_OF_MOVE cid#1555310 COPY_INSTEAD_OF_MOVE Change-Id: Ibabd8fd59a5435b8ab6c33d78c1303e5e1bdfd9a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177609 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-11-30cid#1607542 COPY_INSTEAD_OF_MOVECaolán McNamara
and cid#1606986 COPY_INSTEAD_OF_MOVE cid#1557969 COPY_INSTEAD_OF_MOVE cid#1557837 COPY_INSTEAD_OF_MOVE cid#1557772 COPY_INSTEAD_OF_MOVE cid#1557735 COPY_INSTEAD_OF_MOVE cid#1557672 COPY_INSTEAD_OF_MOVE cid#1557664 COPY_INSTEAD_OF_MOVE cid#1557650 COPY_INSTEAD_OF_MOVE cid#1557642 COPY_INSTEAD_OF_MOVE cid#1557639 COPY_INSTEAD_OF_MOVE cid#1557628 COPY_INSTEAD_OF_MOVE cid#1557623 COPY_INSTEAD_OF_MOVE cid#1557581 COPY_INSTEAD_OF_MOVE cid#1557489 COPY_INSTEAD_OF_MOVE cid#1557473 COPY_INSTEAD_OF_MOVE cid#1557317 COPY_INSTEAD_OF_MOVE cid#1557261 COPY_INSTEAD_OF_MOVE cid#1557146 COPY_INSTEAD_OF_MOVE cid#1557135 COPY_INSTEAD_OF_MOVE cid#1557134 COPY_INSTEAD_OF_MOVE cid#1557079 COPY_INSTEAD_OF_MOVE cid#1557063 COPY_INSTEAD_OF_MOVE cid#1557052 COPY_INSTEAD_OF_MOVE cid#1556982 COPY_INSTEAD_OF_MOVE cid#1556977 COPY_INSTEAD_OF_MOVE cid#1556950 COPY_INSTEAD_OF_MOVE cid#1556943 COPY_INSTEAD_OF_MOVE cid#1556804 COPY_INSTEAD_OF_MOVE cid#1556736 COPY_INSTEAD_OF_MOVE cid#1556658 COPY_INSTEAD_OF_MOVE cid#1556621 COPY_INSTEAD_OF_MOVE cid#1556590 COPY_INSTEAD_OF_MOVE cid#1556579 COPY_INSTEAD_OF_MOVE cid#1556534 COPY_INSTEAD_OF_MOVE cid#1556524 COPY_INSTEAD_OF_MOVE cid#1556478 COPY_INSTEAD_OF_MOVE cid#1556467 COPY_INSTEAD_OF_MOVE cid#1556422 COPY_INSTEAD_OF_MOVE cid#1556314 COPY_INSTEAD_OF_MOVE cid#1556309 COPY_INSTEAD_OF_MOVE cid#1556258 COPY_INSTEAD_OF_MOVE cid#1556143 COPY_INSTEAD_OF_MOVE cid#1556119 COPY_INSTEAD_OF_MOVE cid#1556101 COPY_INSTEAD_OF_MOVE cid#1556097 COPY_INSTEAD_OF_MOVE cid#1556039 COPY_INSTEAD_OF_MOVE cid#1555966 COPY_INSTEAD_OF_MOVE cid#1555948 COPY_INSTEAD_OF_MOVE cid#1555915 COPY_INSTEAD_OF_MOVE cid#1555836 COPY_INSTEAD_OF_MOVE cid#1555748 COPY_INSTEAD_OF_MOVE cid#1555644 COPY_INSTEAD_OF_MOVE cid#1555582 COPY_INSTEAD_OF_MOVE cid#1555478 COPY_INSTEAD_OF_MOVE cid#1555475 COPY_INSTEAD_OF_MOVE cid#1555409 COPY_INSTEAD_OF_MOVE cid#1555372 COPY_INSTEAD_OF_MOVE cid#1555334 COPY_INSTEAD_OF_MOVE cid#1555330 COPY_INSTEAD_OF_MOVE cid#1555310 COPY_INSTEAD_OF_MOVE cid#1555257 COPY_INSTEAD_OF_MOVE cid#1555247 COPY_INSTEAD_OF_MOVE cid#1555147 COPY_INSTEAD_OF_MOVE cid#1555120 COPY_INSTEAD_OF_MOVE cid#1555059 COPY_INSTEAD_OF_MOVE cid#1555016 COPY_INSTEAD_OF_MOVE cid#1554880 COPY_INSTEAD_OF_MOVE cid#1554824 COPY_INSTEAD_OF_MOVE cid#1554808 COPY_INSTEAD_OF_MOVE cid#1546189 COPY_INSTEAD_OF_MOVE Change-Id: I2d2f33c603f1596228c9ecb169472ba6751e7826 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177593 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-11-29tdf#163872 ScTable::SetOptimalHeight: use better way to iterate rowsJustin Luth
I stumbled across GetNextValue while looking how I could optimize GetValue's use of Search. Since this function needs to iterate through every single entry, it was relatively expensive to "Search" for the beginning row each time, when we know it will be index++. Change-Id: I1bc7b6b041b7836aebc4cd2bfd9214851804bf31 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177561 Reviewed-by: Justin Luth <jluth@mail.com> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-11-28tdf#163913 Implement font-relative marginsJonathan Clark
This change adds loext:margin-left and loext:margin-right, which implement margins that support font-relative units. See tdf#36709 for additional details. Change-Id: I31b0dd2b6f98cb5b02fd4dca3608db6fdee4054c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177473 Tested-by: Jenkins Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
2024-11-28Simplify ScSubTotalParamMike Kaganski
Change-Id: I4c1840e377711ad065c3042bddacb2028481b88d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177433 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-11-27PVS: V560 A part of conditional expression is always true: bEqualXisco Fauli
Since commit d0484bcdcbffd42d242647a2fdc1a203d176b775 Author: Jens-Heiner Rechtien <hr@openoffice.org> Date: Mon Sep 18 23:16:46 2000 +0000 initial import Change-Id: Ib1cf69ecf70bf9d866308892562a2d9080e1350f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177413 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-11-27make calc Grid config listen for changesCaolán McNamara
Change-Id: I1015adf6f8a270569e48b8e66b141ef37f217a1b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177400 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-11-26sc: prefix members of ScConditionalFormatXisco Fauli
Change-Id: Ib8d6b19f4ff1a5a641039f7e06083430b53a6edb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177301 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-11-25cid#1607047 Overflowed integer argumentCaolán McNamara
Change-Id: I60c991ba32c85ed872c6086104774259d1ac3b24 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177239 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-11-24Let ESelection use EPaM for simplificationMike Kaganski
And drop EPosition, which duplicates EPaM, except for its default ctor (used in a single place). Change-Id: I48bb6dafcba84465d61579df0ec71b815945532a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177075 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2024-11-24Turn SC_MOD macro to a functionMike Kaganski
Change-Id: I5fc11037902bc6200fdaf4749260efe8e658bdce Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177070 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-11-23Reduce copying of ScEditEngineDefaulter's SfxItemSetMike Kaganski
Change-Id: Ifea96f2cf586b4e5b63761e2f03944dade764430 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177073 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2024-11-22loplugin:unusedmethodsNoel Grandin
Change-Id: I24666a7746f8920ddf84731f204f3e1a5b9b0c85 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177024 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-11-21Related: tdf#160536 - ooxml import export correctly cell protectionBalazs Varga
property for Pivot tables cells. Change-Id: I1bff7a27cf169fd0876e361b22b4d7017f190b40 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176897 Tested-by: Jenkins Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
2024-11-21tdf#163872 ScTable::SetOptimalHeight: optimize if all rows ManualSizeJustin Luth
SetOptimalHeightsToRows does nothing if all the rows are manualsize. GetOptimalHeightsInColumn can be extremely expensive to run, so exit early if all the processing will have been for nothing. This doesn't solve bug 163872, but it does help with some of the sheets. Change-Id: I425bbd4f181058aa637c92f2abccf7c27dcf607d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176808 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Justin Luth <jluth@mail.com>
2024-11-19improve loplugin passparamsbyrefNoel Grandin
I think I managed to disable this when I converted it to use the shared plugin infrastructure. So fix that, and then make it much smarter to avoid various false positives. Change-Id: I0a4657cff3b40a00434924bf764d024dbfd7d5b3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176646 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-11-18Resolves: tdf#163831 Invalidate cache if the style is modifiedCaolán McNamara
Change-Id: I4a43936a6a7130734f5ae459a9406da99bf0f5f1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176727 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-11-16Fix typosAndrea Gelmini
Change-Id: Ibeadfb72c54887ac8a74dbb11958266fbbda46e0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176659 Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net> Tested-by: Jenkins
2024-11-14tdf#160404 tdf#160535 tdf#160536 - sc improve sheet protectionBalazs Varga
tdf#160404: Fix FILEOPEN XLSX Pivot table is not imported if sheet protection has Pivot table editing enabled - Import correctly the pivot tables, even if the tab protection is not allowing to use them. tdf#160535: Support sheet protection option: Use AutoFilter - Add new option for tab protection to enable/disable to use autofilter on the sheet. Import/export correctly to odf/ooxml. Add new ext-odf attribute: XML_USE_AUTOFILTER tdf#160536: Support sheet protection option: Use PivotTable&PivotChart - Add new option for tab protection to enable/disable to use Pivot table on the sheet. Import/export correctly to odf/ooxml. Add new ext-odf attribute: XML_USE_PIVOT Change-Id: I5d34e3608aed1a3d004ec553f6125b6428e9c05e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176274 Tested-by: Jenkins Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
2024-11-13tdf#36709 editeng: Layout for font-relative first-line indentJonathan Clark
This change extends layout for font-relative paragraph first-line indentation into Edit Engine. Change-Id: I5906f493b91fbcb87ded165709fb132b33ce1906 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176487 Tested-by: Jenkins Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
2024-11-13tdf#163486: PVS: pointer not released in destructorXisco Fauli
V773 The 'pDefaults' pointer was not released in destructor. A memory leak is possible. Change-Id: I7df195d1f515b86e85993d6c0a6cf60bcaff3109 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176477 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
generated by cgit (git 2.34.1) at 2025-01-22 01:45:00 +0000