summaryrefslogtreecommitdiff
path: root/sc/source/filter/dif
AgeCommit message (Collapse)Author
2018-05-21loplugin:unusedfields in scNoel Grandin
Change-Id: I04aee9574b97d6120fe20be97b2c0fb8187fb260 Reviewed-on: https://gerrit.libreoffice.org/54453 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-12Replace ScGlobal::GetRscString with simple ScResId callsGabor Kelemen
After the gettext migration there is no point to have two APIs for reading the same .mo file. This patch is for sc/source/filter/ for easier review. Change-Id: I77adc446e66623535a9d4c871ac1403e88efff78 Reviewed-on: https://gerrit.libreoffice.org/54183 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-02-05Translate German variable namesJohnny_M
Akt -> Current in dif filter Change-Id: Ibae58744a1d0b685b9df4d63b2977ec9b09745d0 Reviewed-on: https://gerrit.libreoffice.org/49189 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-01-12More loplugin:cstylecast: scStephan Bergmann
auto-rewrite with <https://gerrit.libreoffice.org/#/c/47798/> "Enable loplugin:cstylecast for some more cases" plus solenv/clang-format/reformat-formatted-files Change-Id: I987ac3a6d062600a5e21c3462c70595dfaa51796
2017-11-22drop duplicate methodCaolán McNamara
Change-Id: Idadd0a64e41cd02f5167b275081c3576a6224b12 Reviewed-on: https://gerrit.libreoffice.org/45075 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-10-23loplugin:includeform: scStephan Bergmann
Change-Id: I2ed763e0584a188032c80fde60890de3c6985cbd
2017-10-18dyncolcontainer: use std::map in DifAttrCacheNoel Grandin
Change-Id: Ic3280c5548555ceeb722788dc0a90f8898f46c2e Reviewed-on: https://gerrit.libreoffice.org/43467 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-12clang-tidy modernize-use-emplace in scNoel Grandin
Change-Id: Ifc38e1fc188fe957a0c717aec19cdd6637e4c658 Reviewed-on: https://gerrit.libreoffice.org/42183 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-02dynamic column container: fix some more for loopsNoel Grandin
and add reverse-iterator functionality Change-Id: Ide7ee9d2152871d414246303d76c91da36557524 Reviewed-on: https://gerrit.libreoffice.org/41727 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-29loplugin:constparam in sc part8Noel Grandin
Change-Id: I6cf9c5e662b20de9c9698a8c1fab56a09950c522 Reviewed-on: https://gerrit.libreoffice.org/41683 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-18Address b0210c34dcaa5fc44956078ffa1dfe734d379224 nitpicks, tdf#43157 follow-upEike Rathke
Change-Id: I3c70225f4d19ea85a54026e8eb78ba729acd6dfd
2017-07-18fdo#43157 convert OSL_ASSERT to assert in sc/source/filterBernhard Widl
Change-Id: I3d6d3da69ed7539dacf7eaf82fa7633f85619b39 Reviewed-on: https://gerrit.libreoffice.org/39366 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-07-13loplugin:useuniqueptr in scNoel Grandin
Change-Id: I004e1f0292c8a40515880546574255ab835dbdbe Reviewed-on: https://gerrit.libreoffice.org/39875 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-05Revert "With ScFormatFilterMissing gone we don't need ScFormatFilterPluginImpl"Stephan Bergmann
This reverts commit cc0524a724d0a9b9516ce9eaf499d845165863f8, which broke UBSan's -fsanitize=vptr, where Library_sc needs the RTTI typeinfo symbol for ScFormatFilterPlugin, but that would now only be emitted in Library_scfilt, together with the first non-pure, non-inline virtual function, and Library_sc cannot link against Library_scfilt (which already links against Library_sc).
2017-07-03Translate German comments and debug strings (leftovers in dirs sal to sc)Johnny_M
Translates leftovers found using a custom regex and manually checking the rest of the affected file. Additionally: - A few spelling fixes Change-Id: I2b83bd11adf520b90bb29c8ea624990759dad3c6 Reviewed-on: https://gerrit.libreoffice.org/39427 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2017-06-30With ScFormatFilterMissing gone we don't need ScFormatFilterPluginImplTor Lillqvist
Change-Id: I01288c953dd02707d017bfba95459b83254ef963 Reviewed-on: https://gerrit.libreoffice.org/39422 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2017-06-06expand out FltError and eERR constantsNoel Grandin
they're just aliases for ErrCode and ERRCODE constants. It's not like I can even convert them to an enum since the relevant functions do not return only these constants, but also a variety of other error constants. This a cleanup commit prior to converting the ErrCode stuff to an o3tl::strong_int Change-Id: Ia9f506a24f6bd382d86b68e46bec36e4da7a4310 Reviewed-on: https://gerrit.libreoffice.org/38412 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-10loplugin:checkunusedparams in sc(part1)Noel Grandin
Change-Id: I8c4fca704fe8ed6f861728cc3f3782c676aba67c Reviewed-on: https://gerrit.libreoffice.org/37435 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-07revert OSL_ASSERT changesChris Sherlock
Change-Id: I365d140446bd2a62cf8256acbfdd53fe72987380
2017-05-07tdf#43157: convert sc module away from OSL_ASSERT to assertChris Sherlock
Change-Id: Iead653868ea7e0d1ed4ba83ef1a46e1ae5874d13
2017-01-10New loplugin:conststringvar: scStephan Bergmann
Change-Id: I5f353f8aaaa82f0f9dcb5af33320dbd7e4a8abb8
2016-09-23convert formula error codes to scoped enumNoel Grandin
Change-Id: I5ff214bf1ec9031e30344bc125bc99916fd11bfb Reviewed-on: https://gerrit.libreoffice.org/28897 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-09-22loplugin:unusedmethods in sc..vclNoel Grandin
Change-Id: I70fcf95dfd3db05b4fd6e5cee37866f673d3afa8 Reviewed-on: https://gerrit.libreoffice.org/29183 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-07-19sc dif import: plain number formatter is unusedJochen Nitschke
commit 2cb7d3c13cc55d8ee680fe19d99819529d8b9ba5 revealed DifOptions is always set to DifOptions::Excel, so DifParser.bPlain is never true. remove import with plain number formatter and DifOptions enum Change-Id: I8e214f3fff8ecfc7e03622dd1fe3fb53c2fb1e25 Reviewed-on: https://gerrit.libreoffice.org/27277 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-18sc: convert SC_DIFOPT_* defines to typed_flagsJochen Nitschke
Change-Id: Ic4ec298fa9147edf8fda20fbcceebf6b803b342d Reviewed-on: https://gerrit.libreoffice.org/27271 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-06tools: rename SvStream::Read/Write to ReadBytes/WriteBytesMichael Stahl
Change-Id: Ib788a30d413436aa03f813aa2fddcbc4d6cd2f9a Reviewed-on: https://gerrit.libreoffice.org/25972 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-05-26loplugin:unusedreturntypesNoel Grandin
and clean up the python script Change-Id: I0a7068153290fbbb60bfeb4c8bda1c24d514500f Reviewed-on: https://gerrit.libreoffice.org/25439 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-10Replace fallthrough comments with new SAL_FALLTHROUGH macroStephan Bergmann
...which (in LIBO_INTERNAL_ONLY) for Clang expands to [[clang::fallthrough]] in preparation of enabling -Wimplicit-fallthrough. (This is only relevant for C++11, as neither C nor old C++ has a way to annotate intended fallthroughs.) Could use BOOST_FALLTHROUGH instead of introducing our own SAL_FALLTHROUGH, but that would require adding back in dependencies on boost_headers to many libraries where we carefully removed any remaining Boost dependencies only recently. (At least make SAL_FALLTHROUGH strictly LIBO_INTERNAL_ONLY, so its future evolution will not have any impact on the stable URE interface.) C++17 will have a proper [[fallthroug]], eventually removing the need for a macro altogether. Change-Id: I342a7610a107db7d7a344ea9cbddfd9714d7e9ca
2016-03-24loplugin:constantparam in scNoel Grandin
Change-Id: I8608a6cb47972e9b838cc5ea431863348758ded0
2016-03-06coverity#1355250 Logically dead codeCaolán McNamara
Change-Id: If5a07e11cf63d0dbb83853fce48b2eb7b458663b
2016-03-04loplugin:unuseddefaultparam in scNoel Grandin
Change-Id: Id461fc600bec5fe372875c2dcf405997fcf9f0b4
2016-03-03loplugin:unuseddefaultparams in sc (part2)Noel Grandin
Change-Id: I356a86bfca20cbf2c52185697042dce5237e847d
2016-01-15loplugin:unusedmethods unused return value in scNoel Grandin
Change-Id: I3ccc98d2e042120093e2e8508518681588692393
2015-11-25coverity#1340224 Logically dead codeCaolán McNamara
Change-Id: I206701fa068c788f77307a649a607316473e6105
2015-11-13sc: boost::ptr_vector->std::vectorNoel Grandin
Change-Id: If3fff7cec768be9ce4cad6064415c1739433e030
2015-11-10loplugin:nullptr (automatic rewrite)Stephan Bergmann
Change-Id: I765d2a600f9c57da50c85354688e3ae796750d94
2015-11-02trash usage of ScRefCellValue default ctor followed by assign()Eike Rathke
... that only results in a performance penalty. Change-Id: Ia161ab7fb03f2d32cf966ce9da9d0319d919fc4c
2015-09-18boost->stdCaolán McNamara
Change-Id: I7f3bb094f116103c1146a7d60e3af94c0b37d9ea Reviewed-on: https://gerrit.libreoffice.org/18677 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-09-17revert for mac and win unit case crashes after boost->stdCaolán McNamara
Change-Id: I82c7084f203a834c2d42f9527705288e6036019b
2015-09-17boost->stdCaolán McNamara
Change-Id: I1e6a7fd66f90e6acd803c6cd464f1d73252f7bcb
2015-08-31loplugin:stringconstant: OUStringBuffer: appendAscii -> appendStephan Bergmann
Change-Id: I4e350a0c6045d07677edae4f9921db0a42b4e0f5
2015-05-22Remove include stdio (part5)Julien Nabet
Change-Id: Iea3eb02b5ae54de1de14b5357726d1073e54e1af Reviewed-on: https://gerrit.libreoffice.org/15851 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2015-04-15remove unnecessary use of void in function declarationsNoel Grandin
ie. void f(void); becomes void f(); I used the following command to make the changes: git grep -lP '\(\s*void\s*\)' -- *.cxx \ | xargs perl -pi -w -e 's/(\w+)\s*\(\s*void\s*\)/$1\(\)/g;' and ran it for both .cxx and .hxx files. Change-Id: I314a1b56e9c14d10726e32841736b0ad5eef8ddd
2015-02-25remove NUMBERFORMAT_ constantsNoel Grandin
.. in favour of just using the underlying constants from css::util::NumberFormat Change-Id: I0c6b128b66c91b268f5ae300f9c17c7792df5e99
2015-01-14fdo#39468 Translate German Comments - replace '//!' with '//TODO:'Christian M. Heller
It seems that most comments starting with '//!' were intended as FIXMEs. This replaces gerrit 12241. Conflicts: sc/source/core/tool/token.cxx sc/source/filter/excel/xlpivot.cxx Change-Id: I6ed06b32c70cc854a896dbbc386565e6fbfa9b28 Reviewed-on: https://gerrit.libreoffice.org/12361 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-12-21fdo#39440 sc: reduce scope of local variablesMichael Weghorn
This addresses some cppcheck warnings. Change-Id: I2eaf9a6792ca2c06a005385ec45c08f1292cba23
2014-11-17sal: clean up public headers with include-what-you-useMichael Stahl
Sadly cannot forward declare "struct {...} TimeValue;". rtl/(u)?string.hxx still include sal/log.hxx but removing osl/diagnose.h was painful enough for now... Change-Id: Id41e17f3870c4f24c53ce7b11f2c40a3d14d1f05
2014-11-14fdo#86023 - O[U]String needs a 'clear' methodBrij Mohan Lal Srivastava
Added clear() method to OString and OUString class, Updated appropriate call-sites. Change-Id: I0ba97fa6dc7af3e31b605953089a4e8e9c3e61ac Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-10-04fdo#39468 Translate German Comments - difimp and htmlimpChristian M. Heller
Change-Id: I221d07c56822905c500f11f3f738231259743acd Reviewed-on: https://gerrit.libreoffice.org/11802 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-01fdo#39468 Translate German Comments - sc/cource/filter/difChristian M. Heller
Change-Id: I1d44c2538baac9a1443118c95a2886db5098dab1 Reviewed-on: https://gerrit.libreoffice.org/11736 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
generated by cgit (git 2.34.1) at 2024-06-22 12:10:56 +0000