summaryrefslogtreecommitdiff
path: root/sc/source/filter/excel/excform.cxx
AgeCommit message (Collapse)Author
2015-03-26const_cast: convert some C-style casts and remove some redundant onesStephan Bergmann
Change-Id: I18b1b0b92b106c5fd96c80472e279a7cfd380235
2015-03-09Bin unused static const fieldTor Lillqvist
2015-02-12tdf#89281 fix performance regression of XLS import - cleanupLászló Németh
Change-Id: I6d7f279732d9992d584aab96c3a747d6e6130147
2015-02-10tdf#89281 fix performance regression of XLS importLászló Németh
The fix for Bug 76611 caused ~20% performance loss in XLS import. With optional cloning of ScTokenArray of the shared XLS formulas depending on the need of address wrapping, it is possible to gain back near the original performance. Note: The original patch for Bug 76611 has already got an unit test, too (see wrapped-refs.xls), and that unit test works with this improved patch, too. Change-Id: Ibfb59d1543ef9c4b8a075d5c4e37f77ab451aaa0
2014-12-23coverity#1260332 Unused valueCaolán McNamara
Change-Id: Ia96b7816708e566d59628ae185bdc08023cdbe00
2014-12-19WaE: -Werror=unused-but-set-variableCaolán McNamara
Change-Id: I2c1dd24fa2215300255ae4e7d50b6cf990b6e843
2014-12-19remove operator>> methodsNoel Grandin
in favour of ReadXXX methods Change-Id: I50a97c1855366dc14c6864da2fb91d1759d4d4db
2014-11-18coverity#1242538 Untrusted loop boundCaolán McNamara
Change-Id: I663f70d6324c6dd42208aa3804edfe3680881ea1
2014-11-12Fix common typos. No automatic tools. Handmade…Andrea Gelmini
Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959 Reviewed-on: https://gerrit.libreoffice.org/12164 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-03fdo#39468 Translate German Comments - final bits of sc/source/filter/Christian M. Heller
Change-Id: Ie01e9488c6b8e36c40e6176bc1cac38a93a8087f Reviewed-on: https://gerrit.libreoffice.org/12194 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2014-06-25remove whitespaceMarkus Mohrhard
Change-Id: Ib15413e73409cc33de01fa92a47b9d1237cfc4b2
2014-06-17coverity#736887 Unintended sign extensionCaolán McNamara
also coverity#736888 coverity#736889 coverity#736890 Change-Id: I3e0d11d12c7da17297ba827f8125b9d99680121b
2014-06-17coverity#706041 Unintended sign extensionCaolán McNamara
also coverity#706042 coverity#706045 coverity#706046 Change-Id: I173603a638ef3e2d9ca358a4d4ba111910fac05f
2014-06-17coverity#706038 Unintended sign extensionCaolán McNamara
Change-Id: I363c90a71225744bacd0bedccf6938da63e0428f
2014-06-05coverity#736046 Missing break in switchCaolán McNamara
Change-Id: I1680d21b8f123ec1d937d699edee62b8ff0d6058
2014-06-05coverity#705209 Missing break in switchCaolán McNamara
Change-Id: Ie9ecc13553e089197de24c8a151eb811e40bd56e
2014-05-11fix-includes.pl: scThomas Arnhold
Change-Id: Iade3fedac5d2f8e978b7dd9c30f001d7d1564946
2014-04-25fdo#76611: Wrap reference addresses at max boundaries.Kohei Yoshida
When importing shared formula tokens. Change-Id: I7e1a05a78c3a93330476516e0459cffb668e3f66
2014-04-23sc: sal_Bool->boolNoel Grandin
Change-Id: I70aad0b38979f45a313b8ac36890fb6c64d11bb0
2014-04-15CID#1202961 init class memberEike Rathke
Change-Id: I5b00cdf68220282e5d0ff99352e04552cdecce09
2014-04-14fdo#76294: Properly intern string literals in formula on xls import.Kohei Yoshida
Change-Id: Ib3a442cbb68c23294762561f2911101a087a795e
2014-04-06whitespace cleanup in scMarkus Mohrhard
Change-Id: Id1dcadcac179c52977e48a6912ce4d5fd542f60c
2014-02-14sal_Bool->boolNoel Grandin
Change-Id: Id93fd35fe2482c4b639c25c9dd0d1ce4b4c8aa75
2014-02-06fdo#74553: Use the shared formula column position Excel tells you...Kohei Yoshida
Because sometimes this may be correct. Change-Id: Id2c47bb4ad3f91b366a25306169de58bb38c1e81
2014-01-28bool improvementsStephan Bergmann
Change-Id: I740c0e18eefc64cb5f1da5b88ceb77289790ec37
2014-01-22bool improvements (related to mixing bool/sal_Bool in &=, |=, ^=)Stephan Bergmann
Change-Id: I9869d9709f28b68ef7b518527175589d80644668
2013-12-04Never attempt to create formula groups based on Excel's shared formula ranges.Kohei Yoshida
Because they are wrong more than half the time. Change-Id: I24e49c53520442be698e43976d28d0f8477648e6
2013-12-04Assign top cell to the formula group if it's still NULL.Kohei Yoshida
This can happen when Excel's original shared formula range is across multiple columns, in which case we split that into multiple groups (one per column), and initialize top cell only for the left most column. This fixes the crasher on the doc from fdo#31296. Change-Id: I9e4def9836947fc67523f0d99ca981465709b934
2013-11-20Point to the group's top cell in ScFormulaCellGroup instead of the top rowTor Lillqvist
It will make implementing the background compilation of OpenCL kernels easier, I hope. That needs data accessible through the ScFormulaCell. Change-Id: I77ad5a94eb13551e6238d5f5285f1c916d7cb992
2013-11-13Don't compile the static OpenCL kernels while loading a spreadsheetTor Lillqvist
It has the potential to slow down the loading as we wait for the compilation thread to finish when loading has otherwise finished. Besides, the static kernels are not even used any more. Keep the static kernel source code and the code that handles it for now, for reference. Also keep the compilation thread source for future modifications and re-use. Change-Id: I7ae6ad08b0ac00a15cc4ce5bc9906972e7e23850
2013-11-06Modify ScFormulaCell's ctor to take a const reference to ScTokenArray.Kohei Yoshida
Instead of a pointer to ScTokenArray, and then clone its instance. If the token array gets cloned in ctor, take a const reference. Change-Id: I280fd7eb9eaea9905dbf954a1ace904ab0814dfe
2013-10-11Properly intern strings going into matrix objects.Kohei Yoshida
Change-Id: Ieb8befa4f19ebc31f4afa1370c924b469aa77382
2013-10-08Store svl::SharedString in document cell storage instead of OUString.Kohei Yoshida
With this, both ScColumn and ScMatrix store svl::SharedString as their string values, instead of OUString. Change-Id: I3faece94d98f774881fd72b3ed5f6143504cd350
2013-10-08convert sc/source/filter/excel/*.cxx from String to OUStringNoel Grandin
Change-Id: Icbfb7a601a01bf8fb2a30cb49a1522a25e6022f1
2013-10-04convert source/filter/inc/*.hxx from String to OUStringNoel Grandin
Change-Id: I7b70d5c699819103260c2b248203c41f1d543a79
2013-10-04covnert sc/source/filter/inc/namebuff.hxx from String to OUStringNoel Grandin
Change-Id: I08d7224df62723b70b46981f1b6d61379ab62747
2013-10-04convert sc/source/filter/inc/tokstack.hxx from String to OUStringNoel Grandin
Change-Id: Ib23a94ee45539c01c3e4c95b3d5983c470950a8b
2013-10-01Related: fdo#38838 remove UniString::AssignAsciiCaolán McNamara
Change-Id: I263ef2594080ff7d47d5499c2b62e60e1689d2d6
2013-09-19"what!?" - Let's not say that...Kohei Yoshida
Change-Id: I1c9c2a62b2a1ede08fb2f27f541b501dc3ce7b2f
2013-09-19Work around another Excel bug with incorrect shared formula range.Kohei Yoshida
Take the start row position from the preceding formula record, rather than believing what's in the shared formula record. The latter can be wrong, and can be wrong often. Change-Id: I3a4da110727a7719e5f8cb3e6250c0e1bef04c64
2013-09-19Add a heuristic to avoid always pre-compile OpenCL kernels (for xls).Kohei Yoshida
If we still have 3 MB worth of stream to parse after the first formula record, we pre-compile OpenCL kernels in a separate thread. Change-Id: I129d95c26f26e4b1eb989bc2a1764a3f87f71fcb
2013-09-19Set up a thread to compile OpenCL kernels during file load.Kohei Yoshida
It's still a no-op & we need to have a smart mechanism to conditionally trigger it rather than running it in all documents. Change-Id: Ia875ebb9405b5de5c5d31418de84c5ca7a62f302
2013-09-11Use ScDocumentImport to populate cell storage during xls import.Kohei Yoshida
Change-Id: I205c5b7c1202862ea7129fbd61d54e48cd37b06e
2013-09-11Handle import of shared formula from xls more gracefully.Kohei Yoshida
Many xls documents contain shared formula entries that don't follow the spec. We still need to be able to handle them. Change-Id: Ia7d01101a6759967d9ebb27b6540dcb67607d13f
2013-08-14Avoid wholesale rebuilding of formula groups at re-calc time.Kohei Yoshida
And do it once when importing xls, xlsx, and ods documents. Although xls(x) file formats support shared formula natively, it's still beneficial to re-group it as some old xls documents limit the length of shared formula span to only 64, or some don't use shared formulas at all even though they could. And re-grouping just once is not terribly expensive. Change-Id: Iff9c605d19baa187553ddab6af8b9fbd4c366d7d
2013-08-12Compile token array only once per formula group.Kohei Yoshida
Change-Id: I70694ee8834b1b2f2ebdfaa90582ccfb19db0210
2013-08-12Map shared formula from xls to formula groups, and share the tokens as well.Kohei Yoshida
No more mapping to range names. Change-Id: Ic43b6ef35a91fe4d6fff748ebc22969ba4e036db
2013-08-12Prepare for importing shared formulas as formula groups from xls.Kohei Yoshida
Still the first step. Change-Id: I1897c9c2cd3a5b5245febbfba76e1b088054f578
2013-07-30Now nobody accesses reference members directly. Make them private.Kohei Yoshida
Change-Id: If4499dbee52532cc8a95c380bbe840719fe9279b
2013-07-30More of the same. Will this ever end, I'm starting to wonder...Kohei Yoshida
Change-Id: I36bc90e8477cba306e107fb6d6e47f5732161df8
generated by cgit (git 2.34.1) at 2024-08-21 08:30:50 +0000