summaryrefslogtreecommitdiff
path: root/sc/source/filter/excel/exctools.cxx
AgeCommit message (Collapse)Author
2019-01-29Simplify containers iterations in sc/source/filter/[d-e]*Arkadiy Illarionov
Use range-based loop or replace with STL functions Change-Id: I7be6568641e154e74ff7bde812da9a8e67790a7f Reviewed-on: https://gerrit.libreoffice.org/66972 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-17tdf#42949 Fix IWYU warnings in sc/source/filter/excel/*cxxGabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ia155032426e02eb9ee64db3fb10946f5c9d445b7 Reviewed-on: https://gerrit.libreoffice.org/64832 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2018-09-04tdf#42949 Fix IWYU warnings in sc/source/filter/inc/[a-l]*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I92cfd8d09ca8229764db4200568b96a62e2ab21e Reviewed-on: https://gerrit.libreoffice.org/59742 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-07-12loplugin:useuniqueptr in RootDataNoel Grandin
Change-Id: Ibb053d17a1da6e3db74b97b4f66a4ad03147b3bc Reviewed-on: https://gerrit.libreoffice.org/57297 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-21loplugin:unusedfields in scNoel Grandin
Change-Id: I04aee9574b97d6120fe20be97b2c0fb8187fb260 Reviewed-on: https://gerrit.libreoffice.org/54453 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-16tdf#42949 Remove unnecessary localization headers from scGabor Kelemen
Found by searching for the header names and the localization function: git grep -l -e \<scresid.hxx\> -e \<strings.hrc\> sc | xargs grep -c ScResId | grep :0$ | grep -v /pch and git grep -l -e \<globstr.hrc\> sc | xargs grep -c GetRscString | grep :0$ | grep -v /pch since global.hxx contains so much more, it's omitted from this round. This also gives some false positives used in ErrorMessage() calls or just untranslated strings. Also translate some stray German comments Change-Id: Icfea2b2942d12c3c134d419cb7c9a84534c04a86 Reviewed-on: https://gerrit.libreoffice.org/52932 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-10-23loplugin:includeform: scStephan Bergmann
Change-Id: I2ed763e0584a188032c80fde60890de3c6985cbd
2017-09-12clang-tidy modernize-use-emplace in scNoel Grandin
Change-Id: Ifc38e1fc188fe957a0c717aec19cdd6637e4c658 Reviewed-on: https://gerrit.libreoffice.org/42183 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-31The code handles the nLevel == nCurLevel case just fineTor Lillqvist
I get the warning from such a case when loading an .xls written by Excel 2013. I have no idea how common it is. I have no deeper understanding of the code here. I just want to get rid of one more unnecessary warning. If nLevel > nCurLevel the code indeed probably will misbehave quite badly (thanks to unsigned arithmetics). Change-Id: I6cc5af454049e6ec054865535d2f7a54c6264613
2017-06-15Fix typosAndrea Gelmini
Change-Id: Iea1f82e95c37bdf778941a568d61f17f179f838d Reviewed-on: https://gerrit.libreoffice.org/38795 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2017-04-25tools: svstream.hxx needs only errcode.hxx & not errinf.hxxChris Sherlock
Change-Id: Ia28e35ae5af4f601e9a586a3deffbcd61702b0ca Reviewed-on: https://gerrit.libreoffice.org/36896 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-01-26NameBuffer is deadJochen Nitschke
all getters are gone since commit 96d44c9b077a6cc8068067a795dc63248ab90fea Date: Wed Jul 22 10:20:03 2015 +0200 loplugin:unusedmethods sc Change-Id: I26b1ac6b24680d0a6045e9a93d40fbbd2caa6a4b Reviewed-on: https://gerrit.libreoffice.org/33542 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-07-26sc: convert SC_SCENARIO_.. defines typed flags ..Jochen Nitschke
ScScenarioFlags add ScScenarioFlags::NONE for 0. replace uses of '-= flag' with '&= ~flag'. Change-Id: I003c0ca1f59b060f52935fec8bb6282fd9981805 Reviewed-on: https://gerrit.libreoffice.org/27464 Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-25Convert SC_MF to scoped enumNoel Grandin
Change-Id: I3089006b502e33710bfb2564f051ebf2892ad08a Reviewed-on: https://gerrit.libreoffice.org/25085 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-22Avoid reserved identifiersStephan Bergmann
Change-Id: I782784f34975d708fdf179d098ce6654aad7a976
2016-04-20clang-tidy clang-analyzer-deadcode.DeadStoresNoel Grandin
suspect that some of these may reveal latent bugs.... Change-Id: I9de9aabbda9c8952715631577c29c1830df1eb71 Reviewed-on: https://gerrit.libreoffice.org/24200 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-13Revert "sc: boost::ptr_vector->std::vector"Noel Grandin
This reverts commit 9822ddf366459d31148a4ccbf0a49da4f726b3db. something is storing a pointer to maXFIndex in XclImpXFRange Change-Id: I2de7a311da2586351e2356b108f723c80f268245
2015-11-13sc: boost::ptr_vector->std::vector<std::unique_ptr>Noel Grandin
and remove some unnecessary usage of dynamic allocation of OUString Change-Id: I6eb49a0733928ba49ea48accd36fbaaa82b9d211
2015-11-10loplugin:nullptr (automatic rewrite)Stephan Bergmann
Change-Id: I765d2a600f9c57da50c85354688e3ae796750d94
2015-06-15remove unnecessary check for null when calling deleteNoel Grandin
Idea originally from caolan. Found using the following command: find . -name *.cxx | xargs /opt/local/bin/grep -zlP '(?m)if\s*\(\s*\w+\s*\)\s*delete\s+\w+\;' Change-Id: I3338f4e22193a6dfd6219c8c75835224a3392763
2015-04-15remove unnecessary use of void in function declarationsNoel Grandin
ie. void f(void); becomes void f(); I used the following command to make the changes: git grep -lP '\(\s*void\s*\)' -- *.cxx \ | xargs perl -pi -w -e 's/(\w+)\s*\(\s*void\s*\)/$1\(\)/g;' and ran it for both .cxx and .hxx files. Change-Id: I314a1b56e9c14d10726e32841736b0ad5eef8ddd
2014-12-19remove operator>> methodsNoel Grandin
in favour of ReadXXX methods Change-Id: I50a97c1855366dc14c6864da2fb91d1759d4d4db
2014-06-25remove whitespaceMarkus Mohrhard
Change-Id: Ib15413e73409cc33de01fa92a47b9d1237cfc4b2
2014-02-21cid#708029 Uninitialized pointer fieldNoel Grandin
Change-Id: Ifb61a1db7a0527f4d722a753c0918ef035436997
2014-02-14sal_Bool->boolNoel Grandin
Change-Id: I87981ec49e1158452b2c6836fae29e13b6dc9dba
2014-01-28bool improvementsStephan Bergmann
Change-Id: I740c0e18eefc64cb5f1da5b88ceb77289790ec37
2013-10-08convert sc/source/filter/excel/*.cxx from String to OUStringNoel Grandin
Change-Id: Icbfb7a601a01bf8fb2a30cb49a1522a25e6022f1
2013-10-04convert source/filter/inc/*.hxx from String to OUStringNoel Grandin
Change-Id: I7b70d5c699819103260c2b248203c41f1d543a79
2012-12-04re-base on ALv2 code. Includes:Michael Meeks
Patches contributed by Herbert Duerr i#118735 prevent endless loop if vlookup/hlookup doesn't find anything http://svn.apache.org/viewvc?view=revision&revision=1239673 Patches contributed by Andre Fischer remove lp_solver http://svn.apache.org/viewvc?view=revision&revision=1199180 i#118160: Added external CoinMP library. http://svn.apache.org/viewvc?view=revision&revision=1233909 Patches contributed by Armin Le-Grand i#118485 - Styles for OLEs are not saved. http://svn.apache.org/viewvc?view=revision&revision=1182166 i#118524: apply patch, followup fixes to 118485 http://svn.apache.org/viewvc?view=revision&revision=1186077 Patches contributed by lihuiibm i#108860 - Fix range validation. http://svn.apache.org/viewvc?view=revision&revision=1242846 i#118954 Chart data will lost after copy to different file http://svn.apache.org/viewvc?view=revision&revision=1301345 Patches contributed by Ariel Constenla-Haile Fix Linux build breaker: extra qualification on member http://svn.apache.org/viewvc?view=revision&revision=1301591 i#118696 - i#118697 - Fix some Sheet Tab Color API issues http://svn.apache.org/viewvc?view=revision&revision=1225428 i#118697 - Fix uninitialized variable http://svn.apache.org/viewvc?view=revision&revision=1225859 i#118771 - ScUndoImportTab should preserve tab background color http://svn.apache.org/viewvc?view=revision&revision=1230356 i#118921 - Repaint linked sheet tab background color after updating link http://svn.apache.org/viewvc?view=revision&revision=1245177 i#118927 - Undo/Redo "Update Link" does not reset sheet tab color http://svn.apache.org/viewvc?view=revision&revision=1245241 i#118747 - Copy tab color when transferring sheets across documents http://svn.apache.org/viewvc?view=revision&revision=1230355 Patch contributed by Oliver Rainer-Wittman i#118012 - methods <ScBroadcastAreaSlot::AreaBroadcast(..)> and <ScBroadcastAreaSlot::AreaBroadcastInRange(..)> adapt stl-container iteration in order to avoid destroyed iterators during iteration. http://svn.apache.org/viewvc?view=revision&revision=1297916 Patches contributed by Mathias Bauer gnumake4 work variously http://svn.apache.org/viewvc?view=revision&revision=1394707 http://svn.apache.org/viewvc?view=revision&revision=1394326 http://svn.apache.org/viewvc?view=revision&revision=1396797 http://svn.apache.org/viewvc?view=revision&revision=1397315 Patch contributed by Daniel Rentz calc69: #i116936# fix VBA symbol Cells http://svn.apache.org/viewvc?view=revision&revision=1172135 Patches contributed by leiw: i#118546 CPU 100% on switched off AutoCalculate with Conditional Formatting on date values http://svn.apache.org/viewvc?view=revision&revision=1301380 Re-add new function documentation. Many various cleanups. Add missing calc66: #o11817313# also look at formula result number format, remove redundant binaries.
2012-06-09Remove superfluous include commentsThomas Arnhold
Change-Id: Icd57ca7fd89e30c190c1b06dbe67c30bea8d1b59
2011-11-27remove include of pch header from scNorbert Thiebaud
2011-08-25sal_Bool -> bool in ScTableMarkus Mohrhard
2011-05-27Replace DBG_* with OSL_* in sc/source/filterJacek Wolszczak
2011-03-14making sc/source/filter compile againBjoern Michaelsen
2011-03-10Merge commit 'ooo/DEV300_m101' into integration/dev300_m101Kohei Yoshida
2011-03-01Remove bogus comments.Guillaume Poussel
2011-02-21[PATCH 08/10] Removed deprecated List container.npcdoom
2011-01-17removetooltypes01: #i112600# remove tooltypes from scMikhail Voytenko
2010-11-29Fixed use of incorrect integer type during import of outlines.Kohei Yoshida
I was supposed to use SCSIZE to store column / row position but was incorrectly using sal_uInt8. This caused import of outlines from Excel document to entirely get screwed when the outline positions were > 255, and it was understandably so. :-P (fdo#31833)
2010-10-13Add vim/emacs modelines to all source filesSebastian Spaeth
Fixes #fdo30794 Based on bin/add-modelines script (originally posted in mail 1286706307.1871.1399280959@webmail.messagingengine.com) Signed-off-by: Sebastian Spaeth <Sebastian@SSpaeth.de>
2010-10-05Removed unused local variables, per compiler warnings.Kohei Yoshida
2010-10-04Port calc-xls-import-mem-footprint.diff from ooo-build.Kohei Yoshida
This change reduces memory footprint of column row attribute import from Excel document, from the previous 20 MB per sheet (!) down to near zero. With the test document I had, the memory use during import dropped from 1.6 GB to 224 MB.
2010-03-01chartshapes: merge with DEV300_m72Thomas Benisch
2010-02-17CWS-TOOLING: integrate CWS changefileheader2Vladimir Glazunov
Notes: split repo tag: calc_ooo/DEV300_m72 split repo tag: calc_ooo/DEV300_m73
2010-02-12changefileheader2: #i109125#: change source file copyright notice from Sun ↵Jens-Heiner Rechtien
Microsystems to Oracle; remove CVS style keywords (RCSfile, Revision)
2010-01-08#i107450#: build all other modules with new editeng libMathias Bauer
2009-12-01chartshapes: merge with DEV300 m62Jens-Heiner Rechtien
2009-10-14CWS-TOOLING: integrate CWS calc32stopper2Kurt Zenker
2009-10-01 12:42:16 +0200 dr r276592 : #i104992# and more typos... 2009-10-01 12:42:13 +0200 nn r276591 : #i105512# SetDocOptions: update number formatter if it already exists 2009-09-30 19:03:58 +0200 dr r276573 : #104992# oops, forgotten to skip a byte 2009-09-30 16:07:17 +0200 dr r276560 : #i103540# check valid vector size 2009-09-29 14:20:45 +0200 dr r276529 : dump some more BIFF records 2009-09-29 13:00:22 +0200 dr r276526 : dump some more BIFF records 2009-09-28 14:34:14 +0200 dr r276490 : #i104057# missing exception file 2009-09-28 10:35:42 +0200 dr r276483 : #i105325# set correct format while opening zip package 2009-09-25 19:07:32 +0200 dr r276475 : #i104992# handle cell styles built-in in Calc correctly 2009-09-25 19:06:46 +0200 dr r276474 : #i104992# handle cell styles built-in in Calc correctly 2009-09-25 17:37:28 +0200 dr r276472 : #i105219# missing include 2009-09-25 12:32:24 +0200 dr r276435 : #i10000# rebase error: renamed variable 2009-09-25 11:34:53 +0200 dr r276431 : CWS-TOOLING: rebase CWS calc32stopper2 to trunk@276429 (milestone: DEV300:m60) 2009-09-24 18:59:23 +0200 dr r276427 : 160550# preserve write-protection password in roundtrip 2009-09-24 18:54:43 +0200 dr r276426 : 160550# preserve write-protection password in roundtrip 2009-09-22 11:38:17 +0200 dr r276353 : #160550# the property has to be integer of course 2009-09-21 18:52:06 +0200 dr r276342 : #160550# new internal property WriteProtectinPassword 2009-09-21 18:22:40 +0200 dr r276340 : #i104057# load sheets substreams according to offsets in SHEET records 2009-09-21 18:11:00 +0200 dr r276338 : #i104057# load sheets substreams according to offsets in SHEET records 2009-09-17 20:07:33 +0200 dr r276255 : #i104057# BIFF5/BIFF8: order of sheet substreams may be different to sheet order, use stream offset provided in SHEET records
2009-08-06#i12587# reorg of svx/EscherEx class (separate class EscherExGlobal for ↵Daniel Rentz
global stuff shared through multiple instances of EscherEx), export of shapes embedded in Calc charts to BIFF8; #i55183# write child anchor instead of client anchor for charts/OLE/controls embedded in shape groups
2009-07-29#i12587# small fixes for BIFF import, preparations for BIFF exportDaniel Rentz