summaryrefslogtreecommitdiff
path: root/sc/source/filter/oox/worksheethelper.cxx
AgeCommit message (Collapse)Author
2016-12-05tdf#91475 Fix column width during .xlsx exportBartosz Kosiorek
With commit 16726a1b37df8bdcae02b3c7699df814977222bd the new import algorithm was introduced. Unfortunately it looks like that some specific column width are improved, but for other widths it is worse. More information is available at: https://bugs.documentfoundation.org/show_bug.cgi?id=91475#c29 In this commit I added unit tests which prooves proper working of old algorithm and I have switched to old algorithm. Unit test which was done: 1. After resave .xlsx file, the column width values did not change 2. After export .ods to .xlsx displayed column width did not change 3. After save .xlsx to .ods displayed column width did not change This commit resolve column width after exporting to .xlsx, and correctly preserve column width for LibreOffice. Change-Id: I26d074b203d08a4bf4e9e31e52dbfd7ca7d3beb1 Reviewed-on: https://gerrit.libreoffice.org/27943 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-12-05loplugin:unnecessaryoverride (dtors) in scStephan Bergmann
Change-Id: Ifc44a22738cbd0ebbd81fae5caf1d9792e7746cf
2016-12-03Remove unnecessary indirections.Kohei Yoshida
Especially in the oox code there are many... Change-Id: I16915cc207c274e5bcdb5d1f4f8708db5a0479a1 Reviewed-on: https://gerrit.libreoffice.org/31578 Reviewed-by: Kohei Yoshida <libreoffice@kohei.us> Tested-by: Kohei Yoshida <libreoffice@kohei.us>
2016-11-29tdf#48140 Replace uno with direct callsBartosz Kosiorek
Change-Id: I63e30c4bb32837b28401474a4ab7627ad2863c5b Reviewed-on: https://gerrit.libreoffice.org/31219 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-21tdf#48140 Replace uno call from worksheethelper.cxxBartosz Kosiorek
Change-Id: Ibf738d67af6536e9300e11f8d4fa3fe79ab7099b Reviewed-on: https://gerrit.libreoffice.org/31006 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-11-19tdf#48140 Remove not used UNO headers from filtersBartosz Kosiorek
Change-Id: I66e775b60343fe8ac772d8c0287ca19be58a7236 Reviewed-on: https://gerrit.libreoffice.org/30966 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-10-18loplugin:unusedmethodsNoel Grandin
Change-Id: Icf773925c37dde8b7404edac9864e7b10fe113b4 Reviewed-on: https://gerrit.libreoffice.org/29968 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-05convert MapUnit to scoped enumNoel Grandin
I left a prefix on the names "Map" so that I would not have to re-arrange each name too much, since I can't start identifiers with digits like "100thMM" And remove RSC_EXTRAMAPUNIT, which doesn't seem to be doing anything anymore. Change-Id: I5187824aa87e30caf5357b51b5384b5ab919d224 Reviewed-on: https://gerrit.libreoffice.org/29096 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-22loplugin:unusedmethods in sc..vclNoel Grandin
Change-Id: I70fcf95dfd3db05b4fd6e5cee37866f673d3afa8 Reviewed-on: https://gerrit.libreoffice.org/29183 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-20loplugin:unusedfieldsNoel Grandin
Change-Id: I852e98b16fdcb88b04e39d11e3101d502c918c24 Reviewed-on: https://gerrit.libreoffice.org/29078 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-13loplugin:override: No more need for the "MSVC dtor override" workaroundStephan Bergmann
The issue of 362d4f0cd4e50111edfae9d30c90602c37ed65a2 "Explicitly mark overriding destructors as 'virtual'" appears to no longer be a problem with MSVC 2013. (The little change in the rewriting code of compilerplugins/clang/override.cxx was necessary to prevent an endless loop when adding "override" to OOO_DLLPUBLIC_CHARTTOOLS virtual ~CloseableLifeTimeManager(); in chart2/source/inc/LifeTime.hxx, getting stuck in the leading OOO_DLLPUBLIC_CHARTTOOLS macro. Can't remember what that isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.) Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
2016-07-28tdf#100946 Fix width calculation and add customWidth support (.xlsx)Bartosz Kosiorek
On some MS Excel version (OS X), the column "width" is not applied, if "customWidth" key (in "col") is not set to "true". It means that in case of .xlsx files, exported by LibreOffice, all columns have default width. To resolve that "customWidth" key was added during export into .xlsx file format. During development it appears that Default Column Width is wrongly calculated, and it was done not according to MS documentation. This issue was also fixed. After fix default column width is properly set. MS documentation: https://msdn.microsoft.com/en-us/library/documentformat.openxml.spreadsheet.column.aspx Change-Id: I0d1944081a5ea445d1e4284db62e9b4d504bf1c0
2016-07-13loplugin:singlevalfields in sc(part2)Noel Grandin
the meFilterType field in WorkbookGlobals lead to a chain reaction of code removal. Change-Id: Iaa8b467c1c76cab78f8ce1796709590b666028db Reviewed-on: https://gerrit.libreoffice.org/26682 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-05-26loplugin:unusedmethodsNoel Grandin
Change-Id: Ib36bc0e87d00abb638cbfec511cd13b6179eabda Reviewed-on: https://gerrit.libreoffice.org/25431 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-24loplugin:unusedmethods in scNoel Grandin
Change-Id: Ic378126a30be853d10fe174c451cee3c6ded404f Reviewed-on: https://gerrit.libreoffice.org/25109 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-10tdf#42949: clean up includes in include/oox/helper with iwyuJorenz Paragas
...and fix the many compiler errors that occurred as a result. Change-Id: I497c326272b2f02737ca3765720d6815b735423b Reviewed-on: https://gerrit.libreoffice.org/24735 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-05-09convert SfxStyleFamily to scoped enumNoel Grandin
and update the RSC compiler to accept such In the process fix some confusion in SD where it was confusing SfxStyleFamily and the index of the relevant family (which other parts of the code in SVL use) Change-Id: I1efc9f85fbed8ab76eafe8f6e1ada411753ae5f9
2016-04-25tdf#42949: clean up includes in include/oox/core using iwyuJorenz Paragas
This allows the headers in that folder to stand on their own and not depend on any transitively included headers. All changes to other files are needed to fix compiler errors related to missing includes that occurred afterwards. Change-Id: I2083b30763f0b2c1aacdff00226e5f567ae52db4 Reviewed-on: https://gerrit.libreoffice.org/24355 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2016-04-20loplugin:salbool: Automatic rewrite of sal_False/TrueStephan Bergmann
Change-Id: I9b99327d58a63dfa5c292784cefb4894ee6d7fa8
2016-04-19setting the properties through uno is not necessary anymoreMarkus Mohrhard
Change-Id: Icdd78ffb386b6b5222558dde0a6a9439b1431781 Reviewed-on: https://gerrit.libreoffice.org/24229 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-03-12tdf#84938 Change defines to typed_flagsJochen Nitschke
Put defines into an enum class and use typed_flags template from o3tl to give them flag operators. There were some shift operations to apply flags from start references to end references, these went into a helper in address.hxx to hide them. A marco with shift operations in address.cxx was rewritten in two helpers without shifts. One shift remained in ScRange::Format with a comment. The other flag untypical operator was a minus 1 in a helper for ScRefFinder::ToggleRel, which iteratates through all possible combinations for absolute references. This is used to make referecnces absolute via SHIFT+F4. A replacement would be too complex. Change-Id: I4850f1623e01e56c60ac2260b95fc5cad8b6fd71 Signed-off-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Reviewed-on: https://gerrit.libreoffice.org/22840 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-02-26tdf#97654 - replaced CellAddress types with ScAddress.Mohammed Abdul Azeem
Differences in default constructors is compensated and other changes have been made as suggested. Change-Id: I15bdf5043816502ace797c352242a4a59f1cd64e Reviewed-on: https://gerrit.libreoffice.org/22579 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-02-17tdf#97654 - replaced UNO cell types in xlsx import with calc internal onesMohammed Abdul Azeem
All reference to CellAddress in ApiCellRangeList::getBaseAddress() is changed to ScAddress and its chain of changes has been made. Change-Id: I43d9eb8dc02c74640d9fac11a44429850f31ade1 Reviewed-on: https://gerrit.libreoffice.org/22222 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2015-11-30loplugin:unusedfieldsNoel Grandin
Change-Id: Ife94d488ead512abc6d137a0df74298bac67185d
2015-11-02trash usage of ScRefCellValue default ctor followed by assign()Eike Rathke
... that only results in a performance penalty. Change-Id: Ia161ab7fb03f2d32cf966ce9da9d0319d919fc4c
2015-10-28com::sun::star->css in scNoel Grandin
Change-Id: I7774890f46f9343e944e34db27af8bce3b1d0915
2015-10-20Resolves: tdf#84713 do not substitute separator in R1C1 notation hyperlinksEike Rathke
During import, in hyperlinks all Sheet!xxx were converted to Sheet.xxx to fit CalcA1 notation, but in this case Sheet!R1C1 was used and Sheet.R1C1 is not a valid address notation, so the hyperlink didn't work. Do not attempt to convert R1C1 notation, the hyperlink handler does handle all known notations. On Excel export, handle that the separator can be both, '.' and '!'. Change-Id: I8428b2240912f42fd6789d249c90982127ee7c01
2015-10-12Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY codeStephan Bergmann
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
2015-08-28make these types future proofMarkus Mohrhard
Our core already supports more than 32k sheets and we should not use sal_Int16 anymore for sheets. Change-Id: Ifeb321cba044b255ef2e7d34da0908c27877d6ae
2015-07-04Fix typosAndrea Gelmini
Change-Id: Iddcc22f62ea134ea797292daa02e47042d52d0d1 Reviewed-on: https://gerrit.libreoffice.org/16710 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2015-06-25TableRef: move getTables().applyTableColumns() to the correct positionEike Rathke
... in import sequence. Change-Id: Ib5601af281f0378d283ecd61fa71c41e6c1be254
2015-06-24TableRef: import OOXML table column names to ScDBDataEike Rathke
Change-Id: I5fa32922fffcd027ddf1c61fe0b122fa2d320d98
2015-06-06Apply new VclPtr clang plugin to catch potential problems.Noel Grandin
Omit the plugin, and sw's FrameControlsManager for now. Change-Id: Ifb98a2e6e03a9d099efc1668305b96bd9142ca5f Reviewed-on: https://gerrit.libreoffice.org/16117 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2015-05-20better algorithm for OOXML column width import, tdf#91267Markus Mohrhard
This patch contains a magic factor of 1.047 that is necessary as the set value and retrieved value are not the same. When we ahve too much time (propably never) we should explore why the value that we set for the column width is not equal to the one that we see on the screen. Change-Id: I317127ea5b8af2d5e8386758e66907a44fe58579
2014-11-17sal: clean up public headers with include-what-you-useMichael Stahl
Sadly cannot forward declare "struct {...} TimeValue;". rtl/(u)?string.hxx still include sal/log.hxx but removing osl/diagnose.h was painful enough for now... Change-Id: Id41e17f3870c4f24c53ce7b11f2c40a3d14d1f05
2014-10-22Set rotation reference directly via internal API.Kohei Yoshida
Note that the original code would first set the rotation reference value stored in the Xf, then later unconditionally overwrite it according to the border setting. The new code only ports the second part. Perhaps there was a bug in the original code.... Change-Id: I15b6839e9a58e8070a43db70e1a88b42ed99f2d8
2014-10-22Set cell style name to the document directly, bypassing the UNO API.Kohei Yoshida
Change-Id: I28decfdfd8248fb9b95416b9b269a4ffabcc6370
2014-10-15More -Werror,-Wunused-private-fieldStephan Bergmann
...detected with a modified trunk Clang with > Index: lib/Sema/SemaDeclCXX.cpp > =================================================================== > --- lib/Sema/SemaDeclCXX.cpp (revision 219190) > +++ lib/Sema/SemaDeclCXX.cpp (working copy) > @@ -1917,9 +1917,10 @@ > const Type *T = FD.getType()->getBaseElementTypeUnsafe(); > // FIXME: Destruction of ObjC lifetime types has side-effects. > if (const CXXRecordDecl *RD = T->getAsCXXRecordDecl()) > - return !RD->isCompleteDefinition() || > - !RD->hasTrivialDefaultConstructor() || > - !RD->hasTrivialDestructor(); > + return !RD->hasAttr<WarnUnusedAttr>() && > + (!RD->isCompleteDefinition() || > + !RD->hasTrivialDefaultConstructor() || > + !RD->hasTrivialDestructor()); > return false; > } > > @@ -3517,9 +3518,11 @@ > bool addFieldInitializer(CXXCtorInitializer *Init) { > AllToInit.push_back(Init); > > +#if 0 > // Check whether this initializer makes the field "used". > if (Init->getInit()->HasSideEffects(S.Context)) > S.UnusedPrivateFields.remove(Init->getAnyMember()); > +#endif > > return false; > } to warn about members of SAL_WARN_UNUSED-annotated class types, and warn about initializations with side effects (cf. <http://lists.cs.uiuc.edu/pipermail/cfe-dev/2014-October/039602.html> "-Wunused-private-field distracted by side effects"). Change-Id: I3f3181c4eb8180ca28e1fa3dffc9dbe1002c6628
2014-09-30sc: std::auto_ptr -> std::unique_ptrStephan Bergmann
Change-Id: I25468d578de597ff9aeba3ffc850c630fa532767
2014-09-18fdo#82577: Handle FontNoel Grandin
Put the VCL Font class in the vcl namespace. Avoids clash with the X11 Font typedef. Change-Id: I1a84f7cad8b31697b9860a3418f7dff794ff6537
2014-09-09fdo#75757: remove inheritance to std::vectorTakeshi Abe
from ApiCellRangeList. Change-Id: I29913e0e437c112640b08187f8bea6b1f0f1c17c Reviewed-on: https://gerrit.libreoffice.org/11349 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-06-25remove whitespaceMarkus Mohrhard
Change-Id: Ib15413e73409cc33de01fa92a47b9d1237cfc4b2
2014-05-11fix-includes.pl: scThomas Arnhold
Change-Id: Iade3fedac5d2f8e978b7dd9c30f001d7d1564946
2014-04-14Clean up function declarations and some unused functionsStephan Bergmann
Change-Id: If2c233a8ced8815b065a72caff907f10ef6166ff
2014-04-06whitespace cleanup in scMarkus Mohrhard
Change-Id: Id1dcadcac179c52977e48a6912ce4d5fd542f60c
2014-04-04coverity#707962 Uninitialized scalar fieldCaolán McNamara
Change-Id: I3620c5cbd16869d2744e5bfa812f88805a030019
2014-03-27Second batch of adding SAL_OVERRIDE to overriding function declarationsStephan Bergmann
...mostly done with a rewriting Clang plugin, with just some manual tweaking necessary to fix poor macro usage. Change-Id: Ie656f9d653fc716f72ac175925272696d509038f
2014-03-10fdo#74747: Make use of cached string formula results.Kohei Yoshida
Just like we do with cached numeric formula results. Change-Id: Ib8b311b540caeb47d8c2162a456f7490c5882ad5
2014-03-03Remove visual noise from scAlexander Wilms
Conflicts: sc/source/ui/inc/docfunc.hxx Change-Id: I9314437ed3dd60e84d28c08ac0a2d1ed7bd1daf8 Reviewed-on: https://gerrit.libreoffice.org/8301 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-03-03remove unused code in oox::xls::WorksheetGlobalsNoel Grandin
oox::xls::WorksheetGlobals::getColumns(oox::ValueRange const&) const oox::xls::WorksheetGlobals::getRows(oox::ValueRange const&) const Change-Id: I573bea69c03a92584851c6ae5e8e01a5e90f8fd4
generated by cgit (git 2.34.1) at 2024-07-12 00:48:42 +0000