summaryrefslogtreecommitdiff
path: root/sc/source/filter/orcus
AgeCommit message (Collapse)Author
2018-11-07move SvTreeListBox to vclCaolán McNamara
Change-Id: I04a146d3d8a428ac1678827dc883525c40240a44 Reviewed-on: https://gerrit.libreoffice.org/62787 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-15loplugin:constfields in scNoel Grandin
Change-Id: If326175d571d15752efd1b63df45b2bc785f7541 Reviewed-on: https://gerrit.libreoffice.org/61653 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-11tdf#42949 Fix IWYU warnings in sc/source/filter/inc/[n-w]*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I32e9e2fb636d80ce351d1ef7beb888afac0e8ee7 Reviewed-on: https://gerrit.libreoffice.org/60205 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-09-06tdf#116453: One less argument to pass to ScOrcusStyles.Kohei Yoshida
You can access ScDocument via ScOrcusFactory. There should be no functionality change. Change-Id: Ia679b6b006cc60bf24ca11432909682fa527b034 Reviewed-on: https://gerrit.libreoffice.org/60063 Reviewed-by: Kohei Yoshida <libreoffice@kohei.us> Tested-by: Kohei Yoshida <libreoffice@kohei.us>
2018-09-05tdf#116453: Pick up non-UTF8 encoding and use it for string values.Kohei Yoshida
Change-Id: Ibb0455359ad41871e86a8858f6fe0c5b834bcb13 Reviewed-on: https://gerrit.libreoffice.org/60013 Tested-by: Jenkins Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2018-09-01Update orcus to 0.14.0.Kohei Yoshida
And make all necessary adjustments for the new version of orcus. Change-Id: I0dc207162a3ddfaad6da198a3d13b65f530757d5 Reviewed-on: https://gerrit.libreoffice.org/59884 Tested-by: Jenkins Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2018-08-01Add missing sal/log.hxx headersGabor Kelemen
rtl/string.hxx and rtl/ustring.hxx both unnecessarily #include <sal/log.hxx> (and don't make use of it themselves), but many other files happen to depend on it. This is a continuation of commit 6ff2d84ade299cb3d14d4110e4cf1a4b8070c030 to be able to remove those unneeded includes. This commit adds missing headers to every file found by: grep -FwL sal/log.hxx $(git grep -Elw 'SAL_INFO|SAL_INFO_IF|SAL_WARN|SAL_WARN_IF|SAL_DETAIL_LOG_STREAM|SAL_WHERE|SAL_STREAM|SAL_DEBUG') to directory sc Change-Id: I988d7d3abaedfb32516a9db88815663bf54da46e Reviewed-on: https://gerrit.libreoffice.org/58266 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-06-24Changes to orcus for implementing XML data providerVikas Mahato
Change-Id: I70075f4240c75f0f46260bb77b160f0b75d6ae94 Reviewed-on: https://gerrit.libreoffice.org/56354 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-06-20push the data from the temporary storage to the document for XML sourceMarkus Mohrhard
Change-Id: I93d489ef9b3fa105db2d364ad9133a26d5366361 Reviewed-on: https://gerrit.libreoffice.org/56126 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-06-05tdf#42949 remove unused compheler includes ..Jochen Nitschke
and fix the fallout Change-Id: I15bc5d626f4d157cbc69a87392078b41e621d14e Reviewed-on: https://gerrit.libreoffice.org/54882 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-05-29loplugin:unusedfields-in-constructor in scNoel Grandin
Change-Id: I074bb272b692dea553e1ec1e625c8afd766627d6 Reviewed-on: https://gerrit.libreoffice.org/54997 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-12Replace ScGlobal::GetRscString with simple ScResId callsGabor Kelemen
After the gettext migration there is no point to have two APIs for reading the same .mo file. This patch is for sc/source/filter/ for easier review. Change-Id: I77adc446e66623535a9d4c871ac1403e88efff78 Reviewed-on: https://gerrit.libreoffice.org/54183 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-04-15remove some unused comphelper includesJochen Nitschke
and fix the fallout Change-Id: I5d0c2040f57a3ac354a7e277592da31d09a5f359 Reviewed-on: https://gerrit.libreoffice.org/52894 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2018-04-01remove unused processfactory.hxx includesJochen Nitschke
and fix fallout Change-Id: Id06bf31f2075111e426ba40c84c885ae70697bee Reviewed-on: https://gerrit.libreoffice.org/52206 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2018-03-02delete colordata.hxxNoel Grandin
move what we still need into color.hxx Change-Id: Ied7e31eb16468aa334c666b1499a6262f16a6350 Reviewed-on: https://gerrit.libreoffice.org/50561 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-06Import cell borders as best as we can from orcus.Kohei Yoshida
This is subject to the infamous Excel to Calc cell border mapping fiasco. The mapping is not perfect and there is certainly room for improvement. Change-Id: Ie224c8e08e6c0b8f13311460acbd371bd65a145f Reviewed-on: https://gerrit.libreoffice.org/49266 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2018-02-06Import distributed text alignment settings correctly from orcus.Kohei Yoshida
Change-Id: Id04e2bd19475d6d7b98560835bc5aaad4bb8addf Reviewed-on: https://gerrit.libreoffice.org/49265 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2018-02-03Ignore the alpha value in font colors.Kohei Yoshida
Using it would remove the color altogether. Change-Id: I2c14316c9c9c885f4e7615e4057e752a58223227 Reviewed-on: https://gerrit.libreoffice.org/49170 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2018-02-02Correctly import solid fill color.Kohei Yoshida
In orcus, a solid fill type uses the foreground color only and ignores the background color. Also, let's not use the alpha component as it would cause the color to not get rendered at all. Some patches are applied against liborcus in order to adjust the ODF styles import code for this change. These changes will be incorporated in 0.13.3. Change-Id: I9e8c243cc6a7f366de2393e7b7ecf77366f5f9ea Reviewed-on: https://gerrit.libreoffice.org/49071 Reviewed-by: Kohei Yoshida <libreoffice@kohei.us> Tested-by: Kohei Yoshida <libreoffice@kohei.us>
2018-01-04remove SfxUsrAnyItem typedefNoel Grandin
and rename SfxUsrAnyItem class to SfxUnoAnyItem, the choice being made by leaving the most popular one behind Change-Id: If3818ee0966a50e3036d7e2db951910b6282c91f Reviewed-on: https://gerrit.libreoffice.org/47313 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-22coverity#1426736 Uninitialized scalar fieldCaolán McNamara
Change-Id: I6fbf7004cea04c61f89f3a720a24c9ee82f4b117
2017-12-20coverity#1426736 Uninitialized scalar fieldCaolán McNamara
and coverity#1426737 Uninitialized scalar field coverity#1426740 Uninitialized scalar field coverity#1426741 Uninitialized scalar field coverity#1426743 Uninitialized scalar field Change-Id: I770b03e54758178f8fdf7128644ddb8c37bf1e83
2017-12-19wrap scoped enum around css::util::NumberFormatNoel Grandin
Change-Id: Icab5ded8bccdb95f79b3fa35ea164f47919c68fa Reviewed-on: https://gerrit.libreoffice.org/46339 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-12-19Pick up sheet-local named expressions as well.Kohei Yoshida
Change-Id: I8a081b5f81740fa91f43ac152a950d73d031ed10 Reviewed-on: https://gerrit.libreoffice.org/46666 Reviewed-by: Kohei Yoshida <libreoffice@kohei.us> Tested-by: Kohei Yoshida <libreoffice@kohei.us>
2017-12-18Defer cell value insertion until later.Kohei Yoshida
Because Calc's formula engine expects all named expressions to be present at the time of re-calculations, we need to delay insertion of cell values until after the named expressions are inserted into the document. Change-Id: I54c7d3dc86b3e2c5c192337b1cebfbdfb901ab1f Reviewed-on: https://gerrit.libreoffice.org/46665 Reviewed-by: Kohei Yoshida <libreoffice@kohei.us> Tested-by: Kohei Yoshida <libreoffice@kohei.us>
2017-12-18Pick up global named expressions.Kohei Yoshida
Formulas with named expressions don't work yet since they get imported before the named expressions do. We need to insert formula cells after the named expressions. Change-Id: Id2d7c59194ce7c07a3580cc8d9afd9fdda660b24 Reviewed-on: https://gerrit.libreoffice.org/46664 Reviewed-by: Kohei Yoshida <libreoffice@kohei.us> Tested-by: Kohei Yoshida <libreoffice@kohei.us>
2017-12-18Handle per-cell settings of cell formats.Kohei Yoshida
Change-Id: I500d01921d436643499a24d375d40a607d8fd576 Reviewed-on: https://gerrit.libreoffice.org/46663 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2017-12-18Implement a reference resolver for orcus.Kohei Yoshida
Orcus uses this to resolve cell addresses for some ops. Change-Id: I6ee9667ad994fb830e545ba3368004866a048c25 Reviewed-on: https://gerrit.libreoffice.org/46662 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2017-12-18Handle merged cells.Kohei Yoshida
Change-Id: Iaa7194d4226300e495982bb1f90f72c31d748955 Reviewed-on: https://gerrit.libreoffice.org/46660 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2017-12-18Take into account the fact that ScDocument already has one sheet.Kohei Yoshida
ScDocument already has one sheet upon creation, so we need to avoid appending sheet when the request is for the first sheet. Change-Id: Ie5526d6791e545f5faa0bf3f16988351c09e94c8 Reviewed-on: https://gerrit.libreoffice.org/46658 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2017-12-18All the other orcus-based filters should take the same code path.Kohei Yoshida
Change-Id: Iac96c6eb842a769d70c3f39830cbdb0e1ee93dc8 Reviewed-on: https://gerrit.libreoffice.org/46657 Reviewed-by: Kohei Yoshida <libreoffice@kohei.us> Tested-by: Kohei Yoshida <libreoffice@kohei.us>
2017-12-18Remove code duplicates.Kohei Yoshida
Change-Id: I424e5999ef2ec6e71f6b6361ed91079b8d949555 Reviewed-on: https://gerrit.libreoffice.org/46656 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2017-12-18Initial step on enabling the orcus-based Excel 2003 XML filter.Kohei Yoshida
Still some work remains in the orcus interface implementation code in sc. Change-Id: Idc4d95b489e8e55fbe3593557399610abe6c4ae0 Reviewed-on: https://gerrit.libreoffice.org/46655 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2017-12-11loplugin:salcall fix functionsNoel Grandin
since cdecl is the default calling convention on Windows for such functions, the annotation is redundant. Change-Id: I1a85fa27e5ac65ce0e04a19bde74c90800ffaa2d Reviewed-on: https://gerrit.libreoffice.org/46164 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-10Fix inconsistent naming of a variable.Kohei Yoshida
Change-Id: I769d95a9800919b2241d48de246bee7fdbaa7996 Reviewed-on: https://gerrit.libreoffice.org/46170 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2017-11-26Convert ScFormatEntryType to scoped enumTor Lillqvist
Change-Id: I9a6b3fb05255630852a96ebf74d901b869a581f4 Reviewed-on: https://gerrit.libreoffice.org/45276 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2017-11-23loplugin:simplifybool for negation of comparison operatorNoel Grandin
Change-Id: Ie56daf560185274754afbc7a09c432b5c2793791 Reviewed-on: https://gerrit.libreoffice.org/45068 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-18Updated liborcus to 0.13.1.Kohei Yoshida
Change-Id: Id5aa07f87603879fe7a21dc96cad207f1b168286 Reviewed-on: https://gerrit.libreoffice.org/44850 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2017-10-23loplugin:includeform: scStephan Bergmann
Change-Id: I2ed763e0584a188032c80fde60890de3c6985cbd
2017-09-15convert SvxCellVerJustify to scoped enumNoel Grandin
Change-Id: I9d1cdb4ddfee43b7a0990624d7d16e06679343c4 Reviewed-on: https://gerrit.libreoffice.org/42276 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-12clang-tidy modernize-use-emplace in scNoel Grandin
Change-Id: Ifc38e1fc188fe957a0c717aec19cdd6637e4c658 Reviewed-on: https://gerrit.libreoffice.org/42183 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-29loplugin:constparam in sc part9Noel Grandin
Change-Id: If5bd37c48ee99210eb8f8a432b87a5e5235865bd Reviewed-on: https://gerrit.libreoffice.org/41702 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-15loplugin:checkunusedparams in scNoel Grandin
Change-Id: Ib4572899caeb7bc2dceb2c188ceb306b8ffc9193 Reviewed-on: https://gerrit.libreoffice.org/40629 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-13log details of exception when we catch std::exceptionNoel Grandin
Change-Id: Ibfaba3473b11e24381d5a71a722c021ecde3488b Reviewed-on: https://gerrit.libreoffice.org/41112 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-12better error reporting for xml source featureMarkus Mohrhard
Change-Id: I1ad9329904fe6d705a1a05b9cd65123b5e010014 Reviewed-on: https://gerrit.libreoffice.org/41084 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-08-11convert std::map::insert to std::map::emplaceNoel Grandin
which is considerably less verbose Change-Id: Ifa373e8eb09e39bd6c8d3578641610a6055a187b Reviewed-on: https://gerrit.libreoffice.org/40978 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-18Eliminate some unnecessary temporary Date instancesEike Rathke
Change-Id: Idede71608458acf4d23504b3a6a1cba557f370d1
2017-07-18Change nonsense non-const Date* GetNullDate() to const Date&Eike Rathke
* first, a non-const Date* may leave the impression that one could change the NullDate through the pointer, which is only partly successful; luckily no one did that * second, there is always a NullDate so checking for nullptr is superfluous * third, the pointer was dereferenced (maybe after a check) everywhere to obtain the NullDate, luckily.. Change-Id: I3c3a788ba0336596ac6bde4c96e77a0cdb7a4a95
2017-07-03C++11 remove std::unary_function bases from functorsJochen Nitschke
std::unary_function is deprecated since C++11 and removed in C++17 90% done with regexp magic. removed obsolete <functional> includes. The std::unary_function base class was used in 3 places: * chart2/source/tools/DataSeriesHelper.cxx: lcl_MatchesRole is used in a std::not1 function helper who uses the members return_type and argument_type. - replace deprecated std::not1 with a lambda * chart2/source/tools/ModifyListenerHelper.cxx: lcl_weakReferenceToSame used the argument_type member in the operator() parameter. - inline the parameter type. * xmloff/source/chart/SchXMLExport.cxx: lcl_SequenceToMapElement used result_type and argument_type in operator(). - inline the types Also fix compile error with gcc about finding std::for_each. Change-Id: I073673beb01410c3108e7d0346d9e7d6b9ad2e2f Reviewed-on: https://gerrit.libreoffice.org/39358 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2017-05-18Pass grammar to ScCompiler ctor instead of subsequent SetGrammar()Eike Rathke
Not only to have more concise code but also to avoid setting grammar twice if the actual grammar differs from the document's default one. Change-Id: I7bfd151c22c48a40aea05f5f983fa0370d9fd9ae