summaryrefslogtreecommitdiff
path: root/sc/source/filter
AgeCommit message (Collapse)Author
2018-03-05drop sax::tools::*base64 methodsNoel Grandin
and use the underlying comphelper methods rather. This is so that I can break the dependency that tools has on sax, and can add methods that make sax depend on tools. Change-Id: I8a2d6ce2ffc3529a0020710ade6a1748ee5af7d5 Reviewed-on: https://gerrit.libreoffice.org/50767 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-05use more Color in ooxNoel Grandin
Change-Id: I8fdc6742de5af9101e246411e7208650bae2c4c7 Reviewed-on: https://gerrit.libreoffice.org/50617 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-02-Werror,-WformatStephan Bergmann
Change-Id: I33a1ff0ba75e26daf9c368a36629122582a85b01
2018-03-02Related: tdf#114555 cater for lastcolumn+1 oddity if last is last possibleEike Rathke
Else our own saved .xlsx files raise the excess columns warning. Change-Id: Ie1791dd026d9faf4b391ad34da43ec0c70c8de83
2018-03-02forcepoint #15 notify FormatsContext if Format deletedCaolán McNamara
Change-Id: Icb7b0c3b1fc3d38e2d7e44e0a8bdb03529c5b41d Reviewed-on: https://gerrit.libreoffice.org/50621 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-02delete colordata.hxxNoel Grandin
move what we still need into color.hxx Change-Id: Ied7e31eb16468aa334c666b1499a6262f16a6350 Reviewed-on: https://gerrit.libreoffice.org/50561 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-01Resolves: tdf#114555 check .xlsx col/row/tab overflow and display warningEike Rathke
Change-Id: I3091a890b6d4a3f27d9284fc5c0e2df3bc8ce527 Reviewed-on: https://gerrit.libreoffice.org/50541 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2018-03-01make Color::GetRGBColor return Color instead of ColorDataNoel Grandin
Change-Id: I532959a7103c3857510f26ecce2f942d676a233b Reviewed-on: https://gerrit.libreoffice.org/50487 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-28Revert "Resolves: tdf#114555 check .xlsx col/row/tab overflow and display ↵Eike Rathke
warning" This reverts commit f2a4cea6c035e9a837942934068b5f80a996580a. Some builds have problem with WarningBox not being declared. Will dig into that later.
2018-02-28Resolves: tdf#114555 check .xlsx col/row/tab overflow and display warningEike Rathke
Change-Id: I3091a890b6d4a3f27d9284fc5c0e2df3bc8ce527
2018-02-28use less COLORDATA_RGBNoel Grandin
part of removing ColorData Change-Id: I5518cddeeefe66f70380367e1e3f78af0f3b5fbc Reviewed-on: https://gerrit.libreoffice.org/50486 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-28convert COL_ constants to be of type ColorNoel Grandin
Change-Id: I0e25c8950ac26b851ff42f71e1471fcbe4770d48 Reviewed-on: https://gerrit.libreoffice.org/50373 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-27crashtesting: remove wrong assert with tdf114555-2.xlsxEike Rathke
Wrong since commit 597f7b1f02be79f2443230c963b6d1bb594cffa0 Date: Sun Nov 20 02:21:56 2016 +0100 tdf#48140 Replace uno call from worksheethelper.cxx We are importing a document, so asserting on our own max dimensions is wrong. Wrong is also to compare positions <= MAXCOLCOUNT or <= MAXROWCOUNT, if at at all it should had been <= MAXCOL and <= MAXROW Change-Id: I9f3aae061785ab62de7c709e19fc68653f15ed1e Reviewed-on: https://gerrit.libreoffice.org/50397 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2018-02-27replace Color(COL_*) with COL_*Noel Grandin
using git grep -lwP "Color\s*\(\s*(COL_\w+)\s*\)" | xargs perl -pi -e "s/Color\s*\(\s*(COL_\w+)\s*\)//g" and then some manual fixup where the resulting expression no longer compiled Change-Id: I0e268d78611c3be40bba9f60ecfdc087a36c0df4 Reviewed-on: https://gerrit.libreoffice.org/50372 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-27drop old tools/gen.hxx methods in scNoel Grandin
Change-Id: I3652c0a35a6873e80ee22d908a8969d09410776b Reviewed-on: https://gerrit.libreoffice.org/50361 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-26convert remaining ErrorBox to weld::MessageDialogCaolán McNamara
and convert remaining QueryBox to weld::MessageDialog Change-Id: Ifb4c316dee8eabf57c4940c44e29c65a2781aa6c
2018-02-26use less RGB_COLORDATANoel Grandin
part of removing ColorData Change-Id: If31b5b88545529863377e9a178f45f4516bf6cbb Reviewed-on: https://gerrit.libreoffice.org/50345 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-26loplugin:useuniqueptr in SvxMSDffSolverContainerNoel Grandin
Change-Id: Ied7b60ac59cf1c869232a96e1b2ccb4e1b5cbf53 Reviewed-on: https://gerrit.libreoffice.org/49945 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-24Resolves: tdf#104250 import sheetProtection hash attributesEike Rathke
Change-Id: Ibae0934a84173b0933a03a6050abaaf3384404cb
2018-02-24Write ScOoxPasswordHash to OOXML if set, tdf#104250 prepEike Rathke
Change-Id: I51996c673e6c44bbfc27972800d78d9807fe67db
2018-02-23Move OOXML password definitions to struct ScOoxPasswordHash, tdf#104250 prepEike Rathke
Change-Id: I595d5ae8db6f739900afdfdde1e36b0a0b1d2179
2018-02-23tdf#115933 set document read-only on presence of hashValue attributeEike Rathke
Though there's currently no way (password dialog) to edit the document other than saving it to a different file, this seems to be what is expected. Change-Id: Iafa8ac9f6e41c3011ed0ad4b19cc57382c9f2a75
2018-02-23Read algorithmName, hashValue, saltValue, spinCount, tdf#115933 prepEike Rathke
Change-Id: I799d4652099059fcd09088c02537ed5dec087259
2018-02-23Read algorithmName, hashValue, saltValue, spinCount, tdf#104250 prepEike Rathke
Change-Id: Idc68ad62e8420646d5aecd0d4126084390a1ed55
2018-02-22loplugin:redundantcastNoel Grandin
Change-Id: I358e9673edcba81336b3895479e787d981fad7a5
2018-02-22ColorData->Color in scNoel Grandin
and fix the sal_Int32() conversion operator in Color, which was always returning 0 Change-Id: I0aefaedc34ee0a8bccd43238ccfe8196d2dd5c5c Reviewed-on: https://gerrit.libreoffice.org/50051 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-20drop Color::SetColor(ColorData) in favour of operator=Noel Grandin
first stage of getting rid of ColorData Change-Id: I5e4e95eb958722814c43c8d1ebfef17ad18c29ec Reviewed-on: https://gerrit.libreoffice.org/49997 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-20for listeners the range needs to be set before the formula, tdf#115530Aron Budea
Change-Id: I001795fd456375c4babab2c2e505bedff03e991f Reviewed-on: https://gerrit.libreoffice.org/49957 Reviewed-by: Aron Budea <aron.budea@collabora.com> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-02-19ofz#5991 limit num of qpro tabs for fuzzingCaolán McNamara
Change-Id: Ifa205912ee0970657debdc17339e3df0c581a18f Reviewed-on: https://gerrit.libreoffice.org/49998 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-19ofz#5956 TimeoutCaolán McNamara
Change-Id: I72f7601d88213953997c9f6eef30ee85a486a20b Reviewed-on: https://gerrit.libreoffice.org/49996 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-17Revert "loplugin:changetoolsgen in sc" and reapply pluginNoel Grandin
because I (a) forgot to insert parentheses which changes the meaning of some expressions and (b) I now use the AdjustFoo calls when changing unary operations, which reads much better This reverts commit 95fab7cbf2f0576d0f728bed8898b7ff769d90e6. Change-Id: Icbdcc0f4227d88812be12e18ba6961088db80c3e Reviewed-on: https://gerrit.libreoffice.org/49840 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-16ofz#5951 speed up wks fuzzing, skip CalcAfterLoadCaolán McNamara
Change-Id: I942480742da9aec18409b2d31dd68a01275682f9 Reviewed-on: https://gerrit.libreoffice.org/49859 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-14ofz#6316 Direct-leakCaolán McNamara
Change-Id: I1ae33f849d252e9682b7386909023821cf336b14 Reviewed-on: https://gerrit.libreoffice.org/49711 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-14unused ScTokenArrayCaolán McNamara
Change-Id: I3132cf7f94efed2db68a1715a892424a24aa1638 Reviewed-on: https://gerrit.libreoffice.org/49715 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-14use BitmapEx in LwpBackgroundStuffNoel Grandin
part of making Bitmap an implementation detail of vcl/ Change-Id: I847a2371cd630637b11aed0fad7263809143c706 Reviewed-on: https://gerrit.libreoffice.org/49705 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-14loplugin:changetoolsgen in scNoel Grandin
Change-Id: Ic24332cac65e665b55b9e1bbaf09ee56066875fd Reviewed-on: https://gerrit.libreoffice.org/49703 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-13speed up slk fuzzingCaolán McNamara
Change-Id: If026585ff39a42467dcf7dc4cf116035995f88f1 Reviewed-on: https://gerrit.libreoffice.org/49659 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-13ScSetStringParam::mbCheckLinkFormula for HTML and RTF importEike Rathke
Change-Id: I7cf7cf12142322cbffd5160e9a8dce55efd36be5
2018-02-12Translate German variable namesJohnny_M
Fakt -> Factor in Excel filter (excform) Change-Id: Id93e2722e4f40cf2916d2abb3684d3570b88fce3 Reviewed-on: https://gerrit.libreoffice.org/49531 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-02-12Translate German variable namesJohnny_M
Akt -> Current Erg -> Result Decimal (places) -> Fractinal (part), with related comment translation corrections in Lotus filter Change-Id: I1ea6917fb8e9da2f0f9c48fd1fe55347f8098cac Reviewed-on: https://gerrit.libreoffice.org/49532 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-02-12Translate German variable namesJohnny_M
Akt -> Current in Lotus filter (lotattr) Change-Id: Ibafa9f70f5bcec65dadc1dc118368bd45849a6c0 Reviewed-on: https://gerrit.libreoffice.org/49533 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-02-12Translate German variable namesJohnny_M
Fakt -> Factor in Excel filter (excform8) Change-Id: Ic63dc819d6b3b5fb5f8c362a72b6d5844dce2c11 Reviewed-on: https://gerrit.libreoffice.org/49530 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-02-10speed up qpw fuzzing, skip CalcAfterLoadCaolán McNamara
Change-Id: Ia94032d6789e830e8dbdc3093201cf8d5d44f537 Reviewed-on: https://gerrit.libreoffice.org/49507 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-10use read_uInt8s_ToOUStringCaolán McNamara
Change-Id: I3575019373632f476737b00d8616d01867970ae6 Reviewed-on: https://gerrit.libreoffice.org/49506 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-08tdf#114168 If minor axis unit is automatic, then set it to 5Bartosz Kosiorek
Based on OOXML implementation in MS Excel, if Minor axis Unit is set to automatic, then during chart import, LibreOffice should set Interval Count to 5, to mimic behaviour of MS Excel. Becaues default Interval Count for LibreOffice is 2, we need to override it to 5. With that solution, the Minor axis unit is preserved also after saving to .ods file format. During .xlsx export, if Interval Count is set to 5, then treat is as automatic axis unit. Change-Id: Iab9209fb3950ef73e79229329606363b528d35fe Reviewed-on: https://gerrit.libreoffice.org/49327 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
2018-02-07tdf#115483 svl xmloff sc sw: verify all ODF 1.2 protection-key hashesMichael Stahl
ODF 1.2 has added some mandatory requirements for protection-key hashes which did not exist in ODF 1.1. This affects sections and indexes in ODT documents, as well as spreadsheets and sheets in ODS documents. 1. Accept the following hashed passwords: * UTF16 LE/BE encoded StarOffice-SHA1, OOo legacy and allowed by ODF 1.1 * UTF8 encoded proper SHA1, as required by ODF 1.2 * UTF8 encoded SHA256, as required by ODF 1.2 - specified either with the wrong URL used in the ODF 1.2 spec or the correct URL from the W3C spec, see OFFICE-3702 * Excel+SHA1 double-hash, only in Calc, see OFFICE-2112 2. Round-trip any of the above as-is * for SHA256 only write the URL from the ODF 1.2 spec 3. Generate only UTF16 LE encoded SHA1 for now, so that older LO releases can still verify the password * some time in the future, switch to generating some valid ODF 1.2 hash More changes are necessary in Calc, which can actually preserve different hashes for the same passwords in its runtime data model, whereas Writer just has a single buffer without even any metadata. For the Calc unit tests we need one document per hash because the protection-key attribute can be set on the entire spreadsheet, which is an unique element in the document. There are further uses of SvlPasswordHelper for change-tracking passwords, but apparently those are stored in settings.xml, so ODF has no requirements for them, so let's leave that as it is. Change-Id: Icb720b14ae9c0d9c04d2e082769ae2b74e3af8aa Reviewed-on: https://gerrit.libreoffice.org/49352 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-02-07use scanline when reading pixel dataNoel Grandin
extracts code from the innermost part of fairly hot loops And add a GetIndexFromData method to make the call sites a little easier to read. Change-Id: I4ce5c5a687ecdb6982562a0aafce8513d86f9107 Reviewed-on: https://gerrit.libreoffice.org/49337 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-06Import cell borders as best as we can from orcus.Kohei Yoshida
This is subject to the infamous Excel to Calc cell border mapping fiasco. The mapping is not perfect and there is certainly room for improvement. Change-Id: Ie224c8e08e6c0b8f13311460acbd371bd65a145f Reviewed-on: https://gerrit.libreoffice.org/49266 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2018-02-06Import distributed text alignment settings correctly from orcus.Kohei Yoshida
Change-Id: Id04e2bd19475d6d7b98560835bc5aaad4bb8addf Reviewed-on: https://gerrit.libreoffice.org/49265 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2018-02-05Translate German variable namesJohnny_M
Fakt -> Factor in ftools Change-Id: I86f8d68015625c8ec7b3d260dbb3f734d2d7008e Reviewed-on: https://gerrit.libreoffice.org/49195 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
generated by cgit (git 2.34.1) at 2024-08-01 23:05:33 +0000