Age | Commit message (Collapse) | Author |
|
Change-Id: Ia8b0d84bbf69f9d8f85505d019acdded14e25133
Conflicts:
sw/qa/tiledrendering/tiledrendering.cxx
|
|
Change-Id: I9522529d918e143aafa6ea368fdb3fa55416d58b
Reviewed-on: https://gerrit.libreoffice.org/15176
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
|
|
Change-Id: Ice2e45a3db59adc34a160b4b410cc51c750835f2
|
|
Change-Id: Id3d6b50e07ea0850af18ab9bdadfffe0e4602aab
|
|
Change-Id: I63706daa3a53f444f96617feec22bc920a098469
|
|
Change-Id: If08968487f62d0bc4c827bb69be25db6f9d5a0ee
|
|
Change-Id: Icc432d6d3e40be9a6e1956c2d0c1dd2250c273a9
|
|
Change-Id: I22cbcb9d1f15ab18a8d70c1793c64f04f27389a2
|
|
That makes my life so much easier when I need to debug where we screw
up.
Change-Id: Ia0b54eef47a06c43e3d0ba66b909e398e02a6d0e
|
|
Change-Id: Iffb7a766f15475e3600332a6c76a15a1d192d7c8
|
|
Change-Id: I393edc816aaf189b1001e630c76f67dd53fd5be3
|
|
...to avoid clashes with macros and poor warnings about hiding global FILE
Change-Id: I444e8b958f029201b228937e088efabc4b6d3050
|
|
...and fix o3tl::enumarray::operator [] const overload
Change-Id: I749b1b9d68686b03a97074253478d9d2d9d32b0b
|
|
Change-Id: Ibf0c73ac17ec19ed672f66907db47057920babca
|
|
since their usage is intertwined.
Also introduce new o3tl utilities enumrange and enumarray to make
working with scoped enums a little simpler.
Change-Id: I2e1cc65dd7c638e59f17d96dfae504747cad6533
|
|
Change-Id: Iddde148aa783c252d0c864e30855383e996dbf69
|
|
Change-Id: I985ccd5f852d10e5565e2a90f094fb0242bb0265
|
|
Change-Id: Iea5209473632891b2015ac2df493e307972867e8
|
|
Change-Id: I8489b0341709d44bc62e5ddef49fe232998f3c80
|
|
Change-Id: I0594de8cc79626720f2f72062c39a6f2590dd64f
|
|
Change-Id: I10c30ef28e7321882a720d1e7869a75a89febfc5
|
|
As the crash tests have shown, the assert introduced with
71b630e5b683b3761af9d6bdce56f13f20da84c1 to force verification of the
assumption made in 8e2293e06adba3f22e824acad99983fb5b997e4d was hit in
120 documents.
Citing from https://gerrit.libreoffice.org/#/c/14427/ comment:
"The assumptions behind this patch are wrong. This only works if every
single part of the export goes through StartRecord/EndRecord calls. We
have some features that don't use that and need the STREAM_SEEK_TO_END
in the beginning of the StartRecord."
Revert "replace an OSL_ENSURE() with assert(), tdf#89319 related"
This reverts commit 71b630e5b683b3761af9d6bdce56f13f20da84c1.
Revert "tdf#89319 remove redundant file seekings in XLS export"
This reverts commit 8e2293e06adba3f22e824acad99983fb5b997e4d.
|
|
Change-Id: I18b1b0b92b106c5fd96c80472e279a7cfd380235
|
|
Change-Id: Iae8e50864dbd90ff49a4fcc31a06b2158eab4afc
Reviewed-on: https://gerrit.libreoffice.org/14998
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
there were a couple of lines in SC and SW where the code was using a
EV_CNTRL constant. I switched it to used the same-valued constant from
EE_CNTRL
Change-Id: I027183cc3b6e700bf365d48833e37eddc9b50f04
|
|
and clean up F-Distribution function names.
Change-Id: I8666659269121b3ea32e8179b42e3497aa86754f
Reviewed-on: https://gerrit.libreoffice.org/14657
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
|
|
Change-Id: I7d1be2365c2e18a007a26e63195ea0cb169ee254
|
|
Change-Id: Ib29a0d5c9fefe15fbd0f08a5cf9600eff58cd030
|
|
Change-Id: Idbbc4b64b616ead6ef880340064623b9a5c0ff51
|
|
Change-Id: I4143b91b4d2edea9a9dab7ce1c06a59ca5d12857
|
|
Change-Id: Id3268114041575d7dbb84e8d963ead566c78b928
|
|
for pivot table cache records.
Regression from commit d17a83fa549f828f29e6939. On loading pivot table
cache records, a dummy sheet is created to store them. Formula buffers
are now vectors, not maps and need to be resized in such case.
Change-Id: Ib6abeac1b139ffb74579712017eed2194cff592b
|
|
Will need it for tdf#89597
Change-Id: I705d30422e2de9d5f75ac0c5c69c69ede05af48f
|
|
Change-Id: I822c21cd3c3bd8f720e39f540b4931050d62fb91
|
|
Change-Id: I6aff104fa5749217d5c9628b5dfbfd3ac79bdc43
|
|
of which there are several.
There are some issues here I am unsure of
- the SW and SC and CHART2 modules essentially ignore the enum values and assign their own ids
Perhaps I should change them to use the common values and create new enum values where necessary?
- the sc/qa/ and sq/qa/ and starmath/qa/ code was doing some dodgy stuff. I translated the code to pass down the stuff
numeric values to the underlying code, but perhaps further fixing is necessary?
Change-Id: Ic06d723e404481e3f1bca67c43b70321b764d923
|
|
Change-Id: Ib275192452c6836cbaac2e517942ec5356dfd9ab
|
|
...for a 32-bit build, similar to what ee11e221d2108212619e1bbe7f029e7d9afdba32
"tdf#43157: Fix format string violations in OSL_TRACE etc." did for a 64-bit
build
Change-Id: I05dd79ede3e66cb9ab7a33792319eb34b34c82dd
|
|
...in preparation of enabling the __attribute__((format(...))) in
sal_detail_logFormat (include/sal/detail/log.h)
Change-Id: I8a859199fa11ca0f9f4f4b4b23a8ebddec955a86
|
|
Change-Id: I44b2521ea548b51a1b3e9b42cfa64c5f50d7798a
Reviewed-on: https://gerrit.libreoffice.org/14504
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
Tested-by: Kohei Yoshida <libreoffice@kohei.us>
|
|
Change-Id: Ie64d47123200c23a1aa2c0a81135b265d09c0f63
|
|
Change-Id: I673c8daabb6438f833571b0c70df1e73e6b8d273
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
|
|
... because sFormula1 in such cases usually (?) is not empty.
Change-Id: Idc0b71e258018b4728e3d7e7f8942e0c09b22e5c
|
|
Change-Id: I7783d96e40de7a8df794f143d2c7830bf3314218
|
|
Commit 8e2293e06adba3f22e824acad99983fb5b997e4d changed
STREAM_SEEK_TO_END logic, ensure that in a dbgutil build we catch
unnoticed corner cases with assert() instead of just another fly-by
warning.
Change-Id: If6c4fb4d2467f7dc7b8177caf7353d0b0e56ed0d
|
|
Change-Id: I85993df91bd14966f9175c356966fbd8eb1a927d
|
|
The TokenPool::operator[] is used to initialise and take into use an object
from the pool. Which is a fascinating thing as such and probably not entirely
in good style. Anyway, the objects in the pool are of type ScTokenArray, a
class derived from FormulaTokenArray. The operator[] called the
FormulaTokenArray::Clear() function to initialise the object. This left the
fields added in ScTokenArray uninitialised, having whatever value the previous
use of the object had set. Which of course is bad.
In practice, this showed up in the handling of formulas in the .xls input
filter. If an earlier (or the first?) formula had happened to be one for which
we don't want to use OpenCL, the meVectorState of its ScTokenArray object in
the pool had been set to FormulaVectorDisabled. When the same pool object was
later re-used for another formula, it kept that same meVectorState, even if
there was no reason to. Thus formula groups that should have been OpenCL
accelerated weren't. This can have a significant impact on performance of
document loading and recalculation for large documents.
I added a function to ScTokenArray to clear (initialise) such an object, both
the FormulaTokenArray part and the ScTokenArray-specific part, and call that
instead. This fixes the issue.
I named the added function ClearScTokenArray() to make it clear that it is a
separate function. Sure, possibly Clear() should be made into a virtual of
FormulaTokenArry and overridden in ScTokenArray, and the overriding Clear()
would first call the base class's Clear(). But I can't be sure that there
aren't other calls of FormulaTokenArray::Clear() that *must* mean the base
class one. Better safe than sorry.
And of course, I did *not* want to name the function in ScTokenArray also
"Clear()", like in the base class, without it being virtual. That is horrible
style in my opinion, even if there certainly is precedence for such even in
the very same classes, i.e. the Clone() function...
Change-Id: I0e0e13e5ca705603005a1e0a46866f095cd2ac4d
|
|
Change-Id: I07400d6dead66ec437436b5ea8b49491f8048335
|
|
|
|
Change-Id: I97c7977fdfea57b5d1c45ce0c5902b74cc719db9
|