summaryrefslogtreecommitdiff
path: root/sc/source/ui/attrdlg
AgeCommit message (Collapse)Author
2017-02-16add SID_SC_TP_STAT and replace RID_SCPAGE_STAT with itCaolán McNamara
Change-Id: Ia4364ba408b439f66e959be915e8b6e9cc5eacb4
2017-02-16replace SID_SC_TP_LAYOUT with SID_SC_TP_LAYOUTCaolán McNamara
Change-Id: I4dc2f1ffa5df5ae47d216d5242530eb63750e915
2017-02-16replace RID_SCPAGE_CONTENT with SID_SC_TP_CONTENTCaolán McNamara
Change-Id: I95f127756200d0389103cf11d5e03c0a40e27d05
2017-02-16replace RID_SCPAGE_USERLISTS with SID_SC_TP_USERLISTSCaolán McNamara
Change-Id: I2e7fdff7e8ab61eee7b67f9e7694f3bdc2c0854c
2017-02-16replace RID_SCPAGE_PRINT with RID_SC_TP_PRINTCaolán McNamara
Change-Id: Ie12f9489290dd9bfce925eff4586f22489cff96a
2017-02-16replace switching off RID_SCPAGE_DEFAULTS with direct RID_SC_TP_DEFAULTSCaolán McNamara
Change-Id: Ie451c6f63d729af85334cabbe2469a44f431f3d3
2017-02-16replace RID_SCPAGE_COMPATIBILITY with direct SID_SC_TP_COMPATIBILITYCaolán McNamara
Change-Id: I256780e66d361233f9099d9f10a735d983f70b03
2017-02-16replace switching off RID_SCPAGE_FORMULA with direct SID_SC_TP_FORMULACaolán McNamara
Change-Id: I6a2738791851aa1ad0813dfe8c8976cb96f1b79a
2017-02-16replace switching off RID_SCPAGE_CALC with direct SID_SC_TP_CALCCaolán McNamara
Change-Id: If8e600ae092a4299cace86c75e3ea28c812ba47e
2017-02-16replace switching off RID_SCPAGE_OPREDLINE with direct SID_SC_TP_CHANGESCaolán McNamara
Change-Id: Iea5646ec22fabbe1e190dd8726cec91cdd39e28b
2016-11-11loplugin:countusersofdefaultparams in sc(part2)Noel Grandin
Change-Id: I1e2a0969ca7e9e0f75079a171150269dfed26507 Reviewed-on: https://gerrit.libreoffice.org/30755 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-31return dialog pointers using VclPtr<>Noel Grandin
or their ref-count could drop to zero before they actually get used Change-Id: I5af7a0cc8650e3d779c870144c23b6de19c8cc45
2016-10-31This needs to be VclPtr tooJulien Nabet
Avoid this segfault: Thread 1 "soffice.bin" received signal SIGSEGV, Segmentation fault. 0x00002aaad2a20e4e in VclReferenceBase::acquire (this=0x9999eeeef579c129) at /home/julien/lo/libreoffice/include/vcl/vclreferencebase.hxx:38 38 assert(mnRefCnt>0); (gdb) bt 0 0x00002aaad2a20e4e in VclReferenceBase::acquire (this=0x9999eeeef579c129) at /home/julien/lo/libreoffice/include/vcl/vclreferencebase.hxx:38 1 0x00002aaad37325ae in rtl::Reference<AbstractScImportAsciiDlg>::Reference (this=0x7ffffffef7c0, pBody=0x55555be02790) at /home/julien/lo/libreoffice/include/rtl/ref.hxx:63 2 0x00002aaad37321b5 in VclPtr<AbstractScImportAsciiDlg>::VclPtr (this=0x7ffffffef7c0, pBody=0x55555be02790) at /home/julien/lo/libreoffice/include/vcl/vclptr.hxx:89 3 0x00002aaad3731e25 in ScopedVclPtr<AbstractScImportAsciiDlg>::ScopedVclPtr (this=0x7ffffffef7c0, pBody=0x55555be02790) at /home/julien/lo/libreoffice/include/vcl/vclptr.hxx:305 4 0x00002aaad373055e in ScFilterOptionsObj::execute (this=0x555558d8d450) at /home/julien/lo/libreoffice/sc/source/ui/unoobj/filtuno.cxx:179 5 0x00002aaad1c03f50 in (anonymous namespace)::handleFilterOptionsRequest_ (xContext=uno::Reference to (cppu::ComponentContext *) 0x5555559ec960, rRequest=..., rContinuations=uno::Sequence of length 2 = {...}) at /home/julien/lo/libreoffice/uui/source/iahndl-filter.cxx:259 6 0x00002aaad1c044f4 in UUIInteractionHelper::handleFilterOptionsRequest (this=0x555558c1b400, rRequest=uno::Reference to (RequestFilterOptions *) 0x555558d5edf8) at /home/julien/lo/libreoffice/uui/source/iahndl-filter.cxx:315 Change-Id: I50f9f5c4c63328a0aaa3ecb2d83a902de6a38add Reviewed-on: https://gerrit.libreoffice.org/30410 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-28these need to be VclPtrsCaolán McNamara
Change-Id: I83616728289e398c97e50f33b5dd1de404deaa27
2016-10-27make the AbstractDialog stuff extend from VclReferenceBaseNoel Grandin
Because some stuff wants to multiple-inherit from VclAbstractDialog and OutputDevice-subclasses, and we'd prefer to keep all the lifetime management through a single smart pointer class (VclPtr) The change in msgbox.cxx and window.cxx is to workaround a bug in VS2013 to do with virtual inheritance and delegating constructors. Change-Id: I178e8983b7d20a7d2790aa283be838dca5d14773 Reviewed-on: https://gerrit.libreoffice.org/29140 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-05Remove _TYPED suffix from tools/link.hxx macrosStephan Bergmann
...which was introduced with 3ead3ad52f9bb2f9d1d6cf8dfc73a0a25e6778ed "Gradually typed Link" to distinguish the new, typed versions from the old, untyped ones, but is no longer necessary since 382eb1a23c390154619c385414bdbe6f6e461173 "remove untyped Link<>" removed the old versions. Change-Id: I494025df486a16a45861fcd8192dfe0275b1103c
2016-09-19tdf#96453, tdf#100793 rework transfer of data between cond format dlgsMarkus Mohrhard
The xml based transfer of information was a bad idea from the start. It can obviously not transport the temporary conditional format information from the manager dialog. Therefore the whole handling here was completely broken and deleted formats came back, changed formats were not saved and added formats got applied directly to the document. Now the document fornat list and the one from the manager are indepedent again and as long as the manager has not been closed with ok nothing is written to the document. Change-Id: I9802be11cd15c2d2d877e55c91d836735fe0e0ff Reviewed-on: https://gerrit.libreoffice.org/28995 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-09-13loplugin:override: No more need for the "MSVC dtor override" workaroundStephan Bergmann
The issue of 362d4f0cd4e50111edfae9d30c90602c37ed65a2 "Explicitly mark overriding destructors as 'virtual'" appears to no longer be a problem with MSVC 2013. (The little change in the rewriting code of compilerplugins/clang/override.cxx was necessary to prevent an endless loop when adding "override" to OOO_DLLPUBLIC_CHARTTOOLS virtual ~CloseableLifeTimeManager(); in chart2/source/inc/LifeTime.hxx, getting stuck in the leading OOO_DLLPUBLIC_CHARTTOOLS macro. Can't remember what that isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.) Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
2016-09-10loplugin:constantparam in scNoel Grandin
Change-Id: I82c78dd880c98532db407b0183a43705be2de67c Reviewed-on: https://gerrit.libreoffice.org/28777 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-29loplugin:countusersofdefaultparamsNoel Grandin
Change-Id: I26f46ddac3d7d810ebfa1c3e7f1a77427369828e Reviewed-on: https://gerrit.libreoffice.org/28451 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-18screenshots: clang plugin & tabpage usage fixesArmin Le Grand
Adapted clang compiler results, made TabDialog implementaions of ScreenShot API work with real UXMLDescription names, including a solution for using multiple tabPages with the same *.ui file Change-Id: I56df878b3db3bcc18fa2b4713b7ad72d42e8eb30
2016-08-18screenshots: sc dialog factory ifc for tab dialogsKatarina Behrens
Change-Id: Ia1f67a161cfadbf2b71d3647c50e1c0a4b24ae8d
2016-08-18screenshots: dialog doesn't even have a help buttonKatarina Behrens
So drop helpID argument from its ctor (not to mention the fact that a help text with ID .uno:TabBgColor doesn't exist either) Change-Id: I0624f0474334cc799d67f7f292e11194de5195fa
2016-08-18screenshots: interface for sc dialog factoryKatarina Behrens
Change-Id: Ibe0f8ec2714002b2dc84ef0c0bb8cb845e906aab
2016-07-26sc: convert SC_SCENARIO_.. defines typed flags ..Jochen Nitschke
ScScenarioFlags add ScScenarioFlags::NONE for 0. replace uses of '-= flag' with '&= ~flag'. Change-Id: I003c0ca1f59b060f52935fec8bb6282fd9981805 Reviewed-on: https://gerrit.libreoffice.org/27464 Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-06Convert DeactivePage return code to scoped enumNoel Grandin
Change-Id: Idd5372ad20fc6676864b31b3796f8b9bc0ad73dd Reviewed-on: https://gerrit.libreoffice.org/25918 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-26loplugin:unusedmethodsNoel Grandin
Change-Id: Ib36bc0e87d00abb638cbfec511cd13b6179eabda Reviewed-on: https://gerrit.libreoffice.org/25431 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-24convert PIVOT_FUNC to scoped enumNoel Grandin
Change-Id: I6d50ad6fa0dbe7b21ad73e14dc2df3c854d08153 Reviewed-on: https://gerrit.libreoffice.org/25076 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2016-03-31sequence->vector in scNoel Grandin
Change-Id: I3edf08fe5db798dbc1190db375cfb82c5b9bc5da Reviewed-on: https://gerrit.libreoffice.org/23696 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-03-23loplugin:constantparam in scNoel Grandin
Change-Id: I437367b8c6960db730a69c020ba82792a9170d01
2016-03-10loplugin:constantparam in scNoel Grandin
Change-Id: Ia7bc394fdc0dba720751c2a58d55bfe34b239098
2016-03-03loplugin:unuseddefaultparams in sc (part2)Noel Grandin
Change-Id: I356a86bfca20cbf2c52185697042dce5237e847d
2016-01-22Move sc/source/ui/dbgui/validate.cxx from scui to scStephan Bergmann
8d1a24dae03690b576310e3539369916f31ac475 "Make virtual ~ScValidationDlg non-inline" caused the RTTI for ScValidationDlg to only be emitted in library scui instead of (weakly) wherever needed. That causes UBSan to fail when it uses the RTTI in ScValidityRefChildWin::ScValidityRefChildWin (sc/source/ui/view/reffact.cxx, in library sc, to check that operations on VclPtr<ScValidationDlg> pDlg indeed operate on an ScValidationDlg object). The cleanest fix appears to be to move ScValidationDlg from scui to sc. As Moggi put it on IRC, "that dialog should be in sc as it is a modeless dialog; no idea why it works for that dialog but all other modeless calc dialogs have to be in sc to avoid linker problems." One remaining question is whether it is save nowadays in ScCellShell::ExecuteDB (sc/source/ui/view/cellsh2.cxx) to clean up the ScValidationDlg pointed to by pDlg when that VclPtr<ScValidationDlg> variable goes out of scope, instead of doing the PostUserEvent(... DelayDeleteAbstractDialog) dance that was there before because "after end execute from !IsModalInputMode, it is safer to delay deleting." Lets see. Change-Id: I3ecfd4fafc7b37b2f30e75974ece9b0a23311ef4
2015-12-15Bin silly 'STATIC DATA' commentsTor Lillqvist
Change-Id: I50e3772b7b479d2cf1eb644c7334d0f987874ccb
2015-11-30loplugin:unusedfieldsNoel Grandin
Change-Id: Icac4ac1a2614e72bc9ff070819533e09eeb1a864
2015-11-25loplugin:unusedfields in include/sfx2/Noel Grandin
Change-Id: I3eb27ed10e82ee56b33866ac576c1b1f8c9756b9
2015-11-10loplugin:nullptr (automatic rewrite)Stephan Bergmann
Change-Id: I765d2a600f9c57da50c85354688e3ae796750d94
2015-11-04loplugin:stringconstantNoel Grandin
Change-Id: I9d3b60bb9f0d8c09968e2be1035fb8e654ac9c95 Reviewed-on: https://gerrit.libreoffice.org/19769 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-02cppcheck: noExplicitConstructorCaolán McNamara
Change-Id: I06186e8f0bbc8522f538e8639a68e816093becc2
2015-10-28com::sun::star->css in scNoel Grandin
Change-Id: I7774890f46f9343e944e34db27af8bce3b1d0915
2015-10-26convert InsertDeleteFlags to use o3tl::typed_flagsNoel Grandin
Change-Id: I3f6a97195d3364b2a0964f62f11e9c0de9493d64
2015-10-14convert Link<> to typedNoel Grandin
Change-Id: I1876f327607e0e23292950741df348d4ec31fde1
2015-10-12Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY codeStephan Bergmann
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
2015-09-22convert SC_PASTE constants to scoped enumNoel Grandin
Change-Id: I2c1b2cd5a89b3124a2e452800bf397e100cc885b Reviewed-on: https://gerrit.libreoffice.org/18734 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-08-31loplugin:stringconstant: OUStringBuffer: appendAscii -> appendStephan Bergmann
Change-Id: I4e350a0c6045d07677edae4f9921db0a42b4e0f5
2015-08-26Convert vcl Button Link<> click handler to typed Link<Button*,void>Noel Grandin
Change-Id: Ie80dfb003118d40741549c41ebcc7eda4819f05b
2015-08-13make Link<> instances typedNoel Grandin
Change-Id: I7d20875cc498d54140cfe75b21373fdab9c369ce
2015-07-22loplugin:unusedmethods scNoel Grandin
Change-Id: I7bdb1889a942d63370731764a58f4ab524dedd8a Reviewed-on: https://gerrit.libreoffice.org/17287 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-06-06Apply new VclPtr clang plugin to catch potential problems.Noel Grandin
Omit the plugin, and sw's FrameControlsManager for now. Change-Id: Ifb98a2e6e03a9d099efc1668305b96bd9142ca5f Reviewed-on: https://gerrit.libreoffice.org/16117 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2015-05-12tdf#60573 Conditional formatting does not allow scrollingHenry Castro
If you need to apply conditional formatting to a cell not shown presently on your screen you cannot scroll to the position you would like to use. Change-Id: I18549316d2c725ce032a65cffb969bed21b771c3 Reviewed-on: https://gerrit.libreoffice.org/14258 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit (git 2.34.1) at 2024-08-01 19:49:17 +0000