summaryrefslogtreecommitdiff
path: root/sc/source/ui/attrdlg
AgeCommit message (Collapse)Author
2023-10-07Revert "tdf#149598 - Remember window state of the format cell dialog"Andreas Heinisch
This reverts commit c1893df42567c260ca5fb069038d1a55616e7b7f. Reason for revert: causes a regression under Linux (Bug 156710) https://bugs.documentfoundation.org/show_bug.cgi?id=156710 Change-Id: I72a570ecba4cf7fe594a0bb50a121ab2e99cc613 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157624 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2023-08-25downgrade from assert to SAL_WARNCaolán McNamara
Change-Id: I78130d438fb9da60e929d7b6bad99bb6ec3d3e30 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156095 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-08-25sc: fix crash in ScAttrDlg::PageCreatedXisco Fauli
See https://crashreport.libreoffice.org/stats/signature/ScAttrDlg::PageCreated(rtl::OString%20const%20&,SfxTabPage%20&) Change-Id: I3f89cc917648462f819eb35461055096a6eb3853 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156093 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-07-25follow tdf#154131 Treat also HMTL importLaurent Balland
Add Detect numbers in scientific notation option to HTML paste Still need some qa tests Change-Id: I553404a01ab2a61566b861b3c01d14bdc0c46668 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152591 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2023-06-01tdf#149598 - Remember window state of the format cell dialogAndreas Heinisch
Change-Id: Ie3b468c674a9a811a5359155cda1d96ed44e50fc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152474 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2023-04-02Avoid conversions between OUString and OString in VCLMike Kaganski
Standardize on OUString, which is the main internal string class. Convert from/to OUString only when communicating with respective external APIs. Removes about 200 conversions from the code. Change-Id: I96ecee7c6fd271bb76639220e96d69d2964bed26 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149930 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-03-22sc drawstyles: Add a dialog for style editingMaxim Monastirsky
Change-Id: I7e62251024df8f24bd6fe318f5c0262bbd6a1a11 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149279 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2023-03-04sc: remove protect cell tab from cell format dialogPranam Lashkari
Change-Id: I33a32ca756263426abb4dcb733139baf58221554 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147897 Tested-by: Jenkins Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
2022-12-16check SfxObjectShell::Current()Caolán McNamara
SfxObjectShell::Current() can return null, it's based on the equally vile SfxViewFrame::Current() Change-Id: Ia5c7783680e9d8e5d3075078f16a2c15cb6f7a47 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144339 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-11-15sc: convert optimal width/height and normal width/height dialog to asyncrash419
Signed-off-by: rash419 <rashesh.padia@collabora.com> Change-Id: I96f6d90692d7767bdc276f753897bdc392c90411 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132919 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133127 Reviewed-by: Gökay ŞATIR <gokaysatir@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142633 Tested-by: Jenkins Reviewed-by: Aron Budea <aron.budea@collabora.com>
2022-11-02sc: make InsertCell and DeleteCell async.Michael Meeks
Also enable them for use with jsdialogs. Change-Id: I378f228e86959edb98ad691089af919330dcdcec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142144 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2022-06-07tdf#129674 Add GoTo Sheet commandLaurent BP
Insert command in menu Sheet > Navigate (alongs with To Previous/Next Sheet) Use .uno:JumpToTable command from Navigator Use its own Go To Sheet dialog Add a Search entry to type partial name of sheet Menu translation missing? Change-Id: I16b8b56a688c8396159617f04a2a7e034721ce31 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134714 Tested-by: Jenkins Reviewed-by: Laurent Balland-Poirier <laurent.balland@mailo.fr>
2022-02-03sal_uLong->sal_Int32 for refresh delayNoel Grandin
and improve the naming of the related methods and variables Change-Id: I1dc522090b0353fd4c63e74864a0deeb8d70fd28 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129404 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-27remove unused DECL_ABSTDLG_BASE and IMPL_ABSTDLG_BASETomoyuki Kubota
Change-Id: I8ba8f940cb4931974d10c8d6cf1d4fd205c18e71 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127469 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-30loplugin:constparams improve handling of pointer paramsNoel Grandin
Change-Id: I4c0002e72703eded435bfe4985f5b0121bf8524b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122843 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-07-28use officecfg for SvtCJKOptionsNoel Grandin
and remove some unused options Change-Id: I487a233de4f7414012e5405f2c2e1f9c8b8fb4f2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119554 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-07-20tdf#142763 sc UI: add first page header/footer optionsDaniel Arato (NISZ)
Add checkbox "Same content on first page" checkbox (similar to the existing "Same content on left and right pages) to the Page Style dialog window, on the Header and Footer panes. Follow-up to commit 19fa853ce12136b5c14e0c5a0aa906c296b75388 (tdf#121715 XLSX: support custom first page header/footer) and commit 52beb3907dd3c7e6ae112e263def1005272cecd8 (tdf#142764 sc: import "Same content on first/left page"). Note: to set different header or footer on the first page of the spreadsheet, disable "Same content on first page" on Format->Page Style...->Header (or Footer), and choose the "Edit..." button. Change-Id: I3348fde216424b8d2c662956eab27cbe5880fc1e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117316 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2021-07-19Move svl::Items to include/svl/whichranges.hxx, and unify its usageMike Kaganski
... in WhichRangesContainer and SfxItemSet ctors. Now it's not needed to explicitly use 'value' in WhichRangesContainer's ctor, or create an instance for use in SfxItemSet ctor (svl::Items is already defined as a template value of corresponding type). Instead of WhichRangesContainer Foo(svl::Items<1, 2>::value); SfxItemSet Bar(rItemPool, svl::Items<1, 2>{}); now use: WhichRangesContainer Foo(svl::Items<1, 2>); SfxItemSet Bar(rItemPool, svl::Items<1, 2>); Change-Id: I4681d952b6442732025e5a26768098878907a238 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119157 Tested-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-07-15WhichRangesContainer, reduce malloc in SfxItemSetNoel Grandin
SfxItemSet shows up in perf profiles frequently, and the hottest part is the malloc of the two arrays we need. But most of the time, one of those arrays is a compile-time constant. So this change introduces (*) WhichRangesContainer, which manages whether the SfxItemSet owns the array it points at or not. (*) a static const member in svl::Items (idea from mkaganski) to store the data. Change-Id: Icb8cdbc4d54fd76739565c575e16a744515e5355 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118703 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-22fix shutdown leak in ScCreateDialogFactoryNoel Grandin
Change-Id: I7be0fa457fb11dbc1096042636b641cd09df8b4e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115987 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-21add Toggleable as a separate thing to a ButtonCaolán McNamara
and inherit ToggleButton from both it and Button Change-Id: If0e500aca8d0ffa087cb5e2bfc1786372fbff4eb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115921 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-17pivot table: properly close all subdialogsSzymon Kłos
Change-Id: Ieda601ce25d822394d6ddd12da861128b9270aa2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107843 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114207 Tested-by: Jenkins
2021-03-23tdf#124176 Use pragma once in s*Vincent LE GARREC
sc, scaddins, sccomp, scripting Change-Id: Ia99fec9e238033821cb784810edd4762c09bd5db Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112049 Tested-by: Jenkins Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2021-03-09let ScLinkedAreaDlg have a Widget parent instead of a WindowCaolán McNamara
Change-Id: Ida871186e5d15290ed2520b18651bad211799c1e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112167 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-08pivot table: make subdialogs of pivot table dialog asyncSzymon Kłos
Change-Id: I2c1b26ebe661a2f66bc7bf94e4f3ede2fc5e18b9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107775 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112095 Tested-by: Jenkins
2021-02-19tdf#65872 [WIP] Allow prefered interpretation of pasted numbers to be savedGeorge Bateman
Change-Id: I065f1f8cff1b3c7d7198ce431df39a7b8cb7b593 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107402 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-01-11CreateScSubTotalDlg always called with a non-null pArgSetCaolán McNamara
Change-Id: I8a13a66ab7ce55a48896a921dc3b91594abefbc4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109068 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-11CreateScAutoFormatDlg always passed a non-null ScViewData*Caolán McNamara
Change-Id: I0b9568df6fdc571b5fa6cbf75a7473ac588442da Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109066 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-07Make Pivot table db & external source dialogs asyncSzymon Kłos
Change-Id: Iff1a49a9fa04b55ece1aa30259ab57d105883eda Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106996 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108798 Tested-by: Jenkins
2020-11-30Make Pivot table data source dialog asyncSzymon Kłos
Change-Id: I573038935e31c5393293197c1a9706110a970837 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106848 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2020-11-27tdf#42949 Fix new IWYU warnings in directory sc/Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I217817e2e4a42b096f5a7fb6344568c10d69aab2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106078 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-11-19tdf#123936 Formatting files in module sc with clang-formatPhilipp Hofer
Change-Id: I66cafda863e3e1e4559a57289c09925d68b0719c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105701 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Jenkins
2020-10-20use tools::Long in scNoel
Change-Id: I8f37a8d1174ed816df971b8cee036d4e88d4a7fc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104526 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-09-23ScRefAddress::GetRefString never passed a null ScDocument*Caolán McNamara
so the nullptr check can be removed and some more along that vein Change-Id: Ic0c1f98564b6bd457edd0d3ba2a4382b7945e806 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103217 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-18Make Group dialog asyncSzymon Kłos
Change-Id: I37fd6c44d43b0f0b424bd023e13ffa07f601a08b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100119 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102876 Tested-by: Jenkins
2020-07-28Make Sort dialog asyncSzymon Kłos
Change-Id: I914e09e59561e261dc2807ad00615d3b58afa541 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99127 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99351 Tested-by: Jenkins
2020-07-08distinguish between dialog screenshoting and rendering a widgetCaolán McNamara
Change-Id: I43ee0c68d72c97a15d26e2ffea577c2a44ba91e8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98326 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-05Upcoming loplugin:elidestringvar: scStephan Bergmann
Change-Id: I0a045ffde0228c316795dbdfce4e0d883bb3b55e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95537 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-04-30loplugin:makeshared in scNoel Grandin
Change-Id: I512d05ea24c519c25f03a35842e362bf23f05693 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93198 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-25tdf#127113: Allow to fill any two numeric fields in Fill Series dialogSarper Akdemir
Added m_nSelectHeight and m_nSelectWidth to ScFillSeriesDlg class for deriving missing box if other two boxes are full. CheckValues() mimics behaviour of previous check functions with added functionality of calculating missing start or increment values (end value was already handled in previous check functions) in linear fill mode if it is possible to calculate them from other two values. Change-Id: If30d96f1b5f7e1bb88f473d7c0c5c2802ba6f225 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87841 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2020-02-07tdf#99693 Add Highlighting tab for CalcMaxim Monastirsky
Works with shapes and comments. Change-Id: I2a91a6038ab618bf7e6fd4eb2d129a9485a47fef Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88163 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2019-11-08Resolves: tdf#128667 crash in csv import from pasteCaolán McNamara
Change-Id: Id50d0a7e4f176ccf83292495cb229da492fbf381 Reviewed-on: https://gerrit.libreoffice.org/82287 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-17weld ScImportAsciiDlgCaolán McNamara
notably the csv control is always LTR even in RTL mode, but the surrounding ScrollingWindow follows the environment direction, except the horizontal scrolling widget itself must LTR scroll. Change-Id: I72ee2b9dade73a11bcc4391e755fdb02886a884d Reviewed-on: https://gerrit.libreoffice.org/80765 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-15new loplugin:bufferaddNoel Grandin
look for OUStringBuffer append sequences that can be turned into creating an OUString with + operations Change-Id: Ica840dc096000307b4a105fb4d9ec7588a15ade6 Reviewed-on: https://gerrit.libreoffice.org/80809 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-09Related: tdf#123765 fix up some screenshottingCaolán McNamara
and add in two special cases for the mentioned cui dialogs Change-Id: Ibd2bf8e9e5bff131f2c009c784652f4500842326 Reviewed-on: https://gerrit.libreoffice.org/80488 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-08implement gtk dialog screenshottingCaolán McNamara
Change-Id: If4e570f775bd1e29dfb75cb7e5dd9d9dfc35e654 Reviewed-on: https://gerrit.libreoffice.org/80416 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-26now drop TabPageParent intermediateCaolán McNamara
Change-Id: I47328f76342ac023628d9042bdfa8213a1c93d0c Reviewed-on: https://gerrit.libreoffice.org/79469 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-26disinherit OWizardPage and SfxTabPage from vcl TabPageCaolán McNamara
Now that there's no need to support weld/unwelded mixes of pages in dialog any more. inherit from a BuilderPage which contains a Builder and Toplevel container BuilderPage Activate and Deactivate replace TabPage ActivatePage and DeactivatePage, allowing disambiguation wrt SfxTabPage ActivatePage and DeactivatePage. Change-Id: I5706e50fd92f712a25328ee9791e054bb9ad9812 Reviewed-on: https://gerrit.libreoffice.org/79317 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-12weld ScDataFormDlgCaolán McNamara
Change-Id: I656a11f5f9c55913cede710cf48543384132129d Reviewed-on: https://gerrit.libreoffice.org/72199 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-11weld ScCondFormatManagerDlgCaolán McNamara
Change-Id: Iccf2657f2c8fe98b4e975936fb75d56fc9523b5a Reviewed-on: https://gerrit.libreoffice.org/72162 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit (git 2.34.1) at 2024-07-18 11:29:52 +0000