summaryrefslogtreecommitdiff
path: root/sc/source/ui/dbgui
AgeCommit message (Collapse)Author
2014-06-25remove whitespaceMarkus Mohrhard
Change-Id: Ib15413e73409cc33de01fa92a47b9d1237cfc4b2
2014-06-24new compilerplugin returnbyrefNoel Grandin
Find places where we are returning a pointer to something, where we can be returning a reference. e.g. class A { struct X x; public X* getX() { return &x; } } which can be: public X& getX() { return x; } Change-Id: I796fd23fd36a18aedf6e36bc28f8fab4f518c6c7
2014-06-17improve the inlinesimplememberfunctions clang pluginNoel Grandin
Change-Id: I6d5a952901648e01904ef5c37f953c517304d31e
2014-06-13loplugin:staticcallStephan Bergmann
Change-Id: I670fbcd83e368f2821d37a392cbc007b1f4cd55e
2014-06-11Change SfxTabPage ctor SfxItemSet param from ref to pointerStephan Bergmann
...and also corresponding param of CreateTabPage function type and corresponding Craete functions. There were some call sites that passed undefined "null pointer references" and SfxTabPage internally uses a pointer member pSet that is checked for null anyway. Change-Id: I4eb3636155eac46c9c9d26e6e6e842e85d7e95af
2014-06-11Change SfxTabPage::Reset param from ref to pointerStephan Bergmann
...there was a call site that passed undefined "null pointer reference" (apparently in a case where the passed argument was actually unused) Change-Id: I663d4264b7a84f44ca69c732f3bc502f614b2b2a
2014-06-10Change SfxTabPage::FillItemSet param from ref to pointerStephan Bergmann
...there were a number of call sites that passed undefined "null pointer references" (apparently in cases where the passed argument was actually unused) Change-Id: I19799e90f0cd8e98367782441a5ea9df27b59830
2014-06-06Bin ugly (ab)use of preprocessor in headers (final part)Thomas Arnhold
Finish the work of ec8617568ff091026b2f17cce3b547b1633fa6c4 Only one is left: SC_PROGRESS_CXX Change-Id: Ifdc07ec377d7a84e92bc4b0a66ab82b1fc93f76a Reviewed-on: https://gerrit.libreoffice.org/9636 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-06-06coverity#735806 Dereference after null checkCaolán McNamara
Change-Id: Ie7a05e694585bcc624bd69b4400d84a05fbc48fb
2014-05-27Actually OK and Cancel is better here than Apply and Close.Kohei Yoshida
Because the same dialog is used when creating a new pivot table, where the Apply and Close semantic feels a bit weird. Also, some features of the dialog were designed with Ok / Cancel in mind (like the destination location). Change-Id: I9ac889bca9f967cb97b34ab45ea563547b58d422
2014-05-21Keep only "Apply" and "Close".Kohei Yoshida
Change-Id: I963419baec24d7599ddb3e481738cbe6ec4e0a69
2014-05-19hrc and src files: squeeze multiple newlinesThomas Arnhold
for i in `find . -name *.src -or -name *.hrc`; do FILE=$(cat -s "$i"); echo "$FILE" > "$i"; done Change-Id: I2bac5ad3e1eb3c566e5c867ccf45893a19e1561e
2014-05-15Avoid possible memory leaks in case of exceptionsTakeshi Abe
Change-Id: I7dc862794f7f0973bd4de7b54f7a1fb15235bc3e
2014-05-11fix-includes.pl: scThomas Arnhold
Change-Id: Iade3fedac5d2f8e978b7dd9c30f001d7d1564946
2014-05-05simplify ternary conditions "xxx ? yyy : false"Noel Grandin
Look for code like: xxx ? yyy : false; Which can be simplified to: xxx && yyy Change-Id: Ia33c0e452aa28af3f0658a5382895aaad0246b4d
2014-04-29coverity#1210191 Uninitialized pointer fieldCaolán McNamara
Change-Id: I7b4161217ccd70d00bd43740719825ba19058bf7
2014-04-29coverity#1210194 Uninitialized scalar fieldCaolán McNamara
Change-Id: I6572f70c1c0eaa149759189c6b196281e74e218d
2014-04-29coverity#1210198 Uninitialized pointer fieldCaolán McNamara
Change-Id: If72fff8b6cc7e5e55e1f395ddc34b4c5810faff3
2014-04-27constLuboš Luňák
Change-Id: I0ce6965f191d1455bcc7a793025282e20b7433a5
2014-04-23sc: sal_Bool->boolNoel Grandin
Change-Id: I70aad0b38979f45a313b8ac36890fb6c64d11bb0
2014-04-22clean up hrc filesThomas Arnhold
and remove some unused stuff Change-Id: Iea6177c3d2f9d0668187e66155b62688ae2ecb04
2014-04-21remove comments why a file gets includedThomas Arnhold
also remove some commented out code Change-Id: Ia80c5c57d8d2a74418032de50eee95642cc0969d
2014-04-19fixincludeguards.sh: scThomas Arnhold
sorry, huge one...
2014-04-16coverity#1202968 Uninitialized scalar fieldCaolán McNamara
Change-Id: Ic226202bb1ce429f9dd8e13183ec64ffc9059d05
2014-04-16coverity#1202963 Uninitialized pointer fieldCaolán McNamara
Change-Id: I1cb588ce7df30886354ac0cf2bd81fb95a7e9d37
2014-04-15CID#1202973 init class membersEike Rathke
Change-Id: Ib14d24970faa35ad0caf8c8a8bf7f9cef5764b89
2014-04-14Clean up function declarations and some unused functionsStephan Bergmann
Change-Id: If2c233a8ced8815b065a72caff907f10ef6166ff
2014-04-10callcatcher: update unused codeCaolán McNamara
OAuth2Handler is from libcmis Change-Id: Ia1986d6df7ab45580c66b4e536c5882af41f357f
2014-04-09convert data validation tab page to .uiCaolán McNamara
Change-Id: I1a4f1f4f06ec1ab0b28637380a8bfcb3bc64ee30
2014-04-08use TriState instead of sal_Bool as there's three possibilitiesCaolán McNamara
Change-Id: If24d4cec9ef4369f20419fe70de7392614a35316
2014-04-06whitespace cleanup in scMarkus Mohrhard
Change-Id: Id1dcadcac179c52977e48a6912ce4d5fd542f60c
2014-04-04coverity#708085 Uninitialized scalar fieldCaolán McNamara
Change-Id: If6aa0a955d8b80b2c1eb4d944829f46167b6fae9
2014-04-04callcatcher: remove old pivot table dialogCaolán McNamara
Change-Id: I9e80a0d6661c29343103a27baa752cebbc876314
2014-04-03pivot: duplicate data field handlingTomaž Vajngerl
Change-Id: I3d367b8b638217f18143118df00324f21a0470f2
2014-04-03pivot: Apply changes made in "Data Field" and "Data Field Options"Tomaž Vajngerl
Change-Id: If8560d47c5b4e64367c441237c1e38f964cf6825
2014-03-31Fix various warningsStephan Bergmann
Change-Id: I78aa55539c2a3e522736bb178ba7d445300bf1f0
2014-03-31pivot: new pivot table layout dialogTomaž Vajngerl
This commit adds a new pivot table layout dialog which was implemented from scratch. Instead of custom controls this one uses list boxes for field entries which greatly reduces the code. It also fixes some visual and behaviour bugs and adds the possibility to edit the "Data" field. Change-Id: I6c01252acee5a2e8910e40e65904504d00e03057
2014-03-29coverity#1194918 Overflowed array index readCaolán McNamara
Change-Id: Ic9cec3fc6749672b30bb1e0c96159897e50a84e5
2014-03-28coverity#982764 Dereference null return valueCaolán McNamara
Change-Id: Ib0f01bf529a739e5f92cd41979c18d76d7b545d1
2014-03-28coverity#982765 Dereference null return valueCaolán McNamara
Change-Id: I2fd5d432aff737016948a4f7bd45888cf6f4dba2
2014-03-27sfx2: sal_Bool->boolNoel Grandin
Change-Id: I1fd02cc148fd9a54d2092dad1e548f51a0813a14
2014-03-24Avoid possible resource leaks by boost::scoped_arrayTakeshi Abe
Change-Id: I7b72c5680d5665b3f1f720f50a2d3ea6fc0c3e39
2014-03-17sc: prefer passing OUString by referenceNoel Grandin
Change-Id: I85e8823e872bf53182ce90576225e462edb1930a
2014-03-12coverity#1158232 Fix ownership of NamedDBs::insert argumentStephan Bergmann
f70d03436b7b501e0ed1d745935a204b9b97b855 "coverity#1158232 have a stab at silencing warning with function markup" claimed that NamedDBs::insert always takes ownerhip of its argument, but boost::ptr_set::insert(std::auto_ptr<U> x) simply calls insert(x.release()), so only takes ownership when it returns true. ScDBDocFunc::AddDBRange (sc/source/ui/docshell/dbdocfun.cxx) relies on this behavior, deleting the argument when insert failed. ScDBDocFunc::RenameDBRange (sc/source/ui/docshell/dbdocfun.cxx) relied on this behavior, deleting the argument when insert failed, until f55cc330dec0dec60c755e2ce28a840c7fca1956 "Fixed the fallout of the changes in ScDBCollection" removed the delete (presumably in error?). I put it back in now. All other uses of NamedDBs::insert ignored the return value (witnessed with SAL_WARN_UNUSED_RESULT). Some are insert-if-not-found cases, where I added asserts now (Sc10Import::LoadDataBaseCollection, sc/source/filter/starcalc/scflt.cxx, is not entirely clear to me, so I added a TODO), while others would have potentially leaked the argument, in which cases I fixed the code. Change-Id: Iad40fbeb625c8ce6b0a61cbf16298d71cdc7de80
2014-03-11svx: sal_Bool->boolNoel Grandin
Change-Id: Ia7db5746fa5d8f60111d10d09865120981956947
2014-03-10convert pivot filter dialog to .uiCaolán McNamara
Change-Id: I795d296bae700d1e3a273fbe71fc842d145c5138
2014-03-10coverity#708086 Uninitialized scalar fieldCaolán McNamara
Change-Id: I7d8967f90da3ad19c82a313636910279d6ef0f73
2014-03-05more list type correctnessEike Rathke
Change-Id: I97cc37c05782b6ab2cd7b8b63a4315ba2386f1ef
2014-03-05WaE: sal_Bool vs. boolTor Lillqvist
Change-Id: I8d5a959fdca8f7deefffb0c3a0529d2e32595df4
2014-03-05Converted group by [number|date] pivot table dlg to .uiKatarina Behrens
Change-Id: I3c6256f1b2d176790a8eb7c094c1583ce053971b Reviewed-on: https://gerrit.libreoffice.org/8382 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit (git 2.34.1) at 2024-07-29 19:29:57 +0000