summaryrefslogtreecommitdiff
path: root/sc/source/ui/dbgui
AgeCommit message (Collapse)Author
2015-02-11tdf#79239: make the dialog closable with 'X' button againKatarina Behrens
that one of window manager, top-right corner mostly. We need to reimplement Close() method for this class - I don't quite get why this has to be the case, but all classes derived from ScAnyRefDlg do it as well. Change-Id: I3e94b7ee09f9b3581d054818d36ea4fb0fd55f78
2015-02-03Resolves: rhbz#1179642 crash in GetFocus with empty mpPreviouslyFocusedListBoxCaolán McNamara
Change-Id: I7559067c00617482d34e7cbdd177202868cbfc76 (cherry picked from commit dae7d2089516d9cf014b9fad0adb484f19282a29) Reviewed-on: https://gerrit.libreoffice.org/14161 Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2015-02-03Related: fdo#88455 crash using delete in available fieldsCaolán McNamara
Change-Id: I4ac5fe6f42b425ee96124b2dde39ff397a081638 (cherry picked from commit 1746c886362b8525b04365dd6b7203b8098b99ba) Reviewed-on: https://gerrit.libreoffice.org/14290 Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2015-01-23Resolves: fdo#88735 crash after calling sort after subtotal removalCaolán McNamara
Change-Id: Ia30271426ea47b7bf5af85d16591a02e6d52b3d9 (cherry picked from commit 0442cd217645aa4fdd924e4c2e4f90a77f1fbbad) Reviewed-on: https://gerrit.libreoffice.org/14139 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2015-01-22Resolves: fdo#88455 delete in empty data field crashesCaolán McNamara
Change-Id: I399bf576fe89283f839842959f06b8fe83f13b2b (cherry picked from commit 66df4d7d309ce237e4979d57b1069659ece1e3a5) Reviewed-on: https://gerrit.libreoffice.org/14107 Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2014-12-15no separator really means no separator, fdo#83027Markus Mohrhard
Change-Id: I612a46701e7447db63f38ed709e8693d0533710d Reviewed-on: https://gerrit.libreoffice.org/13474 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2014-12-01For external data sources this variable can be null, fdo#83534Markus Mohrhard
Change-Id: I8c47cf078b4772fcdba0993880740c22114f1b45
2014-11-14fdo#86023 - O[U]String needs a 'clear' methodBrij Mohan Lal Srivastava
Added clear() method to OString and OUString class, Updated appropriate call-sites. Change-Id: I0ba97fa6dc7af3e31b605953089a4e8e9c3e61ac Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-11-06Bin unused include files, thanks to Andrea GelminiTor Lillqvist
Change-Id: I848505b1d4ff03779b89a08d4aeefd6ea0ff205b
2014-10-31convert COMMAND_WHEEL constants to an enumNoel Grandin
Change-Id: I413d821a984ab556bd19c52704c04de6d828f699
2014-10-28loplugin: cstylecastNoel Grandin
Change-Id: I47adf8a3fc72b4a043724ac40f3637b8dc3878be
2014-10-15More -Werror,-Wunused-private-fieldStephan Bergmann
...detected with a modified trunk Clang with > Index: lib/Sema/SemaDeclCXX.cpp > =================================================================== > --- lib/Sema/SemaDeclCXX.cpp (revision 219190) > +++ lib/Sema/SemaDeclCXX.cpp (working copy) > @@ -1917,9 +1917,10 @@ > const Type *T = FD.getType()->getBaseElementTypeUnsafe(); > // FIXME: Destruction of ObjC lifetime types has side-effects. > if (const CXXRecordDecl *RD = T->getAsCXXRecordDecl()) > - return !RD->isCompleteDefinition() || > - !RD->hasTrivialDefaultConstructor() || > - !RD->hasTrivialDestructor(); > + return !RD->hasAttr<WarnUnusedAttr>() && > + (!RD->isCompleteDefinition() || > + !RD->hasTrivialDefaultConstructor() || > + !RD->hasTrivialDestructor()); > return false; > } > > @@ -3517,9 +3518,11 @@ > bool addFieldInitializer(CXXCtorInitializer *Init) { > AllToInit.push_back(Init); > > +#if 0 > // Check whether this initializer makes the field "used". > if (Init->getInit()->HasSideEffects(S.Context)) > S.UnusedPrivateFields.remove(Init->getAnyMember()); > +#endif > > return false; > } to warn about members of SAL_WARN_UNUSED-annotated class types, and warn about initializations with side effects (cf. <http://lists.cs.uiuc.edu/pipermail/cfe-dev/2014-October/039602.html> "-Wunused-private-field distracted by side effects"). Change-Id: I3f3181c4eb8180ca28e1fa3dffc9dbe1002c6628
2014-10-13create a macro library for implementing bit-flags typesNoel Grandin
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>, changed from a macro- to a template-based solution. (Unfortunately MSVC 2012 does not support explicit conversion operators. Worked around that with explicit #ifs rather than some HAVE_EXPLICIT_CONVERSION_OPERATORS and SAL_EXPLICIT_CONVERSION_OPERATOR ainticipating we hopefully soon move to a baseline that requires unconditional support for them.) Change-Id: I4a89643b218d247e8e4a861faba458ec6dfe1396
2014-10-11convert SFX_CALLMODE constants to SfxCallMode enum classNoel Grandin
and fix a couple of bugs in SC and SW where the call mode was being passed to the hints parameter by accident Change-Id: Ief805410b3f7035e012e229e77f92d5832430f58 Reviewed-on: https://gerrit.libreoffice.org/11916 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-02coverity#1242475 no point calling SetText with GetText resultsCaolán McNamara
Change-Id: I0ebd4a53a0d309b45f5af31adc6fa54a5f143a21
2014-10-01fdo#82577: Handle TimeNoel Grandin
Put the TOOLS Time class in the tools namespace. Avoids clash with the X11 Time typedef. Change-Id: Iac57d5aef35e81ace1ee0d5e6d76cb278f8ad866 Reviewed-on: https://gerrit.libreoffice.org/11684 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-09-30sc: std::auto_ptr -> std::unique_ptrStephan Bergmann
Change-Id: I25468d578de597ff9aeba3ffc850c630fa532767
2014-09-30fdo#53920 Switch back tab at RefButton closure timeLaurent Balland-Poirier
Bug occurs because visible tab is not the initial tab. So, instead of switching back to initial tab at dialog closure time (removed from cellsh2.cxx), this commit proposes that switching back to initial tab is operate when expanding the RefButton shrink dialog. Change-Id: I3cf7ed14054fa69881d4ecbc55c48dfbfc4356aa Reviewed-on: https://gerrit.libreoffice.org/11660 Reviewed-by: Kohei Yoshida <libreoffice@kohei.us> Tested-by: Kohei Yoshida <libreoffice@kohei.us>
2014-09-30fdo#82577: Handle PolyPolygonNoel Grandin
Put the TOOLS PolyPolygon class in the tools namespace. Avoids clash with the Windows PolyPolygon typedef. Change-Id: I811ecbb3d55ba4ce66e4555a8586f60fcd57fb66
2014-09-30fdo#82577: Handle RegionNoel Grandin
Put the VCL Region class in the vcl namespace. Avoids clash with the X11 Region typedef. Change-Id: I6e008111df7cf37121fbc3eaabd44a8306338291
2014-09-23fdo#83848 Add GetAddressConvention to RefButtonLaurent Balland-Poirier
Change-Id: I20d633909d3c13bf49998a6cca054ab125b6c991 Reviewed-on: https://gerrit.libreoffice.org/11578 Reviewed-by: Kohei Yoshida <libreoffice@kohei.us> Tested-by: Kohei Yoshida <libreoffice@kohei.us>
2014-09-23fdo#65281 Empty/Not empty doesn't work in columns with date formatDavid Ostrovsky
"Empty" and "Not empty" predicates were unconditionally overriden in filter dialog for date format columns. Rectify it by preventing the overriding for these functions. Test Plan: * open calc document * define column with date format * put some data and let some columns empty * apply standard filter on date column with "Not empty" function * verify that rows with non empty columns still visible Change-Id: I2111c5a6b6350cab63173d42419069813d1137b6 Reviewed-on: https://gerrit.libreoffice.org/11613 Reviewed-by: Kohei Yoshida <libreoffice@kohei.us> Tested-by: Kohei Yoshida <libreoffice@kohei.us>
2014-09-23fdo#82577: Handle WindowNoel Grandin
Put the VCL Window class in the vcl namespace. Avoids clash with the X11 Window typedef. Change-Id: Ib1beb7ab4ad75562a42aeb252732a073d25eff1a
2014-09-12Turn SfxItemState into a C++11 scoped enumerationStephan Bergmann
...to gain further confidence in the claim "that none of the existing code tries to uses combinations of these enum values" (d92602c5b13d0a60439d86c5a033d124178726ca "more fixes for SfxItemState") Change-Id: I987922d945e8738e38adfde83b869adf3ff35b13 Reviewed-on: https://gerrit.libreoffice.org/11384 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2014-09-08Related #82088: removed last css aliases in hxxStefan Weiberg
* Only unfixed header namespace alias in ConnectionLog.hxx: LogLevel = ::com::sun::star::logging::LogLevel Change-Id: I48c941a4762830f2265c8241f4c1695a43ec891a Reviewed-on: https://gerrit.libreoffice.org/11333 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2014-08-23fdo#82577: Handle KeyCodeTor Lillqvist
Put the VCL KeyCode class in the vcl namespace. Avoids clash with the X11 KeyCode typedef. Change-Id: I624c9d937f7c5f5986d313b6c5f060bd8bb7e028
2014-08-20Bad hack to enforce weakly emitted RTTI for ScValidationDlgStephan Bergmann
...(by inlining all its virtual functions), as otherwise -fsanitize=undefined makes sc require ScValidationDlg RTTI (to verify the cast to ScValidationDlg in the ScValidityRefChildWin ctor in sc/source/ui/view/reffact.cxx) but which would only be emitted in scui (against which sc cannot link). Change-Id: Id9e2bf0719ba3bba35e5ae1f0e58190d9fdb6dd4
2014-08-18ErrorBox->MessageDialogCaolán McNamara
Change-Id: I57d4e43460e40d3aff54873280eddbb18c12446b
2014-08-13RID_SCDLG_DAPISERVICE conversion to .uiSzymon Kłos
Change-Id: I4194af3033f6591c7a8ca219aebf2ef816edcd63 Reviewed-on: https://gerrit.libreoffice.org/10915 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2014-08-13fdo#82418 prefer UTF-8 over UTF-16David Tardon
Change-Id: Id2c990d24dc942a6d061146ea88cf53ee29a1c3d
2014-08-07coverity#735805 Explicit null dereferencedCaolán McNamara
Change-Id: I6641930b42f233096f4a0067ab320383ff07a72a
2014-08-04Convert RID_SCDLG_DPSHOWDETAIL to .uiPalenik Mihály
Change-Id: If515e8f554f36e4ba203474d08d5ebe9caa023fa Reviewed-on: https://gerrit.libreoffice.org/10739 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2014-07-28Move this fucntion to ScDBDocFunc.Kohei Yoshida
so that it could be usable from unit test. Change-Id: Iea10cb473bc17d7e030c018fd2c84fbeccce3e47
2014-07-04coverity#735805 dereference null valueNorbert Thiebaud
Change-Id: I3782cffb19e45635076f19eb568fc547b9680b0d
2014-06-27remove SFX_APP() macro that was a mer wrapper for SfxGetApp()Norbert Thiebaud
Change-Id: I480a789c767dd671775c9d70d96bf71908f21f5b
2014-06-25remove whitespaceMarkus Mohrhard
Change-Id: Ib15413e73409cc33de01fa92a47b9d1237cfc4b2
2014-06-24new compilerplugin returnbyrefNoel Grandin
Find places where we are returning a pointer to something, where we can be returning a reference. e.g. class A { struct X x; public X* getX() { return &x; } } which can be: public X& getX() { return x; } Change-Id: I796fd23fd36a18aedf6e36bc28f8fab4f518c6c7
2014-06-17improve the inlinesimplememberfunctions clang pluginNoel Grandin
Change-Id: I6d5a952901648e01904ef5c37f953c517304d31e
2014-06-13loplugin:staticcallStephan Bergmann
Change-Id: I670fbcd83e368f2821d37a392cbc007b1f4cd55e
2014-06-11Change SfxTabPage ctor SfxItemSet param from ref to pointerStephan Bergmann
...and also corresponding param of CreateTabPage function type and corresponding Craete functions. There were some call sites that passed undefined "null pointer references" and SfxTabPage internally uses a pointer member pSet that is checked for null anyway. Change-Id: I4eb3636155eac46c9c9d26e6e6e842e85d7e95af
2014-06-11Change SfxTabPage::Reset param from ref to pointerStephan Bergmann
...there was a call site that passed undefined "null pointer reference" (apparently in a case where the passed argument was actually unused) Change-Id: I663d4264b7a84f44ca69c732f3bc502f614b2b2a
2014-06-10Change SfxTabPage::FillItemSet param from ref to pointerStephan Bergmann
...there were a number of call sites that passed undefined "null pointer references" (apparently in cases where the passed argument was actually unused) Change-Id: I19799e90f0cd8e98367782441a5ea9df27b59830
2014-06-06Bin ugly (ab)use of preprocessor in headers (final part)Thomas Arnhold
Finish the work of ec8617568ff091026b2f17cce3b547b1633fa6c4 Only one is left: SC_PROGRESS_CXX Change-Id: Ifdc07ec377d7a84e92bc4b0a66ab82b1fc93f76a Reviewed-on: https://gerrit.libreoffice.org/9636 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-06-06coverity#735806 Dereference after null checkCaolán McNamara
Change-Id: Ie7a05e694585bcc624bd69b4400d84a05fbc48fb
2014-05-27Actually OK and Cancel is better here than Apply and Close.Kohei Yoshida
Because the same dialog is used when creating a new pivot table, where the Apply and Close semantic feels a bit weird. Also, some features of the dialog were designed with Ok / Cancel in mind (like the destination location). Change-Id: I9ac889bca9f967cb97b34ab45ea563547b58d422
2014-05-21Keep only "Apply" and "Close".Kohei Yoshida
Change-Id: I963419baec24d7599ddb3e481738cbe6ec4e0a69
2014-05-19hrc and src files: squeeze multiple newlinesThomas Arnhold
for i in `find . -name *.src -or -name *.hrc`; do FILE=$(cat -s "$i"); echo "$FILE" > "$i"; done Change-Id: I2bac5ad3e1eb3c566e5c867ccf45893a19e1561e
2014-05-15Avoid possible memory leaks in case of exceptionsTakeshi Abe
Change-Id: I7dc862794f7f0973bd4de7b54f7a1fb15235bc3e
2014-05-11fix-includes.pl: scThomas Arnhold
Change-Id: Iade3fedac5d2f8e978b7dd9c30f001d7d1564946
2014-05-05simplify ternary conditions "xxx ? yyy : false"Noel Grandin
Look for code like: xxx ? yyy : false; Which can be simplified to: xxx && yyy Change-Id: Ia33c0e452aa28af3f0658a5382895aaad0246b4d
generated by cgit (git 2.34.1) at 2024-08-05 01:21:29 +0000