summaryrefslogtreecommitdiff
path: root/sc/source/ui/uitest
AgeCommit message (Collapse)Author
2024-11-24Turn SC_MOD macro to a functionMike Kaganski
Change-Id: I5fc11037902bc6200fdaf4749260efe8e658bdce Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177070 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-06-03loplugin:ostr in scNoel Grandin
Change-Id: I72438d38c75a7facb9bd5f9cfb7be1213ac3d141 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168356 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-05-06WaE: C6011 Dereferencing NULL pointer warningsCaolán McNamara
Change-Id: I71d20c4d35b5123216da55a8b314400c93cae6fd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167173 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-06-02uitest: sc: check whether current row/column/table has dataXisco Fauli
Since 41b991ea0cf3f8ce36cbdbf16b9c2c6d2bb16b5d "tdf#153709 Adapt message for Delete Sheet" when a sheet with no data is deleted the confirmation dialog is not prompted anymore. Adding this so the code in dev-tools/uitest/mass-testing can make use of it Change-Id: I5b9846982cffeb11d6bcded691255b96a98f5a11 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152303 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-10-06use more string_view in scNoel Grandin
Change-Id: Ic7126ac57f8cc06b37f3098603f0710602f0ab28 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140998 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-02-14Recheck modules s[a-c]* with IWYUGabor Kelemen
See tdf#42949 for motivation Change-Id: I867e1f7a2c44210de3281b36e22708a5d32ddb7f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129476 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2022-01-07remove E3D_INVENTOR_FLAG and convert SdrObjKind to scoped enumNoel Grandin
We don't need E3D_INVENTOR_FLAG, we can just check if the SdrObjKind is in the right range. Which exposes some dodgy code in DrawViewShell::GetMenuStateSel SfxItemState::DEFAULT == rSet.GetItemState( OBJ_TITLETEXT ) || SfxItemState::DEFAULT == rSet.GetItemState( OBJ_OUTLINETEXT ) || which has been there ever since commit f47a9d9db3d06927380bb79b04bb6d4721a92d2b Date: Mon Sep 18 16:07:07 2000 +0000 initial import just remove that. In SwFEShell::ImpEndCreate() move some logic around to avoid using an out-of-range SdrObjKind value Change-Id: I4620bfe61aca8f7415503debe3c84bfe5f4368a0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127763 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-16uitest: sc: make sure the tab number existsXisco Fauli
Otherwise, something like gridwin.executeAction("SELECT", mkPropertyValues({"TABLE": "100"})) would create a new tab called Sheet101 Change-Id: I052c68a1881bfe0a32e35a62f5c4f557ef10db8d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126917 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-11-15uitest: sc: add support for pivot table popupXisco Fauli
Change-Id: Id990178051e81a81bf6f6a0fb920473d3ee21fff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125259 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-03-09decompose ScNavigatorDlgUIObject and use sub components directlyCaolán McNamara
Change-Id: I817d0e201804dce3e83d204702ff236f5689ebb8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112148 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-02use css::embed::EmbedVerbs::MS_OLEVERB_PRIMARY instead of bare 0Caolán McNamara
Change-Id: I3fb67bcdaa27159790d36100f897efa7d43856ca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110317 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-25change pointers to references where never possible to be nullptrsCaolán McNamara
and drop some null checks then shown not to be needed Change-Id: I2806eeb64f43072a34aecd46424dbd063a119b7c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103356 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-17GetAddressFromString never passed a null ScDocument*Caolán McNamara
for the xml case this isn't immediately obvious, but pDoc should only be null between Init and Destroy. Change-Id: I6f517be6c620a8a2e5eec0f5a2fabd176745bb8a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102957 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-17GetRangeFromString, etc. never passed a null ScDocument*Caolán McNamara
for the xml case this isn't immediately obvious, but pDoc should only be null between Init and Destroy. Change-Id: I7def8df4a4144964e3ec10964819451eb8316836 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102915 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-15establish that ScViewData::GetDocument can always return ScDocument&Caolán McNamara
we can only be ctored with a ScDocShell& or ScDocument&, and ScDocShell provides a ScDocument& from its GetDocument() so we can always have a ScDocument& when a public ctor has completed some null checks can then be seen to be redundant and are removed Change-Id: Ifaf39cb06e8dbce363999c05ee0aeb3ec4f00428 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102775 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-12cid#1465252 Dereference null return valueCaolán McNamara
Change-Id: I8884218bb93a5684fb8f0754013fa00215bbc002 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98578 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-11cid#1465255 Unchecked dynamic_castCaolán McNamara
Change-Id: I564bcde3ee6a96307ae133e550888f41b610e904 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98575 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-08uitest : Add support to Calc - commentsAhmed ElShreif
This patch has the implementation of the support for Calc comments . Now you can use these lines to use comments in calc: * Open Comment Window : >> gridwin.executeAction("COMMENT",mkPropertyValues({"OPEN":""})) * Then Type text as normal : >> gridwin.executeAction("TYPE",mkPropertyValues({"TEXT":"any"})) * Close Comment Window : >> gridwin.executeAction("COMMENT",mkPropertyValues({"CLOSE":""})) * Write Comment without opening comment window: >> gridwin.executeAction("COMMENT",mkPropertyValues({"SETTEXT":"any"})) You can also check the comment text by this line: >> get_state_as_dict(gridwind)["CurrentCellCommentText"] I will provide a test case in another patch. Change-Id: Ie3fc4efffb07827e742bdaa99dd5147c8b9711d3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96837 Tested-by: Jenkins Reviewed-by: Ahmed ElShreif <aelshreif7@gmail.com> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2020-06-21uitest : Add support for Dropdown items in grid windowAhmed ElShreif
This patch add support for test cases that test Dropdown list of cells in Calc that can be created using: Data -> Validity -> List. You can select items from the list by it's id or it's text . This may help in tdf#133855 . Change-Id: I830149fd5520df72f07540fd4eebd3f3bad48616 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96670 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2020-06-07uitest: Add support for Calc - Set ZoomShiko
Also add a test case for zoom in calc Change-Id: Ic59480a884ed61bfdecdc6b4d509706dde9a194c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95389 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2020-05-16uitest: sc: test navigatorXisco Fauli
Change-Id: I7ea7076df4e84726dadcdf9161914a28371f4563 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94325 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-10-29sc: rowcol: tdf#50916 convert core/toolNoel Grandin
Change-Id: I0fe5a7ef4a79d0832802945ce1b9da4752f1d5fc Reviewed-on: https://gerrit.libreoffice.org/81598 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-31Improved loplugin:stringconstant (now that GCC 7 supports it): scStephan Bergmann
Change-Id: I1bfd2bb623aac5ac457a0b719da64ab393ccd0ba Reviewed-on: https://gerrit.libreoffice.org/76654 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-03-21tdf#42949 Fix IWYU warnings in sc/source/ui/pagedlg...undoGabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Icb5f0235339364e6dc09936e26f256765a60830a Reviewed-on: https://gerrit.libreoffice.org/69378 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2018-08-01Add missing sal/log.hxx headersGabor Kelemen
rtl/string.hxx and rtl/ustring.hxx both unnecessarily #include <sal/log.hxx> (and don't make use of it themselves), but many other files happen to depend on it. This is a continuation of commit 6ff2d84ade299cb3d14d4110e4cf1a4b8070c030 to be able to remove those unneeded includes. This commit adds missing headers to every file found by: grep -FwL sal/log.hxx $(git grep -Elw 'SAL_INFO|SAL_INFO_IF|SAL_WARN|SAL_WARN_IF|SAL_DETAIL_LOG_STREAM|SAL_WHERE|SAL_STREAM|SAL_DEBUG') to directory sc Change-Id: I988d7d3abaedfb32516a9db88815663bf54da46e Reviewed-on: https://gerrit.libreoffice.org/58266 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-06-26tdf#42949 Fix more IWYU warnings in sc/inc/d*Gabor Kelemen
Found with bin/find-unneeded-includes These were quite a bit entangled with each other thus a lot of fallout management was necessary. Also try harder to use fw declarations in files already checked Change-Id: Ia69c3a0d66ec2763ac03094aaa1b646a290d3cfa Reviewed-on: https://gerrit.libreoffice.org/56361 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-05-25SOSAW080: Derive SdrObjGroup from SdrObjListArmin Le Grand
Also simplify parent/child relationships, get rid of double data (SdrPage/Parent infos in SdrObjects, also in SdrObjList). This is all not needed - when a SdrObject is inserted to a SdrPage, get SdrPage by traveling over parents (no double info, member as soon as inserted, ...). More cleanups/reworks included, will need some more cleanups, too. Stabilizing: SetRectsDirty/DefaultStyleSheet Had to correct the SetRectsDirty stuff for 3D due to going down the hierarchy while the 2D implementation goes the other direction -> endless loops. Added special handling for 3D stuff for now (will be chnaged again when SnapRect is no longer needed at SdrObject level). Also had to adapt how the DefaultStyleSheet is set at incarnated SdrObjects - better: their properties. Since we now always have a SdrModel, it is possible to correctly initialize with the correct default StyleSheet from that SdrModel. This needs to be done after ForceDefaultAttributes and in a way that again deletes Items that are set in the StyleSheet. This leads to an error in CppunitTest_sd_import_tests where I checked tdf100491 - it is okay and thus I change the control instance of the imported, XML-dumped file. The less hard attributes, the better for Styles in general. Cleanup of comments for last two commits Corrected SvxShape::getParent() Needed to get the direct parent, so test for SdrObject first (to get SdrObjGroup/E3DScene), for SdrPage second Fixed CppunitTest_sc_subsequent_export_test Several problems arose. The used SdrCaptionObj was Cloned, but the clone not inserted to a SdrPage. This leads to not being able to access a UNO API imlementation of the SdrPage (SvxPage) on lower levels. It worked before due to SdrObject having a SdrPage* additionally to being added to a SdrPage - this is exactly the main cleanup this change does. Looked for why it is cloned, could see no reasons. The SdrCaptionObj exists during all im/export, not difference to other SdrObjects (that do not get cloned). It is not changed in any way. It *might* be to suppress a crash that happened due to UNO API Service emfio/emfio not being available in the UnitTest scenario. Interestingly it did not crash with the cloned SdrCaptionObj, but the Graphic exported was probably wrong. Fixed by no longer Cloning the SdrCaptionObj and adding emfio/emfio UNO API Service. d139f821a5b39535a3e7b9c6261df7e18f8ae8ac 910e7f4bc628a715fda7545dffaf3369d5e76ea0 ca1de01b723051e09ac37d7ec7bba978beea41c5 3a76da1471dfe75e69847f64a6a3519ad21c8c9c Change-Id: I986586e326b563acebf00d931a7084c6eb09e5f8 Reviewed-on: https://gerrit.libreoffice.org/54689 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2018-03-07uitest: fix small bug when trying to select different sheet in calcMarkus Mohrhard
Change-Id: I83e2b8dc1b0da9f28475994493e3776c898a5729 Reviewed-on: https://gerrit.libreoffice.org/50853 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-10-23loplugin:includeform: scStephan Bergmann
Change-Id: I2ed763e0584a188032c80fde60890de3c6985cbd
2017-09-22Bin leftover SAL_DEBUGTor Lillqvist
Change-Id: I452909cc1f0529ecb24b1f705a86a0a8bc1a3c9f
2017-06-05clang-tidy performance-unnecessary-value-paramNoel Grandin
Change-Id: I6ed8c54c7c45931d91709cc818f2483c70197192 Reviewed-on: https://gerrit.libreoffice.org/38400 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-25tools: svstream.hxx needs only errcode.hxx & not errinf.hxxChris Sherlock
Change-Id: Ia28e35ae5af4f601e9a586a3deffbcd61702b0ca Reviewed-on: https://gerrit.libreoffice.org/36896 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-04-09uitest: add state about currently visible rangeMarkus Mohrhard
Change-Id: Ie07ef2379086f84f9596771bc91683fa3e9bcd32 Reviewed-on: https://gerrit.libreoffice.org/36304 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-03-26uitest: add ability to open autofilter dialogMarkus Mohrhard
Change-Id: If03b2699975756ab650488abe032aefa8880a6b4 Reviewed-on: https://gerrit.libreoffice.org/35692 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-12-21uitest: add selected area to gridwin stateMarkus Mohrhard
Change-Id: I27e17640cc426dc3a63c605e6a294c3f90f5350c Reviewed-on: https://gerrit.libreoffice.org/32279 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-08-23convert SdrIterMode to scoped enumNoel Grandin
Change-Id: Iaa4631039e6b96627d8e547f21136f107e157d8a
2016-07-19clang-tidy performance-unnecessary-value-param in scStephan Bergmann
Change-Id: I1941c050a385e3a1020c5d2495471f5805c4c180
2016-06-18uitest: loplugin:stringconstantMarkus Mohrhard
Change-Id: Ib63a978bd488f41602d982789699ba3f3ca2dcf0
2016-06-18uitest: add way to deselect OLE objectMarkus Mohrhard
Change-Id: I34515de0b149147e40c23df6fef1339d0b69d469
2016-06-18uitest: allow activating OLE objectsMarkus Mohrhard
Change-Id: I960f5d644afb9392f8b3fe1d2f393c499af57bdb
2016-06-18uitest: allow to select charts in calcMarkus Mohrhard
Change-Id: I7fd899d7abda968e9c849e46714208a650b3cfdb
2016-06-18uitest: provide charts as children of calc's grid windowMarkus Mohrhard
2016-06-18uitest: allow selecting different tabs in gridwinMarkus Mohrhard
Change-Id: Id8104eac183b4f7129d7f23092c52b58376ed492
2016-06-18uitest: warn when we can not handle the select typeMarkus Mohrhard
Change-Id: I7c3055f84edd2bbab0799cf2c61269355ba82055
2016-06-18uitest: provide some more state information about gridwinMarkus Mohrhard
Change-Id: Ic5c481c7d7f84b7e6a155d2b3b2c427349b1db9d
2016-06-18uitest: support extending the select cell rangeMarkus Mohrhard
Change-Id: Ia3093e06cc2168f415bd8477b57a57e0fe897e4d
2016-06-18uitest: add wrapper for calc's gridwindowMarkus Mohrhard
It already supports selecting cell ranges. Change-Id: I8c3e4a42dea8956e2429b82b50ff8506c1774bbb