summaryrefslogtreecommitdiff
path: root/sc/source/ui/unoobj/condformatuno.cxx
AgeCommit message (Collapse)Author
2019-05-04tdf#122590 Import and export xlsx x14:cfRule element for type = cellis.Gülşah Köse
Change-Id: I3d940269ec25657b64c714400a2828781dd9dd3e Reviewed-on: https://gerrit.libreoffice.org/69713 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2019-03-05re-land "new loplugin typedefparam""Noel Grandin
This reverts commit c9bb48386bad7d2a40e6958883328145ae439cad, and adds a bunch more fixes. Change-Id: Ib584d302a73125528eba85fa1e722cb6fc41538a Reviewed-on: https://gerrit.libreoffice.org/68680 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-29pass ScConditionalFormat around by unique_ptrNoel Grandin
Change-Id: If15ac08d8334a386312870d3ebebb385cf55e5f6 Reviewed-on: https://gerrit.libreoffice.org/67050 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-07Simplify containers iterations in sc/source/ui/{unoobj,vba}Arkadiy Illarionov
Use range-based loop or replace with STL functions Change-Id: Ia8a8cfb71047e5612aa62c817c76ae0dfb7b3fa2 Reviewed-on: https://gerrit.libreoffice.org/65903 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-18loplugin:staticvar in scNoel Grandin
Change-Id: I9f1d66e9af454a27a341e56bbe50a558898b65a1 Reviewed-on: https://gerrit.libreoffice.org/61900 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-15loplugin:constfields in scNoel Grandin
Change-Id: If326175d571d15752efd1b63df45b2bc785f7541 Reviewed-on: https://gerrit.libreoffice.org/61653 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-01Add missing sal/log.hxx headersGabor Kelemen
rtl/string.hxx and rtl/ustring.hxx both unnecessarily #include <sal/log.hxx> (and don't make use of it themselves), but many other files happen to depend on it. This is a continuation of commit 6ff2d84ade299cb3d14d4110e4cf1a4b8070c030 to be able to remove those unneeded includes. This commit adds missing headers to every file found by: grep -FwL sal/log.hxx $(git grep -Elw 'SAL_INFO|SAL_INFO_IF|SAL_WARN|SAL_WARN_IF|SAL_DETAIL_LOG_STREAM|SAL_WHERE|SAL_STREAM|SAL_DEBUG') to directory sc Change-Id: I988d7d3abaedfb32516a9db88815663bf54da46e Reviewed-on: https://gerrit.libreoffice.org/58266 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-03-10don't use heap for elements in ScRangeListNoel Grandin
no need to store small objects like this out of line. Also - add move constructor and move assignment operator - drop Assign method since it now has the same signature as push_back Change-Id: I9a8647d3a11f24166a83d399a358a2bce3b2cb79 Reviewed-on: https://gerrit.libreoffice.org/50899 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2018-03-07use more Color in scNoel Grandin
Change-Id: Ifdd53fa0eed8cec7878d0f5b9eea1e2c826e3ae5 Reviewed-on: https://gerrit.libreoffice.org/50819 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-28convert COL_ constants to be of type ColorNoel Grandin
Change-Id: I0e25c8950ac26b851ff42f71e1471fcbe4770d48 Reviewed-on: https://gerrit.libreoffice.org/50373 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-20drop Color::SetColor(ColorData) in favour of operator=Noel Grandin
first stage of getting rid of ColorData Change-Id: I5e4e95eb958722814c43c8d1ebfef17ad18c29ec Reviewed-on: https://gerrit.libreoffice.org/49997 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-26Convert ScFormatEntryType to scoped enumTor Lillqvist
Change-Id: I9a6b3fb05255630852a96ebf74d901b869a581f4 Reviewed-on: https://gerrit.libreoffice.org/45276 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2017-11-25Convert ScConditionMode to scoped enumTor Lillqvist
Change-Id: I9b6aaa64e7f649581b27f0238e2908026ab6e0bd Reviewed-on: https://gerrit.libreoffice.org/45157 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2017-10-23loplugin:includeform: scStephan Bergmann
Change-Id: I2ed763e0584a188032c80fde60890de3c6985cbd
2017-09-22loplugin:flatten in pyuno..scNoel Grandin
Change-Id: I7ddc0b76532d26910f78642200750459508c2861 Reviewed-on: https://gerrit.libreoffice.org/42617 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-25loplugin:constparam in sc part6Noel Grandin
Change-Id: Ifbb921b820b7210e7f9539e45d4852764a1e9cbd Reviewed-on: https://gerrit.libreoffice.org/41563 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-18tdf#107920: Crash when using ScCompiler in condformatJulien Nabet
Just call SetGrammar from ScCompiler object with grammar of document See bt in https://bugs.documentfoundation.org/attachment.cgi?id=133382 Change-Id: Iedf4b88f2821bbcf728e4b1c023041fd6f10e5f3 Reviewed-on: https://gerrit.libreoffice.org/37739 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-04-25tools: svstream.hxx needs only errcode.hxx & not errinf.hxxChris Sherlock
Change-Id: Ia28e35ae5af4f601e9a586a3deffbcd61702b0ca Reviewed-on: https://gerrit.libreoffice.org/36896 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-04-05tdf#39468 Translate German commentsJens Carl
Translate German comments and terms in sc/source/core and sc/source/ui Change-Id: I214565e73893688963d99c0f0ddfc356b5ad63be Reviewed-on: https://gerrit.libreoffice.org/36107 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2017-01-26Remove dynamic exception specificationsStephan Bergmann
...(for now, from LIBO_INTERNAL_CODE only). See the mail thread starting at <https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html> "Dynamic Exception Specifications" for details. Most changes have been done automatically by the rewriting loplugin:dynexcspec (after enabling the rewriting mode, to be committed shortly). The way it only removes exception specs from declarations if it also sees a definition, it identified some dead declarations-w/o-definitions (that have been removed manually) and some cases where a definition appeared in multiple include files (which have also been cleaned up manually). There's also been cases of macro paramters (that were used to abstract over exception specs) that have become unused now (and been removed). Furthermore, some code needed to be cleaned up manually (avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no configurations available that would actually build that code. Missing @throws documentation has not been applied in such manual clean-up. Change-Id: I3408691256c9b0c12bc5332de976743626e13960 Reviewed-on: https://gerrit.libreoffice.org/33574 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-12-08convert SFX_HINT to scoped enumNoel Grandin
Notes (*) In SC, BULK_DATACHANGED was or'ed into the hint id. Replaced with a dynamic_cast check. (*) In SC, removed the hint id field from ScIndexHint, no point in storing the hint id twice (*) Fold the SfxStyleSheetHintId enum into the new SfxHintId enum, no point in storing two different hint ids (*) In some cases, multiple #define's used to map to the same SFX_HINT value (notably the SFX_HINT_USER* values). I made all of those separate values. Change-Id: I990e2fb587335ebc51c9005588c6a44f768d9de5 Reviewed-on: https://gerrit.libreoffice.org/31751 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-23perf: eliminate SfxSimpleHint and move to SfxHint, tdf#87101 relatedEike Rathke
There were over 150 places in *::Notify() functions that did some dynamic_cast<SfxSimpleHint*> of which ~98% were unnecessary because the base class SfxHint passed was an SfxSimpleHint anyway. dynamic_cast operations come with quite some cost, so avoid if possible. Specifically for ScFormulaCell::Notify() that created a bottleneck in scenarios where cells were notified that already handled a previous notification. In mass operations doing the dynamic_cast before it could be decided whether having to act on it or not this made 2/3 of all time spent in the Notify() call. To get rid of that rename/move SfxSimpleHint to SfxHint and let classes derive from SfxHint instead of SfxSimpleHint. This comes only with a slight cost that an additional sal_uInt32 is transported in such hints, initialized to 0, but this is neglectable compared to the huge gain. For the rare cases where a Notify() actually expects both, an SfxHint (formerly SfxSimpleHint) and a derived hint, this changed order of the dynamic_cast involved so the simple SfxHint::GetId() is handled last. Modules using such combinations can further optimize by treating the simple SfxHint::GetId() first once verified that none of the other derived hints use an ID not equal to zero respectively none of the ID values the simple hint uses. Change-Id: I9fcf723e3a4487ceb92336189d23a62c344cf0ce Reviewed-on: https://gerrit.libreoffice.org/29205 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-07-07loplugin:passstuffbyref also for {css::uno,rtl}::ReferenceStephan Bergmann
Change-Id: I2707d16e6dd7bc5617094963933fced147a496e8
2016-05-07clang-tidy modernize-loop-convert in scNoel Grandin
Change-Id: I620028d69b11ea0469efd7b02ac7bbc7edab1066 Reviewed-on: https://gerrit.libreoffice.org/24690 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2016-05-04use Any constructor instead of temporariesNoel Grandin
Change-Id: Iffb82a2cee1a28d89eeea2b905aaa14086ee475a
2016-01-10Fix typosAndrea Gelmini
Change-Id: I9a5940027423ff0791fa7da0b79b617412ce6b86 Reviewed-on: https://gerrit.libreoffice.org/21209 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2015-11-10loplugin:nullptr (automatic rewrite)Stephan Bergmann
Change-Id: I765d2a600f9c57da50c85354688e3ae796750d94
2015-11-09sc: replace boost::ptr_vector with std::vector<std::unique_ptr>Michael Stahl
Change-Id: Id80f6d6be9f5cb15448ea00299b8e371ccd812ee
2015-09-18boost->stdCaolán McNamara
Change-Id: I7f3bb094f116103c1146a7d60e3af94c0b37d9ea Reviewed-on: https://gerrit.libreoffice.org/18677 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-09-17revert for mac and win unit case crashes after boost->stdCaolán McNamara
Change-Id: I82c7084f203a834c2d42f9527705288e6036019b
2015-09-17boost->stdCaolán McNamara
Change-Id: I1e6a7fd66f90e6acd803c6cd464f1d73252f7bcb
2015-08-19sc: replace boost::ptr_set with std::set<std::unique_ptr>Michael Stahl
Change-Id: I966069726fd7dbc57e03e93514bec62d8bbb2ba0 Reviewed-on: https://gerrit.libreoffice.org/17862 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2015-07-24-Werror,-Wunused-private-fieldStephan Bergmann
Change-Id: I3104a661b7c00851f6e444eb6899483bfc9c7417
2015-06-23Drop duplicate #includesTakeshi Abe
Change-Id: I4db77ea1de42676d9d2df70db3f2e1665a3fd983 Reviewed-on: https://gerrit.libreoffice.org/16419 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2015-04-03document a few missing piecesMarkus Mohrhard
Change-Id: I88a48ada4f9e261e425127bc1b0d3db83f1fabba
2015-04-03first part for correct handling of new cond format entriesMarkus Mohrhard
Change-Id: I82f66218bf02898e523e4f69fec9166aa00d0b83
2015-04-03correct implementationMarkus Mohrhard
Change-Id: Ie195e46e1cb14b39875efd1c9689db0f13968e87
2015-04-03rename UNO API method for cond formatMarkus Mohrhard
My first idea does not work that well as it introduces some nasty problems with the lifecycle. THe new approach will only allow to use cond format objects of the same document. Change-Id: I276c3750ef24cdee6d63162c678ec839d4845b08
2015-04-02-Werror,-Wdeprecated-declarationsStephan Bergmann
Change-Id: Ia2c37fd20cec9e5b11f4518da33f18065d592783
2015-04-02fix error in databar entry type api mapMarkus Mohrhard
Change-Id: Ibf81edf40f1b8a591b48aa77314104e511f0ff49
2015-04-02add properties for new databar propertiesMarkus Mohrhard
Change-Id: Icc65283a1e60ea61af917432e3fb577e7b0370a7
2015-04-02forgot the property definitionMarkus Mohrhard
Change-Id: I60b28152068fa9d5fee9dff0509eb4a3721ce0ca
2015-04-01Replace remaining getCppuType et al with cppu::UnoTypeStephan Bergmann
Change-Id: Iddde148aa783c252d0c864e30855383e996dbf69
2015-03-30-Werror,-Wunused-private-fieldStephan Bergmann
Change-Id: I91968ea95b59eca3d9435fac0c48e03c039bbebb
2015-03-30finally implement and define also date formattingMarkus Mohrhard
Change-Id: I261e6d3199573fc2e37d940e4249a1fce105e6eb
2015-03-30warning C4701: potentially uninitialized local variable 'eType' usedStephan Bergmann
Change-Id: I5c7f81a30d06b4dbaddb3b64ea5467ed4faeac38
2015-03-30let all cond format objects inherit from XConditionEntryMarkus Mohrhard
Change-Id: I60f156b4a64cc70bd1d19f4bb29c79cc8cff3e94
2015-03-30implement last part for color scalesMarkus Mohrhard
Change-Id: Ieaca45d01b5e631e624016b58ab7964dc880725a
2015-03-30add color scale entriesMarkus Mohrhard
Change-Id: If88822765b5ec738f3204a4ef7c76c3d529e6be2
2015-03-30add last databar partMarkus Mohrhard
Change-Id: Id86dfa4e6795d0ec6a66850747f95de6b0bd8b98
generated by cgit (git 2.34.1) at 2024-07-31 16:24:42 +0000