summaryrefslogtreecommitdiff
path: root/sc/source/ui/view/prevloc.cxx
AgeCommit message (Collapse)Author
2022-03-28-Werror,-Wunused-but-set-variableStephan Bergmann
...ever since 24da580f8bd0a348fee64c07f9015b09918f8388 "95584#; add RangeId to have the draw ranges unique" Change-Id: I60e98b9645eb4acb2d3d4e47ada81c976e43a424 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132235 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-12-06rename In() to Contains()Luboš Luňák
Similarly to b22d4785310eac35696d, 'A.In(B)' makes it unclear whether the check is for A in B or B in A, as it's actually the latter. Change-Id: Iaccc41d40f4bb105a44c1bb8d9211c06d1a3c127 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126392 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-09-20clean up ambiguous confusing rectangle APIs like IsInside()Luboš Luňák
Reading 'rectA.IsInside( rectB )' kind of suggests that the code checks whether 'rectA is inside rectB', but it's actually the other way around. Rename IsInside() -> Contains(), IsOver() -> Overlaps(), which should make it clear which way the logic goes. Change-Id: I9347450fe7dc34c96df6d636a4e3e660de1801ac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122271 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Luboš Luňák <l.lunak@collabora.com> Tested-by: Jenkins
2021-09-12clang:optin.performance.Padding in scNoel Grandin
Excessive padding in 'struct ScPreviewLocationEntry' (10 padding bytes, where 2 is optimal). Excessive padding in 'struct oox::xls::FormulaBuffer::SharedFormulaDesc' (8 padding bytes, where 0 is optimal). Excessive padding in 'struct ScOrcusStyles::font' (11 padding bytes, where 3 is optimal). Excessive padding in 'struct ScOrcusFactory::CellStoreToken' (8 padding bytes, where 0 is optimal). Excessive padding in 'struct TokenPool::ExtCellRef' (10 padding bytes, where 2 is optimal). Excessive padding in 'struct TokenPool::ExtAreaRef' (10 padding bytes, where 2 is optimal). Change-Id: Ifce31c799b0f64d3c6971279345391bb74f210c0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121994 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-02-22Some more unit conversion unificationMike Kaganski
Change-Id: I0410a73e4376ea0e4698f311cb3deb02c37fb931 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111341 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-10-20use tools::Long in scNoel
Change-Id: I8f37a8d1174ed816df971b8cee036d4e88d4a7fc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104526 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-12loplugin:flatten in sc/ui/viewNoel Grandin
Change-Id: I0ea33fc076a280e5f4559eea8420b1b7fa442361 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100400 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-12Revert "loplugin:constfields in sc"Noel Grandin
This reverts commit fb1d3b580763a333bbbfe115d09e1b5cd8849675. Now that we know that making fields has negative side effects like disabling assignment operator generation. Change-Id: Ib48334ffbeb2c768896dd8ced6818aa0b9910b0b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90333 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-17Extend loplugin:external to warn about enumsStephan Bergmann
To mitigate the dangers of silently breaking ADL when moving enums into unnamed namespaces (see the commit message of 206b5b2661be37efdff3c6aedb6f248c4636be79 "New loplugin:external"), note all functions that are affected. (The plan is to extend loplugin:external further to also warn about classes and class templates, and the code to identify affected functions already takes that into account, so some parts of that code are not actually relevant for enums.) But it appears that none of the functions that are actually affected by the changes in this commit relied on being found through ADL, so no adaptions were necessary for them. (clang::DeclContext::collectAllContexts is non-const, which recursively means that External's Visit... functions must take non-const Decl*. Which required compilerplugins/clang/sharedvisitor/analyzer.cxx to be generalized to support such Visit... functions with non-const Decl* parameters.) Change-Id: Ia215291402bf850d43defdab3cff4db5b270d1bd Reviewed-on: https://gerrit.libreoffice.org/83001 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-01-29o3tl::make_unique -> std::make_unique in scGabor Kelemen
Since it is now possible to use C++14, it's time to replace the temporary solution with the standard one Change-Id: Ib69a4a2a08b1edbc0f40beac00f7f68075b479a1 Reviewed-on: https://gerrit.libreoffice.org/66967 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-15loplugin:constfields in scNoel Grandin
Change-Id: If326175d571d15752efd1b63df45b2bc785f7541 Reviewed-on: https://gerrit.libreoffice.org/61653 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-10loplugin:simplifyconstruct in scNoel Grandin
Change-Id: I1f67cef740eb946fea9097e6f62085d25b1e891b Reviewed-on: https://gerrit.libreoffice.org/60225 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-14loplugin:changetoolsgen in scNoel Grandin
Change-Id: Ic24332cac65e665b55b9e1bbaf09ee56066875fd Reviewed-on: https://gerrit.libreoffice.org/49703 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-12More loplugin:cstylecast: scStephan Bergmann
auto-rewrite with <https://gerrit.libreoffice.org/#/c/47798/> "Enable loplugin:cstylecast for some more cases" plus solenv/clang-format/reformat-formatted-files Change-Id: I987ac3a6d062600a5e21c3462c70595dfaa51796
2017-12-06Remove unused #include <vcl/metaact.hxx> from vcl/outdev.hxxStephan Bergmann
...and fix the fallout Change-Id: Ie514bd95d5a9f990a887566619031e9844c40b92 Reviewed-on: https://gerrit.libreoffice.org/45195 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-10-23loplugin:includeform: scStephan Bergmann
Change-Id: I2ed763e0584a188032c80fde60890de3c6985cbd
2017-07-13loplugin:useuniqueptr in scNoel Grandin
Change-Id: I004e1f0292c8a40515880546574255ab835dbdbe Reviewed-on: https://gerrit.libreoffice.org/39875 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-31tdf#82580 tools: rename Rectangle to tools::RectangleMiklos Vajna
Mostly generated using make check COMPILER_EXTERNAL_TOOL=1 CCACHE_PREFIX=clang-rename-wrapper RENAME_ARGS="-qualified-name=Rectangle -new-name=tools::Rectangle" Except some modules have their own foo::tools namespace, so there have to use ::tools::Rectangle. This commit just moves the class from the global namespace, it does not update pre/postwin.h yet. Change-Id: I42b2de3c6f769fcf28cfe086f98eb31e42a305f2 Reviewed-on: https://gerrit.libreoffice.org/35923 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-01-15loplugin:unusedmethods unused return value in scNoel Grandin
Change-Id: Ic0b4d7efb2679f735892806d66258af231cda3fe
2015-11-10loplugin:nullptr (automatic rewrite)Stephan Bergmann
Change-Id: I765d2a600f9c57da50c85354688e3ae796750d94
2015-11-09loplugin:redundantcastStephan Bergmann
Change-Id: I8bfdb2c88b82dc9f1335d92589838cda4b1e7cf7
2015-11-09sc: add missing includes to prevloc.hxxMichael Stahl
Change-Id: I7ee876d52a0a04a162ee7acd0ec03e73557abe89
2015-11-09sc: replace boost::ptr_list with std::list<std::unique_ptr>Michael Stahl
Change-Id: Ic1202dc49789d7f392fc7c0065e071e114687717
2014-06-25remove whitespaceMarkus Mohrhard
Change-Id: Ib15413e73409cc33de01fa92a47b9d1237cfc4b2
2014-03-03Remove visual noise from scAlexander Wilms
Conflicts: sc/source/ui/inc/docfunc.hxx Change-Id: I9314437ed3dd60e84d28c08ac0a2d1ed7bd1daf8 Reviewed-on: https://gerrit.libreoffice.org/8301 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-19sal_Bool->boolNoel Grandin
Change-Id: Ic12f038f84f5150600206051173d88dfe8dcbad8
2012-12-04re-base on ALv2 code. Includes:Michael Meeks
Patches contributed by Herbert Duerr i#118735 prevent endless loop if vlookup/hlookup doesn't find anything http://svn.apache.org/viewvc?view=revision&revision=1239673 Patches contributed by Andre Fischer remove lp_solver http://svn.apache.org/viewvc?view=revision&revision=1199180 i#118160: Added external CoinMP library. http://svn.apache.org/viewvc?view=revision&revision=1233909 Patches contributed by Armin Le-Grand i#118485 - Styles for OLEs are not saved. http://svn.apache.org/viewvc?view=revision&revision=1182166 i#118524: apply patch, followup fixes to 118485 http://svn.apache.org/viewvc?view=revision&revision=1186077 Patches contributed by lihuiibm i#108860 - Fix range validation. http://svn.apache.org/viewvc?view=revision&revision=1242846 i#118954 Chart data will lost after copy to different file http://svn.apache.org/viewvc?view=revision&revision=1301345 Patches contributed by Ariel Constenla-Haile Fix Linux build breaker: extra qualification on member http://svn.apache.org/viewvc?view=revision&revision=1301591 i#118696 - i#118697 - Fix some Sheet Tab Color API issues http://svn.apache.org/viewvc?view=revision&revision=1225428 i#118697 - Fix uninitialized variable http://svn.apache.org/viewvc?view=revision&revision=1225859 i#118771 - ScUndoImportTab should preserve tab background color http://svn.apache.org/viewvc?view=revision&revision=1230356 i#118921 - Repaint linked sheet tab background color after updating link http://svn.apache.org/viewvc?view=revision&revision=1245177 i#118927 - Undo/Redo "Update Link" does not reset sheet tab color http://svn.apache.org/viewvc?view=revision&revision=1245241 i#118747 - Copy tab color when transferring sheets across documents http://svn.apache.org/viewvc?view=revision&revision=1230355 Patch contributed by Oliver Rainer-Wittman i#118012 - methods <ScBroadcastAreaSlot::AreaBroadcast(..)> and <ScBroadcastAreaSlot::AreaBroadcastInRange(..)> adapt stl-container iteration in order to avoid destroyed iterators during iteration. http://svn.apache.org/viewvc?view=revision&revision=1297916 Patches contributed by Mathias Bauer gnumake4 work variously http://svn.apache.org/viewvc?view=revision&revision=1394707 http://svn.apache.org/viewvc?view=revision&revision=1394326 http://svn.apache.org/viewvc?view=revision&revision=1396797 http://svn.apache.org/viewvc?view=revision&revision=1397315 Patch contributed by Daniel Rentz calc69: #i116936# fix VBA symbol Cells http://svn.apache.org/viewvc?view=revision&revision=1172135 Patches contributed by leiw: i#118546 CPU 100% on switched off AutoCalculate with Conditional Formatting on date values http://svn.apache.org/viewvc?view=revision&revision=1301380 Re-add new function documentation. Many various cleanups. Add missing calc66: #o11817313# also look at formula result number format, remove redundant binaries.
2012-10-12mark lcl_ functions static or rename them if they are not local at allLuboš Luňák
http://lists.freedesktop.org/archives/libreoffice/2012-October/039639.html Change-Id: I231f0b367bf0b513c6c1ce4c4cfdb7c3dc8660d5
2011-11-27remove include of pch header from scNorbert Thiebaud
2011-05-27Replace DBG_* with OSL_* in sc/source/uiJacek Wolszczak
2011-03-10Merge commit 'ooo/DEV300_m101' into integration/dev300_m101Kohei Yoshida
2011-02-21[PATCH 04/10] Removed deprecated List container.npcdoom
2011-01-17removetooltypes01: #i112600# remove tooltypes from scMikhail Voytenko
2010-10-13Add vim/emacs modelines to all source filesSebastian Spaeth
Fixes #fdo30794 Based on bin/add-modelines script (originally posted in mail 1286706307.1871.1399280959@webmail.messagingengine.com) Signed-off-by: Sebastian Spaeth <Sebastian@SSpaeth.de>
2010-09-28This gets rid of a great number of the commentsJustin Malcolm
There are a great number of places in calc where code is commented out with lines staring in "//UNUSED". Since 'git' is being used, there is no reason to keep old code like this in comments.
2010-06-23koheirowlimitperf: #i109369# #i109373# #i109384# #i109385# #i109386# ↵obo
#i109387# #i109388# #i109389# #i109391# #i109934# #i109935# #i110116# #i111531# #i111887# #i112190# #i30215# increased the row limit to 1 million, and integrated lots of speed optimization and bug fixes to ensure Calc remains usable after the row limit increase.
2010-02-12changefileheader2: #i109125#: change source file copyright notice from Sun ↵Jens-Heiner Rechtien
Microsystems to Oracle; remove CVS style keywords (RCSfile, Revision)
2008-09-30CWS-TOOLING: integrate CWS koheicoderemovalVladimir Glazounov
2008-04-11INTEGRATION: CWS changefileheader (1.15.330); FILE MERGEDRüdiger Timm
2008/03/31 17:20:00 rt 1.15.330.1: #i87441# Change license header to LPGL v3.
2007-02-27INTEGRATION: CWS calcwarnings (1.14.110); FILE MERGEDVladimir Glazounov
2006/12/12 17:03:32 nn 1.14.110.2: #i69284# warning-free: ui, unxlngi6 2006/12/01 08:53:49 nn 1.14.110.1: #i69284# warning-free: ui, wntmsci10
2006-07-21INTEGRATION: CWS pchfix01 (1.13.216); FILE MERGEDKurt Zenker
2006/07/12 10:03:07 kaib 1.13.216.1: #i67080# Converted cxx files in sc, added initial project level pch and stripped old PCH definitions.
2005-09-08INTEGRATION: CWS ooo19126 (1.12.274); FILE MERGEDRüdiger Timm
2005/09/05 15:09:37 rt 1.12.274.1: #i54170# Change license header: remove SISSL
2004-10-28INTEGRATION: CWS pdf02 (1.11.46); FILE MERGEDPascal Junck
2004/10/01 11:57:17 nn 1.11.46.1: #i34865# handle internal links in PDF export
2004-08-20INTEGRATION: CWS rowlimit2 (1.10.4); FILE MERGEDRüdiger Timm
2004/07/30 16:59:46 er 1.10.4.1: #i28834# reduce memory consumption of increased row limit; compressed arrays for flags and heights
2004-06-04INTEGRATION: CWS rowlimit (1.9.202); FILE MERGEDOliver Bolte
2004/03/03 21:36:25 er 1.9.202.3: #i1967# type correctness 2004/02/26 18:15:43 jmarmion 1.9.202.2: #i1967# step 5 changes. 2004/01/16 17:43:03 er 1.9.202.1: #i1967# SCCOL,SCROW,SCTAB replace USHORT; SCsCOL,SCsROW,SCsTAB replace short
2003-03-26MWS_SRX644: migrate branch mws_srx644 -> HEADJens-Heiner Rechtien
2002-05-24#95584#; add RangeId to have the draw ranges uniqueSascha Ballach
2002-05-06#95584# added draw ranges to location dataNiklas Nebel
2002-04-24#95584# make table that is shown availableNiklas Nebel
2002-04-23#95584# make missing information about headers and notes availableNiklas Nebel
generated by cgit (git 2.34.1) at 2024-07-03 17:24:38 +0000