summaryrefslogtreecommitdiff
path: root/sc/source/ui
AgeCommit message (Collapse)Author
2022-02-04lokCalcRTL: negate mouse event X for chart and controlsDennis Francis
Conflicts: sc/source/ui/unoobj/docuno.cxx Change-Id: I389047140d1a3d2c67a861a3e20f799206d937b6 (cherry picked from commit 0f2208a43861ebe94c4a2482a0cf7e5c63bb186e) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129361 Tested-by: Jenkins Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
2022-02-04lokCalcRTL: fix editing of shape textDennis Francis
Inform editeng that negated document x coordinates are used in this case and ensure that editeng generated invalidation rectangles always have positive X coordinates. Conflicts: sc/source/ui/view/gridwin4.cxx Change-Id: I2e450707ce02f7bcd8e4d299f857c37ebbd5e2c6 (cherry picked from commit 0fe02bb99e5dfa8379a49de75683fc350e4c4dbd) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129360 Tested-by: Jenkins Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
2022-02-04add toId/fromId to tidy up some ugly castingCaolán McNamara
Change-Id: I70f34ac5e9b5d2f2d6c0375e823908eaa2e540b2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129487 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-02-04Resolves: tdf#146997 use sal_Int64 instead of sal_Int32 for spinbutton valuesCaolán McNamara
for these cases where draw wants to massively scale the units the underlying "metric conversion" are already using sal_Int64 anyway Change-Id: I94e120d72644319548f75b2f68cfe60d4829a2e8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129356 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-02-03no point in mapping SID to itselfNoel Grandin
and once we remove that self mapping, no need to call GetWhich for those IDs either Change-Id: Ia881328a29bb022dace8d5f25c57279a381e0377 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129321 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-02-03sal_uLong->sal_Int32 for refresh delayNoel Grandin
and improve the naming of the related methods and variables Change-Id: I1dc522090b0353fd4c63e74864a0deeb8d70fd28 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129404 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-02-02lokCalcRTL: negate the +ve shape handle X coordinate...Dennis Francis
...from lok client as all shape X coordinates are negative in lok-RTL mode. Conflicts: sc/source/ui/drawfunc/drawsh.cxx Change-Id: Ic4ba064888901109c85760bb0afda609b5d5942c (cherry picked from commit 3df583520ee03bad42df09db7dde4c0c683a228b) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129193 Tested-by: Jenkins Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
2022-02-02disable ScPosWnd completely in LOK modeLuboš Luňák
366e328dc7f36061971c549c2d33d365026b65ca already mostly disabled it, but the instance was still created, and it sets up listening that results in ScPosWnd::FillRangeNames() getting called on every SfxLokHelper::setView(), which forms the major cost of the view switching. Change-Id: Ic16da4bdfb678d53a79da57e9bbdcb7fc59c576d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126481 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-02-02lokCalcRTL: RTL negation for shape insertionDennis Francis
Conflicts: sc/source/ui/view/tabvwsh2.cxx Change-Id: I8e3bb21fadd05a7b67acce34bfdc354fefba076b (cherry picked from commit 18038bd35c01abf1aad69932c4a7e75988921289) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129192 Tested-by: Jenkins Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
2022-02-02lokCalcRTL: shape selection: negate mouse X...Dennis Francis
as in LOK RTL mode draw objects have negated document X coordinate. Change-Id: Ie4c00fc0d1aa458a0aa6dd502be227cd6f82be3e (cherry picked from commit d423a86b3e063da02cfdb302eaa996ca54eed9d0) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129191 Tested-by: Jenkins Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
2022-02-02lokCalcRTL: shapes: do not send negative(X) invalidationsDennis Francis
LOK client expects tile invalidations in positive document coordinates irrespective of RTL flags. For this introduce a flag mbNegativeX in svx class SdrMarkView to indicate the case when all x coordinates are negated (this happens only for the LOK + Calc + RTL mode). Use this flag to counter negate the x coordinates before sending invalidation rectangles. Conflicts: sc/source/ui/view/drawvie3.cxx Change-Id: I35d8142718b538e55b668a8ee18f3dd1fe433951 (cherry picked from commit 5e37acbaaa0b0891829907331ecacd2d3b67526d) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129195 Tested-by: Jenkins Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
2022-02-02Fix variable nameAndrea Gelmini
It passed "make check" Change-Id: I3536d5ff0100cfa6b840aeded822e6e310c081dd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129315 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-02-02convert OfaRefItem to a normal classNoel Grandin
only instantiated with one type, so just turn it into a normal class Change-Id: If3ae908f3e226ae9f4d3b81a7a7d9ba492ccda4f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129283 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-02-01fix buildLuboš Luňák
cdd0a141094c9ceb690a702bb0 got pushed now after it got a Jenkins verification in September, and now fails because of my change from November. Change-Id: I6472444a05c8ff8f2e844dfff29c14a75a40ada1
2022-02-01Fix issues of Data Transformations.tushar
* Corrected Delete column Transformation considering the case when multiple columns are provided as input. * Corrected implementation of Split Column Transformation. * Provided valid ranges for Sort Transformation and corrected implementation . Change-Id: I4558602f69bf4aa7836e1e84931fabd346f83465 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118368 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2022-02-01tdf#64345: EDITING: Selected area looses selection when switching sheetAhmet Hakan Çelik
Change-Id: Idf59c3968319053431741394e2ad218d7be6463d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119478 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2022-02-01lokCalcRTL: adjustments for shapes renderingDennis Francis
In LOK-RTL mode GetScrPos() always returns document pixel coordinates and not something mirrored w.r.t gridwindow width. * Grid offset must have the opposite sign since the SdrObjects/ranges have negative coordinates with no offset. * Drawing area rectangle and the pixel-offset for tile rendering device also needs adjustments when painting the drawing layers. Conflicts: sc/source/ui/view/gridwin4.cxx Change-Id: I987a6876983aee129c06b3577918dbc62d6e7c4c (cherry picked from commit 2e7d02ab55754ffbc9e799c98cb7c8e37394a420) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129189 Tested-by: Jenkins Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
2022-02-01tdf#120896 sc: commit change after PopupSpellingJustin Luth
Although PopupSpelling visually has changed the screen, the underlying document still contained the old cached string or spelling status. Thus spell-check still thought it was spelled wrong, and right-clicking got very confused. Steps to reproduce: 1.) type aaa and hit enter. (spelling error noted) 2.) right-click on "aaa" and chose various options. 2a.) --- replace with a suggestion 2b.) --- ignore word 2c.) --- add to dictionary 2d.) --- change language 2d.) --- autocorrect (note we are still in editing mode) 3.) right-click again on the new or approved word (no pop-up at all.) The fix is to stop editing, so the changes are applied to the various caches. Steps that should NOT stop editing the cell 2e.) --- press ESC (or anything that cancels the pop-up) 2f.) --- choose Autocorrect Options Change-Id: I9965ede6f6a5c31a811ff89abb687497306d6d1e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126802 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2022-01-31lokCalcRTL: fix autofilter popup positionDennis Francis
Change-Id: Iecf41c286e28f849f77da47a0c5f73cbbc02986a (cherry picked from commit be329f241ee4953a039ab4bb22f46a5ac0ad5859) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128904 Tested-by: Jenkins Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
2022-01-31lokCalcRTL: fix autofilter button hit detectionDennis Francis
No mirroring needed when not in tile painting mode. All positions are in document coordinates. Conflicts: sc/source/ui/view/gridwin2.cxx Change-Id: I45425e2ddce7f5ddc5086dcdce31bb6d081edc41 (cherry picked from commit 2eb5f597c3b1c5a680d6e0f9d0719f9f6977e1a3) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128903 Tested-by: Jenkins Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
2022-01-31lokCalcRTL: Workaround to avoid DrawPoly ghost drawingsDennis Francis
Conflicts: sc/source/ui/cctrl/dpcontrol.cxx Change-Id: Ib6c794766fe68305566a293892c9123d64a2fc47 (cherry picked from commit 85a986f25956518978381df097b1f7d88477fd3d) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128902 Tested-by: Jenkins Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
2022-01-31lokCalcRTL: draw autofilter buttons at correct coordinatesDennis Francis
Factor out the transformation from document coordinates to tile device coordinates in ScLokRTLContext. Conflicts: sc/source/ui/view/gridwin4.cxx Change-Id: I426a179bff253233f6d45b67ddfde8b3bb1344a1 (cherry picked from commit 0145c2c0e4c69d486693488fa24490ee4458349a) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128901 Tested-by: Jenkins Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
2022-01-30cid#1497923 Logically dead codeCaolán McNamara
and cid#1497924 Logically dead code Change-Id: I548c09b2394e263d88a48fe97490f5b63d7d693a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129171 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-30Resolves: tdf#146994 InitOwnBlockMode() with current mark range or cursor posEike Rathke
This sets specifically the end position to the correct value. The start position and dependent logic if meBlockMode==Own is re-initialized in MarkCursor() via InitBlockMode(). Unfortunately that (calling MarkCursor()) happens after the end position was incremented in ExpandBlock(), previous with the wrong values. This new own block mode init now also makes it possible to expand/shrink the marked range after a paste or undo/redo, as it would be expected for any existing selection. Change-Id: Id26e4aa32896ec0c714e33b99dbf6702df144995 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129158 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2022-01-29cid#1497868 Logically dead codeCaolán McNamara
given the surrounding bIsTiledRendering conditional Change-Id: Ic4853f0f840ca2b50937c29f5399b981c5f9bde2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129131 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-29used TypedWhichId in the constructor of various svx *Item classesNoel Grandin
to act as an extra check that we have the association of Item and TypedWhichId annotations correct. (*) requires that I add an upcasting constructor to TypedWhichId (*) Make the field dialog stuff in writer use a new item id FN_FIELD_DIALOG_DOC_PROPS instead of abusing the existing SID_DOCINFO Change-Id: Ica4aea930c80124609a063768c9af5a189df1c27 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129098 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-01-29no need to call GetWhich on these SID_ valuesNoel Grandin
none of them are remapped (via the SfxItemfo stuff in the pool) Change-Id: Iefd38f1aac55e6059e2c57d102efb508bd1572b0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129090 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-01-29Standardize the flag name on bSkipEmptyCells.Kohei Yoshida
And document what the flag does. This corresponds with the "Skip empty cells" check box in the Paste Special dialog. Change-Id: Ic6cf9099efbee43f737a1472a4e275839e3d2c82 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129130 Tested-by: Jenkins Reviewed-by: Kohei Yoshida <kohei@libreoffice.org>
2022-01-29lokCalcRTL: fix editcell painting from other views as wellDennis Francis
Change-Id: Iac431996570f1f7eb091809442d8781ea60aa9b5 (cherry picked from commit 455d4047487396c3c70d6113ac5d07deecb1d3a1) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128899 Tested-by: Jenkins Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
2022-01-29lokCalcRTL: edit cell painting: avoid indent...Dennis Francis
to match the behaviour in desktop Calc. Change-Id: I615255635500edf375b237abcab0a21ba6153cce (cherry picked from commit 48e6ef20c6bab7029e46d985d67a907147dd2adf) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128898 Tested-by: Jenkins Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
2022-01-29lokCalcRTL: fix editcell tile paintingDennis Francis
Don't use internal gridwindow width to invert the edit area coordinates. The gridwin width is not in sync with lok client width, and it seems making them in sync is non-trivial as it currently breaks other things. For tile-painting, always use the width of visible columns in the (combined-)tile area as the mirror width. In the case of LOK + RTL, because we avoid coordinate mirroring based on gridwin-width, any corresponding adjustments in edit engine paper-size, output area, visible area are done appropriately. Advantage of this approach is that the invalidation rectangles sent are in the document coordinates which is exactly what the client expects! So no additional coordinate reversal needed in core or in lok client for invalidation. Change-Id: I0b687a12dc9344fba9ee772111e7598888fa16bf (cherry picked from commit 8266f569c864ae309f362088d42dfb3b952c4267) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128896 Tested-by: Jenkins Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
2022-01-28Resolves: tdf#147016 ensure focus returns to document after popup closesCaolán McNamara
Change-Id: I67e59afc08bc5983d473cb9dceb4fcefedeec117 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129094 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-27no need to call GetWhich on these SID_ valuesNoel Grandin
none of them are remapped (via the SfxItemEntryInfo stuff in the pool) Change-Id: Ic7b5f2c3cc75a65bdf9c45f9522cc53954b4ba38 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129040 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-01-27document what the workaround is forCaolán McNamara
Change-Id: Icceaa0fde4100f9d49293bec1f826030cbae99ca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129038 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-27lokCalcRTL: incorrect invalidation rectangle for...Dennis Francis
cell properties change. LOK client expects invalidation rectangle in document coordinates so ensure we don't mirror the x coordinate. Change-Id: I27bdd29a0d56c7a7b838b7669e3edde805dd1504 (cherry picked from commit d819e543c13f85bd9c18fbe61c7983efab9d21c5) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128895 Tested-by: Jenkins Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
2022-01-27lokCalcRTL: selections: lokclients need exact document coordinatesDennis Francis
so do not do horizontal mirroring. Change-Id: I93432002810dacfeb609268f436bdf2cfecb3a60 (cherry picked from commit 241909beda0d8985667435127e16bdf902850932) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128894 Tested-by: Jenkins Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
2022-01-27Resolves tdf#128258 - Draw a dotted line before hidden columns/rowsHeiko Tietze
Color and on/off configurable via Tools > Options > Application Colors Change-Id: Ia4b1e1c86f36d1b0f508a5b3e866a79418f16c5a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128553 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2022-01-27vba: add support for Application.WindowState + testTomaž Vajngerl
This just delegates the get/set calls to ActiveWindow.WindowState which is already supported, but calling it directly on Application is also possible. Change-Id: Ibf6f55581a5c66a47ec4dd21cc8d0fe3558330ac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129013 Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-01-26tdf#146991 Insert chart -> crashNoel Grandin
regression from commit a2eaf99e46f370ffb3b73828c2bdc53dc193b9a4 Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Fri Jan 14 10:56:50 2022 +0200 make comphelper::OInterfaceContainerHelper4 more threadsafe Change-Id: I259d24a3f0c710222544797728c5f40ff299e50b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128987 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-01-26move ToolBoxItemId into its own headerCaolán McNamara
Change-Id: I34838bee7ad27bfd60d92c26af7eb2de508686b9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128974 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-26lokCalcRTL: no internal width based mirroring in GetPosFromPixelDennis Francis
The gridwindow width is historically not synced with the visible area in client. Mirroring is not necessary when the client is already sending the true document coordinates of the mouse events etc. Change-Id: I74573be406c512324f4c5db0c53fbc12374b88c8 (cherry picked from commit ef3c67beb96df80179b46bb6d5116d4a5cab7f77) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128893 Tested-by: Jenkins Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
2022-01-26lokCalcRTL: provide sheet RTL flags to clientDennis Francis
Change-Id: If881fdea1c6bae10735cfde624ad6f4f3a34e389 (cherry picked from commit 1ebd27ac521f78f9cc2124573d85b03b533e8653) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128892 Tested-by: Jenkins Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
2022-01-26split two paragraph warning into primary and secondary messagesCaolán McNamara
Change-Id: Ie3bd9205a549ac55a0e5c7b9a444928b0fd80174 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128935 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-25tdf#146970 use a textview to show the proposed replacement formulaCaolán McNamara
so it can scroll and keep the text area to some finite size no strings changes or new translations, so this is a backportable change. Change-Id: Ibc36812c6aa7fff8e035c06d0dad885909f057ff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128933 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-25lok: enable in-place editing of math equationsMike Kaganski
Change-Id: Ic4d187d1e2ee92eab74a6bb43e47bb4f3d47ebd2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128506 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-01-25call baseclass CloseCaolán McNamara
Change-Id: I661b4fe839a01f3929119540eb3bd1065f5fdbf1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128917 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-25lokCalcRTL: h-flip the "combined" tileDennis Francis
This h-flip is needed because the tile containing cell A1 will have the coordinates (0, 0). Further aim is to have document coordinates for all tile messages and tile invalidation messages. The LOK client should be able to map the document coordinates to the correct view coordinates. In the lok client we also need to h-flip the "regular" tiles at the tile position. Change-Id: Iaf89afeb89f916cb490800ee5d34c4780125f3a0 (cherry picked from commit b3ca461871a92d8d2bd1d4ee713046ee74abbcf0) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128890 Tested-by: Jenkins Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
2022-01-25lokCalcRTL: Fix the tile offsetsDennis Francis
Change-Id: Id0db3d422c8c47ed6fbbc505ca9a857ac54c033a (cherry picked from commit 250aeac7434f924c82927a9de8a089e42a4fec00) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128889 Tested-by: Jenkins Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
2022-01-24ScInputHandler::UpdateFormulaMode() also for multi-line formulasEike Rathke
Additionally sprinkle some TODO: MLFORMULA comments on places where multi-line formulas should be supported as well but code currently only works for one paragraph. Change-Id: If2630a6493910984e0abb81ff2ed42ed51394681 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128787 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2022-01-24tdf#146913 don't destroy the dialog if we just want to hide itCaolán McNamara
Change-Id: Ie534aba915120d12e65aa965e5435bc7575ecb29 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128879 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>