summaryrefslogtreecommitdiff
path: root/sc/source/ui
AgeCommit message (Collapse)Author
2017-02-18loplugin:vclwidgets check for assigning from VclPt<T> to T*Noel Grandin
Inspired by a recent bug report where we were assigning the result of VclPtr<T>::Create to a raw pointer. As a consequence, we also need to change various methods that were returning newly created Window subclasses via raw pointer, to instead return those via VclPtr Change-Id: I8118e0195a5b2b4780e646cfb0e151692e54ae2b Reviewed-on: https://gerrit.libreoffice.org/31318 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit e6ffb539ee232ea0c679928ff456c1cf97429f63)
2017-02-17LOK: Calc: notes: on edit mode starts/ends: missing tiles invalidationMarco Cecchetti
On edit mode starts/ends, when a note is hidden, tiles, only the note tail belongs to, are not invalidated. Change-Id: I69487f428a121fc05da99d3b06786afd4f834766 Reviewed-on: https://gerrit.libreoffice.org/30101 Reviewed-by: Marco Cecchetti <mrcekets@gmail.com> Tested-by: Marco Cecchetti <mrcekets@gmail.com> (cherry picked from commit 457642759ff81aacf1451dd9025846799d0b978e)
2017-02-17LOK: Calc: show/hide a note does not perform any tile invalidationMarco Cecchetti
Change-Id: Ia904b6bbe82c395299b269ddbde523d19bf486bc Reviewed-on: https://gerrit.libreoffice.org/30099 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Marco Cecchetti <mrcekets@gmail.com> (cherry picked from commit ffb1fe4f434a48358a18c0af2c44a112d9ad04be)
2017-02-17LOK: Calc: notes: when edit mode begins the text content is misplacedMarco Cecchetti
Change-Id: Ia8efcee6fbeb75dd712d3ac480e355c2972875f3 Reviewed-on: https://gerrit.libreoffice.org/30098 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 1e3879f7be9384e6c1027f2ac148ddf0754b6b54)
2017-02-17tdf#71409: Let's not crash the function wizard dialog.Kohei Yoshida
It's a long story, but here is a short summary: When the function wizard dialog launches, it uses an edit engine instance to process text input, and that edit engine instance comes from the input window (for whatever reason). And, we are supposed to get ScTextWnd::MakeDialogEditView() called to instantiate such edit engine instance for the function wizard dialog. My previous change, however, changed this and ScTextWnd::InitEditEngine() ended up getting called to instantiate the edit engine instance. These two functions create edit engine instances with different settings intended for different use cases... The crash we saw is just one manifestation of such differences. Change-Id: I7fd84c1b1eca2351b9ecc87e325c2fd3787369eb Reviewed-on: https://gerrit.libreoffice.org/31664 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us> (cherry picked from commit ae923f941f70ebe99cc785076f3357015dd69003)
2017-02-17tdf#71409: always create edit engine instance for the input window.Kohei Yoshida
In order to properly manage accessibility events esp when no letters are typed. Without this, doing things like: 1) hit F2 to active cell edit, 2) hit ESC to deactivate, 3) go back to 1) and repeat the cycle several times, 4) hit Shift-Ctrl-F2 to activate the top input window would result in duplicated accessibility events fired, the number of which depends on how many times the above step was repeated. Change-Id: I116fdcbc63cbe9d33039d38a47770a6813c4e523 Reviewed-on: https://gerrit.libreoffice.org/31389 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us> (cherry picked from commit 9ba24ac54100a5af6ecdde479ebeb5c916e6fad2)
2017-02-16tdf#95306: Be sure to specify the entire range.Kohei Yoshida
Especially in presence of multiple disjointed selections. Change-Id: I8e7779824109c30e69fd43a2448ae900beaf28d3 Reviewed-on: https://gerrit.libreoffice.org/34140 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us> (cherry picked from commit 6d450aad0a8f82ee0320ffc3e76eefb43c16addb) Reviewed-on: https://gerrit.libreoffice.org/34143 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2017-01-31Resolves: tdf#105410 do not crash on a deleted formatEike Rathke
... if the last condition was deleted and the Manage list is to be updated. The format is gone. Change-Id: I0fc056b5c75849197f351871b0d05e5015d0d1bf (cherry picked from commit e32c8293709d4940ccf9f3def963e5a87925e583) Reviewed-on: https://gerrit.libreoffice.org/33713 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-01-27Resolves: tdf#105450 calc navigator gets 0 height on toggle off/on when dockedCaolán McNamara
Change-Id: Icd346cdf0a208ccaeddd77e6803f4f906361324c (cherry picked from commit b37ac48935621fcc7b71f81a8b892f24e85e5b6f) Reviewed-on: https://gerrit.libreoffice.org/33498 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-01-27dissolve LinkUpdateMode confusion, document::Settings vs XGlobalSheetSettingsEike Rathke
This is a combination of 3 commits. this is css::sheet::XGlobalSheetSettings attribute LinkUpdateMode ... and not css::document::Settings property LinkUpdateMode. It directly maps to ScLkUpdMode, LM_UNKNOWN isn't documented as a valid input value. (cherry picked from commit 109cff60a3a18b20b2e0efefd0d49f6eab9b52fd) remove now unused header file (cherry picked from commit d03cacfb7b9b126e375dfeaeed2fcd74d4fa48fb) this is the css::document::Settings property LinkUpdateMode ... not the css::sheet::XGlobalSheetSettings attribute LinkUpdateMode. (cherry picked from commit 32d90e643e4d9285366169301af4342d871c0d94) 7a9696f07c1a6e1deec342f224343bd938078c2c 039c8d39e89e693de1c5a1a4218c2fca70a6de9f Change-Id: I062a1fd32ad6a98db4f8e78de4724be1c8190407 Reviewed-on: https://gerrit.libreoffice.org/33600 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-01-27Resolves: tdf#104153 crash on drag and drop pivot table fieldCaolán McNamara
This is a combination of 2 commits. Resolves: tdf#104153 crash on drag and drop pivot table field now though sometimes it doesn't get removed at all, so a band aid for the moment (cherry picked from commit 068edb65b1dce375223d8642a01b07db3948ac03) Resolves: tdf#104153 lookup what listbox an entry is dragged from so we can find where its been dragged from in order to remove it from that source, rather than relying that it comes from the previously focused listbox Reviewed-on: https://gerrit.libreoffice.org/33575 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 011bae55cdd24a1d3e42f0aa2fcfd98d3ddc9b14) e6aa1a311b46e5e9ee96cab05e0705b794b5eb0b Change-Id: I6ccbbe51fe9250af0f85c30a9d253269a18df457 Reviewed-on: https://gerrit.libreoffice.org/33630 Reviewed-by: Eike Rathke <erack@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-01-26tdf#101828 handle rtf/richtext correctlyOliver Specht
Change-Id: Id894f62a918bd6e6fa59f8d546307343bf2bd4b0 Reviewed-on: https://gerrit.libreoffice.org/32682 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> (cherry picked from commit 048e30c1f8231e6cd144a9251061f6fa127b353e) Reviewed-on: https://gerrit.libreoffice.org/33567 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-01-25Resolves: tdf#105351 pass matching index key to conditional format dialogEike Rathke
Change-Id: I9d872140755c4ec0ae67349530b00f339057a356 (cherry picked from commit 0367acdcc59e14b0b067976a08202e8afef0ecf3) Reviewed-on: https://gerrit.libreoffice.org/33528 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-01-25tdf#104967 preserve isolated notes data in clipboard when closing documentEike Rathke
Change-Id: I0e263583e27c5103c0bb90e8fe00562e46a52d98 (cherry picked from commit b8b657123cc508c906622d20669507628c93e104) Reviewed-on: https://gerrit.libreoffice.org/33289 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-01-23Resolves: tdf#105466 crash when changing conditional formatting conditionCaolán McNamara
Change-Id: Id219a7935f83acf3924e60cb1bf02311dc5c4372 (cherry picked from commit 0b7c1dcd149cd98136e5ed3e8e0e70255d87cd16) Reviewed-on: https://gerrit.libreoffice.org/33481 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-01-23Resolves: tdf#105411 remove from entries before disposeCaolán McNamara
cause on dispose all the state change callbacks are called, and all of the conditional formatting code assumes that if there's an entry in the entries, that its not an empty disposed one Change-Id: I50d85128ba884a0719959f2d6e7ae83d6fb3431c (cherry picked from commit 2fb220093f7178f75ebd582bbcd956c1ee7e03db) Reviewed-on: https://gerrit.libreoffice.org/33476 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2017-01-06Resolves: tdf#105061 Only one text box shown in case of 'between'Caolán McNamara
non-layout ScCondFormatList widget not responding to layout child change Change-Id: I7edd4fc54de9e71fb86b47a9b182bfc22fa4af25 (cherry picked from commit ac561ab34ea9d26243fe3791f624c440dcf7ae6d)
2017-01-05Resolves: tdf#104919 crash with empty ScNavigatorDlg memberCaolán McNamara
commit 292560a957498bed70b625c992ec6bcf631dceb3 Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Mon Oct 17 13:23:23 2016 +0200 loplugin:unusedmethods detected the intended methods to do this were unused, so restore then, but hook them up this time Change-Id: I3b7e4a557696a91a70956487468b99fec6324a93 (cherry picked from commit f91dc0342de13e648dba5d9a93c01db23ae83533)
2016-12-16tdf#71435: Accessible caret-moved events are missing when "freeze" is enabledTamás Zolnai
Two accessible document is created when "freeze" options is enabled. meSplitPos identifies which accessible document handle which part of the window. We should handle events only in that accessible document which handles the active part. Change-Id: Ic9674344951f620546dd272beaad796de611d258 Reviewed-on: https://gerrit.libreoffice.org/32065 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit 06ea887f8ba34a628d7641eab210501f7bd2493d) Reviewed-on: https://gerrit.libreoffice.org/32077 Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2016-12-08tdf#104446: there can only be 1 condition for SUMIFJulien Nabet
Change-Id: I10b1e3880e79794b7f748882606d5c4101811d75 Reviewed-on: https://gerrit.libreoffice.org/31739 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Winfried Donkers <winfrieddonkers@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 5e4649debc1d7b68fd93073cebd691d840c1fa6c) Reviewed-on: https://gerrit.libreoffice.org/31764 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2016-12-02coverity#1396676 Uninitialized pointer fieldCaolán McNamara
Change-Id: I7d7557485fe603f49ae176378ef41539ebe4970c (cherry picked from commit 211925e144849ad14469a1a6c6451f61fcf369cf)
2016-11-30ScTabViewShell::InnerResizePixel must not mark document as modified...Stephan Bergmann
...when merely toggling the edit mode of a Calc document embedded in another document (via "Insert - Object - OLE Object... - LibreOffice 5.4 Spreadsheet"). Interestingly, none of the other document kinds seem to have this problem. (Maybe it's even unhelpful that ScTabViewShell::InnerResizePixel calls SetDocumentModified() at all?) Anyway, pass this inplaceEditModeChange information down there. Change-Id: Iffb24b068419e3608c9f4b5e9645e44e1716aafe (cherry picked from commit 424d17e62e0d670aa79a890f85bb98c19169f9f5) Reviewed-on: https://gerrit.libreoffice.org/31428 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-11-28nitpicks, tdf#43544 follow-upEike Rathke
Address nitpicks stated in https://gerrit.libreoffice.org/29274 Change-Id: If7ce8a7239a65a2ff619259622b85ce239060e52 (cherry picked from commit dd974413acc6ab00168a301cbb53b3c9caa11e32) Reviewed-on: https://gerrit.libreoffice.org/31320 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-11-28tdf#43544 ScStyleObj: Only call StylePool->find() when necessaryMaarten Bosmans
Avoid repeatedly calling GetStyle() when setting/getting multiple properties. By caching the SfxStyleSheet before entering the loop over all properties, performance of loading the document attached to tdf#43544 improves by 12%. Change-Id: Ic3f1314892b4771aa87801b63f854f83ec761d41 Reviewed-on: https://gerrit.libreoffice.org/29274 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 9d99a7b2d1dd973b50a699440ffb69d99d614607) Reviewed-on: https://gerrit.libreoffice.org/31319
2016-11-23[API Change]: Create new GeneralFunction2 for adding medianTamás Zolnai
New functionality added to pivot table became fully broken with Eike's revertion: 50244309501d738e7314fa79785db139c826f8d7 This commit fixes this problem. Reviewed-on: https://gerrit.libreoffice.org/31096 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit c0d4aadf08c16f2d79508367c631366f7a856346) GeneralFunction is not an enum anymore Reviewed-on: https://gerrit.libreoffice.org/31103 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit 5b7b2c8649596299c8f00b8b3b5056d272e25ccd) Change-Id: I67cfc63305bb9b2edeed2abd26d729fbf650579f Reviewed-on: https://gerrit.libreoffice.org/31099 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2016-11-22[API Change] revert incompatible change of enum css::sheet::GeneralFunctionEike Rathke
Quick solution before 5-3 branch off without reverting everything related. This will need a new constant value type for API instead of the enum and an internal mapping from/to the enum. Kept the GeneralFunction_MEDIAN at all places in uing code so it can be easily grep'ed for. Change-Id: I95256649f16ded08e467003d2924be0ff5efb87f
2016-11-22Retain sheet protect options throughout unprotect/protect sessionMike Kaganski
Currently, unprotecting a sheet clears the protection options it had (i.e. if to allow users to select protected/unprotected cells). So, protecting next time requires setting these options again. Unprotecting a sheet usually happens when author edits e.g. a form and intents to re-protect it when the edit is done, so it would be handy to restore previous flags as they were before. This patch allows saving the protection settings by using current ScTableProtection copy with its protection set to appropriate value, instead of new clean ScTableProtection or nullptr. This does not allow to save the flags between edit sessions if the protection is unset. Change-Id: Ieaba4eee746efcf05308dbc88e402c200a59b0d2 Reviewed-on: https://gerrit.libreoffice.org/31044 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2016-11-21Remove excessive parenthesis.Kohei Yoshida
Ugly. Change-Id: Ifdb9638e998b83c7aeaf9908f9584ff69d56d7b2
2016-11-21convert inventorId to scoped enumNoel Grandin
SW_DRAWLAYER had the same value as SC_DRAWLAYER, so I merged it into the ScOrSwDraw enum constant Change-Id: I5c45d378c00364d11cc960c9e48a6e3f10928724 Reviewed-on: https://gerrit.libreoffice.org/31037 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-21new loplugin datamembershadowNoel Grandin
Change-Id: Ib14319848bafd1fe7e0e663c434bbdeef5e98ecf Reviewed-on: https://gerrit.libreoffice.org/30963 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-19Revert "Use rtl::Reference to wrap ScAccessibleEditObject here."Kohei Yoshida
This reverts commit da7aa2561297da42058da55ed2629d0df6fb03f3.
2016-11-20PivotMedian: Implement median as a new pivot table functionTamás Zolnai
Change-Id: Ife90c8f1c36980254de3cec6e395a6ba94d99fea
2016-11-20Display localized function names in Pivot Layout dialogTamás Zolnai
Same names which are displayed for pivot table placed on a sheet. Change-Id: Ic05d0dddea7d17101f253874dff15b8a49b87287
2016-11-20Remove some unused resource stringsTamás Zolnai
Change-Id: I8529aa491d37aef5e732909357ddf93372dde6d2
2016-11-19Use rtl::Reference to wrap ScAccessibleEditObject here.Kohei Yoshida
And avoid ScAccessibleEditObject from getting instantiated every time cell edit mode is triggered. Change-Id: Id214248c7b6fcc28ab33777e1c44cdfc07276620 Reviewed-on: https://gerrit.libreoffice.org/30991 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2016-11-19tdf#48140 Remove not used UNO headers from filtersBartosz Kosiorek
Change-Id: I66e775b60343fe8ac772d8c0287ca19be58a7236 Reviewed-on: https://gerrit.libreoffice.org/30966 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-11-19LOK - Calc: use the tiled rendering area as visible area in PaintAreaMarco Cecchetti
This workaround is needed since the visible area in core is not the same which is used in the client. Change-Id: I82b23e689000c4d8106ffa01ed082ae3d629b1be Reviewed-on: https://gerrit.libreoffice.org/30976 Reviewed-by: Marco Cecchetti <mrcekets@gmail.com> Tested-by: Marco Cecchetti <mrcekets@gmail.com>
2016-11-19LOK - calc: now PgUp/PgDn offset is used only when PgUp/PgDn are pressedMarco Cecchetti
Change-Id: I340d747021bc794361d6b8eff76335345b60010c Reviewed-on: https://gerrit.libreoffice.org/30975 Reviewed-by: Marco Cecchetti <mrcekets@gmail.com> Tested-by: Marco Cecchetti <mrcekets@gmail.com>
2016-11-18fdo#71409: Prevent the a11y code from creating an edit view instance.Kohei Yoshida
GetEditView() now creates one if one does not exist. Clearly that's not the behavior the original a11y code was expecting. This at least removes the duplicated focus events with F2 press on sheet cell, though I still see a fair amount of duplicated events firing in other places... Change-Id: Ib5310ce5c67ab862b3a8a7a6c912d164475d62fa Reviewed-on: https://gerrit.libreoffice.org/30946 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2016-11-18Use std::unique_ptr for pEditEngine.Kohei Yoshida
And rename it to mpEditEngine. Change-Id: Iacaad04ca476bfb5b5e35e6e29f372812c40b3bc Reviewed-on: https://gerrit.libreoffice.org/30945 Reviewed-by: Kohei Yoshida <libreoffice@kohei.us> Tested-by: Kohei Yoshida <libreoffice@kohei.us>
2016-11-18Use std::unique_ptr for EditView.Kohei Yoshida
Also rename pEditView to mpEditView. Change-Id: Iac3b35cd59960df5be5dd90532dc7e757652d50e Reviewed-on: https://gerrit.libreoffice.org/30944 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2016-11-18includes should be at the top of the fileNoel Grandin
not randomly scattered through the code found with something like: git ls-files *.cpp | xargs grep -Pzl "(?s){.*#include" Change-Id: I9c242fa4ef99e8677f2800d7ec9f16d16e488351 Reviewed-on: https://gerrit.libreoffice.org/30952 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-17Re-label more class members private from protected.Kohei Yoshida
Change-Id: I0043da67de3a459bf26b13f9f69d3677bcc2824d
2016-11-17Avoid -fsanitize=signed-integer-overflowStephan Bergmann
Both Writer: "Table - Insert Table... - Insert", "Table - AutoFormat Styles..."; and Calc: select multiple cells, "Format - AutoFormat Styles..." cause > svx/source/dialog/framelinkarray.cxx:82:29: runtime error: signed integer overflow: -4702111234474983744 + -4702111234474983746 cannot be represented in type 'long' > #0 0x7f84ef0e36ba in svx::frame::lclRecalcCoordVec(std::__debug::vector<long, std::allocator<long> >&, std::__debug::vector<long, std::allocator<long> > const&) svx/source/dialog/framelinkarray.cxx:82:29 > #1 0x7f84ef0e780e in svx::frame::ArrayImpl::GetColPosition(unsigned long) const svx/source/dialog/framelinkarray.cxx:265:9 > #2 0x7f84ef0f95ae in svx::frame::Array::GetColPosition(unsigned long) const svx/source/dialog/framelinkarray.cxx:762:20 > #3 0x7f84ef0f9e56 in svx::frame::Array::GetWidth() const svx/source/dialog/framelinkarray.cxx:787:12 > #4 0x7f852e9df8fd in ScAutoFmtPreview::CalcCellArray(bool) sc/source/ui/miscdlgs/autofmt.cxx:429:32 > #5 0x7f852e9c7740 in ScAutoFmtPreview::Init() sc/source/ui/miscdlgs/autofmt.cxx:407:5 > #6 0x7f852e9c9102 in ScAutoFmtPreview::ScAutoFmtPreview(vcl::Window*) sc/source/ui/miscdlgs/autofmt.cxx:73:5 where -4702111234474983746 = 0xbebebebebebebebe is ASan's uninitialized value stored into ScAutoFmtPreview::mnLableColWidth et al. Those (overflowing, even) computations on uninitialized values appear to be harmless in practice, though, presumably because they are overwritten with "real" values soon after. Change-Id: I487fc4681afe79c4e8532595226cba4c9c0c9b2d
2016-11-17Add Skeleton for DataProvider ClassJaskaran Singh
DataProvider class serves as an abstraction of various External Data Importing Techniques we have and the others which could be implemented in the future. Change-Id: I9fc9455f7fbf9025aace4c3248df9b32f522ce52 Reviewed-on: https://gerrit.libreoffice.org/30906 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jaskaran singh <jvsg1303@gmail.com>
2016-11-17Remove redundant checks on nullptr.Kohei Yoshida
CreateTextHelp() itself does the check on nullptr. No need for the callers to do the same. Change-Id: Ib57f3b818235a4e0fb302dda3562c9c8a29a4e54 Reviewed-on: https://gerrit.libreoffice.org/30919 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2016-11-17Use std::unique_ptr for mpTextHelper.Kohei Yoshida
Change-Id: I7cbb68a947232c6b3410815349cae306b384608c Reviewed-on: https://gerrit.libreoffice.org/30918 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2016-11-16new loplugin finalprotectedNoel Grandin
look for final classes, and make sure they don't have protected members Change-Id: I1fa810659bba02b61a5160dbfd8e24185ec9abf4 Reviewed-on: https://gerrit.libreoffice.org/30895 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-15loplugin:constantparamNoel Grandin
Change-Id: I1a6e13584ca516f44195e724b39e78360a842c7c Reviewed-on: https://gerrit.libreoffice.org/30859 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-14coverity#703927 Unchecked return valueCaolán McNamara
make these less odd and simply return the thing they selected, rather than a bool that indicates that the rpObj arg was successfully set to non-null, so there's one flag to check not two which both mean the same thing. Change-Id: If70e412f98dea8b7114fb77f26a9c59aab93be50 Reviewed-on: https://gerrit.libreoffice.org/30794 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit (git 2.34.1) at 2024-07-10 18:35:22 +0000