summaryrefslogtreecommitdiff
path: root/sc/source/ui
AgeCommit message (Collapse)Author
2021-11-25Resolves: tdf#145863 crash if popup closed before becoming truly visibleCaolán McNamara
the timing has to be just right to get this to happen Change-Id: I1ae81bf5c79b7f8b3fdf82b3fab94d5a3b6076cc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125816 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-11-24tdf#145828 Sidebar line styles: Default to "thin" widthSamuel Mehrbrodt
Change-Id: I78d754d36c7ea41f7e3259be331d23b8a25c480f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125771 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2021-11-23tdf#139460 improve autofilter sub-menu interaction under gtkCaolán McNamara
so the submenu pops down when the mouse moves back into its parent. This removes layer of InterimItemWindow and for gtk (under wayland) the autofilter and its submenu can use native GtkPopovers Change-Id: I4c8c3d2087566f508d75eda72e272d9f7fba2f00 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125428 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-11-23O[U]String::replaceAt overloads that take string_viewNoel Grandin
which results in lots of nice string_view improvements picked up by the plugins Change-Id: Ib0ec3887816b3d4436d003b739d9814f83e244b2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125657 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-11-22Use less DegreeN::get()Mike Kaganski
Change-Id: I97b8d6282c72307cc29a913af221d283523f2fae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125653 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-11-22Generalize DegreeNMike Kaganski
This potentially allows to introduce other degree fractions easily, like Degree<sal_Int64, 60000>, with automatically defined conversion functions. Change-Id: Id1c32d9e029943844bdc833178c1f99387ff87fc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125640 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-11-18drop unnecessary TODOCaolán McNamara
Change-Id: Id906f7a6bf806d5c102f8653b1174aaa47e8bb7d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125488 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-11-18when color menu popdowns only popdown the autofilter if something was selectedCaolán McNamara
so the color menu can be dismissed without dismissing the autofilter Change-Id: Idb44f40a599382f86ffa9519910c37e64a56820c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125439 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-11-18menu placement is a little offCaolán McNamara
its relative to the treeview, not the floating window Change-Id: I70c15231eb61d5b8da3bbf473db39489b4544f0c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125473 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-11-17use ListBoxPreview size for the color shown in autofilter color listCaolán McNamara
it's used for a similar case in the color button, GetToolbarIconSizePixel is relatively narrow and we have a hectare of space available here. Draw a border around the color as we do for the similar color button case. Change-Id: If0b24a142d47038d02a977ed88281b2de0b529fe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125418 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-11-17weld colormenuCaolán McNamara
Change-Id: I6feef72cf924865e2407a96cdd0b6e60c835dbc3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125417 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-11-17tdf#142420 color menu should be a child of the autofilter, not a siblingCaolán McNamara
which is why it doesn't appear at all under wayland. This should also get it positioned better rather than using a fixed pixel offset. Change-Id: I9a4193c27b4172469cea3d980c86cff9ca701ca2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125409 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-11-17wrong function name in commentCaolán McNamara
Change-Id: I80f7f8cbf17bea0de770eb590ade6bbdb2fc7ac6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125406 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-11-17SCSTR_FILTER_TEXT_COLOR is used in two different contextsCaolán McNamara
in the autofilter popup and the standard filter combobox. In the autofilter we want title case to match the other entries there, for the standard filter we need the same text as appears in the combobox list Change-Id: I693d3fa8a9fa1bac0803971be593f107d5817e74 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125371 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-11-17don't attempt to set cursor to first entry if there are no entriesCaolán McNamara
avoids gtk warning of: gtk_tree_view_scroll_to_cell: assertion 'tree_view->priv->tree != NULL Change-Id: Ie2c22a02d795591600a7f6da2e11741ba084a81f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125380 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-11-17Resolves tdf#144247 - Change display precision of row height / column widthHeiko Tietze
Use 2 digits by default but 4 in case of user-defined values for row height and column width. This partially reverts ad8edac43e73555bc2055514300c5b81a1bb04ea as the optimal width is back to 2 digits Change-Id: I4cb53071783c76d9fbea0cc2feaa0b860c73c647 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123802 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2021-11-16rtl::Static->thread-safe staticNoel Grandin
Change-Id: I0f39dea1392eb2ba11881615aedbe386870282ee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125324 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-11-15uitest: sc: add support for pivot table popupXisco Fauli
Change-Id: Id990178051e81a81bf6f6a0fb920473d3ee21fff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125259 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-11-12Resolves: tdf#145645 pivot table popups don't dismiss when item activatedCaolán McNamara
Change-Id: I5a68a08600b7792d924ec77694a60651df5d9c83 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125112 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-11-12Use more o3tl::convert in scMike Kaganski
Change-Id: I624b6c570eff8b6cdc83ffcb2d0dbadf848715b0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120330 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-11-11Drop ScGlobal::GetEmptyOUString() and EMPTY_OUSTRINGMike Kaganski
OUString default ctor already uses a static instance (through rtl_uString_new), no need to have another module-specific static. Commit d8037ae18a297229d1b79f8f76331abfd548350d had removed its sw counterpart some time ago. Change-Id: I140fe13bc1f6b0cbe188e83e602fdebe995e467a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125061 Tested-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-11-11tdf#142986 sc sampling: allow more than default (100) samplesJustin Luth
The default maximum for a spinbutton must be 100. For some reason, the previous setMax to maxint was removed in LO 6.3 in commit 2c5c20b19c349a4b7f6d78d69d8d57f9af5c351c. Change-Id: I846c1ce037db6ef3b8d48975e24b748cad0394d6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124948 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2021-11-10sc: EMBED_SOURCE: extend copy to clip area...Dennis Francis
to include the draw objects in the sheet read from system clipboard. This is needed because GetCellArea() computes the "last row" and "last column" only based on the cell contents and not the drawing layer contents. So copying a "empty cells" range that has images in it and pasting it will not include any images without this fix. Change-Id: I56ffb14e881a1aecc5b43590ea4fb3fc1c35ace8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124629 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Dennis Francis <dennis.francis@collabora.com> (cherry picked from commit 789d19776ab451a6118b938830d488961b42dae5) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124673 Tested-by: Jenkins
2021-11-10sc: EMBED_SOURCE: also include objects on copy to clipDennis Francis
This is to match the behaviour of copy-pasting with the internal clipboard. If user copies a range that contains some images then on pasting these images are also included when using internal clipboard document. Change-Id: I61a6e71bd6afcace51230d1e7e7539e88404cbe5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124628 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Dennis Francis <dennis.francis@collabora.com> (cherry picked from commit 430a3e123c24ba2e87d89dddebb4fda4d3ff2e93) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124672 Tested-by: Jenkins
2021-11-10sc: fix clip cell range for clip with no contentDennis Francis
The problem was observed in LOK mode with the following step: 1. Select and copy a sheet area with no content. 2. Paste this into another document. => You get an error dialog saying "Protected cells cannot be modified". The issue here is in ScViewFunc::PasteDataFormat, rSrcDoc.GetDataStart() gives the correct cell indices of the clip selection, but GetCellArea() truncates the range to empty range as there is no content. Since these functions are used in many places which might depend on this behaviour, it seems right to fix it just for this usecase. Change-Id: Ibc85a8d7dd33b377a37298ea9a2a7ebb55eccf1d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124627 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Dennis Francis <dennis.francis@collabora.com> (cherry picked from commit 4ff08a1332e5150d7ef978572e747ac8da3a0820) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124671 Tested-by: Jenkins
2021-11-08tdf#142033 - Handle embedded newline set via SetDataArrayAndreas Heinisch
Change-Id: I798f9a2a2ce599ba8ca3ef1f5ae91801d8f1b138 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124681 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2021-11-08make a number of Calc functions return value by actually returning itLuboš Luňák
All these returned their value using a reference argument, for apprently no good reason. Change-Id: I6a33417e7df2aac67427c16e5003dfaaa1a814d7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124872 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-11-08use more OUStringLiteral in MediaDescriptorNoel Grandin
Change-Id: I0567d103db8db401c737fed98483912a39352929 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124835 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-11-08tdf#48622 Adapt sidebar line styles to new defaultsSamuel Mehrbrodt
Change-Id: I81287d90c2250838391fa79d2f6455219ea822c8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124680 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2021-11-07forward decls go after #includeNoel Grandin
Change-Id: I54c33508639044092356eed5144720261b4f65db Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124816 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-11-07return XShape from SdrObject::getUnoShapeNoel Grandin
instead of XInterface, to make it obvious what the reality of the requirement is Change-Id: Icdd4113f2a0ece930305f4d8ba010b81d24f43c3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124802 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-11-05use more DECL_DLLPRIVATE_STATIC_LINKNoel Grandin
to avoid unnecessarily exporting symbols Change-Id: I224848cea217977088fe0643511660a7c99b7277 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124733 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-11-05use more DECL_DLLPRIVATE_LINKNoel Grandin
to avoid unnecessarily exporting symbols Change-Id: I6855894d0166c300ced169e36861f38811baa48d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124730 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-11-04tdf#48622 Add new border line width defaultsSamuel Mehrbrodt
* Hairline (0.05pt) * Very thin (0.5pt) * Thin (0.75pt) * Medium (1.5pt) * Thick (2.25pt) * Extra thick (4.5pt) This unifies the default border line widths throughout the program. Users can still set any line width they want by chosing "Custom" in the "Border" tabpage. Also, existing documents won't be changed. The new defaults are just for newly added borders. Change-Id: I7af85dc189a688a749812824508c33c7814b50f5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122683 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2021-11-03improve find-can-be-private scriptNoel Grandin
add progress display and cleanup child processes Change-Id: I86cc13dee17f6d1ea2874f0ebe178426fbc82076 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124634 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-11-01multiline calc inputbar not redrawing and adjusting scrollbar on delete of textCaolán McNamara
backspace is ok, but with delete when a line is deleted the scrolled up lines are visually duplicated at the bottom Change-Id: I22e91aa3c3213876d36c593cae7989e8913bffc3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124548 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-31add o3tl::span ctor from std::vectorLuboš Luňák
Makes code simpler, and std::span can be constructed from std::vector too. Change-Id: Iae26b53c52148c19d9068a63126a7393d098d654 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124507 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Luboš Luňák <l.lunak@collabora.com> Tested-by: Jenkins
2021-10-30Prepare for removal of non-const operator[] from Sequence in scMike Kaganski
Change-Id: Ic49c0fda3e98aeda471e674b68d40464ddac1ea1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124382 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-10-30tools::Long->sal_Int32 in the DX arraysNoel Grandin
Change-Id: I36ddc11b39763dc77086591fe9bb756195b4294f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124459 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-10-30Add comments for defaults of bEvaluateFormulasEike Rathke
The default is "true" if not present at all for compatibility of older filter options strings. The default is "false" if present. Change-Id: I79383e6fcf211fc8b8f933ae93f6d53ec084d551 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124454 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2021-10-29pass DX array around using o3tl::span instead of pointerNoel Grandin
so we get bounds checking in debug mode Note that I cannot just pass around the std::vectors involved because there is a place in editeng which calls with a subset of a vector. Change-Id: I5088a139593c27bf9cbe5d843ab4b0048ac6d508 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124330 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-10-26let focus enter calc sheet bg color dialog's valueset on clickCaolán McNamara
Change-Id: I884c8209e6b26e6c99654c4126ba81cf7e46c69f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124236 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-22no need to allocate RangeIndexMapPtr separatelyNoel Grandin
Change-Id: I0e2aae923530667877bfb111b006b214ca51a730 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124057 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-10-22lok: invalidate sheet-geometry sizes on clip pasteDennis Francis
Change-Id: Ie2b308f970673381dfa354620e3394acb44f971f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123869 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com> (cherry picked from commit a547f8a1db3c39ad2c84a6bc11cec075ad52c268) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124011 Tested-by: Jenkins Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
2021-10-21loplugin:flattenNoel Grandin
Change-Id: I3b4226a9d089ec9aedab95d96e50a068f57a76c7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123991 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-10-20svx: Don't end text edit mode for all viewsTomaž Vajngerl
This allows multiple views to not disturb each other editing inside a impress document. With the ending of text edit for all views still enabled, one view can cancel other views text editing just by moving or resizing a unrelated shape in the document. To make this possible we also need a view-local undo manager for the text edit mode, which is independent of the document undo manager. When the text edit mode ends, all the changes will be added as one change to the document undo stack. This prevents any conflicts in the undo stack that could be made when 2 views are editing the same document at the same time. This also adds the test for the new use case and changes the existing tests to reflect the change. Change-Id: I04edb4f91d7e111a490c946f7121cbca75f818d7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123220 Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-10-20loplugin:indentation check for indent inside blockNoel Grandin
look for places where the statements inside a block are not indented Change-Id: I0cbfa7e0b6fb194b2aff6fa7e070fb907d70ca2f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123885 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-10-19consider font when caching SalLayoutGlyphs in calc (tdf#143978)Luboš Luňák
d62ad3efe3c8778cfd added the caching, but did not consider that the used OutputDevice (its font) may change. Change-Id: I291999d3613b7ba161e3d82348f621aa84a93067 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123809 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-10-19Use MsLangId::getConfiguredSystemLanguage()Eike Rathke
Change-Id: I298f762ac7f3298aa9cb9621ad1f8cae50527b24 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123790 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2021-10-18tdf#145198: Bash like autocompletion for Calc autoinputDennis Francis
Refer ESC minutes section "Calc auto-complete behavior changes" at https://lists.freedesktop.org/archives/libreoffice/2021-October/087911.html for context. Consider an example of the following data in a column: ABCD123xyz ABCD345qwel ABCD123pqr ABCD123xyz PQR 1. When user types A, it will show the partial suggestion BCD. 2. User can accept the suggestion with the right arrow key and then the cursor will be placed after the letter D, waiting for more input. User can choose to not accept the suggestion either by typing more or by ending the edit mode by pressing Esc key. 3. If the user accepts the suggestion BCD by right arrow key, and types 1, it will show a partial suggestion of 23. User can accept this by pressing the right arrow key. 4. If the user accepts the suggestion in the 3rd step and types x it will show the final suggestion yz. Again user can choose to accept or decline the suggestion as mentioned in the 1st step. The tiledrendering test ScTiledRenderingTest::testAutoInputExactMatch() is amended to match the new behaviour. Change-Id: Ib2cfc16af71483790384e70eb7332f864cf744c5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123578 Tested-by: Jenkins Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
generated by cgit (git 2.34.1) at 2024-07-10 18:35:01 +0000