summaryrefslogtreecommitdiff
path: root/sc/source/ui
AgeCommit message (Collapse)Author
2019-11-27jsdialogs: send .uno:FillStyle updates in CalcSzymon Kłos
Change-Id: I51682546a3c8fd4ee6d97cf8bf79d066e571addf Reviewed-on: https://gerrit.libreoffice.org/83386 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/83780 Tested-by: Jenkins
2019-11-26lok: calc formula bar tunneling: function list callbackMarco Cecchetti
Added a lok callback for sending the list of functions matching the current characters typed by the user. Change-Id: Ia971fc55ec5eb961b4098592a8049dd0eed3ba14 Reviewed-on: https://gerrit.libreoffice.org/83750 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-11-25sc: rowcol: tdf#50916 convert segmenttreeNoel Grandin
Change-Id: Ia05d1bc60a76a8bbf65afe5b0459ce213be9bfbe Reviewed-on: https://gerrit.libreoffice.org/83646 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-22make some classes module-privateNoel Grandin
Change-Id: If7303a082e06f6937fca911c578a40475546cda2 Reviewed-on: https://gerrit.libreoffice.org/83442 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-22tdf#128951: restore passing nullptr to ScTableSheetObj when not inserted yetMike Kaganski
This partially reverts 009e7a54f40ebacd9dd4a394504c277789699801 Change-Id: I5a9605ff9d0ff1cd825968fb247b2a3bf4b2902a Reviewed-on: https://gerrit.libreoffice.org/83464 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-11-22Extend loplugin:external to warn about classesStephan Bergmann
...following up on 314f15bff08b76bf96acf99141776ef64d2f1355 "Extend loplugin:external to warn about enums". Cases where free functions were moved into an unnamed namespace along with a class, to not break ADL, are in: filter/source/svg/svgexport.cxx sc/source/filter/excel/xelink.cxx sc/source/filter/excel/xilink.cxx svx/source/sdr/contact/viewobjectcontactofunocontrol.cxx All other free functions mentioning moved classes appear to be harmless and not give rise to (silent, even) ADL breakage. (One remaining TODO in compilerplugins/clang/external.cxx is that derived classes are not covered by computeAffectedTypes, even though they could also be affected by ADL-breakage--- but don't seem to be in any acutal case across the code base.) For friend declarations using elaborate type specifiers, like class C1 {}; class C2 { friend class C1; }; * If C2 (but not C1) is moved into an unnamed namespace, the friend declaration must be changed to not use an elaborate type specifier (i.e., "friend C1;"; see C++17 [namespace.memdef]/3: "If the name in a friend declaration is neither qualified nor a template-id and the declaration is a function or an elaborated-type-specifier, the lookup to determine whether the entity has been previously declared shall not consider any scopes outside the innermost enclosing namespace.") * If C1 (but not C2) is moved into an unnamed namespace, the friend declaration must be changed too, see <https://gcc.gnu.org/bugzilla/show_bug.cgi?id=71882> "elaborated-type-specifier friend not looked up in unnamed namespace". Apart from that, to keep changes simple and mostly mechanical (which should help avoid regressions), out-of-line definitions of class members have been left in the enclosing (named) namespace. But explicit specializations of class templates had to be moved into the unnamed namespace to appease <https://gcc.gnu.org/bugzilla/show_bug.cgi?id=92598> "explicit specialization of template from unnamed namespace using unqualified-id in enclosing namespace". Also, accompanying declarations (of e.g. typedefs or static variables) that could arguably be moved into the unnamed namespace too have been left alone. And in some cases, mention of affected types in blacklists in other loplugins needed to be adapted. And sc/qa/unit/mark_test.cxx uses a hack of including other .cxx, one of which is sc/source/core/data/segmenttree.cxx where e.g. ScFlatUInt16SegmentsImpl is not moved into an unnamed namespace (because it is declared in sc/inc/segmenttree.hxx), but its base ScFlatSegmentsImpl is. GCC warns about such combinations with enabled-by-default -Wsubobject-linkage, but "The compiler doesn’t give this warning for types defined in the main .C file, as those are unlikely to have multiple definitions." (<https://gcc.gnu.org/onlinedocs/gcc-9.2.0/gcc/Warning-Options.html>) The warned-about classes also don't have multiple definitions in the given test, so disable the warning when including the .cxx. Change-Id: Ib694094c0d8168be68f8fe90dfd0acbb66a3f1e4 Reviewed-on: https://gerrit.libreoffice.org/83239 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-11-22tdf#124513 let wizard reappear on tabbing back to documentCaolán McNamara
where it was showing before tabbing away Change-Id: Ia87aeb9789ae034611431983c6489569a59d47d3 Reviewed-on: https://gerrit.libreoffice.org/83434 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-21tdf#47490: Show overwrite warning when pasting data using "Enter"Aditya
In Calc when a cell is copied and its value is filled/pasted to different cell(s) by using the "Enter" key when focus is on selected cells -- replace warning is not shown even if the selected cells have values of their own inside it. The old data is simply lost. Provide a replace warning dialog box whenever such a case is encountered. Change-Id: I13acb424bc449e096512b5a0864ebc47a407f234 Reviewed-on: https://gerrit.libreoffice.org/83333 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-11-20loplugin:unusedmethodsNoel Grandin
Remove a filtering step in the python script that was hiding some results Change-Id: Id94268f150902405ab197c077f18aaedf98845fc Reviewed-on: https://gerrit.libreoffice.org/83256 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-19Fix typoAndrea Gelmini
Change-Id: I5ae932e727eb3bb4cef3f7e160c3ace32e3f7d47 Reviewed-on: https://gerrit.libreoffice.org/83225 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-11-19don't crash if a linked to object is deleted after the doc is loadedCaolán McNamara
Change-Id: Ia6ab1261745d223dcf84b638edf6a64d46bc6f4b Reviewed-on: https://gerrit.libreoffice.org/83201 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-19Related: tdf#125917 remove active editing when we want to replace contentsCaolán McNamara
this addresses comment #6 so that the chosen value is entered in the cell Change-Id: I3b45301e00b2f79038e88c926f15babd49dcc2bf Reviewed-on: https://gerrit.libreoffice.org/83085 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-19tdf#125917 Ensure mouse is captured before the menu is launchedCaolán McNamara
calc seems to excessively capture the mouse and grabs + floats are messy across the different ports. But We usually have the mouse captured before calling the menu, except if we are editing a cell, an additional capture here will ensure the grab status is the same in both modes and that events go to the same place in either case. Change-Id: I213560273be1a6a398d6a1787a53d64501c473f0 Reviewed-on: https://gerrit.libreoffice.org/83130 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-19Related: tdf#125917 release mouse grab before showing warning dialogCaolán McNamara
Type text into the data validity dropdown cell and click elsewhere. The warning dialog cannot be interacted with due to the active mouse grab to its parent Change-Id: I51702c828dee6ec88106f7d44d7e3440f2e61298 Reviewed-on: https://gerrit.libreoffice.org/83128 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-19cid#1399259 Uncaught exceptionCaolán McNamara
Change-Id: Ia811eeb04cb9ab86aea205aa848e210fc34ab9d6 Reviewed-on: https://gerrit.libreoffice.org/83072 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-19tdf#97926 Add UNO API for InfobarSamuel Mehrbrodt
This allows creating, updating and removing infobars from macros/extensions. It also extends the infobar with a primary and a secondary text, so there can be a bold summary at the beginning at the infobar with a longer text following in normal letters. Macro sample: ------------------------------------------------------------ Sub AddInfobar dim buttons(1) as new com.sun.star.beans.StringPair buttons(0).first = "Close doc" buttons(0).second = ".uno:CloseDoc" buttons(1).first = "Paste into doc" buttons(1).second = ".uno:Paste" ThisComponent.getCurrentController().appendInfobar("my", "Hello world", "Things happened. What now?", com.sun.star.frame.InfobarType.INFO, buttons, true) End Sub Sub UpdateInfobar ThisComponent.getCurrentController().updateInfobar("my", "WARNING","Do not read this message.", com.sun.star.frame.InfobarType.WARNING) End Sub Sub RemoveInfobar ThisComponent.getCurrentController().removeInfobar("my") End Sub ------------------------------------------------------------ Change-Id: I5d0a223525845d23ffab17acdaa431e0eb783fec Reviewed-on: https://gerrit.libreoffice.org/29816 Reviewed-by: Serge Krot (CIB) <Serge.Krot@cib.de> Tested-by: Serge Krot (CIB) <Serge.Krot@cib.de> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-11-18convert AccessibilityFlowTo to scoped enumNoel Grandin
and drop the unused FORSPELLCHECKFLOWTO Change-Id: I128e84d386c10d001aa63f93b4b6dcb7238a1242 Reviewed-on: https://gerrit.libreoffice.org/83060 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-17cid#1430084 Arguments in wrong orderCaolán McNamara
add an annotation Change-Id: Id3b90eae8a2306cfb7f0f46b3fd73e320c851f6a Reviewed-on: https://gerrit.libreoffice.org/83029 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-17Extend loplugin:external to warn about enumsStephan Bergmann
To mitigate the dangers of silently breaking ADL when moving enums into unnamed namespaces (see the commit message of 206b5b2661be37efdff3c6aedb6f248c4636be79 "New loplugin:external"), note all functions that are affected. (The plan is to extend loplugin:external further to also warn about classes and class templates, and the code to identify affected functions already takes that into account, so some parts of that code are not actually relevant for enums.) But it appears that none of the functions that are actually affected by the changes in this commit relied on being found through ADL, so no adaptions were necessary for them. (clang::DeclContext::collectAllContexts is non-const, which recursively means that External's Visit... functions must take non-const Decl*. Which required compilerplugins/clang/sharedvisitor/analyzer.cxx to be generalized to support such Visit... functions with non-const Decl* parameters.) Change-Id: Ia215291402bf850d43defdab3cff4db5b270d1bd Reviewed-on: https://gerrit.libreoffice.org/83001 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-11-15reduce iteration in ScViewData::GetScrPosNoel Grandin
we already have a ScTable::GetRowHeightScaled method that uses spans, so use that. Change-Id: I126292b4a8b37ebf2d4f737dcbfdadc31226531e Reviewed-on: https://gerrit.libreoffice.org/82520 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-14cid#1455325 establish that pDoc cannot be null thereCaolán McNamara
Change-Id: Ia7bca1e74a8ede90e29ec6cbd63c7fdcaf25b072 Reviewed-on: https://gerrit.libreoffice.org/82696 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-14mpDoc is assumed to be non-nullCaolán McNamara
Change-Id: Ib3fbd6cc2b01e4923e97260b66aa1cd7807ee281 Reviewed-on: https://gerrit.libreoffice.org/82684 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-14Details always dereferences ScDocument argumentCaolán McNamara
Change-Id: If56c03af49606ffe6b5d4d782bd4a848aa79d8c2 Reviewed-on: https://gerrit.libreoffice.org/82695 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-14mpDocument is assumed to be non-nullCaolán McNamara
Change-Id: I2ca91a1baf2c34b89b972871025c4039f0eea85b Reviewed-on: https://gerrit.libreoffice.org/82683 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-14SetReference ScDocument arg is never nullCaolán McNamara
Change-Id: Ifdfe305e5319926d804e14962e786389b79fe476 Reviewed-on: https://gerrit.libreoffice.org/82682 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-14ParseWithNames pDoc arg assumed to be non-nullCaolán McNamara
Change-Id: I97451daf3a99ace4c936912a3978dfaee8fe9fb2 Reviewed-on: https://gerrit.libreoffice.org/82681 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-14mDocument is assumed to be non-nullCaolán McNamara
Change-Id: I53cf6625a24fe0b79914736f271ed3577af2e6e5 Reviewed-on: https://gerrit.libreoffice.org/82680 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-14mDocument is assumed to be non-nullCaolán McNamara
Change-Id: I180c0a6d5041c52cef332b07a0ff433e47f2f384 Reviewed-on: https://gerrit.libreoffice.org/82679 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-14mpDoc is assumed to be non-nullCaolán McNamara
Change-Id: Iecb34ff0483b522146e1a4e89da71e6a06b0b3c2 Reviewed-on: https://gerrit.libreoffice.org/82678 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-14mDocument is assumed to be non-nullCaolán McNamara
Change-Id: I8b012305363116393c88a81ab6e78f6074d6955a Reviewed-on: https://gerrit.libreoffice.org/82677 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-14pDoc is always dereferencedCaolán McNamara
so make it a reference Change-Id: I0b732c76f864129521c2c15a8556359b7367a026 Reviewed-on: https://gerrit.libreoffice.org/82668 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-13tdf#128466: Accept also JPEGTor Lillqvist
Change-Id: If8499cde875e03cb6c56259badd64ba6aee08a66 Reviewed-on: https://gerrit.libreoffice.org/82584 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com> (cherry picked from commit 7dba640b5691c22d6529e53752255fddc2b461e6) Reviewed-on: https://gerrit.libreoffice.org/82618 Tested-by: Jenkins
2019-11-13jsdialogs: send .uno:NumberFormat updatesSzymon Kłos
Change-Id: I5c482123c51ba580ef9b597dc8e07fbf51b96ca9 Reviewed-on: https://gerrit.libreoffice.org/82578 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> (cherry picked from commit 97451c8ab5f571c4e291f6c21121d68ee2423b05) Reviewed-on: https://gerrit.libreoffice.org/82581 Tested-by: Jenkins
2019-11-13lok: calc: switch row / column / grouping data to pixels.Michael Meeks
This simplifies lots of logic in the clients, making it trivial to get good row/column header alignment at any zoom. Ultimately TWIPS here are highly misleading print-twips, and in this state are ~impossible to map to pixels accurately unless all data is present back to the origin (which is not the current approach). Change-Id: I6ca30e77865b62e886e23860f7c23350e544c9fc Reviewed-on: https://gerrit.libreoffice.org/82572 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2019-11-13Related tdf#128753: fix regressionJulien Nabet
from https://cgit.freedesktop.org/libreoffice/core/commit/?id=a8a064d11c05feed83f05b0ce8209f7054afd804 See bt: https://bugs.documentfoundation.org/attachment.cgi?id=155761 Change-Id: If527f539e47e3a2ff9f3745665080adc955ea75b Reviewed-on: https://gerrit.libreoffice.org/82559 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-12Resolves: tdf#122232 Move TabStartCol logic to ScTable::GetNextPos()Eike Rathke
... instead of blindly applying it to every move if set. Change-Id: Ief2efb4eb2288cd479852d5a250c2523715de38b Reviewed-on: https://gerrit.libreoffice.org/82513 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2019-11-12tdf#121239 give writer, calc and draw/impress the same underline optionsCaolán McNamara
uno:Underline is the "real" deal, and has multiple underline options uno:UnderlineSimple is "some underline on" vs no underline calc and writer had UnderlineSingle, UnderlineDouble and UnderlineDotted for that specific type of underline on vs not-on add those to draw/impress too and then use UnderlineSingle instead of Underline in the format menu so that when UnderlineDouble is applied, UnderlineSingle is not show as applied, instead of using Underline ot UnderlineSimple which would show as on if UnderlineDouble was applied Change-Id: I6f9fcf37c2c90d215ea52b536e4fa84734754850 Reviewed-on: https://gerrit.libreoffice.org/82469 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-12sc: pViewSh can be nullptr in the ScNavigatorDlg ctorMiklos Vajna
In case the nagivator dialog was enabled the last time the user exited from Calc, resulting in a crash-on-startup in subsequent runs. This avoids the need for a workaround to reset the user profile. Change-Id: I5041a9a258efb82051036d8404fde77c8985089a Reviewed-on: https://gerrit.libreoffice.org/82491 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-11-12Related: tdf#121239 super/sub not shown as toggles in calcCaolán McNamara
Change-Id: Ida4c5014538454b845d19f74d27548c8f9540de8 Reviewed-on: https://gerrit.libreoffice.org/82470 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-11sc: rowcol: tdf#50916 convert mark data structuresNoel Grandin
Change-Id: I9b706c9bcc2925f72cc024142ffe72af5ddea82a Reviewed-on: https://gerrit.libreoffice.org/82419 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-11cid#1455327 Dereference null return valueCaolán McNamara
Change-Id: I336659e820d46e8b23881fdf9d5f3b6fac072771 Reviewed-on: https://gerrit.libreoffice.org/82429 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-09tdf#121239 set double underline status to false when not double underlinedCaolán McNamara
Change-Id: I0d609b8e6cd205e4d0c530d4a9111c0640f89b2c Reviewed-on: https://gerrit.libreoffice.org/82360 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-08jsdialogs: apply .uno:FillColor in CalcSzymon Kłos
Change-Id: I7cbd447c8a66f9240d6a093c9ab24a7c2dbb2024 Reviewed-on: https://gerrit.libreoffice.org/82293 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/82306 Tested-by: Jenkins
2019-11-08Resolves: tdf#128667 crash in csv import from pasteCaolán McNamara
Change-Id: Id50d0a7e4f176ccf83292495cb229da492fbf381 Reviewed-on: https://gerrit.libreoffice.org/82287 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-08jsdialog: apply .uno:XLineColor in CalcSzymon Kłos
Change-Id: I6951241444a3dec4f81bcd121b5c2917895456a3 Reviewed-on: https://gerrit.libreoffice.org/82279 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/82289 Tested-by: Szymon Kłos <szymon.klos@collabora.com>
2019-11-08jsdialog: apply .uno:LineWidth in CalcSzymon Kłos
Change-Id: I2d3bc18d7e687547ec840840111af83b171499c7 Reviewed-on: https://gerrit.libreoffice.org/82278 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> (cherry picked from commit 695745c8bf947409b731e2feeac615ee25d41b01) Reviewed-on: https://gerrit.libreoffice.org/82283 Tested-by: Jenkins
2019-11-07Show highlight ranges when chart is selectedSzymon Kłos
Change-Id: Ibb9a085699065869a7f122f37a36c5873b934271 Reviewed-on: https://gerrit.libreoffice.org/82138 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/82140 Tested-by: Jenkins
2019-11-06loplugin:unnecessaryvirtualNoel Grandin
Change-Id: Ibffbd0f5d30ec14cace3638b2bb47c91a583711c Reviewed-on: https://gerrit.libreoffice.org/82171 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-06jsdialogs: .uno:Color with string argument in CalcSzymon Kłos
Change-Id: I93ac635fc16a74cfc7a956be6d6529b4d692101b Reviewed-on: https://gerrit.libreoffice.org/82152 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2019-11-06loplugin:unusedvariablecheck tweak to find more stuffNoel Grandin
but leave the tweak commented out, since it generates false positives Change-Id: Iaf3f92414d2618f8780561f98765e33e282afe0c Reviewed-on: https://gerrit.libreoffice.org/82121 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>