summaryrefslogtreecommitdiff
path: root/sc/source/ui
AgeCommit message (Collapse)Author
2015-06-21Fix typosAndrea Gelmini
Change-Id: I2297bf392a405f02be2450f4624f1c9fc0b512ce Reviewed-on: https://gerrit.libreoffice.org/16373 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-06-20tdf#83859: Make arrow keys work again in named ranges dropdownKatarina Behrens
Regression from ed6b8c9f8d1b93230 which slightly changed the logic and set bHandled to true by default, thus effectively throwing all key press events except for Enter and Esc away. Set key press events (minus Enter & Esc) to bHandled = false and let them fall through to be dealt with in the base class (ComboBox) Change-Id: Ie1d857725a7de1d0bed1fd59df7eef5390ae5f3d
2015-06-19rendercontext: Fix crash with double-buffering in the Styles combo box.Jan Holesovsky
Decouple the actual window from rendercontext in UserDrawEvent. Change-Id: Ic440c4e7f59fcffb7800c578146e8eb528cbb7b4
2015-06-18Fix typosAndrea Gelmini
Change-Id: Ibfa971952cd330ddf430e7e951c5c235d2ae6bd8 Reviewed-on: https://gerrit.libreoffice.org/16314 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2015-06-17Replace boost::scoped_array<T> with std::unique_ptr<T[]>Takeshi Abe
This may reduce some degree of dependency on boost. Done by running a script like: git grep -l '#include *.boost/scoped_array.hpp.' \ | xargs sed -i -e 's@#include *.boost/scoped_array.hpp.@#include <memory>@' git grep -l '\(boost::\)\?scoped_array<\([^<>]*\)>' \ | xargs sed -i -e 's/\(boost::\)\?scoped_array<\([^<>]*\)>/std::unique_ptr<\2[]>/' ... and then killing duplicate or unnecessary includes, while changing manually m_xOutlineStylesCandidates in xmloff/source/text/txtimp.cxx, extensions/source/ole/unoconversionutilities.hxx, and extensions/source/ole/oleobjw.cxx. Change-Id: I3955ed3ad99b94499a7bd0e6e3a09078771f9bfd Reviewed-on: https://gerrit.libreoffice.org/16289 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-06-16Fix typosAndrea Gelmini
Change-Id: Id8c7cf460cba5af89891c470e1aaa61b227d356e Reviewed-on: https://gerrit.libreoffice.org/16310 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-06-16Fix typosAndrea Gelmini
Change-Id: Icfb885b72d51edc886851cf503c56fa12b8f559f Reviewed-on: https://gerrit.libreoffice.org/16309 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-06-16Fix typosAndrea Gelmini
Change-Id: I28cfc629dc3d6ef54128615452667ccce86c1072 Reviewed-on: https://gerrit.libreoffice.org/16297 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-06-16Fix typosAndrea Gelmini
Change-Id: Ieaf67cf597e05dbae5affa153af907fda4462a41 Reviewed-on: https://gerrit.libreoffice.org/16295 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-06-15remove unnecessary check for null when calling deleteNoel Grandin
Idea originally from caolan. Found using the following command: find . -name *.cxx | xargs /opt/local/bin/grep -zlP '(?m)if\s*\(\s*\w+\s*\)\s*delete\s+\w+\;' Change-Id: I3338f4e22193a6dfd6219c8c75835224a3392763
2015-06-15cppcheck:unreadVariableNoel Grandin
Change-Id: I03981ceba67280e8ed98a9add7f24b3bd958d522
2015-06-15cppcheck:redundantAssignmentNoel Grandin
Change-Id: I1167d0ce6b6f6e48309d0551c1d2a283d79546a7
2015-06-15cppcheck:redundantConditionNoel Grandin
Change-Id: Ib8b6342d1da526df6104125ded546b3f053c448b
2015-06-14cppcheck: redundantCondition [part1]Julien Nabet
Change-Id: I21c5340e7b5ec09248b08aa76f43acf883c56cd8
2015-06-12FLOOR.MATH has 3 parameters, show them in UIEike Rathke
Change-Id: I04a3990b90bd84c680df56ab6a5dc9eca575e696
2015-06-11tdf#69552 [part 2] support all ODFF1.2 and Excel2013 variationsWinfried Donkers
of CEILING and FLOOR Change-Id: I9537d9bd8dbca2eac769e74e9d3d5b298b76f594 Reviewed-on: https://gerrit.libreoffice.org/16016 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2015-06-11convert expressions like 'size() == 0' to 'empty()'Noel Grandin
Change-Id: Ia5c8c0f38a347f398d587970a22e03f29ffd37af
2015-06-11loplugin:staticmethodsStephan Bergmann
Change-Id: If54b3017296f5bcea01b3b0d24d9ac821f6a24e9
2015-06-10coverity#1302618 deref of NULLCaolán McNamara
on examination this PreparePaint virtual is only called from SvTreeListBox::PaintEntry1 and PaintEntry1 is only called from SvImpLBox::Paint in a for(sal_uInt16 n=0; n< nCount && pEntry; n++) { /*long nMaxRight=*/ pView->PaintEntry1 loop so pEntry always exists given that test. Re-jig things so these families of method take a reference instead of a pointer so verifying it cannot be NULL and a whole pile of else paths fall away Change-Id: Ied40acb1c2263c21b4447832f8cb86f64ed9e80d
2015-06-10tdf#89972: also copy external reference statusMike Kaganski
fixes regression from commit 4467c67dc8bf17c67c70985c0d0ea64636884f9f, where the new optimized code path failed to properly register ScFormulaCell with ScExternalRefManager. Introduces a new public method in ScExternalRefManager: insertRefCellAsTmpl that registers a formula cell to listen to the same external references as template cell Introduces new property to ScFormulaCell: mbIsExtRef that indicates that some external references are referenced by this cell Also introduces new method ScExternalRefManager::hasCellExternalReference (for use in unit test, will be posted immediately) Change-Id: Iee07d7b51949fd31953b5fa662a213052eb85181 Reviewed-on: https://gerrit.libreoffice.org/16066 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2015-06-10sc tiled editing: Mapping has to be turned off after drawing the buttons.Jan Holesovsky
Otherwise the redlines are on wrong positions in the tiled rendering case. Also - we are actually never call with something else than MAP_PIXEL, so let's kill the resetting of the mapmode; let's see if some obscure corner case bites us here. Change-Id: I8da07dd5448b8863df3148882ec50e6746760cca
2015-06-10Enablaed -> Enabled.Jan Holesovsky
Change-Id: Ia73ae54068d208d6b2db3439f38402664bfa8d29
2015-06-10sc tiled editing: Corrected dropdown button offsetHenry Castro
Change-Id: Ieff88d5de119db30c3fbd2f58ba52696eeb3d327
2015-06-09calc mapmode: Convert ScOutputData::DrawGrid to draw in logic units.Jan Holesovsky
Change-Id: Ie641c31e9023accf9d6bc510f8ca0b25ced3031b
2015-06-08loplugin:cstylecast: deal with remaining pointer castsStephan Bergmann
Change-Id: I700b727c048aff5c19411fb9d5bd9601b296cb06
2015-06-08\<the the\> -> theJan Holesovsky
Change-Id: I9d820446411eb7dfca37bb3baf5e994f4ba6f421
2015-06-06Apply new VclPtr clang plugin to catch potential problems.Noel Grandin
Omit the plugin, and sw's FrameControlsManager for now. Change-Id: Ifb98a2e6e03a9d099efc1668305b96bd9142ca5f Reviewed-on: https://gerrit.libreoffice.org/16117 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2015-06-05CALC: readd InsertRows/InsertColsPhilippe Jung
Following ESC decision, uno commands InsertRows / InsertColumns must be added to the current one InsertRowsBefore / InsertColumnsBefore and InsertRowsAfter / InsertColumnsAfter. This will guarantee ascending compatibility while making more explicit the behaviour thanks to the new commands. For Calc, these commands are equivalent to InsertxxxBefore Change-Id: I3aada5c9b03c504e6728c33cad2b2d569df1d60a Reviewed-on: https://gerrit.libreoffice.org/16099 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Philippe Jung <phil.jung@free.fr>
2015-06-04sc tiled editing: Editview register LOKit callbackHenry Castro
Change-Id: I5ad07f0f3defacaac0f5dac724e9867bbc011dd6
2015-06-04sc tiled editing: double-click empty cellHenry Castro
Change-Id: I35c43e2a22ac6591a2bcf9857808503c0e111344
2015-06-04sc tiled editing: EndTracking trigger MouseUpHenry Castro
It does not need to trigger fake MouseUp event Change-Id: Id90c7787ef3312abe81bce359648aee0dfccd905
2015-06-04Don't downcast this to derived in base ctorStephan Bergmann
Change-Id: I1a0a6a7f0ac2292a7824bd35967140a20ee93f89
2015-06-03calc mapmode: Refactor DrawDocumentBackground to use logic unitsKrisztian Pinter
Change-Id: I316e51bac78981263bfbee55ea5b684a40b44afa
2015-06-03tdf#91726: AutoFormat: Crash when using an existing nameJulien Nabet
Add a test to check if name already exists Change-Id: Ie23de04c0b747f58ab61a6e498bf212bf38b346a Reviewed-on: https://gerrit.libreoffice.org/16000 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-06-03intermittent CppunitTest_sc_macros_test failureCaolán McNamara
void OutputDevice::acquire() const: Assertion `mnRefCnt>0' failed" Window gets destroyed between postWindowResizeEvent and processWindowResizeEvent Change-Id: I3452a23ad8c3b6d863a56b73166520ef103dad1b
2015-06-02tdf#90888:Shrink the properties sidebar sections in CalcRishabh Kumar
Removal of less used controls Change-Id: I2948e6582031db1f743af59fb1ae02c1a86467f4 Reviewed-on: https://gerrit.libreoffice.org/15935 Reviewed-by: Yousuf Philips <philipz85@hotmail.com> Tested-by: Yousuf Philips <philipz85@hotmail.com>
2015-06-02loplugin:loopvartoosmallNoel Grandin
Change-Id: Ib4def3435eab4625645c5afe3b151f9f430564ac
2015-06-02loplugin:cstylecast: deal with those that are (technically) const_castStephan Bergmann
Change-Id: I23f887e88ad21b715e62b05ac6874ab88597ea90
2015-06-02tdf#91641 EditLine should have focus on accessibleText init.Justin Luth
The first time an accessibleEdit is created, it didnt recognize any focused text when editing in the "Input Line". Change-Id: I5aff199c10313d9c51ea15541a825cfbfd7ad374 Reviewed-on: https://gerrit.libreoffice.org/15962 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-06-01Reorganize the entries in the column and row context menusYousuf Philips
Change-Id: Ia833a7ca147b9a2730715de14cc18f6d839cdb2a Reviewed-on: https://gerrit.libreoffice.org/16012 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Yousuf Philips <philipz85@hotmail.com>
2015-06-02move header file out sc/incMarkus Mohrhard
Change-Id: I1b8e94612ffb4cf71bb16b424af37f4f8781775f
2015-06-02remove unused includeMarkus Mohrhard
Change-Id: I2dd5d2c87849c27ed96890699e326a26a19b14a4
2015-06-01loplugin:loopvartoosmallNoel Grandin
Change-Id: Iafe55d4aa65a380d8d338edd54338f53a3e920dc
2015-05-31Calc: Insert row/col before/after [2/2]Philippe Jung
This part adds features to add rows/cols after the selection which is a new behaviour. Change-Id: Iec1201ae56970cd3dd0622c2ffa1eb6e46ad7446 Reviewed-on: https://gerrit.libreoffice.org/15831 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Yousuf Philips <philipz85@hotmail.com>
2015-05-31Calc: Insert row/col before/after [1/2]Philippe Jung
This part renames all INSROW / INSCOL to INSROWS_BEFORE / INSCOLS_BEFORE which is the current (default) behaviour. Change-Id: Ia084f17a3be8bf09908e5d227ef4e6d09b8420a4 Reviewed-on: https://gerrit.libreoffice.org/15830 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Yousuf Philips <philipz85@hotmail.com>
2015-05-30Implemented formula group count statisticBenjamin Ni
Change-Id: I8b9c11fdd4b6e4343b467f1e5b1d1e96f1dd3140 Reviewed-on: https://gerrit.libreoffice.org/15927 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2015-05-29sc: SvxSearchItem, m_nStartPoint{X,Y}Henry Castro
The idea is that if you have your cursor at the begining of a Calc document, and you scroll down a lot, then search, then it's annoying that search jumps back to the start of the document for the first hit. Add an optional way to provide what is the starting point of such a search, so we can have "when nothing is selected, then search from the top left corner of the visible area". Change-Id: I22624dd52a093759d46541e003d838aeb0db943f
2015-05-29tdf#91702 - fix stack-based MessBox allocation.Michael Meeks
Change-Id: I62dd164e281911d9db3de453789a5badc7cd5fd7 Reviewed-on: https://gerrit.libreoffice.org/15954 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2015-05-28Bug 91489 - CONDITIONAL FORMATTING: Crash on select Icon Set from dialogPhilippe Jung
Removed the recalcAll line in IMPL_LINK_NOARG( ScIconSetFrmtEntry, IconSetTypeHdl ) 1) ScCondFormatList already calls RecalcAll on selection new/changed 2) Without this line, it does not crash Change-Id: I8aa45f691d33d8ad046a88e7695913e2ccff3caf Reviewed-on: https://gerrit.libreoffice.org/15928 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> Tested-by: Katarina Behrens <Katarina.Behrens@cib.de>
2015-05-28Resolves: tdf#90960 toggle out of paste-mode on editing an objectCaolán McNamara
otherwise pressing return in the object goes to the sheet and attempts to paste over the current cell reproduce with insert->comment in A1, insert some text and click in e.g. A5, ctrl c, right click on A1 and show comment, double click on comment to edit, go to end of text and press enter, either "bad things happen" if a11y is enabled , or "nothing happens" instead of a new line appearing in the object Change-Id: Ie44851cf3394652e1a60eecb59a999889094b3c5
generated by cgit (git 2.34.1) at 2025-01-22 01:04:56 +0000