summaryrefslogtreecommitdiff
path: root/sc/source/ui
AgeCommit message (Collapse)Author
2016-03-02loplugin:unuseddefaultparams in sc (part1)Noel Grandin
Change-Id: Ie7c23bfee7cb6c73e455a47801f7eb1b481a8cf0
2016-03-02loplugin:unuseddefaultparam in sfx2Noel Grandin
Change-Id: I37afde801a6468c79259fe51acbdea0614c2c8c5
2016-03-01ccu#1573 sc lok: fix reporting of hidden row heightMiklos Vajna
For columns we use ScDocument::GetColWidth(), which returns 0 for hidden columsn. Do the same for rows: so instead of using GetOriginalHeight(), use GetRowHeight(), and then 0 size will be reported for hidden rows as well. Change-Id: Ic23b6af744bbc8e194e1906614adebe5ba0c7ced
2016-02-29fix error in new cell dump property codeMarkus Mohrhard
It is also ALT+CTRL+SHIFT+F9 for now. Change-Id: Ic632ae070118e5c4083f47302b8b0086ccebdcd2
2016-02-29loplugin:nullptrNoel Grandin
Change-Id: I318a669d8b6b26c179111f887e13da784385a4ac
2016-02-29Related: tdf#89646 sc: Fix some issues with the new toolsMaxim Monastirsky
- Fix default object creation (by holding CTRL). - Fix Polygon (45°) tools (inverted SHIFT effect via doConstructOrthogonal). - Toolbar layout similar to Impress/Draw. Change-Id: Ib4e4aec1560599201c00e0726c29021763d773ad
2016-02-28tdf#89646 Implement "uno:LineToolbox" command into calc.Gulsah Kose
Freeline filled, Polygon filled, Bezier Filled, Polygon 45, Polygon 45 filled buttons are added into writer's LineToolbox. Change-Id: I181d3cbc64a70ef1ef363b1ef76641b6b8ec2c79 Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/22748 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2016-02-28move the cell property dump code into dbgutil buildsMarkus Mohrhard
We now allow with a CTRL+SHIFT+F9 to dump the cell properties as a xml file. Change-Id: I730e7009bbe95d3105541a9afbd2c8a19c992600
2016-02-28tdf#97667 Added a dump method for SfxItemSet in gridwin.cxxJaskaran
This is the first part of solving the task at tdf#97667. The goal is to dump SfxItemSet where our cell properties are stored.Improved it after inputs from moggi.Also I've commented out a few lines in gridwin_dbgutils.cxx That were causing build to fail on jenkins.Once the dump function is moved to the DBG_UTIL Change-Id: I502eaa985b3bf8d296e301d96e42f13d6fd53da5
2016-02-28tdf#97963: Impose size limit on all 3 edit windowsKatarina Behrens
Doing it for 1 window (tdf#90257) isn't enough, the dialog will grow outta screen with large fonts not immediately, but on the next opening Change-Id: I890ecd91a00efc4c7596b30a237f5abb4f87215a Reviewed-on: https://gerrit.libreoffice.org/22739 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2016-02-27tdf#97906 : Toggle reference and show data sources shortcutsDennis Francis
In Default mode : F4 = Toggle reference Shift F4 = Toggle reference Ctrl+Shift+F4 = Show data sources (both Mac and non Mac) In Legacy mode : F4 = Show data sources Shift F4 = Toggle reference Change-Id: Ifb53bfa671f212d73ebb8c3f80ed5c498d517d4d Reviewed-on: https://gerrit.libreoffice.org/22728 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-02-26handle SearchWildcard API optionEike Rathke
Change-Id: I5350167638a5831e1f125728397fecfc637ee004
2016-02-22add wildcards to Tools->Options->Calc->Calculate dialog, tdf#72196Eike Rathke
Maybe this should be a radio button instead (wildcards/regex/literal), on the other hand it reflects the two API bool values. Also only two checkbox lines are needed instead of three radio button lines. Change-Id: I3fa74e19c838e10dc0cffd6c0ad6329017e10e56
2016-02-22Pick a single place to declare SfxObjectShellRef typedefStephan Bergmann
Change-Id: Ie949f4d9002beefb810c87cdd44bf59f575da101
2016-02-22loplugin:commaoperator in sc/Noel Grandin
Change-Id: Id3f21f80c1ce83293d10c29c8035a0e74e076f80
2016-02-22Missing dispose of dialogStephan Bergmann
...causing crash later at > SfxItemPool::GetFrozenIdRanges() const > SfxItemSet::~SfxItemSet() > SfxTabDialog::dispose() > ScRefHdlrImpl<ScValidationDlg, SfxTabDialog, false>::dispose() > ScValidationDlg::dispose() > OutputDevice::disposeOnce() > VclPtr<vcl::Window>::disposeAndClear() > vcl::LazyDeletor::~LazyDeletor() > vcl::LazyDelete::flush() > ImplYield(bool, bool, unsigned long) > Application::Yield() Change-Id: Ia4ae95cbbf4b5660ed08058b67ab674029c0b437
2016-02-21tdf#93837 Convert RID_FM_TEXTATTRIBUTE_MENU to xmlMaxim Monastirsky
Change-Id: Ic37bfb9e25eba9b03b2c896c904823aec478355e
2016-02-20use O(n) algorithm to change all autofilter entriesMarkus Mohrhard
Change-Id: Iae80c0c23b15a9c2ba0cd4913d6e22dc4c3a1816 Reviewed-on: https://gerrit.libreoffice.org/22516 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-02-20use calc brace styleMarkus Mohrhard
Change-Id: I96d05359308f38d6952137bc0b326505bba47c89 Reviewed-on: https://gerrit.libreoffice.org/22515 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-02-20add missing IsFormulaWildcardsEnabled() calls, tdf#72196Eike Rathke
Change-Id: Ia684cfe93c6a0e71a0fbbe22974501bf610e9190
2016-02-20add Wildcards UNO API implementation, tdf#72196Eike Rathke
Change-Id: I3dbca9661b55596484ac77f92243fd463fa01ec9
2016-02-19new loplugin: find write-only fieldsNoel Grandin
Change-Id: I0f83939babacf92485420ee63f290a297d7cb717 Reviewed-on: https://gerrit.libreoffice.org/22498 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-19editeng: remove never read mpLibreOfficeKitCallbackMiklos Vajna
As all callback invocations happen with SdrModel's callback pointer. Change-Id: I0111040c501b7927332f88cc4797b8ebab2bc57a
2016-02-19change all bool bRegExp to utl::SearchParam::SearchType enum, tdf#72196Eike Rathke
Later inspect all places that use utl::SearchParam::SRCH_REGEXP if and how to use utl::SearchParam::SRCH_WILDCARD as well. Change-Id: I6ad4e5dea3cd656fd670f2281aaceec817953211
2016-02-18don't fill the matrix cell by cell, tdf#67071Markus Mohrhard
We are now at a place where filling one cell takes about a second with the big document. We could in theory for the special case of this document add some caching but that would fail in other cases. This document is already quite large with an external reference to 70k cells for each formula cell. I consider it already quite nice and useable again. Change-Id: I804094838471507e6bb7b0e0e3387e0c7fe53e4b Reviewed-on: https://gerrit.libreoffice.org/22388 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-02-17gtk3: use native GtkPopover for calc formula prompt, etcCaolán McNamara
Change-Id: I9aa7e977228780b6273daa03be5e872342414437
2016-02-17use consistent #define checks for the Windows platformNoel Grandin
stage 2 of replacing usage of various checks for the windows platform with the compiler-defined '_WIN32' macro In this stage we focus on replacing usage of the WIN macro Change-Id: Ie8a4a63198a6de96bd158ecd707dadafb9c8ea84 Reviewed-on: https://gerrit.libreoffice.org/22393 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-17tdf#91013 Add new uno commands to freeze one row and column.Gulsah Kose
Added freezepanesfirstcolumn and freezepanesfirstrow commands. FreezePanes button became a split button that includes this two new uno commands. And this new commands added to menu. Change-Id: Ic6958067cc98b3df50bcd06a1eac220bd9a61473 Reviewed-on: https://gerrit.libreoffice.org/21604 Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com>
2016-02-16loplugin:implicitboolconversionStephan Bergmann
Change-Id: Ib21fe1f18a48246fc38c8c26454c28de2efc699f
2016-02-16sc lok: Handle left mouse button up events for tiled renderingPranav Kant
This solves two common problems: 1) Allow selections via mouse drag 2) Deselect when clicked inside already selected block of cells Change-Id: I9c1b5f90b6c4dc6155b14c68852d6cad81e2290a Reviewed-on: https://gerrit.libreoffice.org/22391 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2016-02-16coverity#1352645 Uncaught exceptionCaolán McNamara
and coverity#1352646 Uncaught exception coverity#1352647 Uncaught exception Change-Id: Ic96e93d219476eeb458ddab6372368f91bbd0398
2016-02-16single element access is really slow in mdds, tdf#67071Markus Mohrhard
Change-Id: I5491ba0bc44a9ce8844b31126835671c5d5abcaa Reviewed-on: https://gerrit.libreoffice.org/22386 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-02-16sc lok: Notify LibreOfficeKit of empty selectionPranav Kant
Change-Id: Ib77f2e008473a18460e7783b20ef3237ff885d57 Reviewed-on: https://gerrit.libreoffice.org/22387 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: David Tardon <dtardon@redhat.com>
2016-02-16declare variable when using itMarkus Mohrhard
Change-Id: I7df457dfa3f1d36641c577f353a50e03c37cb09b Reviewed-on: https://gerrit.libreoffice.org/22382 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-02-14coverity#1352451 Uncaught exceptionCaolán McNamara
and coverity#1352452 Uncaught exception coverity#1352453 Uncaught exception Change-Id: I100aa7ebf729bfe2e379e28891f5cd217d4187cc
2016-02-10Refactor ScMarkData for tdf#50916Dennis Francis
Made the container for storing multimarks dynamic. Also let the full row marks to be stored in a dedicated ScMarkArray object rather than in the multimarks container. Unit tests for ScMarkData and ScMultiSel will come in a follow up patch. Change-Id: I300ff80bebd6f4f39c284c1e8cb7deece82c1bec Reviewed-on: https://gerrit.libreoffice.org/22163 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-02-09Remove excess newlinesChris Sherlock
A ridiculously fast way of doing this is: for i in $(pcregrep -l -M -r --include='.*[hc]xx$' \ --exclude-dir=workdir --exclude-dir=instdir '^ {3,}' .) do perl -0777 -i -pe 's/^ {3,}/ /gm' $i done Change-Id: Iebb93eccbee9e4fc5c4380474ba595858a27ac2c Reviewed-on: https://gerrit.libreoffice.org/22224 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-02-09Formatting changes across all modulesChris Sherlock
+ Removed comment cruft + Tab formatting in number of files + Some commented out code removed + Tab characters replaced with spaces + Newline cleanup in quite a few files + Tweak header guard #endifs Change-Id: I3208ff2f047da890edcc49b73389aca22442f5fc Reviewed-on: https://gerrit.libreoffice.org/22221 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-02-08svx: SdrModel::mbTiledRendering is never readMiklos Vajna
Change-Id: I8571032b5c43a47872cb3364613ffb936624aa2d
2016-02-06lok: Search result should contain info if it is a 'search all' result.Jan Holesovsky
Change-Id: Ia3ee81ced4f74c0d029a478bd59eff44d72ef327
2016-02-06vcl: bmpacc.hxx -> bitmapaccess.hxxChris Sherlock
Change-Id: I4bb19d6103c4a6a902d86b62a857e3478493924c
2016-02-05coverity#1351877 'Constant' variable guards dead codeCaolán McNamara
and coverity#1351882 Useless call sigh, silly me regression from commit 2ce227a7642647267c982909a8b3175d22c58b74 Author: Caolán McNamara <caolanm@redhat.com> Date: Thu Feb 4 09:17:42 2016 +0000 coverity#1351755 Dereference null return value Change-Id: I6d6841d04f9bba68ec2077d874dcd24edbf4ab6c
2016-02-05Resolves: tdf#97465 like scroll ignore wheel for sc input handler inputchangedCaolán McNamara
Change-Id: Ide7fe1388ffe6f85a1f459037316d03193470d8a
2016-02-05Fix typosAndrea Gelmini
Change-Id: Ice72f8d9971e15dd6ef365e64cd567b8581a92d3 Reviewed-on: https://gerrit.libreoffice.org/21797 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2016-02-05vcl: remove VCL_INPUT_MOUSEANDKEYBOARD, not necessaryChris Sherlock
Change-Id: Ia5b9581d06f6884d6a06abde9cb4039b64c29a05
2016-02-04show parameter tip help below instead of above, tdf#95878 follow-upEike Rathke
Showing it above obstructs the column headers when entering a formula in the first two rows and mouse selection on column headers is also not possible. Change-Id: I8261f234fe7ed8f329ea7a131eb675e86e1d7988
2016-02-04tdf#65206 Highlighted (colored) references limited to 32 references in formulaKumar Thangavel
Change-Id: I45731be3d7c3a8ebbafb11d8580294dab01784f4 Reviewed-on: https://gerrit.libreoffice.org/22094 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-02-04coverity#1351755 Dereference null return valueCaolán McNamara
Change-Id: I144a2c498763534b8aff604bdb3440180ac0f2ff
2016-02-04pItem isn't used here, its the same as result, so weird cast can goCaolán McNamara
Change-Id: Ib646fcffa3d2298b06565ef78b69873546d76b0a
2016-02-04vcl: take into account the font width is the average font widthChris Sherlock
I'm changing the Font class function names: - SetSize -> SetFontSize - GetSize -> GetFontSize - SetHeight -> SetFontHeight - GetHeight -> GetFontHeight - SetWidth -> SetAverageFontWidth - GetWidth -> GetAverageFontWidth That's because it really makes no sense to say that there is a single constant font width because obviously proportional fonts don't have one - the best we can do is an average font width, which is what folks like Microsoft sort of do already. On a fixed font, the average is still accurate, for obvious reasons :-) I'm also not a fan of GetSize/SetSize as I find it a might too generic. Change-Id: Ib80a604ba62d6883fd6cbc7994da763976be5c70 Reviewed-on: https://gerrit.libreoffice.org/22069 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>