summaryrefslogtreecommitdiff
path: root/sc/source/ui
AgeCommit message (Collapse)Author
6 daysjsdialog: send cell address on startup with jsdialog tooSzymon Kłos
When loaded, LOK_CALLBACK_CELL_ADDRESS is called in: libsclo.so!ScInputHandler::NotifyChange(ScInputHandler * this, const ScInputHdlState * pState, bool bForce, ScTabViewShell * pSourceSh, bool bStopEditing) libsclo.so!ScTabViewShell::UpdateInputHandler(ScTabViewShell * this, bool bForce, bool bStopEditing) libsclo.so!ScInputWindow::ScInputWindow(ScInputWindow * this, vcl::Window * pParent, const SfxBindings * pBind) libsclo.so!VclPtr<ScInputWindow>::Create<vcl::Window*&, SfxBindings*&>(SfxBindings *& arg, SfxBindings *& arg) but we didn't allow the same for SetPosString which was called in the neighbouring place Signed-off-by: Szymon Kłos <szymon.klos@collabora.com> Change-Id: I9cec1b05d5d9b31c352d99bcb92045ead618a3d8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175192 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175301 Tested-by: Jenkins
9 dayscrashreporting: more checks of pActiveViewShXisco Fauli
See https://crashreport.libreoffice.org/stats/signature/ScInputHandler::SetMode(ScInputMode,rtl::OUString%20const%20*,ScEditEngineDefaulter%20*) Change-Id: Ib0a07f4ee8d7da05960eaac14af561a6b624b0d5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179263 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins
9 dayscrashreporting: check pActiveViewShXisco Fauli
See https://crashreport.libreoffice.org/stats/signature/ScInputHandler::UpdateFormulaMode() Change-Id: I87ccb3c07b08ebe0a77b1ebb6a5f4e8c2ea89894 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179259 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins
9 daysoptimise ScBoundsProvider::GetIndexTowardsNoel Grandin
Especially when laying out rows in sheets with thousands of rows. By pushing the work down to a new GetRowForHeightPixels method, we can do the work in only a couple of iterations of the loop, because row heights are normally represented by only a few spans. Change-Id: If3f62a131a3e7a0794d7352d7c6c1a5de0ef2df0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179086 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
9 daystdf#42989: don't set fake ATTR_VALUE_FORMAT for multi-format selectionMike Kaganski
Change-Id: Iaed133b19c4d870ff85fd9d2dd69db36318bb28e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179190 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
11 daysSimplify abstract dialog impls using vcl::AbstractDialogImpl* in scMike Kaganski
Change-Id: Iff9ac377a5cfa259c5911632ad16d2b1e3269868 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178986 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
12 dayssc: fix: can't switch focus from font menu back to edit windowRashesh
- Steps to reproduce: 1. Open Calc 2. Put the cursor in the font selection field, and type 3. Try to move the cursor back to the sheet and to type Change-Id: I596e5380d38f761a310c2a363389b0b03a0e94ae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178787 Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> (cherry picked from commit 2c95e7186e053ed5f2e7d8388fbe087fa60636c2) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178796 Tested-by: Jenkins
12 dayssc: fix: unnecessary updates to ScPosWnd when named range are emptyRashesh
- follow up 115776004c875b3a8a861d070129187c893b136a Change-Id: I57072d1999e703975a43dc50077698d4b28df461 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175869 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177646 Tested-by: Jenkins
12 dayssc: fix: unnecessary updates to ScPosWnd even if NamedRanges are sameRashesh
Change-Id: Idd32343f38d6294f5140835d99137dae9f1237ab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175061 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> (cherry picked from commit 115776004c875b3a8a861d070129187c893b136a) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177647 Tested-by: Jenkins
12 dayscool#10115 sc: enable ScPosWnd for lokit with jsdialogRashesh
Change-Id: I18829c48a2495e3aa31af83970c8c1c4791a170a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173987 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> (cherry picked from commit 9ffc274bbc414d1e98313af804386861beeff9bf) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177645 Tested-by: Jenkins
13 dayssc: autofill: no need to send deleted cell addressesBayram Çiçek
- with LOK_CALLBACK_TOOLTIP. we already send them with SendReferenceMarks (https://gerrit.libreoffice.org/c/core/+/176557) - also avoid warning "unknown tooltip type - CanvasTileLayer.js" on the console Signed-off-by: Bayram Çiçek <bayram.cicek@collabora.com> Change-Id: Id6e6d2c20c7b874d8d57324ed4dd3984a56ac398 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176565 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> (cherry picked from commit 02046576573e1547c7cd00cd17faffc87d1ede72) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178790 Tested-by: Jenkins
13 dayssc: send cell addresses of delete-by-autofillBayram Çiçek
with LOK_CALLBACK_REFERENCE_MARKS Signed-off-by: Bayram Çiçek <bayram.cicek@collabora.com> Change-Id: Ic991f1dd41b99cf6caca7dc408caaf6d4dfeac3c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176557 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> (cherry picked from commit c82ceac1cc544fe77f1ce8aaccc8baa0de938821) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178789 Tested-by: Jenkins
2024-12-18tdf#163395 tdf#153057 - sc fix standard filter problem with formattedBalazs Varga
values ScQueryEntry::ByValue was removed unnecessarily in the original patch, but it is necessary for filtering number values correctly. Regression from commit: 1f755525189884e4b2824889a6b9dea8933402db Change-Id: Ib013d971ad0b0809fc55949a6a2d9bf02418b516 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178690 Tested-by: Jenkins Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de> Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
2024-12-18use more concrete UNO in swNoel Grandin
Change-Id: Ie83d957349f123bca0fd46ce3144ce778c3ec101 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178704 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-12-18Resolves: tdf#156398 use same color combination as used in tdf#51300Caolán McNamara
so we don't get white text on yellow background Change-Id: I346decaab293e2bb15c1110dfa61df5838607d79 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178694 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-12-18tdf#163319 Do not decrement destination position when moving a tabAlin Andrei Abahnencei
to the right Signed-off-by: Alin Andrei Abahnencei <alinandrei2004@gmail.com> Change-Id: Id8da1a1b199927bb2f1b71b814737b8287ea2a34 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178362 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2024-12-17Port ScDataFormFragment to new weld::Grid APIMichael Weghorn
See previous commit Change-Id: I67f5ea16b5108e8359820850f0815e34db439ef1 Author: Michael Weghorn <m.weghorn@posteo.de> Date: Mon Dec 16 11:02:00 2024 +0100 weld: Add weld::Grid to handle grid child positions for more background. Change-Id: I1e0202182dc1f4f3136cfcabdb451ab52ee17294 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178625 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-12-17Port ScIconSetFrmtDataEntry to new weld::Grid APIMichael Weghorn
See previous commit Change-Id: I67f5ea16b5108e8359820850f0815e34db439ef1 Author: Michael Weghorn <m.weghorn@posteo.de> Date: Mon Dec 16 11:02:00 2024 +0100 weld: Add weld::Grid to handle grid child positions for more background. Change-Id: I310bade49f4732e1da34486dcfb2dc23a3c3ae0f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178624 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-12-17Port ScCondFrmtEntry to new weld::Grid APIMichael Weghorn
See previous commit Change-Id: I67f5ea16b5108e8359820850f0815e34db439ef1 Author: Michael Weghorn <m.weghorn@posteo.de> Date: Mon Dec 16 11:02:00 2024 +0100 weld: Add weld::Grid to handle grid child positions for more background. Change-Id: I0d808c4738e14321c9d0a9b022abd4d215030910 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178623 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-12-17Fix and port ScHFEditPage grid handling to new APIMichael Weghorn
The code was calling weld::Widget::get_grid_left_attach and weld::Widget_set_grid_left_attach on the wrong widgets that are not direct children of the grid, but children of the grid children, triggering these warnings with gtk3: (soffice:1996241): Gtk-WARNING **: 21:10:33.461: ../../../gtk/gtkcontainer.c:1206: container class 'GtkViewport' has no child property named 'left-attach' (soffice:1996241): Gtk-WARNING **: 21:10:33.461: ../../../gtk/gtkcontainer.c:1206: container class 'GtkViewport' has no child property named 'left-attach' (soffice:1996241): Gtk-WARNING **: 21:10:33.461: ../../../gtk/gtkcontainer.c:1348: container class 'GtkViewport' has no child property named 'left-attach' (soffice:1996241): Gtk-WARNING **: 21:10:33.461: ../../../gtk/gtkcontainer.c:1348: container class 'GtkViewport' has no child property named 'left-attach' (soffice:1996241): Gtk-WARNING **: 21:10:33.472: ../../../gtk/gtkcontainer.c:1206: container class 'GtkViewport' has no child property named 'left-attach' (soffice:1996241): Gtk-WARNING **: 21:10:33.472: ../../../gtk/gtkcontainer.c:1206: container class 'GtkViewport' has no child property named 'left-attach' (soffice:1996241): Gtk-WARNING **: 21:10:33.472: ../../../gtk/gtkcontainer.c:1348: container class 'GtkViewport' has no child property named 'left-attach' (soffice:1996241): Gtk-WARNING **: 21:10:33.472: ../../../gtk/gtkcontainer.c:1348: container class 'GtkViewport' has no child property named 'left-attach' To trigger: * start Calc with the gtk3 VCL plugin and SAL_RTL_ENABLED=1 * "Format" -> "Page Style" * select the "Header" tab page * click on the "Edit" button Fix this by assigning IDs for the GtkScrolledWindows that are actually the direct children of the grid and using these instead. Port to the new weld::Grid API instead of calling the methods directly on the weld::Widget children, see previous commit Change-Id: I67f5ea16b5108e8359820850f0815e34db439ef1 Author: Michael Weghorn <m.weghorn@posteo.de> Date: Mon Dec 16 11:02:00 2024 +0100 weld: Add weld::Grid to handle grid child positions for more background. Change-Id: I22c31a2f6b5eade56f6061023f5b914b615f4ba4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178615 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-12-11cid#1607842 Overflowed constantCaolán McNamara
Change-Id: I4768cf58a14c0664257b74160d0c09497efec574 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178075 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-12-10lok: calc: fix assertion on toggle autofilterSzymon Kłos
Steps to reproduce: Open attached spreadsheet type "date" in D1 type any date eg. 2020-02-02 in D2 Select all data visible ~ A1:D7 Insert -> Autofilter result: crash Signed-off-by: Szymon Kłos <szymon.klos@collabora.com> Change-Id: I53e794d644120c6a2a67453727f1206aa47aa9b7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175837 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178204 Tested-by: Jenkins
2024-12-09tdf#157747 Add tooltip to Calc select all rowsAdesola Samuel
Added a tooltip that says "Click here to select all cells" to calc select all rows corner. The report shows a tooltip will suffice instead of an added icon Change-Id: I33f9bcb48f9185267be760219f58b196e4d5874d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178092 Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Tested-by: Jenkins
2024-12-08Simplify ScCellRangesBase and descendantsMike Kaganski
Change-Id: I2416ab8a9263bd7858e0d62055067b3c6132e0b7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178093 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-12-08cid#1607247 Overflowed constantCaolán McNamara
Change-Id: I9648bc8a41a44a98fd8d0d78e889228948e38a34 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178045 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-12-08Simplify a bitMike Kaganski
Change-Id: I7ecbf2c1e4b08175dabd29782a40dd2f25fe040c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178058 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2024-12-07weld: Rename weld::Treeview selection signal/connectMichael Weghorn
Rename weld::TreeView member + methods to clarify that these are about selection changes: * m_aChangeHdl to m_aSelectionChangedHdl, * signal_changed to signal_selection_changed * connect_changed to connect_selection_changed In GtkInstanceTreeview, also rename the related methods calling signal_selection_changed accordingly for consistency. Change-Id: I299d7930484677395a0bdd0ff105df18688f2e04 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178023 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-12-06tdf#145538: Use range based for loopsSimon Chenery
Change-Id: I6f8539869b991c2c71044e1a18dba69641ffabe8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177505 Tested-by: Jenkins Reviewed-by: Hossein <hossein@libreoffice.org>
2024-12-05LOK: don't recreate the dialogs of an old view when loading new viewsPranam Lashkari
follow up for f5ebf512ccd3d5ae3af5fe706b411a85fa19182d now same actions are performed on all the dialogs Change-Id: I6531a766327dda106770a2c513ebd492dea7c655 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176933 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> (cherry picked from commit 2fba6df7242586870988b62909156538b42c2bc0) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177892 Tested-by: Jenkins
2024-12-05tdf#163419 Save import dialog window size and skip resizing separator optionsAvramoniu Calin
Signed-off-by: Avramoniu Calin <clavramoniu@gmail.com> Change-Id: Ib894b61edc15d4a89e7a83bb990a2819084879f4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177397 Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Tested-by: Jenkins
2024-12-05tdf#163752 fix: hide drag target border on cancellation of d&d operationAndre Herbst
Not relying on rData.pCellTransfer anymore since it is always null when rEvt.mbLeaving is true. Change-Id: I4755e8f9b62efacd2eb4d515e1993578beadef09 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175970 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-12-04Move helpers for css::awt/VCL point/rect/size to vcl::unohelperMichael Weghorn
Move helpers to convert between the Rectangle, Point and Size classes in vcl and in css::awt from VCLUnoHelper (in the toolkit module) to vcl::unohelper (in the vcl module), for reuse in vcl in upcoming commits. Change-Id: I7b11c8a6b8c843a01ce25b1e4c0fb1869ad1e6ee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177816 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-12-04tdf#158979 Add static variable for last used merge optionanonymotter
A static variable has been added so that, when merging cells in Calc where multiple cells have content in them, it will remember which of the three merge options was last used in a given session and automatically select that option the next time the merge cells dialog pops up. The default for the first merge in a session remains the option to keep the content of hidden cells. Change-Id: I35f6c01ffe9dff2756e3b9f5d530725e5d939db8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177455 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2024-12-04cid#1636562 Uninitialized scalar fieldCaolán McNamara
Change-Id: I4d9f76cc5cb767054e138819d2b8dd9032188c6c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177770 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-12-03Revert "sc: manage conditional format with simpler dialog"Pranam Lashkari
This reverts commit 58c3f70c514ef4ce0de5419ab7daa3bebfb96f37. Change-Id: I500a96508684547c158cdd1814540a4b24f667d9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177290 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177341 Tested-by: Jenkins
2024-12-03Revert "sc: added date condition option in conditional format manage dialog"Pranam Lashkari
This reverts commit 9928f1fa147d4ff838cbf6fcfe0d976ecef97cef. Change-Id: Ieb7dfdeccaffed4ad81ff9b5b0eb3b3b49fd8d05 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177289 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177340 Tested-by: Pranam Lashkari <lpranam@collabora.com>
2024-12-03Revert "sc: now formula conditions can be managedPranam Lashkari
...from condition format manager" This reverts commit 8374dd472cb4a2e2edab969a73ca88ffeaadbcd8. Change-Id: I532c17596adccfa5c88baaf2df897f3ffbee0fe6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177288 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177339 Tested-by: Pranam Lashkari <lpranam@collabora.com>
2024-12-03Revert "sc: preview style in easy format dialog"Pranam Lashkari
This reverts commit 2661be5f8fb28ada80b4f5336d59f54b520bf614. Change-Id: Ie3482641cbbb34baa866a679c782221d2d513df1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177287 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177338 Tested-by: Jenkins
2024-12-03Revert "sc: give warning about condition input in easy condition dialog"Pranam Lashkari
This reverts commit 2a6dc9dfd84b278352608f475a600e866846af2e. Change-Id: I061f8ebfbf0115dd55d357c325a3905c5a774a57 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177286 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177337 Tested-by: Jenkins
2024-12-03Revert "sc: display all the conditions of same rangesPranam Lashkari
...in conditional format manager" This reverts commit 399253ca8ca391504ff1f6a3709fb41d438ce2d6. Change-Id: I3c0a79ee0a34364d0a51ab4736810f35efe4bfdc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177285 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177336 Tested-by: Jenkins
2024-12-03Revert "sc: now conditions can be edited from easy conditional format dialog"Pranam Lashkari
This reverts commit 8115c82f1f7f2621e2d99c93e1a3b2196279602a. Change-Id: Ie3f389561ee8f734ac76b3dec352382281f91c30 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177284 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177335 Tested-by: Pranam Lashkari <lpranam@collabora.com>
2024-12-03Revert "sc: prefill easy condition dialog with editing condition data"Pranam Lashkari
This reverts commit 598e93b1b11f4cdff96f6117c2a7d35f3698fd23. Change-Id: Ifdbc8920f232d388eac2a07cd6e2e2dece204a7a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177283 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177334 Tested-by: Jenkins
2024-12-03Resolves tdf#127937 - Feedback for AutoCalculateHeiko Tietze
Shows an icon in the statusbar if autocalc is off; clicking the icon toggles autocalc on Change-Id: I7fb3296281647583f6f761427d35dcd79282f06c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177418 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-12-02loplugin:unusedmethodsNoel Grandin
Change-Id: I85ef1d4e9391e211c9e5e7ac6e9de875e9f5f5af Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177679 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-12-02sc a11y: Don't suppress a11y events when setting new posMichael Weghorn
Don't suppress a11y events when setting the new position string in the combobox in Calc's formula toolbar. Suppressing events was added in commit 38fe580341a3f1e379edada08db7e1aebab258f5 Author: Malte Timmermann [mt] <malte.timmermann@oracle.com> Date: Thu Jan 20 16:34:26 2011 +0100 accfixes: added more accessibility information and fixed tab orders in multiple dialogs (sc module) for unclear reasons. The only potential reason I can come up with could be to avoid announcement by screen readers, but they usually don't announce text/value changes to non-focused controls anyway, and neither Orca on Linux nor NVDA on Windows announcement changed with this change in place when moving focus between cells in Calc. Without this change in place, having the combobox's "text" child selected in Accerciser's treeview of LO's a11y hierarchy, the text shown in the "Text" interface section would not automatically update to display the newly selected location due to the missing event when using the qt6 VCL plugin. With this change in place, it is updated as expected. Change-Id: I88fe0e6ec9bb693710e3f7ab0c6c2e46686be720 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177638 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2024-11-30cid#1607542 COPY_INSTEAD_OF_MOVECaolán McNamara
and cid#1606986 COPY_INSTEAD_OF_MOVE cid#1557969 COPY_INSTEAD_OF_MOVE cid#1557837 COPY_INSTEAD_OF_MOVE cid#1557772 COPY_INSTEAD_OF_MOVE cid#1557735 COPY_INSTEAD_OF_MOVE cid#1557672 COPY_INSTEAD_OF_MOVE cid#1557664 COPY_INSTEAD_OF_MOVE cid#1557650 COPY_INSTEAD_OF_MOVE cid#1557642 COPY_INSTEAD_OF_MOVE cid#1557639 COPY_INSTEAD_OF_MOVE cid#1557628 COPY_INSTEAD_OF_MOVE cid#1557623 COPY_INSTEAD_OF_MOVE cid#1557581 COPY_INSTEAD_OF_MOVE cid#1557489 COPY_INSTEAD_OF_MOVE cid#1557473 COPY_INSTEAD_OF_MOVE cid#1557317 COPY_INSTEAD_OF_MOVE cid#1557261 COPY_INSTEAD_OF_MOVE cid#1557146 COPY_INSTEAD_OF_MOVE cid#1557135 COPY_INSTEAD_OF_MOVE cid#1557134 COPY_INSTEAD_OF_MOVE cid#1557079 COPY_INSTEAD_OF_MOVE cid#1557063 COPY_INSTEAD_OF_MOVE cid#1557052 COPY_INSTEAD_OF_MOVE cid#1556982 COPY_INSTEAD_OF_MOVE cid#1556977 COPY_INSTEAD_OF_MOVE cid#1556950 COPY_INSTEAD_OF_MOVE cid#1556943 COPY_INSTEAD_OF_MOVE cid#1556804 COPY_INSTEAD_OF_MOVE cid#1556736 COPY_INSTEAD_OF_MOVE cid#1556658 COPY_INSTEAD_OF_MOVE cid#1556621 COPY_INSTEAD_OF_MOVE cid#1556590 COPY_INSTEAD_OF_MOVE cid#1556579 COPY_INSTEAD_OF_MOVE cid#1556534 COPY_INSTEAD_OF_MOVE cid#1556524 COPY_INSTEAD_OF_MOVE cid#1556478 COPY_INSTEAD_OF_MOVE cid#1556467 COPY_INSTEAD_OF_MOVE cid#1556422 COPY_INSTEAD_OF_MOVE cid#1556314 COPY_INSTEAD_OF_MOVE cid#1556309 COPY_INSTEAD_OF_MOVE cid#1556258 COPY_INSTEAD_OF_MOVE cid#1556143 COPY_INSTEAD_OF_MOVE cid#1556119 COPY_INSTEAD_OF_MOVE cid#1556101 COPY_INSTEAD_OF_MOVE cid#1556097 COPY_INSTEAD_OF_MOVE cid#1556039 COPY_INSTEAD_OF_MOVE cid#1555966 COPY_INSTEAD_OF_MOVE cid#1555948 COPY_INSTEAD_OF_MOVE cid#1555915 COPY_INSTEAD_OF_MOVE cid#1555836 COPY_INSTEAD_OF_MOVE cid#1555748 COPY_INSTEAD_OF_MOVE cid#1555644 COPY_INSTEAD_OF_MOVE cid#1555582 COPY_INSTEAD_OF_MOVE cid#1555478 COPY_INSTEAD_OF_MOVE cid#1555475 COPY_INSTEAD_OF_MOVE cid#1555409 COPY_INSTEAD_OF_MOVE cid#1555372 COPY_INSTEAD_OF_MOVE cid#1555334 COPY_INSTEAD_OF_MOVE cid#1555330 COPY_INSTEAD_OF_MOVE cid#1555310 COPY_INSTEAD_OF_MOVE cid#1555257 COPY_INSTEAD_OF_MOVE cid#1555247 COPY_INSTEAD_OF_MOVE cid#1555147 COPY_INSTEAD_OF_MOVE cid#1555120 COPY_INSTEAD_OF_MOVE cid#1555059 COPY_INSTEAD_OF_MOVE cid#1555016 COPY_INSTEAD_OF_MOVE cid#1554880 COPY_INSTEAD_OF_MOVE cid#1554824 COPY_INSTEAD_OF_MOVE cid#1554808 COPY_INSTEAD_OF_MOVE cid#1546189 COPY_INSTEAD_OF_MOVE Change-Id: I2d2f33c603f1596228c9ecb169472ba6751e7826 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177593 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-11-30cid#1608320 COPY_INSTEAD_OF_MOVECaolán McNamara
and cid#1607135 COPY_INSTEAD_OF_MOVE Change-Id: If8f36744c53bb0515516a23589ffdb389aaec02c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177592 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-11-28sc a11y: Make 2 members non-mutableMichael Weghorn
... and use a non-const pointer when iterating instead. Change-Id: I165b0ce907cadacc76562bff974ff913a3a711da Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177480 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2024-11-28tdf#163913 Implement font-relative marginsJonathan Clark
This change adds loext:margin-left and loext:margin-right, which implement margins that support font-relative units. See tdf#36709 for additional details. Change-Id: I31b0dd2b6f98cb5b02fd4dca3608db6fdee4054c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177473 Tested-by: Jenkins Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
2024-11-28Simplify ScSubTotalParamMike Kaganski
Change-Id: I4c1840e377711ad065c3042bddacb2028481b88d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177433 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
generated by cgit (git 2.34.1) at 2025-01-01 18:49:12 +0000