summaryrefslogtreecommitdiff
path: root/sc/source
AgeCommit message (Collapse)Author
2015-09-19tdf#61908 OOXML export cell range for matrix/array formulaEike Rathke
Problem Description: - Matrix multiplication cell formula range is not exported after roundtrip. XML Difference: Original : <f t="array" ref="G5:G6">MMULT(A1:C2,E1:E3)</f> Roundtrip : <f aca="false">MMULT(A1:C2,E1:E3)</f> Solution : Added formula cell range support for matrix multiplication. Reviewed-on: https://gerrit.libreoffice.org/16033 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com> (cherry picked from commit beb8e2830dc9e1c771e196fcaf08cdfd6bf3dde3) Conflicts: sc/qa/unit/subsequent_export-test.cxx fix 176 unbalanced XML_f xlsx export failuires regression from commit beb8e2830dc9e1c771e196fcaf08cdfd6bf3dde3 Author: yogesh.bharate001 <yogesh.bharate@synerzip.com> Date: Tue Jun 2 16:39:09 2015 +0530 tdf#61908:XLSX formula cell range is not exported for MMULT. (cherry picked from commit 103b619401f06697255167c788192601e87758b9) array formulas do not consist only of multiple rows, tdf#61908 follow-up For example, {={1,2}*3} is a two columns one row vector, or even a single cell could hold an array formula. (cherry picked from commit 92df7db85a3da10f18a5a06fb53a9cb69910e835) a54ce5ce437e592378fe930b779c518de9670995 14a44ac8356fdffc98b7097f48319755f5f2f317 do not write MM_REFERENCE formulas to OOXML, tdf#61908 follow-up The array range is covered by MM_FORMULA. Excel even complained when loading such a document. (cherry picked from commit f501fe4da88e1d64fcc88a492a52911113d28f6a) Change-Id: Ic871f064a98a324bc16a4253b633c97417c3f900 10e1b19fbfb8ea849ffe3d46504fdf3389633c5f Reviewed-on: https://gerrit.libreoffice.org/18592 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-09-19Resolves: tdf#94249 do not remove broadcasters while iterators are in useEike Rathke
EndListeningContext holds BroadcasterStoreType iterators in its ColumnBlockPositionSet and collects broadcasters to purge them at the end. Removing broadcasters from ScColumn::maBroadcasters in between invalidates the iterators. Hence calling the "normal" EndListening() that removes a broadcaster when all listeners are gone while an EndListeningContext is in use is bad. Change-Id: Ibdd88469e91e6173ceff1f391c23ef7cb7c6f596 (cherry picked from commit e4a8ae0bf54476e9a0c9e1f5348c05f3cd838899) Reviewed-on: https://gerrit.libreoffice.org/18615 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-09-19Resolves: tdf#93895 broadcast cell changes when multi-selection was pastedEike Rathke
It is not sufficient to collect the cells, one has to broadcast on the collection. Change-Id: I11f889936aff43f958c56789e539809289819752 (cherry picked from commit 97ad6393525a928b5dfe2a6562d7604446da7af0) Reviewed-on: https://gerrit.libreoffice.org/18573 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2015-09-19Split formula group for OpenCL up into smaller bitsTor Lillqvist
Will make it less demanding on low-end hardware, where the device driver is unresponsive for too long when a OpenCL kernel handling lots of data is executing. This makes Windows restart it which is problematic. I tried several approaches of splitting, both at higher levels in sc and at the lowest level just before creating and executing the OpenCL kernel(s). This seems to be the most minimal and local approach. Doing it at the lower level would have required too much poking into our obscure OpenCL code, like passing an offset parameter to every kernel. Use a simple heuristic to find out whether to split. On the problematic low-end devices, CL_DEVICE_PREFERRED_VECTOR_WIDTH_FLOAT is 4, while for more performant devices it is 1 or 8. Change-Id: If16d152710057b34d09ef0203960e1fbb9ac067f Reviewed-on: https://gerrit.libreoffice.org/18613 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2015-09-19tdf#94079 allow empty array for holiday sequenceWinfried Donkers
in Calc functions NETWORKDAYS and WORKDAY.INTL Change-Id: I2d42ab956e4ab9f2187a0c6bc3c64c9306ca892a Reviewed-on: https://gerrit.libreoffice.org/18559 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 75bde904d5b4f756037889f2b2ddee3e34dd81b8) Reviewed-on: https://gerrit.libreoffice.org/18595
2015-09-19Resolves: tdf#92995 do not delete caption objects that are held by UndoEike Rathke
Drag&Drop Undo is a special case of ownership.. Change-Id: I2fe7769c4d84efe09d432335d5d8e72d506bf7a1 (cherry picked from commit 44f34c1163882c2e3086282374fee9cd55ee211f) Reviewed-on: https://gerrit.libreoffice.org/18470 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-09-19loplugin:staticmethodsStephan Bergmann
Change-Id: If54b3017296f5bcea01b3b0d24d9ac821f6a24e9 (cherry picked from commit c82c94b40157c08bbbc524b2dc02714cbe82dc65)
2015-09-19loplugin:passstuffbyrefStephan Bergmann
Change-Id: I88baef02e5c8c87e7bc408212e16fd7039bfd7a1 (cherry picked from commit ec923b0c19f9d210c3ff9ad59d39ddcd4f958286)
2015-09-19tdf#91501: Add data bar colour to the list if not there yetKatarina Behrens
Change-Id: I18dd5b8dc49bd9f4dc9c27556782fa5f2b3c4f58
2015-09-19tdf#91882 - make this hideous busy-loop lower priority and less busy.Michael Meeks
This way the rendering code can get a look in. Change-Id: Id100031ffe1c4b415ed4ef1272a0772ec99ab4a9 Reviewed-on: https://gerrit.libreoffice.org/18301 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2015-09-19tdf#93600: Avoid crash on entering '=' as a cell valueKatarina Behrens
To match formulas, 'formula is' condition should be used instead Change-Id: I37a9a2680c49bffcb8b25a11faedc1421cfa2d00 Reviewed-on: https://gerrit.libreoffice.org/18126 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Reviewed-on: https://gerrit.libreoffice.org/18159 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2015-09-19Fix the OpenCL VLOOKUP to work properly and add it to the trusted subsetTor Lillqvist
Treat an array of null string pointers as no strings for OpenCL. For some reason, at least in the case of the "Test OpenCL" thing, we got an mpStringArray that is non-null but where all the elements (rtl_uString pointers) in it are null. Treat that case as if the mpStringArray was null. This makes the tests "Test OpenCL" actually use OpenCL. Maybe it has other useful effects, too. (But for normal spreadsheet use, the mpStringArray that gets handled here *is* null when all the cells used by a formula group are numbers. At least it seemed so in a simple test.) Add a few more useful (?) SAL_INFO calls. Some cosmetic changes to make the code look saner. Return correct value from the OpenCL VLOOKUP implementation. Also, when the lookup fails, produce the expected N/A error code instead of a bare NaN. Don't claim we support strings arguments in the OpenCL VLOOKUP. The string support certainly isn't complete or correct anyway. Partially revert c3383aafa18ef9d03b04b2a4719e71fdfabc14eb. Add VLOOKUP to the set of opcodes that we trust the OpenCL implementation for. (cherry picked from commit 7e91726f4d81f0ab27d79ee231abd666b4999758) (cherry picked from commit d4310b6cd8a367666cc702c3e47cf12a35407ef7) (cherry picked from commit 32b35d9d8a21091b987d94fc2ad24d69e9d8a6f3) (cherry picked from commit 41a6094095a0cd42f24eb996c7ec8c28ab9d6c1a) (cherry picked from commit 162264450cb62177ea133829d081fecdb02136b5) (cherry picked from commit 7bb7539c0e34283baeaacf7e4ff0b19287afadc2) Change-Id: I5402732c9ddcac1efcc25960a5c46175d7a90b4d Reviewed-on: https://gerrit.libreoffice.org/18022 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2015-09-19do not parse range fragments as valid rangesEike Rathke
For example, "B2:" or ":B2" were accepted as valid range, with the missing part set to A1, which resulted in a A1:B2 range. An omitted sheet specifier always results in a valid relative sheet, hence that flag is set, so testing flags for non-null before the final result is available isn't sufficient. Additionally this revealed a flaw in handling of external references when loading documents if the original file name differs from the resulting real file name due to relative paths. Actually now the displayed file name matches the real file name when such a document was loaded, where before the original file name was displayed. Probably such references didn't even work before if the reference spanned more than one sheet, which is a rather rare case for external references. Change-Id: I38035f2e4b3a11c0280457498cf62b02f882d2a1 (cherry picked from commit 56238d58a7da705e4e91604964e6564d819a9196) Reviewed-on: https://gerrit.libreoffice.org/18035 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-09-19Revert "do not parse range fragments as valid ranges"Eike Rathke
This reverts commit 350b00af0a1d0bf516ac308e21849ece77acbaf6. Breaks CppunitTest_sc_subsequent_filters_test Change-Id: I92963fa16aacbf01f4d6660eff7497347538371d Reviewed-on: https://gerrit.libreoffice.org/18029 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2015-09-19do not parse range fragments as valid rangesEike Rathke
For example, "B2:" or ":B2" were accepted as valid range, with the missing part set to A1, which resulted in a A1:B2 range. An omitted sheet specifier always results in a valid relative sheet, hence that flag is set, so testing flags for non-null before the final result is available isn't sufficient. Change-Id: I57d1b7cf71a298e7ac108b0e13aab88208f0f00c (cherry picked from commit ed6209f572bad38bdb066be668163fe8acf52056) Reviewed-on: https://gerrit.libreoffice.org/18023 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-09-19Resolves: rhbz#1255811 implement Edit modify handlerEike Rathke
... and disable/enable Apply/Ok buttons for in/valid ranges. (cherry picked from commit ad1284df599f3493e7c76c7f8b4230aab1946558) implement Edit modify handler, rhbz#1255811 related Same as in ScRandomNumberGeneratorDialog. (cherry picked from commit da9ecf1a59b85eb93004507fe55b92f74c2cdb4c) implement Edit modify handler, rhbz#1255811 related Same as in ScSamplingDialog. (cherry picked from commit a88fecdcdbf0b3f6a5ba3375f8193a9dc7ba7422) implement Edit modify handler, rhbz#1255811 related Same as in ScStatisticsInputOutputDialog. (cherry picked from commit b2363e98af7b0281279617e43b8fec5b898b9120) 1bc9296bfc8b1b2b8f3fc20183e2c626f94dee09 ff709ec2284673efa8824a9b8cfc037e4d6d567a 0e3eb06bc86cf77c405c54f312340c7b2551c1ec Change-Id: I52b5eae2f34e3fca7c0761b14124477a0d160b01 Reviewed-on: https://gerrit.libreoffice.org/18009 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-09-19tdf#93437: release reference held by ScFormulaReferenceHelperKatarina Behrens
which prevents destructor from being called. It was ScFormulaDlg's own m_aHelper member variable holding reference to 'this' (extra-wicked, through SetWindow(this)), never releasing it. Change-Id: I258a280e09674d1a2f1ddebea19ea1b42dcdc777 Reviewed-on: https://gerrit.libreoffice.org/17954 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2015-08-18tdf#92256: Improved interop of INDIRECT functionKatarina Behrens
This is a combination of 12 commits from master branch: tdf#92256: ODF save/load syntax for string reference Related tdf#92256: map CONV_OOO to listbox item no.1 tdf#92256: Introducing CONV_A1_XL_A1 address pseudoconvention tdf#92256: OOXML save/load syntax for string reference add unhandled case in switch that comment is not correct anymore don't generate invalid XLSX files tdf#92256: Handle case when string ref syntax is unknown tdf#92256: Make OOXML filter CONV_A1_XL_A1 aware too tdf#92256: Make sure ref syntax of Excel docs gets saved tdf#92256: Save ref syntax when different from native one tdf#92256: Don't force CalcA1 syntax on all !Microsoft xlsx docs Change-Id: I226d5644ce729f1311aefc9a8998b3a75633c334 Reviewed-on: https://gerrit.libreoffice.org/17837 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2015-08-18Resolves: tdf#92749 invalidate lookup caches after initial hard recalcEike Rathke
... because the caches are not setup as listeners during when the document's hard recalc state is active. Change-Id: Ie7ec84ee64d046e3e55ce26b92824e94a2f660e9 (cherry picked from commit f7e493229bd949066b4d8984dce7678b8687d1ae) Reviewed-on: https://gerrit.libreoffice.org/17829 Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-08-17Resolves: tdf#93358 resync attribute pattern that may have changedEike Rathke
Change-Id: If3ce8feec940c7212fe467f39db868630522b17e (cherry picked from commit f089de7dc5c367a3123129b08a9050b3bacc4eba) Reviewed-on: https://gerrit.libreoffice.org/17765 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2015-08-17Resolves: tdf#93098 replace remembered listener when replacing cellEike Rathke
... where SvtListener* is the base of ScFormulaCell* and lead to use after delete. Change-Id: I45b8e16f05cf5d4d0d4858dc9cd0c748f8184978 (cherry picked from commit ea29d320754fdb21b336cb78f816b8081371def9) Reviewed-on: https://gerrit.libreoffice.org/17726 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2015-08-17tdf#44399 Do not display 0 decimal for General formatLaurent Balland-Poirier
For General (Standard) format, "0" is not the number of decimal places Replaced by an empty string in dialog UI and Sidebar. (cherry picked from commit 0db37d785311aa2294f60b750fce4dadff6c75e0) Change-Id: Ia367b491b71fa7b4480cdd03408c0c0315425dc8 Reviewed-on: https://gerrit.libreoffice.org/17771 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2015-08-13Another GrabFocus during disposeMaxim Monastirsky
Change-Id: I89f8aa5e087e95c96d63695be0ec4e9b4fbe0a0c (cherry picked from commit 4622823a800804acf15c0f4a5adecce03ae65189) Reviewed-on: https://gerrit.libreoffice.org/17706 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-08-13Resolves: tdf#93388 broadcasting to removed listeners isn't a good ideaEike Rathke
This cures only a symptom, the underlying cause is that the broadcasters still are listed in maBulkGroupAreas. Change-Id: I9625483016a51eb6f6a7e3d58ed42c7dad3a57b3 (cherry picked from commit 2d4edd7de2e67db5bd17e7a89e2496611ebcc165) Reviewed-on: https://gerrit.libreoffice.org/17684 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-08-11Resolves: tdf#86024 do not attempt to shorten numeric value outputEike Rathke
Regression of 087a79db1272858f107656c5ca3c6efb45680986 Change-Id: I903e05234882c79e6da6499cb17e16fd7226f91c (cherry picked from commit 2a06a052b920f696a794c2fb847fce63038220e9) Reviewed-on: https://gerrit.libreoffice.org/17636 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-08-11tdf#79741: Macro with Find @ Replace crash CalcJulien Nabet
0x00002aaaaf4bd163 in SfxItemSet::GetItemState (this=0x0, nWhich=26182, bSrchInParent=true, ppItem=0x7fffffff1730) at /home/julien/compile-libreoffice/libreoffice/svl/source/items/itemset.cxx:422 422 SfxItemArray ppFnd = pAktSet->m_pItems; (gdb) bt 0 0x00002aaaaf4bd163 in SfxItemSet::GetItemState(unsigned short, bool, SfxPoolItem const**) const (this=0x0, nWhich=26182, bSrchInParent=true, ppItem=0x7fffffff1730) at /home/julien/compile-libreoffice/libreoffice/svl/source/items/itemset.cxx:422 1 0x00002aaaaf4bd306 in SfxItemSet::HasItem(unsigned short, SfxPoolItem const**) const (this=0x0, nWhich=26182, ppItem=0x7fffffff1730) at /home/julien/compile-libreoffice/libreoffice/svl/source/items/itemset.cxx:463 2 0x00002aaacd9902c9 in ScCellShell::ExecuteEdit(SfxRequest&) (this=0x312fe10, rReq=...) at /home/julien/compile-libreoffice/libreoffice/sc/source/ui/view/cellsh1.cxx:1032 See https://gerrit.libreoffice.org/#/c/17603/ for details Thank you Maxim! Change-Id: Ie4cf31e3764c02f335830c59674a94acd6c209df Reviewed-on: https://gerrit.libreoffice.org/17603 Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com> Tested-by: Maxim Monastirsky <momonasmon@gmail.com> (cherry picked from commit 958ec9ccfe3bbe54369f9e9105c10beae80d9548) Reviewed-on: https://gerrit.libreoffice.org/17615 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2015-08-10tdf#89387 related, fix SumSquare bug in SumMXMY2Łukasz Hryniuk
SumSquare returns IterateResult, which, because of rounding errors, store first value in mfFirst and rest in mfRest. They should be added to get the full sum of square of matrices difference. Change-Id: I9bc435801d94206960b0b4fe4a9149ef1abeb3be Reviewed-on: https://gerrit.libreoffice.org/17592 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com> (cherry picked from commit d5bff1225a6739e8369bacd8392686bd26630d2f) Reviewed-on: https://gerrit.libreoffice.org/17639
2015-08-07Resolves: tdf#58838 do not use collation for Equal/NotEqual operatorsEike Rathke
Unicode collation ignores control characters and other specific characters, see http://www.unicode.org/charts/collation/chart_Ignored.html and thus is not suitable to be used for Equal/NotEqual operators. Change-Id: Ib84713e1da59d92e07bc974d93b6def8217bb067 (cherry picked from commit 1e5e7b9323c3321a380edf86097ccc2e3f0a7a7a) Reviewed-on: https://gerrit.libreoffice.org/17240 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2015-08-07Resolves: tdf#92709 conditional formats are applied to ranges, not expressionsEike Rathke
Hence we need a separate string as header in the dialog. Unfortunately I did not see this when applying 0cf38e7d0c5d2b67dca828aae1797bff58b6c5fe Change-Id: Ib60cef29e663e71a25849df1d5a926f0e871bb8b (cherry picked from commit ffebdead5445dffd60fb09382e69701d8a06cfc8) Reviewed-on: https://gerrit.libreoffice.org/17239 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2015-08-07MATCH, HLOOKUP and VLOOKUP have a ReferenceOrForceArray parameterEike Rathke
tdf#91278 related Change-Id: Iab4728b07649bcbb1beb372e68369f3762b13a5c (cherry picked from commit 01eea7fe40c939311bf1920b6e8b4391a93c2e82) Reviewed-on: https://gerrit.libreoffice.org/17264 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2015-08-07init maTabData to the correct tab size tdf#92629Laurent Godard
Change-Id: I6b226f8e992b3a2b6bcebc44b36ca1f2f06a128e Reviewed-on: https://gerrit.libreoffice.org/16894 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit ebdc15f93587b59a79a5104f8358841a28940a82)
2015-07-31tdf#92918 Engineering notation lost with Add/Delete Decimal PlaceLaurent Balland-Poirier
With scientific format, use the trick of thousand separator to detect Engineering notation. Change-Id: I7acdfb8bec646f9d6c1a17c334b60fa9708c8111 Reviewed-on: https://gerrit.libreoffice.org/17406 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com> (cherry picked from commit f4bdd7989f237e8e90ac94c2798e0ea0fb31af6b) Reviewed-on: https://gerrit.libreoffice.org/17440
2015-07-28tiledrendering: added getPartName method for calcMihai Varga
This method is used to get the sheet's name and to display it in the tabs (sheet selector) I've also added an unit test for it and uncommented a similar one Change-Id: Ia866815c594a873812c71a6c86e303c869e1f093 Reviewed-on: https://gerrit.libreoffice.org/17294 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com> (cherry picked from commit 50fe21c7807afb9650c048e1a82bd97a7fc1d226) Reviewed-on: https://gerrit.libreoffice.org/17368
2015-07-23TableRef: generate error for header-less column references, tdf#91278 relatedEike Rathke
... instead of using an arbitray first data record's string as column name. We don't support header-less tables properly yet, so don't pretend to. Squashed 4 commits into one: add optional ContainsHeader property great we never had this :-( (cherry picked from commit 6dddd1aaf5dd3c54aaf87222712c9147466056f6) handle ContainsHeader property at database range (cherry picked from commit ed497c014444baf8036b1fb79ffeba2b139919f4) clear HasHeader at database range if table headerRowCount is 0 (cherry picked from commit 22c9977d70e4812bca4bc038b775bb7eddb19bab) TableRef: generate error for header-less column references, tdf#91278 related ... instead of using an arbitray first data record's string as column name. We don't support header-less tables properly yet, so don't pretend to. (cherry picked from commit d77947929c7f02cebe3d3e5d79c78642a8a439ba) Change-Id: Id79b08ff9dfe42228ed7d6b27ad0c8cc29b1bfb0 f0d54ab1dee6c861b973dc490f6c4a1e11260546 1cf5b0ac3884320f39d439b6eecf0b39cdf6bc49 a42619ec800291b6617a61c8a89a2d54ef231cec Reviewed-on: https://gerrit.libreoffice.org/17321 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2015-07-21Resolves: tdf#92448 check for numeric '.' only if sheet separator is '.'Eike Rathke
Change-Id: I427da08eed3fc5daed2bac4d588b66a3f03fd28c (cherry picked from commit 2fd3560e0815b547ada7d7f6557857fe3c8678ba) Reviewed-on: https://gerrit.libreoffice.org/17244 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2015-07-20check annotation caption pointers, blind fix for rhbz#1242099Eike Rathke
Apparently there may have been situations when the caption or its shape could not be obtained for whatever reason. Change-Id: Ie9b97d4b3999cb4645bb6b8b688b3666cfd71ccc (cherry picked from commit 47d90af52a548429224c38b5c58a70116e0f7907) Reviewed-on: https://gerrit.libreoffice.org/17220 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-07-20Resolves: tdf#92767 use ISO 8601 for internal date string representationEike Rathke
Change-Id: I481bf3295feb64827de2122234a9300d0b8ced40 (cherry picked from commit 3e17ed1fc2845da5a279d21ffa3ea51d637e515e) Reviewed-on: https://gerrit.libreoffice.org/17172 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2015-07-19Resolves: tdf#88402 remember sort "has headers" at anonymous database rangesEike Rathke
Change-Id: I4a126f40589fd401f3a63f74be5e86e3df947ef6 (cherry picked from commit 33255f974fc712b9e9e2965a350c65a2195a7ae6) Reviewed-on: https://gerrit.libreoffice.org/17136 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2015-07-13tdf#92668: Revert some implementation names, for backwards compatibilityStephan Bergmann
These implementation names of Calc, Draw, Impress, and Writer documents are the most likely to be checked by existing third-party code, so revert the corresponding parts of 3099c70b11c7e5b80fe4dbe3dc99171fb38c6fc2 "Fix various XServiceInfo implementations" (and instead add fixups in CppunitTest_serives). Change-Id: I1a760adbf4c89a1b4477d6e628abba8d2028ccfe (cherry picked from commit 61a3be76c221c822b189d20e9269ec5caf1aadcc) Reviewed-on: https://gerrit.libreoffice.org/17010 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2015-07-13tdf#89031 remove agressiveness from Calc function suggestionsWinfried Donkers
Change-Id: I7751a038f8482addc0e45c0461666bbd1c959d12 Reviewed-on: https://gerrit.libreoffice.org/16478 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com> (cherry picked from commit f3d748937a177cbbc0033bcf54d0d0fd57a1b409) Reviewed-on: https://gerrit.libreoffice.org/17009
2015-07-10SdrPaintView::AddWindowToPaintView: take a vcl::Window, tooMiklos Vajna
Change-Id: Iedb296732c0819a1d6cdc1c59b3f1718e2cd6d38 (cherry picked from commit 9a11e59e5699c5eb0854355d3dd3848bc895545c)
2015-07-09execute the terrible bottle neck loop only if there are conditional formatsEike Rathke
Change-Id: Ic8bd65a728289c9fa1a0721b0ecbd9b4a48672ca (cherry picked from commit 2aefb89b299e7ebdca5bb35aa4e9059e59805715) Reviewed-on: https://gerrit.libreoffice.org/16902 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2015-07-09Resolves: tdf#84762 collect all recalc-always cells before setting any dirtyEike Rathke
Change-Id: I38f69bcbb9eb550fb97b0f84bc0cb486863060b4 (cherry picked from commit bf35419b68d7f100a634572236f7d593638981c8) Reviewed-on: https://gerrit.libreoffice.org/16873 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-07-09fix export to xls, tdf#69552Winfried Donkers
CEILING.PRECISE, ISO.CEILING and FLOOR.PRECISE with 1 argument are now exported properly to xls. export test for xls activated. Reviewed-on: https://gerrit.libreoffice.org/16882 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 570852376464f238d7c3c0b58b37250ac5944a1c) Conflicts: sc/qa/unit/subsequent_export-test.cxx Tests not present on branch. Change-Id: Ib2a813183bbf8f2e9a5bbe08630403ffecb3cbb1
2015-07-08always justify a referenced range in order, tdf#92468Eike Rathke
(cherry picked from commit d24c6a0280b0287ee6c23ca89068323c6b7c3dd7) (re-)introduce ScComplexRefData::PutInOrder(), tdf#92468 (cherry picked from commit ad3d2b6c2e88d191d76f90eb5be927f7ca76c670) introduce ScTokenArray::AdjustReferenceOnCopy(), tdf#92468 (cherry picked from commit 369ee0b1faf79f1bd23c75ee04dd0dcc5bf283af) call ScTokenArray::AdjustReferenceOnCopy() in ScFormulaCell clone, tdf#92468 (cherry picked from commit 3ddaeaab37d585971e376de6ad7b0f06f55f2e1a) f551e02a77a416b95f74266de896391d1d72eb3c 0a7ac0d9d10e96223cd5f095a771aa6f9d271417 0dc0c3528b35bc6ea2525bafb94d72ee65e4791a Change-Id: Id69c58800d28f1733777f7931a20d8ee7bdf034f Reviewed-on: https://gerrit.libreoffice.org/16815 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-07-08end/restart group listening in DeleteSelection(), similar to DeleteArea()Eike Rathke
Reproducer: * in A1 enter =SUM(B1:C4) * copy A1 to clipboard * paste to A2 and A3 * formula in A2 is =SUM(B2:C5) A3 is =SUM(B3:C6) * select A2:A3 * hit Del key to delete the two cells * enter any numeric value in B2 => formula result in A1 is not updated Shift+Ctrl+F9 hard recalc updates Change-Id: I55e55b8cfe69e9273170ceaea4e6c046b3d4f7b7 (cherry picked from commit a49b8af4cf03ae08cb7a28f66e24368a7b08ae3f) Reviewed-on: https://gerrit.libreoffice.org/16840 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-07-08Related: tdf#92392 clear some more vclptrs on disposeCaolán McNamara
Change-Id: I91b8d082ff19328e35e2f1c2a02838d96224dc9c (cherry picked from commit 8e20a25319e16d2f74e18696480556bc841a1679) Reviewed-on: https://gerrit.libreoffice.org/16831 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2015-07-07Related: tdf#92392 protect against double dispose from dtor with disposeOnceCaolán McNamara
Change-Id: I40f3bdea784a1abed8f9732a9444cd8d1eccf4a9 (cherry picked from commit 5f216c82ab5fbab44ab55a5127d0be7d4a2da8e3) Reviewed-on: https://gerrit.libreoffice.org/16830 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2015-07-06tdf#92392 - Dispose ScFormulaReferenceHelper properly.Michael Meeks
Release the accelerator, and cleanup global references. Change-Id: Id9931527f1b6d89067bc1e520e521ccfa6e28197 Reviewed-on: https://gerrit.libreoffice.org/16740 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/16751 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2015-07-06This one should override SfxToolBoxControl::SelectMaxim Monastirsky
We don't have there Select(bool) since c3a89936abc7967ebe8916ca83cb38f6837f9aa1. (cherry picked from commit 4604a6a7cd66907fc29e01aacf2146f17fa19d34) (cherry picked from commit bc3c7f2557a1871fb1e41fc9cac4426a6b208901) Conflicts: sc/source/ui/cctrl/tbinsert.cxx Change-Id: Id496725d82289d1be004bdc36195877c12f336b0 Reviewed-on: https://gerrit.libreoffice.org/16772 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
generated by cgit (git 2.34.1) at 2024-08-03 10:11:08 +0000