summaryrefslogtreecommitdiff
path: root/sc/source
AgeCommit message (Collapse)Author
2014-10-07Don't call comphelper::rng::uniform_real_distribution(a,b) with a==bTor Lillqvist
Change-Id: I95a3ac8da83e02001de13af8d31a04fe0d654dc0
2014-10-06avoid use of ref. to possibly deleted objectDavid Tardon
Change-Id: If5977b280fed8d8b053f59852d3984a59ce61a69
2014-10-06Resolves: fdo#80101 inserting non-chart as chart -> unhandled exceptionCaolán McNamara
Change-Id: I4d5438292d9a5c49f1336304ebd3dc4e155dd212
2014-10-06use comphelper::rng::uniform_*_distribution everywhereCaolán McNamara
and automatically seed from time on first use coverity#1242393 Don't call rand coverity#1242404 Don't call rand coverity#1242410 Don't call rand and additionally allow 0xFF as a value coverity#1242409 Don't call rand coverity#1242399 Don't call rand coverity#1242372 Don't call rand coverity#1242377 Don't call rand coverity#1242378 Don't call rand coverity#1242379 Don't call rand coverity#1242382 Don't call rand coverity#1242383 Don't call rand coverity#1242402 Don't call rand coverity#1242397 Don't call rand coverity#1242390 Don't call rand coverity#1242389 Don't call rand coverity#1242388 Don't call rand coverity#1242386 Don't call rand coverity#1242384 Don't call rand coverity#1242394 Don't call rand Change-Id: I241feab9cb370e091fd6ccaba2af941eb95bc7cf
2014-10-06fdo#73151 Always open Styles&Formatting dialog in the sidebarSamuel Mehrbrodt
Change-Id: I05b63dc00023945d92fd837bd64042135d3f9aed Reviewed-on: https://gerrit.libreoffice.org/11648 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2014-10-06fdo#39468 Translate German Comments - sc/source/filter/inc/Christian M. Heller
Change-Id: I26eacb2f8ab02c788e82aa6fdcb76d8fa07f64fb Reviewed-on: https://gerrit.libreoffice.org/11803 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-05coverity#1231669 Unchecked return valueNorbert Thiebaud
Change-Id: I60b7c8267c81b0545c2bcc367ad6cac43aefad64
2014-10-05coverity#1231670 Unchecked return valueNorbert Thiebaud
Change-Id: I29a751b2d44e86ccf115015b0ede8bae2e702eea
2014-10-05related fdo#70998 use plural for Objects/Images optionStanislav Horacek
Change-Id: Ia76021bcb9044a10b880c12fcbf67e86b837ebd4 Reviewed-on: https://gerrit.libreoffice.org/11811 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2014-10-04coverity#704002 Unchecked return valueNorbert Thiebaud
Change-Id: Ibf506a219df7d0ad67959b3d266a037003fceea4
2014-10-04coverity#1242368: Unchecked return valueNorbert Thiebaud
Change-Id: I6aaad60cf08349aee6c07621764a1a6c071ad2b6
2014-10-04coverity#1242369: Unchecked return valueNorbert Thiebaud
Change-Id: Ib5a938d9a8a0ac1f2f5dfb299c948951bb845349
2014-10-04Add menu entry for the "formula to value" feature.Kohei Yoshida
Not sure 100% if that's the best place for this. Feel free to move it to a better place. Change-Id: Id66a92e1184e988bd71f7d845ea370b021c02c21
2014-10-04coverity#1242413: logically dead codeNorbert Thiebaud
Change-Id: I6e5e5025df4ad8eef6ff6a7910cb9c3ab5fc3c4e
2014-10-04coverity#124890,1242726 Unused ValueNorbert Thiebaud
Change-Id: I1d32b7d68ac0ec3752364e855390af21be3f4496
2014-10-04coverity#1242818 Unused valueNorbert Thiebaud
Change-Id: I487026489937679978e7ed403edb7125eb2c7fcf
2014-10-04coverity#1242771 Unused valueNorbert Thiebaud
Change-Id: I86455a041c98f010724ac6878e78a1b14cd26899
2014-10-04coverity#1242781 Unused ValueNorbert Thiebaud
if nLen2 is 0 then bNextNum is set and nLen1 is then 0, and the if(nLen1 || nLen2) can only be true if nLen2 is non zero and bNextNum get overriden... so the line bNextNum = !bLastAlp is useless. Change-Id: Ice62562bf321e5389f2118677e72d1b421816858
2014-10-04fdo#39468 Translate German Comments - difimp and htmlimpChristian M. Heller
Change-Id: I221d07c56822905c500f11f3f738231259743acd Reviewed-on: https://gerrit.libreoffice.org/11802 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-03Let's consistently spell OpenCL as 'OpenCL'.Kohei Yoshida
Change-Id: I8bdcf0667b326b77d11001efeeefd5247987ebdc
2014-10-03Let's not omit 'virtual' keyword here.Kohei Yoshida
Change-Id: Idf4ccbb6415852325acab673a3d81f758e50c880
2014-10-03Make these non-inline.Kohei Yoshida
Change-Id: I1cc28c16796934f20afc53c6f6f083f372b7ce69
2014-10-03Run 'beautify' on these files as well.Kohei Yoshida
And some trivial manual fixing afterward... Change-Id: Ib60411f689b7971a2dd1acd1541864f38b34b570
2014-10-03coverity#1242443 Identical code for different branchesCaolán McNamara
Splitter derives from Window and doesn't override MouseMove so both branches are the same Change-Id: Id74f12e2efb458ac2ae183686a57befdf0225778
2014-10-03coverity#1242454 Identical code for different branchesCaolán McNamara
Splitter derives from Window and doesn't override MouseButtonUp so both branches are the same Change-Id: I9072d24b60dacfdb1d3e9ca1c97f08002f7e24ba
2014-10-03coverity#1242431 Explicit null dereferencedCaolán McNamara
Change-Id: I96cbc59931400ad2f348ffb44925e8fe34b782ed
2014-10-03coverity#1242477 Dereference null return valueCaolán McNamara
Change-Id: Ic2d8dab00d5af47f6274433ee811f567f990400b
2014-10-03coverity#1242849 Unused valueCaolán McNamara
status gets overwritten after the switch ends Change-Id: I60d4f61e6e1f31f9dd79c178c9a6f7060d154013
2014-10-03WaE: private fields 'mnTab' and 'mnCol' are not usedTor Lillqvist
Change-Id: I449b85b00aeaf690644e17be0a6b2b9398a3cd3f
2014-10-02New feature to allow converting formula cells to static values.Kohei Yoshida
You used to have to convert formula cells to static values by copying them and pasting them as values onto the original place. Why not just allow converting them in place? This is something I've always wanted to implement.
2014-10-02Scope reduction by early bail-out.Kohei Yoshida
Change-Id: Iacbf9f46a1b5683b6de5dd93002a69078af46951
2014-10-02Make the coding style consistent with the rest of Calc code.Kohei Yoshida
I just ran SlickEdit's 'beautify' command with some follow-up manual editing. Change-Id: I402e782e7d147c4c95ebaa8ffcc40b50a0c565a7
2014-10-02Bin EE_CNTRL_URLSFXEXECUTE which was only set, never testedTor Lillqvist
Change-Id: I18a9355bb902b19f0eeecb26d33eba4fb25db8cb
2014-10-02coverity#1242506 silence Arguments in wrong orderCaolán McNamara
order doesn't matter one bit as far as I can see Change-Id: I55aa5d23d9865a47ef4dcda9d3e19863794a18c9
2014-10-02coverity#1130190 'Constant' variable guards dead codeCaolán McNamara
Change-Id: Ifc462622919c8247c1f4ff8304f3107a23ef1c49
2014-10-02coverity#1242475 no point calling SetText with GetText resultsCaolán McNamara
Change-Id: I0ebd4a53a0d309b45f5af31adc6fa54a5f143a21
2014-10-02coverity#1242751 Uninitialized scalar fieldCaolán McNamara
Change-Id: Ib56544cf49d53952c7381512b650633abac047e9
2014-10-02coverity#1242872 Unused valueCaolán McNamara
Change-Id: If385b910c1778217d8db881b5d27ea993e27a66e
2014-10-02coverity#1242940 Uninitialized scalar fieldCaolán McNamara
Change-Id: I60efbf0cbba81f973a258f1ba90cc910b1abe075
2014-10-02coverity#1242417 Logically dead codeCaolán McNamara
this looked a little less odd before commit 6dda3d45c902d64323a085ea1604a993521f313d Date: Wed Apr 23 11:08:48 2014 +0200 sc: sal_Bool->bool so simplifying it now Change-Id: Ibadfc140581f186ba4c98874b740a18d19b77970
2014-10-02coverity#735819 Unchecked dynamic_castCaolán McNamara
Change-Id: I4e8834a2cdc979757ae6d37730a89fc20bcc6b26
2014-10-01Remove leftover SAL_WNODEPRECATED_DECLARATIONS_PUSH/POPStephan Bergmann
...from times when code used std::auto_ptr. Change-Id: Ia4eca8b0b95a8846886884404009e895daba8a22
2014-10-01fdo#39468 Translate German Comments - sc/cource/filter/difChristian M. Heller
Change-Id: I1d44c2538baac9a1443118c95a2886db5098dab1 Reviewed-on: https://gerrit.libreoffice.org/11736 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-01fdo#39468 Translate German Comments - sc/source/filter/excel/Christian M. Heller
Change-Id: I2a5104c6da0cf9843c42b1687aec6eb9c459c3d4 Reviewed-on: https://gerrit.libreoffice.org/11735 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-01fdo#82577: Handle TimeNoel Grandin
Put the TOOLS Time class in the tools namespace. Avoids clash with the X11 Time typedef. Change-Id: Iac57d5aef35e81ace1ee0d5e6d76cb278f8ad866 Reviewed-on: https://gerrit.libreoffice.org/11684 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-01Replace TSdrObjectPtr with unique_ptr with custom deleterStephan Bergmann
Change-Id: If15e1bab07ee5e9c70a6a0f1961ec2db0c946eb5
2014-09-30sc: std::auto_ptr -> std::unique_ptrStephan Bergmann
Change-Id: I25468d578de597ff9aeba3ffc850c630fa532767
2014-09-30sc: lock SolarMutex before calling ScDocument::RemoveUnoObject()Michael Stahl
This can race against other threads calling AddUnoObject(), and hopefully this should fix the assert from SfxBroadcaster::AddListener() line 96 that has been observed in sc_unoapi. Change-Id: Ia2dd38a499c51a77c54cffe9dde31e14053ae0e5
2014-09-30fdo#53920 Switch back tab at RefButton closure timeLaurent Balland-Poirier
Bug occurs because visible tab is not the initial tab. So, instead of switching back to initial tab at dialog closure time (removed from cellsh2.cxx), this commit proposes that switching back to initial tab is operate when expanding the RefButton shrink dialog. Change-Id: I3cf7ed14054fa69881d4ecbc55c48dfbfc4356aa Reviewed-on: https://gerrit.libreoffice.org/11660 Reviewed-by: Kohei Yoshida <libreoffice@kohei.us> Tested-by: Kohei Yoshida <libreoffice@kohei.us>
2014-09-30fdo#82577: Handle PolyPolygonNoel Grandin
Put the TOOLS PolyPolygon class in the tools namespace. Avoids clash with the Windows PolyPolygon typedef. Change-Id: I811ecbb3d55ba4ce66e4555a8586f60fcd57fb66