summaryrefslogtreecommitdiff
path: root/sc/source
AgeCommit message (Collapse)Author
2016-03-15vcl: move graph.[hx]xx to graphic.[hc]xxChris Sherlock
It's IMO a bit confusing to see a "graph" header that doesn't strictly deal with graphs, but graphics. Backporting to 5.1 series to allow for easier backporting of other potential hotfixes. Change-Id: Ic37c6cd78e23d05939486f98667144c4453bb0a3 Reviewed-on: https://gerrit.libreoffice.org/22949 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2016-03-15Resolves: tdf#93196 add RecursionCounter guard also to InterpretFormulaGroup()Eike Rathke
... same as for ScFormulaCell::InterpretTail() Change-Id: I444f259fe4e86ed0638a04f1b5d9272edd182e2e (cherry picked from commit 29ee431c1cf859c3d5a5041cff5cb04b89db27a0) Reviewed-on: https://gerrit.libreoffice.org/23279 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: David Tardon <dtardon@redhat.com>
2016-03-14tdf#94561 : Create notes drawing objects only once on sheet copyDennis Francis
Skip copying notes in CopyToColumn() and then call CopyCellNotesToDocument() only after copying hidden rows and filtered rows info. Skip copying notes drawing objects in ScDocument::DrawCopyPage() when inside ScDocument::CopyTab(). Change-Id: I38296bb5d1cc062d473ea4a5a3143f6c1787fc4a Reviewed-on: https://gerrit.libreoffice.org/22331 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 7c0f6b9d0fb8d7d9e54865ccf1047bb8f8148101) Reviewed-on: https://gerrit.libreoffice.org/23122
2016-03-14tdf#98083: Always save cell formatKatarina Behrens
it was pretty bad idea not to save it for rich-formatted cells (tdf#92296) as there is more to cell format than just a font Due to a bug in xpath helper I'm backporting only part of the test (cherry picked from commit 7945cdf0ea570302a04550540848c03c0cd030ab) Change-Id: I0e5e7d7187c69519bb8f4de2b627e385fccd3d46 Reviewed-on: https://gerrit.libreoffice.org/23032 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-03-09Resolves: tdf#95226 second case, stack error count in JumpMatrix contextEike Rathke
For the early bail out on errors to work correctly and not prematurely end calculations the current error function needs to be stacked in JumpMatrix context, otherwise we may end up with ((nErrorFunction=74)>=(nErrorFunctionCount=2)) or some such.. Change-Id: I3559e15180694961585db92f6aa98a46430ae372 (cherry picked from commit 62b40429946c0e5021912072dc79a60fc11fce06) Reviewed-on: https://gerrit.libreoffice.org/23089 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-03-09Resolves: tdf#98297 exclude error values from COUNT in array/matrixEike Rathke
Change-Id: I202dcc2a2b90ee8ed27815b97a2aad6e4df2f1b9 (cherry picked from commit b2f5336b08b5f638f890a626eb2aeefaf499a79b) Reviewed-on: https://gerrit.libreoffice.org/22843 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-03-08Resolves: tdf#98389 check memory requirement of matrixEike Rathke
Attachment 123203 of tdf#98389 has external references of the form [1]Data!$1:$1048576 which effectively address the entire cell range of sheet Data and allocating a matrix for a billion cells attempted to allocate 8GB+xGB of memory which the system said no-no ... Some brave soul along the road once decided that a check on the number of elements wasn't needed anymore and dared to remove it during refactoring.. This change reintroduces the check and adds it also to other places that try to instanciate or resize a matrix. When allocation of a matrix for an external range reference fails it is checked whether the request is for such nasty entire rows or entire columns ranges and if so tries to shrink the range to the actual data area used, which at least in this case helps and works. Additionally it fixes a long standing bug in the cached area to array mapping which caused the cache to not be hit but instead the matrix was aquired over and over again for the same range, causing a serious performance bottle neck specifically for VLOOKUP and related functions where the same external range is used in a lot of cells. (cherry picked from commit 9e60bbdb3aa5f80ca80c9c4fdf7accd12c4a5d1c) Change in convertToTokenArray() backported to older code flow. disable means Enable(false), not true.. tdf#98389 related EnableAdjustHeight(true) lead to the side effect that when clearing the range of a pivot table during import, formulas in the same rows were recalculated with then empty data. Through xSheetOp->clearContents() in PivotTable::finalizeImport() of sc/source/filter/oox/pivottablebuffer.cxx In the case of the bugdoc attached to tdf#98389 that lead to all VLOOKUP() calls resulting in #N/A errors because an empty string was looked up. (cherry picked from commit 088ba465d6bb0931c7034d564a3077e21078cb13) e629ce871d255cc871671165c4da974f21041cec setCellRangeData: check matrix size before operating, tdf#98389 follow-up Now that we can have the one element error matrix we can't blindly call ExecuteOperation() on it that would access elements out of bounds. (cherry picked from commit 9cae3a88587deaf22ee83b2e36487013a1220a3b) Backported to older code flow. b6e5525f685c9324235f128a943dd716ea7a3fca Change-Id: I35f67b48e665bf1cc8d672325c32b889f2e05c57 Reviewed-on: https://gerrit.libreoffice.org/22988 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-03-03tdf#97215 Sorting with update reference causes crashArul Michael
The memory of SvtBroadcaster* of a cell is freed in EndlisteningCell() during SplitFormulaGroups call. The same memory address is assigned back to the cell again when the contents are transferred back after sorting. This is because the CreateSortinfoArray is done before SplitformulaGroup. For fix getting mpbroadcaster from the Document instead of SortinfoArray since we change the broadcaster in document after creating the SortInfoArray. Change-Id: Ic492d5019e26ff204307db4fefccc48ec99c0a6d Reviewed-on: https://gerrit.libreoffice.org/22607 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com> (cherry picked from commit fca1147953989ef26e641e2ee9bb7e6390a69dd6) Reviewed-on: https://gerrit.libreoffice.org/22877
2016-03-01fix the "group not recalculated after delete" second part of tdf#97897Eike Rathke
If a formula cell group was split during deletion and the group also listened into the range where a cell was deleted, the group wasn't notified of the deletion. Change-Id: I858f5d4c0b647636611133fc32f3df7fbdaf7288 (cherry picked from commit 164419bfe6270015ccf94183c0b6273da7730391) Reviewed-on: https://gerrit.libreoffice.org/22783 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-03-01tdf#97369/#97587 - Further fix SUMming in the software interpreterMarco Cecchetti
When SUMming in the software interpreter involved trailing empty cells, code tried to read beyond numeric array limit. Change-Id: I50c1148e7e79d02bedb02a771df172035112915c
2016-02-29tdf#97963: Impose size limit on all 3 edit windowsKatarina Behrens
Doing it for 1 window (tdf#90257) isn't enough, the dialog will grow outta screen with large fonts not immediately, but on the next opening Change-Id: I890ecd91a00efc4c7596b30a237f5abb4f87215a Reviewed-on: https://gerrit.libreoffice.org/22739 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> (cherry picked from commit 787e17d15a1cdb259b56f91bfda9af80b95167c3) Reviewed-on: https://gerrit.libreoffice.org/22758 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-02-09tdf#97369: Fix SUMming in the software interpreterTor Lillqvist
GetRefRowSize() is not what we want, but GetArrayLength(). I think. At least helps in the sample document. (Need a hard recalc after loading it, though, but I assume that is expected.) Also, fix the handling of multiple columns in the area being summed. Change-Id: I21477ca83042a40a300bc033e4a8b74ab5fc3015 Reviewed-on: https://gerrit.libreoffice.org/22153 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/22200 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2016-02-08tdf#97587: Treat plain NaNs as zero in the software interpreter for SUMTor Lillqvist
The NaNs that have been stored in the arrays by ScColumn::FetchVectorRefArray() and other code correspond to empty cells. For the purpose of SUM they should be treated as zero. Change-Id: I8ac0c8afdf71da415ed120f9f8f6d51a8b5edb15 Reviewed-on: https://gerrit.libreoffice.org/22199 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2016-02-05Resolves: tdf#97465 like scroll ignore wheel for sc input handler inputchangedCaolán McNamara
Change-Id: Ide7fe1388ffe6f85a1f459037316d03193470d8a (cherry picked from commit e35f3b6a3357fc3832a9d68ed37ddb9b5320ef0a)
2016-02-02Resolves: tdf#93151 handle ExpandRefs and mnColDelta the same as mnRowDeltaEike Rathke
Change-Id: I8cd00494fc63124443fc01582296ef17f4cd5e27 (cherry picked from commit 02e69f0c3acec2c2e81692bc53c4356591a84ba5) Reviewed-on: https://gerrit.libreoffice.org/21812 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-01-27tdf#96222: Don't attempt to handle matrix formulas as formula groupsTor Lillqvist
(Also known as array formulas.) (cherry picked from commit aee3355a8a7a6b7749f2eddd74e9389fe5782186) (cherry picked from commit 4d43f0c018c1f0fb12f55ebb16c074fb60a8aa73) Change-Id: Ief61c75efb05ea7c880d05e118d9fe10177774db Reviewed-on: https://gerrit.libreoffice.org/21839 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2016-01-26tdf#97247 Keep focus on merged cell at top-left cornerTakeshi Abe
... when typing either UP or LEFT key. Change-Id: I7bc0e7eb0cba322bcc26c35d0474ea558d3bdd6e Reviewed-on: https://gerrit.libreoffice.org/21599 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com> (cherry picked from commit c13226bcc5b298dacfe32340711bdfd4d15d8b3b) Reviewed-on: https://gerrit.libreoffice.org/21652 Tested-by: Jenkins <ci@libreoffice.org>
2016-01-25tdf#74667 interchange slope and intercept for power regressionTomaž Vajngerl
Change-Id: I9da7edeabcc9f963ac19d26114fa101d4b5ce98f (cherry picked from commit 4d67b0baaa4f0fb009b9ee6fbcf4618abf009f53) Reviewed-on: https://gerrit.libreoffice.org/21743 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-01-25tdf#96910 : Calc crashes while using "Insert Column Left" for large DocumentsYogesh
Change-Id: I6e813b7525a3d9b1db131db9f08fc20f7320345f Reviewed-on: https://gerrit.libreoffice.org/21661 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit 208883398dcf9af6b88611097d1f75d5fbc9afad) Reviewed-on: https://gerrit.libreoffice.org/21791 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-01-24tdf#97308: fix logic with conditional "ends with"Julien Nabet
Change-Id: Ib9f9ed627dc37b11d8c3911aa4fe62141ff471c2 Reviewed-on: https://gerrit.libreoffice.org/21723 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr> (cherry picked from commit a0a4ea3c636fc18cca6a3b2f9391996fb909e81f) Reviewed-on: https://gerrit.libreoffice.org/21730 Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-01-20Make virtual ~ScValidationDlg non-inlineStephan Bergmann
...otherwise, GCC 6 would aggressively inline ScValidationDlg destruction of the VclPtr<ScValidationDlg> in ScValidityRefChildWin::ScValidityRefChildWin (sc/source/ui/view/reffact.cxx, in sc library), checking whether the vtable points at ~ScValidationDlg (instead of a derived class dtor) to directly inline the ~ScValidationDlg code, which requires the ScValidateionDlg vtable (to store it in the object's vtable during destruction), which requires the code of inline virtual ScValidationDlg::dispose and ScValidationDlg::Close, which in turn need the addresses of (non-inline) ScValidationDlg::RemoveRefDlg and ScTPValidationValue::RemoveRefDlg, both defined in the scui library and not exported from there. Change-Id: I7eb96f42deb5edd844d91e999aa5511679302c01 (cherry picked from commit 8d1a24dae03690b576310e3539369916f31ac475) Reviewed-on: https://gerrit.libreoffice.org/21637 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-01-19follow-up of tdf#89031Winfried Donkers
No function name hints or autocompletion when character right of caret is '$' Change-Id: I4fcfa6e29e5671e97743c7fc520953721d0bda24 Reviewed-on: https://gerrit.libreoffice.org/21577 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 1e2bcb3177d58e6f446296ae28fcff7f5da9b620) Reviewed-on: https://gerrit.libreoffice.org/21601
2016-01-18oox: move enum DocumentType out of drawingml.hxxMichael Stahl
... which has nasty dependencies. Change-Id: I84ba0302142ade6e15291b782453dbe3bac753dd (cherry picked from commit 3e0bc5c7fe715ebd38bfa64a49b23df58d6d29a9) Reviewed-on: https://gerrit.libreoffice.org/21493 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-01-12New saving behaviorMaxim Monastirsky
Changes in this commit: - AlwaysAllowSave config is gone. Saving is always permitted, unless in a read only document. Also changed the behavior in dbaccess to match sfx2. - The toolbar save button is always enabled, to always give access to the dropdown. That's the case even in a read only document, except that it changes to DROPDOWNONLY, and the save as command icon+tooltip. In table/query designers we still disable the button in read only state. - When the document is modified, the toolbar button gets a special icon to indicate that. Reviewed-on: https://gerrit.libreoffice.org/20839 Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com> Tested-by: Maxim Monastirsky <momonasmon@gmail.com> (cherry picked from commit 22328a224df4619218b88205838307f70612207e) loplugin:unreffun (cherry picked from commit ea708936c4684668f9aefc3ce9ec2001dbd4bdf2) Change-Id: I56c169bf48b78faaf53c2989ce8624f8297ffb6e Tango: Update Save icons and support “savemodified” status Change-Id: I03589895437907b9048542f07128801577fe62dc (cherry picked from commit a7198d38f0294ab5db04a7f4457565ea8b2c32f1) Reviewed-on: https://gerrit.libreoffice.org/21260 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Jenkins <ci@libreoffice.org> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-01-12tdf#90606 Crash when delete a large part of a column with shift cells leftArul
skipping splitFormulaCellGroup() and joinFormulaCellAbove() for nEndRow equal to MAXROW since nEndRow + 1 is not valid Change-Id: Iabfcb33bf58d20331841ca386cca4a91fd6598bf Reviewed-on: https://gerrit.libreoffice.org/21389 Reviewed-by: jan iversen <jani@documentfoundation.org> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 975ceab198a06558875006bbd9a4d0a2708e416e) Reviewed-on: https://gerrit.libreoffice.org/21392
2016-01-07Resolves: tdf#94208 broadcast fill undo (for deleted cells)Eike Rathke
Change-Id: I0fb54956bffc77dad4236b326eee3af836017623 (cherry picked from commit ece5cc21aa7814be79016e0d285981c6ced4d9ee) Reviewed-on: https://gerrit.libreoffice.org/21206 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-01-05tdf#96198 add WEEKNUM_OOO compatibility function, tdf#50950 follow-upEike Rathke
The remaining cases when loading old and wrong ISOWEEKNUM that can't be mapped to either new WEEKNUM or ISOWEEKNUM now are mapped to WEEKNUM_OOO(date,mode) with calculations identical to the old and wrong OOo WEEKNUM. These WEEKNUM_OOO cases are still wrongly saved as ISOWEEKNUM so can be read by 5.0 or earlier versions as the old WEEKNUM, which should be changed for 5.3 or later. WEEKNUM_OOO is not offered in the Function Wizard to prevent deliberate usage. Also reverts the interim unit test change to sc/qa/unit/data/contentCSV/date-time-functions.csv that was necessary to catch the error generated by ISOWEEKNUM with two arguments. (cherry picked from commit 902c593196741ffec2d096855369313f6bbe756e) Conflicts: include/formula/compiler.hrc sc/inc/helpids.h sc/source/filter/excel/xlformula.cxx Change-Id: I874c4c7225900f03b879f2947512ae02270cbd4f
2016-01-04correct WEEKNUM DayOfWeek handling, tdf#50950 follow-up, tdf#95419 relatedEike Rathke
Slight misinterpretation of the {Sunday, Monday, Monday, Tuesday, ..., Sunday} sequence defined in ODFF. Change-Id: I09ac711adf8a52db1c9efbb1c67dc908b8e06618 (cherry picked from commit 7ea839ae3904d96dcea35a0339f3e6ee7d58bbaa)
2016-01-04correct ISOWEEKNUM resource ExtraData parameter flags, tdf#50950 follow-upEike Rathke
... which now has exactly 1 parameter; removed the now non-matching required flag of a not existing second parameter. Luckily the resource manager treats this as a separate record block and this 0 didn't harm the subsequent 0, accidentally.. Change-Id: I0994ed75643245c1bdebc9a92ade77abdd1c61d8 (cherry picked from commit 68098cf1551d0b27cb723c927b5fd3bc2ba9b3ac)
2016-01-04WEEKNUM second parameter is optional defaulting to 1, tdf#50950 follow-upEike Rathke
Change-Id: I64b22f91bf56497b9f705e4773e24c5ba88a14ae (cherry picked from commit 1c5eb11d42ccdacdaf29e0b8f26c4f674069f227)
2015-12-21tdf#93949 ensure memory stream is properly flushedTomaž Vajngerl
Change-Id: I6d6a926f5d3fd62dd3b7b78a5721f6483b3b4ee7 (cherry picked from commit c6b11cf681f8e8d131031ea7e5d19c4b6473503a) Reviewed-on: https://gerrit.libreoffice.org/20841 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2015-12-18Formula Wizard: evaluating expressions always in matrix context is wrongEike Rathke
Change-Id: I276f7bbf2bd6fa7c67d8691634ad9d79e4a08b1c (cherry picked from commit dc89367a5622748dd7c37b89ac300a663b8b98e9)
2015-12-18crashtesting: crash on converting ooo93489-1.ods to pdfCaolán McNamara
with --headless --convert-to pdf ooo93489-1.ods probable regression from... commit d4daad185e9583bedbb5a4eef1fd53e1f22e219b Author: Jan Holesovsky <kendy@collabora.com> Date: Mon Nov 30 10:28:43 2015 +0100 sc interpreter: Move the code that can create a ScFullMatrix. In that original code I see there was a check for "Data array is shorter than the row size of the reference. Truncate it to the data" which doesn't exist anymore. If I reintroduce that check here the crash is avoided. Change-Id: I7c7a5979d9c14c133b05e89ce3794e6b739ca61c Reviewed-on: https://gerrit.libreoffice.org/20794 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com> (cherry picked from commit ddeca090ba612cdd5a2d55785fb1c4b66b6bc0a5) Reviewed-on: https://gerrit.libreoffice.org/20800
2015-12-15filter: add BaseURL parameter to SvxMSDffManager::ImportOLE()Michael Stahl
... mainly for the (unlikely) case of ODF embedded objects in MSO binary files, which can be created by toggling the Tools->Options->Load/Save->Microsoft Office export settings. Change-Id: I270f1516b70b20ec0b60cfbd17c2c327c3d9efd0 (cherry picked from commit 36a0abed4ab27abd77b502070d4e17e70e6afe7b)
2015-12-15Resolves: tdf#95440 SharedString are interned per document, re-internEike Rathke
... if literal strings are copied with formula expression tokens. Change-Id: I13526907bb6c2c605c6ed9584fa6e3f2b18623b8 (cherry picked from commit dad412e07f805a53ad73ce2e80d187a70c77e8de)
2015-12-12tdf#73006 : Put results in correct cells after Text to ColumnsDennis Francis
Change-Id: I7a1653424edd93b2de0597ce8a94aa5f4fa85622 Reviewed-on: https://gerrit.libreoffice.org/20673 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2015-12-12tdf#96339 fix bug in sort listNoel Grandin
this bug was caused by commit 2aacf6c2cd82322b953988ff30d3bc997ae76d7b "sc: boost::ptr_vector->std::vector" Since the code in question likes passing around a pointer to the element of the vector, convert to using std::vector<std::unique_ptr> Change-Id: I9e9676fe7c2dc32e23ba6708aaea1f16c1bf2ff8 (cherry picked from commit 0bcef149ce3785306271fa06184eb62950b62087)
2015-12-11separate ScRange::Move() and MoveSticky(), tdf#92779Eike Rathke
To selectively use the sticky mechanism, i.e. not in an actual move of a range during cut&paste or drag&drop. Actually currently only in ScTokenArray::AdjustReferenceOnShift() Change-Id: I223e5013e4b820efb4ecb9e8ce8aa04a8bc01e27 (cherry picked from commit 21dfe37aca134b22cdbdb73fc29d30a89cd85524)
2015-12-11geez, how about actually checking the Move() error return? tdf#92779 relatedEike Rathke
Handle failure condition where we know how to treat it, i.e. when updating references, assert in all other places that so far silently ignored it and implicitly assumed the failing Move() truncating at bounds would be alright. In case we'll encounter an assertion we'll have to inspect those places and decide what to do about it. Noticed this error with a reference like B1048575 and inserting two rows above, it became B1048576 instead of B#REF! Change-Id: I00757f3ed2e305b591178047933ed60f1533317e (cherry picked from commit 9c1ba0988f5db05bb796eaf7cf902a0b601c6736)
2015-12-11sticky end only if it already was a range on the same axis, tdf#92779Eike Rathke
Change-Id: I66f624e696a4a6e681733ab863cd57c342cc0bc1 (cherry picked from commit d6f6459350e9e661bc09191cfb31c5e779d522de)
2015-12-10tdf#93263: Take function mask from ScPivotFieldKatarina Behrens
and not from ScDPLabelData (that's what old code used to do as well). Afaics ScDPLabelData.mnFuncMask member is never modified as the array gets populated in ScDPObject::FillLabelDataForDimension. UI has thus only its default value (PIVOT_FUNC_NONE) and so subtotals get reset on every change. ScPivotField however contains the right func mask, so take it from there. Change-Id: I862be121683aac079e788ce535f714ac8cdbcd0b Reviewed-on: https://gerrit.libreoffice.org/20041 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 0bfa6ddc99710c1e166140f97cf3212348d04d05) Reviewed-on: https://gerrit.libreoffice.org/20626
2015-12-10display as entire col/row also if both anchors relative, tdf#92779Eike Rathke
... if not in named expression. Change-Id: Ie50fedd2303021c925e006d9a8db6ed02321ae5e (cherry picked from commit a0c4ce340d253d5f197f4e96676225f3f5f216de)
2015-12-10sticky end col/row anchor for range references, tdf#92779Eike Rathke
In range references referring more than one column/row where the end col/row points to the maximum column or row number that col/row is not decremented when the range is shrunken. Incrementing an end col/row is not done past the maximum column or row number, so such references do not yield #REF! errors anymore. This is also done in named expressions if the end col/row is an absolute reference. Change-Id: Iafa2d62abd3e816a1c56c3166af92807e55b75ce (cherry picked from commit cfecdd6199710921f8fd921f615203c9e34c551e)
2015-12-08tdf#96202 Revert accelerator back to 'I'Yousuf Philips
Change-Id: Ie07d0b27c18a9cd66e6afd32163f773340967a6b Reviewed-on: https://gerrit.libreoffice.org/20437 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> (cherry picked from commit 14fb1d6421802be3b69ff50dcd9703c2596df4e3) Reviewed-on: https://gerrit.libreoffice.org/20463 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2015-12-01Resolves: tdf#95629 quote CSV also if cell contains embedded '\r' CREike Rathke
Change-Id: I37fb62a53338a7edcac1c72153eefcee6096e6f9 (cherry picked from commit 129935443cfd9378e1263489fc4bf47aee1f1a46)
2015-12-01sc interpreter: Don't throw when we hit something not yet implemented.Jan Holesovsky
Instead create a ScFullMatrix, and perform the operation using that. This has a performance penalty, as we need to copy the data from ScVectorRefMatrix to the ScFullMatrix; but this is one-off, and the same performance penalty that was there before introducing ScVectorRefMatrix. Additionally now we can optimize the methods that appear to be the bottlenecks one after another (and whitelist them). Change-Id: If94a5017b96fb914817cfd7ed1b7ae823db8b5f5
2015-12-01sc interpreter: Move the code that can create a ScFullMatrix.Jan Holesovsky
For the operations that we haven't implemented directly in ScVectorRefMatrix yet, create the ScFullMatrix the same way as we used to do before, and call the appropriate method of ScFullMatrix. This commit only moves the code, does not turn the 'throw std::runtime_exception' into actually using the new ensureFullMatrix(). Change-Id: I336a4ddf07b0b60a5a41036e19c70a44ba575834
2015-12-01sc interpreter: Don't hide S/W Interpreter behind an environment variable.Jan Holesovsky
Instead provide a user setting that can be enabled so that the S/W Interpreter is used on a subset of the operations. The operations for which it is used are controlled by a whitelist in ScCalcConfig::setOpenCLConfigToDefault(). Change-Id: I7d3f3a864fcb1231e5484ec23961f14fca1466c5
2015-12-01Resolves: tdf#95748 no group interpreter when calculations are runningEike Rathke
Change-Id: I17283fc5e39da2d7222c302dd63522df69d0ad96 (cherry picked from commit d46203b55d92185ab2c1d3ac79761100d26aaee3)
2015-12-01add DebugCalculationEntry::mnGroupEike Rathke
Change-Id: Ic8b6c661be7570479c271d3ce0aa750e13724fc7 (cherry picked from commit 87ad1705746f8e6a15ae60037a1dd8a163eeecd7)
generated by cgit (git 2.34.1) at 2024-06-17 15:03:13 +0000