summaryrefslogtreecommitdiff
path: root/sc/source
AgeCommit message (Collapse)Author
2017-03-28fix too small loop varJochen Nitschke
Change-Id: Icaa64ac579a55f53fb1397e5eeee6dcc4c9d37cc Reviewed-on: https://gerrit.libreoffice.org/35802 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-03-28Turn XclSupbookType into scoped enum and add operator<< for SAL_INFO etcTor Lillqvist
Part of preparatory work for handling xlExternalLinkPath/xlPathMissing. Change-Id: I29b77bb2680e4dbf293ab65bda5401afee132f11
2017-03-28Bin an unused and a used-once typedefTor Lillqvist
Change-Id: I3f93378889d2c8eb0476dba4a4ea5aca31647f5c
2017-03-28First steps to round-trip xlExternalLinkPath/xlPathMissing thingsTor Lillqvist
Links to broken or missing external workbooks in .xlsx have the relationship type http://schemas.microsoft.com/office/2006/relationships/xlExternalLinkPath/xlPathMissing . Ideally we should round-trip those (save identically back to .xlsx). Currently we don't save them at all, and Excel doesn't like formulas that refer to such external (but not mentioned in externalLinks) workbooks. Just a start, does not actually produce anything useful yet. Change-Id: Ic5a481c91864134f1caf66c56a4aef685d3018a7
2017-03-28tdf#42949: clean up includes in include/svx/[a-c]* with iwyuJorenz Paragas
Change-Id: I7768f4dbe9892c4264cb16eed87497894aa7494e Reviewed-on: https://gerrit.libreoffice.org/26582 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-03-28sc: include cleanup for --enable_formula_loggerJochen Nitschke
don't include osl/file.hxx everywhere it's only needed for --enable_formula_logger builds Change-Id: I6ba30351b5a7afe975ea859e838930f9d1454c8c Reviewed-on: https://gerrit.libreoffice.org/35766 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2017-03-27tdf#39468 translate German source code commentsdennisroczek
Change-Id: Ic10f7543daed77a516155f7130838a1e8558243f Reviewed-on: https://gerrit.libreoffice.org/34833 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-03-27Move StackVarEnumToString to <formula/token.hxx> and use in a SAL_INFOTor Lillqvist
Once StackVarEnum has been changed to a scoped enum, we should probably add an operator<< for it, too. Is 'std::string FooToString(Foo e)' a good return type, signature, and naming pattern for functions to turn enums into strings? Would return type OUString be better? Is there some consistent existing convention? For use only in SAL_INFO and friends, probably just an operator<< is enough? Change-Id: I89abbcb37ba2ab925b0a9d7fc6294d8f9ee5aebd
2017-03-27change int to enumJochen Nitschke
plus some includes cleanup Change-Id: I3b57264ed67fc49ee06b825bbbeb397f596d0bea Reviewed-on: https://gerrit.libreoffice.org/35752 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-27create SfxInterfaceId o3tl::strong_intNoel Grandin
Change-Id: Ie52f63382a9fb36f9a472801be012b140bfb51f6 Reviewed-on: https://gerrit.libreoffice.org/35722 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-27handle date autofilter entries correctly, tdf#106214Markus Mohrhard
Change-Id: I8fd2896c8998e79794a0ccaae1c2442caf8b89ac Reviewed-on: https://gerrit.libreoffice.org/35730 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-03-26Kill remaining PseudoSlots usageMaxim Monastirsky
Change-Id: I14a820b7c0baba8d8b17d07715bf17c42c73c8fb TODO: Remove support code from idl and sfx2 modules Reviewed-on: https://gerrit.libreoffice.org/35718 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2017-03-26uitest: add more IDs to autofilter elementsMarkus Mohrhard
Change-Id: I6b22409403cf9ab39c9a120c712976316bf3a22a Reviewed-on: https://gerrit.libreoffice.org/35696 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-03-26uitest: add ability to open autofilter dialogMarkus Mohrhard
Change-Id: If03b2699975756ab650488abe032aefa8880a6b4 Reviewed-on: https://gerrit.libreoffice.org/35692 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-03-26uitest: add id to autofilter popupMarkus Mohrhard
Change-Id: Icf3b731c18333d97aa43535e31df73bc2dbfba42 Reviewed-on: https://gerrit.libreoffice.org/35691 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-03-25Fix typosAndrea Gelmini
Change-Id: I4e1a613fc99b931e84a1955695364e1d25e25e5c Reviewed-on: https://gerrit.libreoffice.org/35642 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-03-25Fix typosAndrea Gelmini
Change-Id: Ia17fe891f8a681ada69639ca579ebf6d6d781759 Reviewed-on: https://gerrit.libreoffice.org/35641 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-03-25loplugin:redundantcastStephan Bergmann
Change-Id: I61676e74413942ff5bde9ae8d376269a651bf93a Reviewed-on: https://gerrit.libreoffice.org/35676 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-03-24tdf#105908: restore previously deleted range references upon undo.Kohei Yoshida
Change-Id: If1932a5eb10da4c50fbcc3329af75f2e7a0a5137 Reviewed-on: https://gerrit.libreoffice.org/35607 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2017-03-24tdf#86119 Fix toggle behaviour of SID_NUMBER_TWODEC.Gulsah Kose
Change-Id: If17935cbb35c1a57fe9ea4cfaca58385ed437842 Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com>
2017-03-24convert ViewShellId to o3tl::strong_intNoel Grandin
Change-Id: I45553d11d56aa8c4432aec126ca51f24bd3ead09 Reviewed-on: https://gerrit.libreoffice.org/35421 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-24Remove near-duplicated code.Kohei Yoshida
Change-Id: I46e743ae47c76c4e9c22d092f501636ebab92878 Reviewed-on: https://gerrit.libreoffice.org/35606 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2017-03-23Remove unused #include <ctype.h>Stephan Bergmann
Change-Id: I8bf3e30687e20151a9e1936e69362abfe9b3a99d
2017-03-23convert ScMatrixMode to scoped enumNoel Grandin
and fix a bug in ScChangeActionContent::SetValueString where it was passing the grammar as the ScMatrixMode to the ScFormulaCell constructor. Change-Id: I7c1a174cdd8365dedc30cff0b26e3079bb8b84f3 Reviewed-on: https://gerrit.libreoffice.org/35552 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-23remove unused helpid in SfxShellNoel Grandin
Unused since commit 2c8fe2e737b84ecd3dbac36a4fe6bd061bbd3bae "update unusedmethods plugin to deal with constructors" where I removed a unused SfxDockingWindow constructor. And in that case, the helpid was only being used to assign the window a UniqueId. Change-Id: I148e424424fcf08449440b83a8600071b39d7a07 Reviewed-on: https://gerrit.libreoffice.org/35554 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-23loplugins:redundantcast teach it about c-style typedef castsNoel Grandin
Change-Id: I1ac11a2481c0f4d8be1e1fd7c7637ac0ece3d65c Reviewed-on: https://gerrit.libreoffice.org/35558 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-23convert SC_CELL_SHIFT_DISABLE to o3tl::typed_flags enumNoel Grandin
Change-Id: Iae4358828edc6bad26ef5c769a8ff42fe63ade7b Reviewed-on: https://gerrit.libreoffice.org/35556 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-23convert NAME constants to CreateNameFlags o3tl::typed_flags enumNoel Grandin
Change-Id: I6265c76067402808454184f1318feeb78a140617 Reviewed-on: https://gerrit.libreoffice.org/35555 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-23convert INS_CONT constants to o3tl::typed_flags enumNoel Grandin
Change-Id: Ic59dad906c58ee765f36fac685c038c79bca9f3b Reviewed-on: https://gerrit.libreoffice.org/35557 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-23“Hyperlink” is NOT a dated word, it’s just a precise oneAdolfo Jayme Barrientos
We should always be clear and precise, given that LibreOffice handles various kinds of links. Nobody at L10n wanted this change, but they were ignored. This should fix tdf#103093, which was a consequence of the introduced ambiguity. This reverts commit a1297fc2df243d765ffb14f18bbdde158459b9f4. Change-Id: I29232c7a8384c3fa501c61aab26e061ebcb1a0d8
2017-03-23Typo: boder->borderJulien Nabet
Change-Id: I46940c5b584f93b478b1dfca9aa66e036fe951c2 Reviewed-on: https://gerrit.libreoffice.org/35547 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-03-22Use rtl::isAscii* instead of ctype.h is* (and fix passing plain char)Stephan Bergmann
Change-Id: Ia3cc11ed882bf7e58c008f68af4340336c82b119
2017-03-22tdf#96099 Reduce no of typedefs used for trivial containersDennis Nielen
Change-Id: Idf7bd4c80f9dc1fb9f93859e1e1106dd620d2311 Reviewed-on: https://gerrit.libreoffice.org/35511 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-22fix typo: bee --> be or beendennisroczek
* Removed old comment cruft * clean up some indentation Change-Id: I0ddbd66aec0f27d7563dc4c2cfa2e095a48cda46 Reviewed-on: https://gerrit.libreoffice.org/35134 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-03-22loplugin:redundantcast find redundant c-style enum castsNoel Grandin
Change-Id: I2dab376d87804521aed6b6bd41ad7762830fa349 Reviewed-on: https://gerrit.libreoffice.org/35467 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-20remove unused defines from HRC files in misc(2)Noel Grandin
Change-Id: I6d27c03925e7756022c3e343c0873c4dd1dd90dc Reviewed-on: https://gerrit.libreoffice.org/35324 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-20remove unused defines from HRC files in sc(2)Noel Grandin
Change-Id: I368abd0c39151c65ac8f0d56cbb6f2c498131534 Reviewed-on: https://gerrit.libreoffice.org/35322 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-19TyposJulien Nabet
Change-Id: I13020539fe121151e884a90d72d47788fb3ae65c Reviewed-on: https://gerrit.libreoffice.org/35436 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-03-19Fix typos + some German translationsAndrea Gelmini
Change-Id: I1c5bb725ffdf72363279436ad9bbb88064228253 Reviewed-on: https://gerrit.libreoffice.org/35406 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-03-18remove EE_RESSTR preprocessor abuseBjoern Michaelsen
Change-Id: I83b35c4e2d4275ac76a36bec03807be69a605c58 Reviewed-on: https://gerrit.libreoffice.org/35370 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2017-03-17Use SfxObjectFactory::GetFactoryName/URLMatteo Casalin
instead of OUString::createFromAscii( GetShortName() ), in one case manually added to factory URL prefix. Change-Id: I762fc1bcd6dcf7246531816faad2682caf9133fb Reviewed-on: https://gerrit.libreoffice.org/35371 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
2017-03-17remove unused defines from HRC files in sc(1)Noel Grandin
Change-Id: I7803a0564b2f7a2308bd7d009dbd300bec8a755f Reviewed-on: https://gerrit.libreoffice.org/35316 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-17cleanup double includes and declarationsJochen Nitschke
Change-Id: I770e09f48b1a3e8299f59a8e475ba3c18d436d7b Reviewed-on: https://gerrit.libreoffice.org/35312 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2017-03-17convert SvxBorderStyle to scoped enumNoel Grandin
and rename to SvxBorderLineStyle Change-Id: I19e530f162e4ca6290a0ad076e7fe3d5775ae6bc Reviewed-on: https://gerrit.libreoffice.org/35265 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-17CopyOneCellFromClip also copies one row ranges, tdf#106242Markus Mohrhard
Change-Id: I1750d411766ba2b4128fc1c00769a8b2e56e7547 Reviewed-on: https://gerrit.libreoffice.org/35294 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-03-17tdf#104383: prevent crash during file load.Kohei Yoshida
Apparently xView may be null sometimes. Change-Id: Icef81159eeaf5c9bdb0a91e036019b820952d20b Reviewed-on: https://gerrit.libreoffice.org/35304 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2017-03-16the range should be updated after the references, tdf#104026Markus Mohrhard
Change-Id: I2cb674b8b3bc64df031b473b337d266a2eaab43d Reviewed-on: https://gerrit.libreoffice.org/35289 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-03-16use forward declaration for SfxItemSetJochen Nitschke
Change-Id: I81f5d1ca22868d278662a55443e2038581dd3246 Reviewed-on: https://gerrit.libreoffice.org/35280 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-16sc lok: Edit annotation by idPranav Kant
Change-Id: Iaea08b7a31fab1a8c9b8edc193754821c6608c53 Reviewed-on: https://gerrit.libreoffice.org/35249 Reviewed-by: pranavk <pranavk@collabora.co.uk> Tested-by: pranavk <pranavk@collabora.co.uk>
2017-03-16sc lok: Delete cell note by IdPranav Kant
Change-Id: I97224afb4eb7af36abefd0c3b59ee07de7eaa601 Reviewed-on: https://gerrit.libreoffice.org/35247 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: pranavk <pranavk@collabora.co.uk>