summaryrefslogtreecommitdiff
path: root/sc/source
AgeCommit message (Collapse)Author
2019-06-19tdf#125309 XLSX editing: fix hyperlink at numeric dataTünde Tóth
Long Cell-level hyperlink was clickable in neighboring cells. Change-Id: I3e2a4db170975d997f3fe471188fd0ead593ad6e Reviewed-on: https://gerrit.libreoffice.org/74033 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
2019-06-19fix memory usage regression when loading files with lots of marksNoel Grandin
regression from commit 3c3a371c799d00475deb13b4c3e0a8860c7e4fb3 Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Wed May 15 15:35:51 2019 +0200 tdf#125254 Performance: A spreadsheet opens too slow, part2 without this fix, the file from the above bug chews up more than 16G and crashes my box. With the fix, it loads, and requires about 2G. Change-Id: I87063196e56b49eab52e77126347bf8d421b1e0f Reviewed-on: https://gerrit.libreoffice.org/74352 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-18loplugin:passstuffbyrefNoel Grandin
Change-Id: Icb7c22cf4ac95eab54d04e79312fb471ca27bceb Reviewed-on: https://gerrit.libreoffice.org/74246 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-18tdf#39593 Remove ScModelObj::getImplementationArkadiy Illarionov
Replace with comphelper::getUnoTunnelImplementation. Change-Id: I06a8db37b5c5c38c52a15a76e6e2df3b431a2040 Reviewed-on: https://gerrit.libreoffice.org/74237 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-06-18Fix typosAndrea Gelmini
Change-Id: I7afd722b18759366bda139c8b881c03c35623e24 Reviewed-on: https://gerrit.libreoffice.org/74256 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-18tdf#42949 Fix IWYU warnings in include/svx/[t-v]*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I345b8c54890b5bc27f51addd2e6e73ba68b6b327 Reviewed-on: https://gerrit.libreoffice.org/73977 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-06-17Add comphelper::getUnoTunnelImplementation templateArkadiy Illarionov
Use it instead of classname::getImplementation from UNO3_GETIMPLEMENTATION_* Change-Id: Ifcc8cfcd6369c576250008c76ce31ba79ea3a596 Reviewed-on: https://gerrit.libreoffice.org/74107 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-06-15loplugin:logexceptionnicely in scNoel Grandin
Change-Id: Icaa476206312a5f81896f59fa8109448a8ea8963 Reviewed-on: https://gerrit.libreoffice.org/74101 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-14Resolves: tdf#124251 do not treat internal "URI" as real path URIEike Rathke
Change-Id: I754704b0a979e8449b7ec799cbda58b14ab17098 Reviewed-on: https://gerrit.libreoffice.org/74067 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2019-06-14remove some unused includesCaolán McNamara
Change-Id: I1a3512fd7fd50379ecd25389a894c2a3aadb7edb Reviewed-on: https://gerrit.libreoffice.org/74035 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-06-14lok: avoid locking table when ScSpecialFilterDlg is destroyedHenry Castro
ScSpecialFilterDlg by default does not lock the table, but in tiled rendering case, switching sheets are locked when the dialog is closed Thanks Michael Meeks for debugging Change-Id: Ifa32fd63085f3e082b97ad0313dff7b826b95d2e Reviewed-on: https://gerrit.libreoffice.org/72074 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com> (cherry picked from commit c5457de07e9d6e6a202f577067cf2a0f904bfcd0) Reviewed-on: https://gerrit.libreoffice.org/72096 Tested-by: Jenkins
2019-06-14loplugin:unusedfields improvementsNoel Grandin
tighten up the only calling write-only methods part of the analysis Change-Id: I5bc6fdf0ce51940653317e8a48c5241705c90d4c Reviewed-on: https://gerrit.libreoffice.org/74022 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-13Related: tdf#113541 use reference syntax of the document being editedEike Rathke
When creating a formula referencing an external document by travelling (clicking in) to that document, the reference was created using the reference syntax of the referenced document, which may be different if the syntax was changed for only one of the documents after being opened. Use the reference syntax of the document being edited instead so the created reference is correct and can be compiled. Change-Id: I07d0ce9cd911ac8e62576b4cdabdfd2569336fbf Reviewed-on: https://gerrit.libreoffice.org/73983 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2019-06-13Resolves: tdf#113541 handle external reference in Excel syntaxEike Rathke
... not only OOXML. This wasn't only a problem when creating a reference by clicking or travelling to a cell in the external document, but also when editing an external reference in Excel_A1 or Excel_R1C1 reference syntax. Change-Id: Iee3d529ff9834e5013a61c2056238277f33356fe Reviewed-on: https://gerrit.libreoffice.org/73979 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2019-06-13Intel OpenCL also has broken nan() that ignores the argumentLuboš Luňák
And since whether this works correctly is tested by cl-test.ods, without this OpenCL gets disabled on Intel machines. Change-Id: I8d5c9b1298a08f2e2cb6dfdf183f542315372889 Reviewed-on: https://gerrit.libreoffice.org/73887 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-06-12Change some static const variables to constexprEike Rathke
Also use some static const OUString instead of const OUString (or even static char[]) to not allocate every time in the Convention. Change-Id: I176b0a39667b7c4a3856fc9de0a6a24e58d54dd0 Reviewed-on: https://gerrit.libreoffice.org/73826 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2019-06-12tdf#125791 sc autofilter popup: make sure menu item text uses the label fontMiklos Vajna
It happened that the first and subsequent paints used a different font size, standardize on the label font. E.g. the linux gen backend used either 11 or 12 pt font height, now it always uses 12pt, matching the gtk3 behavior. (No cutoff of text with Windows gdi 125% text size this way, either.) Change-Id: Ia3f7b69c5a76e1c15fe04743870e92cffdc351d7 Reviewed-on: https://gerrit.libreoffice.org/73870 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-06-12loplugin:unusedmethodsNoel Grandin
Change-Id: I42667e8483d2cb4363227344faca3899bd95d424 Reviewed-on: https://gerrit.libreoffice.org/73824 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-12Revert "improve empty tools::Rectangle (width)"Noel Grandin
This reverts commit a46a257794f1f53b294735fc876c394be23a3811. Too many issues, I'm going to try landing this in smaller pieces to make it easier to fix regressions Change-Id: Ie5e8979838017af86c119c887b580385ba068d54 Reviewed-on: https://gerrit.libreoffice.org/73859 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-11Resolves: tdf#125808 empty labels in pivot table from registered data sourceCaolán McNamara
since... commit 238cadd315901cbacfd9304bb1205e9f53f13eae Date: Wed Apr 10 04:30:25 2019 +0530 dpcache : use case-insensitive normalization of... Change-Id: I19057bde268ec07561da323bc694536dcad03a95 Reviewed-on: https://gerrit.libreoffice.org/73806 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-06-11tdf#42949 Fix IWYU warnings in include/svx/[sS][v-Z]*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ie2a4122d67d2d40732e6fd00b584f33edd802c5b Reviewed-on: https://gerrit.libreoffice.org/73476 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-06-11loplugin:virtualdown in DataProviderNoel Grandin
Change-Id: Id61d2ddc25767c642e13212be8b00c5836ce4996 Reviewed-on: https://gerrit.libreoffice.org/73764 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-08loplugin:unusedmethodsNoel Grandin
Change-Id: I52efd8d843d0e4cc7a6adefb0eb95aa50469af38 Reviewed-on: https://gerrit.libreoffice.org/73693 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-08loplugin:singlevalfieldsNoel Grandin
Change-Id: I7c00b7d932bf96a0725eac5482580461baea6977 Reviewed-on: https://gerrit.libreoffice.org/73697 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-08loplugin:unusedfieldsNoel Grandin
Change-Id: I9758fd606c7d4c251a3ac06661d642a47260b5fc Reviewed-on: https://gerrit.libreoffice.org/73674 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-07lok: re-factor getTextSelection.Michael Meeks
Change-Id: I2c27c213ee980e19d6020e9599b2b72115e7f28e Reviewed-on: https://gerrit.libreoffice.org/73626 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2019-06-07improve empty tools::Rectangle (width)Noel Grandin
This is the width part, the height part will come next. Instead of storing "empty" as a special value (which is easy to get wrong, eg. some image filters pass in that special value, expecting it to be a valid width), just use separate boolean values for width and height empty. Also lots of code was calling GetBottom() or GetRight() on an empty rectangle, getting back that magic value and doing calculations on it, resulting in completely bogus data. So (1) make the various Rectangle methods do something reasonable when the empty flags are set (2) fix various other code to handle empty better (3) assert when code accesses Bottom or Right and the empty flag is set. Change-Id: I1163378cd2773dd8b386210f83400bb6b4701069 Reviewed-on: https://gerrit.libreoffice.org/73564 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-07tdf#42949 Fix IWYU warnings in svl/Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Except source/svdde/* which is WIN-specific Also recheck include/svl Change-Id: I32d3bcb6b14665c56c07a2f10526329b08c64cbe Reviewed-on: https://gerrit.libreoffice.org/73630 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-06-04tdf#101086 sc autofilter popup: avoid flickerMiklos Vajna
Regression from commit a4cb27f61376d8f2d8faed0022c291af68d437bd (refactor ScMenuFloatingWindow to use RenderContext, 2015-05-14), the problem was that the change had two effects: 1) It removed incremental rendering that now causes flicker. 2) It added support for painting into a rendercontext, not on the window itself. Given that here a hierarchy of widgets have to be painted at once (to avoid flicker), use vcl::Window::RequestDoubleBuffering() instead of the much simpler vcl::BufferDevice. This improves the situation on Windows, but explicitly blacklist the focus rectangle case (gtk3) which is currently not compatible with this higher level double-buffering (and there we already have lower-level double-buffering anyway, similar to OpenGL). Change-Id: I77aa951e14db668166dc8757e36c037ee98243bf Reviewed-on: https://gerrit.libreoffice.org/73441 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-06-04Resolves: tdf#123752 allow group separator in formula values if possibleEike Rathke
If possible here means if it can't be an operator (is not an ASCII value) and is not any other separator. This restores the "working by chance" behaviour for some locales that use NO-BREAK SPACE as group separator. It never worked for locales that use one of the "ordinary" comma or dot or apostrophe group separator and will not. Change-Id: I8b7ba1b502b6b7367ffb2199d2f3922ab605a659 Reviewed-on: https://gerrit.libreoffice.org/73422 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2019-06-04tdf#121094 Opening xlxs with many rows takes several minutesNoel Grandin
Use a more useful expansion strategy when re-sizing the array, we use this 150% in a lot of other places. This takes the opening time from more than 4m (I lost patience) to under 5s. Change-Id: I8511662947d737c26ec49503a75af8d4cf447f67 Reviewed-on: https://gerrit.libreoffice.org/73394 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-04tdf#39593 remove IMPL_XUNOTUNNEL* macrosArkadiy Illarionov
Replace with UNO3_GETIMPLEMENTATION* macros. Replace single usage of IMPL_XUNOTUNNEL_MINIMAL with it's body. Change-Id: I7d4ad76399b999ebb2178ecf57edcf6bd2aa6c3e Reviewed-on: https://gerrit.libreoffice.org/73424 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-06-04Missing includeStephan Bergmann
Change-Id: I4c733df9c5a01f911c6a99fca21a2dd70aeecf18 Reviewed-on: https://gerrit.libreoffice.org/73407 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-06-03Resolves: tdf#125589 we are initially unsortedCaolán McNamara
so turn on sorting on first sort request Change-Id: I897f64c0695be8cca6d93e234a7d7c4718c94f78 Reviewed-on: https://gerrit.libreoffice.org/73344 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-06-03Avoid overflow with large row heightsStephan Bergmann
With -fsanitize=float-cast-overflow, opening csv/fdo54919-3.csv as obtained by bin/get-bugzilla-attachments-by-mimetype (i.e., the attachment at <https://bugs.documentfoundation.org/show_bug.cgi?id=54919#c2>) fails first with > sc/source/core/data/column2.cxx:942:75: runtime error: 73940.3 is outside the range of representable values of type 'unsigned short' > #0 in ScColumn::GetOptimalHeight(sc::RowHeightContext&, int, int, unsigned short, int) at sc/source/core/data/column2.cxx:942:75 (instdir/program/../program/libsclo.so +0xc93bfaf) > #1 in (anonymous namespace)::GetOptimalHeightsInColumn(sc::RowHeightContext&, ScColContainer&, int, int, ScProgress*, unsigned long) at sc/source/core/data/table1.cxx:114:20 (instdir/program/../program/libsclo.so +0xe02fd57) > #2 in ScTable::SetOptimalHeight(sc::RowHeightContext&, int, int, ScProgress*, unsigned long) at sc/source/core/data/table1.cxx:466:5 (instdir/program/../program/libsclo.so +0xe02ec69) > #3 in ScDocument::SetOptimalHeight(sc::RowHeightContext&, int, int, short) at sc/source/core/data/document.cxx:4267:18 (instdir/program/../program/libsclo.so +0xd18bc12) > #4 in ScDocShell::AdjustRowHeight(int, int, short) at sc/source/ui/docshell/docsh5.cxx:411:32 (instdir/program/../program/libsclo.so +0x111eb5c6) > #5 in ScImportExport::ExtText2Doc(SvStream&) at sc/source/ui/docshell/impex.cxx:1469:29 (instdir/program/../program/libsclo.so +0x11498773) > #6 in ScImportExport::ImportStream(SvStream&, rtl::OUString const&, SotClipboardFormatId) at sc/source/ui/docshell/impex.cxx:379:13 (instdir/program/../program/libsclo.so +0x11492715) > #7 in ScDocShell::ConvertFrom(SfxMedium&) at sc/source/ui/docshell/docsh.cxx:1299:35 (instdir/program/../program/libsclo.so +0x110b0cee) > #8 in SfxObjectShell::DoLoad(SfxMedium*) at sfx2/source/doc/objstor.cxx:768:23 (instdir/program/libsfxlo.so +0x49d934a) [...] and then with > sc/source/core/data/fillinfo.cxx:216:59: runtime error: 113431 is outside the range of representable values of type 'unsigned short' > #0 in (anonymous namespace)::initRowInfo(ScDocument const*, RowInfo*, unsigned long, double, int, short, int&, unsigned long&, int&) at sc/source/core/data/fillinfo.cxx:216:59 (instdir/program/../program/libsclo.so +0xdb8ebcf) > #1 in ScDocument::FillInfo(ScTableInfo&, short, int, short, int, short, double, double, bool, bool, ScMarkData const*) at sc/source/core/data/fillinfo.cxx:401:5 (instdir/program/../program/libsclo.so +0xdb7896e) > #2 in ScPrintFunc::DrawToDev(ScDocument*, OutputDevice*, double, tools::Rectangle const&, ScViewData*, bool) at sc/source/ui/view/printfun.cxx:544:11 (instdir/program/../program/libsclo.so +0x1309d461) > #3 in ScDocShell::Draw(OutputDevice*, JobSetup const&, unsigned short) at sc/source/ui/docshell/docsh4.cxx:2036:9 (instdir/program/../program/libsclo.so +0x111aabd7) > #4 in SfxObjectShell::DoDraw_Impl(OutputDevice*, Point const&, Fraction const&, Fraction const&, JobSetup const&, unsigned short) at sfx2/source/doc/objembed.cxx:229:5 (instdir/program/libsfxlo.so +0x491e953) > #5 in SfxObjectShell::DoDraw(OutputDevice*, Point const&, Size const&, JobSetup const&, unsigned short) at sfx2/source/doc/objembed.cxx:176:9 (instdir/program/libsfxlo.so +0x491cbb3) > #6 in SfxObjectShell::CreatePreviewMetaFile_Impl(bool) const at sfx2/source/doc/objcont.cxx:171:40 (instdir/program/libsfxlo.so +0x48ffc5a) > #7 in SfxObjectShell::GetPreviewMetaFile(bool) const at sfx2/source/doc/objcont.cxx:118:12 (instdir/program/libsfxlo.so +0x48fdc15) > #8 in SfxPickListImpl::AddDocumentToPickList(SfxObjectShell*) at sfx2/source/appl/sfxpicklist.cxx:135:62 (instdir/program/libsfxlo.so +0x361c3e5) [...] These are similar to <https://gerrit.libreoffice.org/#/c/73267/> "Avoid overflow when scaling column width" and <https://gerrit.libreoffice.org/#/c/73273/> "Avoid overflow in ScColumn::GetOptimalColWidth", respectively, for column width calculations, and given csv/fdo54919-3.csv has a rather tall fifth row, these values do not look completely implausible---which of course begs the question whether sal_uInt16 is an appropriate data type here. But assuming sal_uInt16 is a useful choice, just clamp the calculated heights accordingly. (Using std::clamp, we can get rid of the following lines in initRowInfo that ensure nHeight >= 1.) Change-Id: I99f97c1dedcd8c6d2daa63f2e10011a3ce837fe4 Reviewed-on: https://gerrit.libreoffice.org/73278 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2019-06-03tdf#67538 XTypeDetection::queryTypeByDescriptor poor performance, part3Noel Grandin
Size the OUStringBuffer in OrcusFormatDetect::detect better at construction, to avoid re-alloc. This is specifically fixing the performance of queryTypeByDescriptor when called from a basic macro on a local test file. This takes my test macro from 9s to 8s Change-Id: Id4c2bf386de172b1deed98efece8c1f040c599a5 Reviewed-on: https://gerrit.libreoffice.org/73376 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-03tdf#39593 use UNO3_GETIMPLEMENTATION* macrosArkadiy Illarionov
Change-Id: I4e9af3b43a5baf19e100f42b3f37a2ade89ada5d Reviewed-on: https://gerrit.libreoffice.org/73320 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-06-03tdf#112567 XLSX export: correct built-in namesLászló Németh
Non-en_US locale setting resulted broken XLSX export with incorrect localized range separator. The previous commit 19976f079800ec4c1d0d5d7e226986cb41f834c2 "tdf#112567 XLSX export: fix broken built-in names" only avoided of the bad export of the XSLX documents with correct definedName. Note: this commit fixes the bad XLSX documents during the next import/export cycle. Change-Id: I9101c5df0f29c7a42fd49f4c2765dcf47a711916 Reviewed-on: https://gerrit.libreoffice.org/73220 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2019-06-02drop some unneeded includesCaolán McNamara
Change-Id: I13019ae1b991b5910c50e760a8a825bcf50509d2 Reviewed-on: https://gerrit.libreoffice.org/73321 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-06-01Resolves: tdf#101473 handle volatile Add-In results without formula cellEike Rathke
... while temporarily interpreting from within the Function Wizard. Change-Id: I88e7e062989ed395accd50ed9bfe1b76b3b297ea Reviewed-on: https://gerrit.libreoffice.org/73290 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2019-05-31Avoid overflow in ScColumn::GetOptimalColWidthStephan Bergmann
With -fsanitize=float-cast-overflow, opening csv/fdo40680-1.csv as obtained by bin/get-bugzilla-attachments-by-mimetype (i.e., the attachment at <https://bugs.documentfoundation.org/show_bug.cgi?id=40680#c0>) fails with > sc/source/core/data/column2.cxx:741:53: runtime error: 833163 is outside the range of representable values of type 'unsigned short' > #0 in ScColumn::GetOptimalColWidth(OutputDevice*, double, double, Fraction const&, Fraction const&, bool, unsigned short, ScMarkData const*, ScColWidthParam const*) const at sc/source/core/data/column2.cxx:741:53 (instdir/program/../program/libsclo.so +0xc9374aa) > #1 in ScTable::GetOptimalColWidth(short, OutputDevice*, double, double, Fraction const&, Fraction const&, bool, ScMarkData const*, ScColWidthParam const*) at sc/source/core/data/table1.cxx:427:23 (instdir/program/../program/libsclo.so +0xe02deee) > #2 in ScDocument::GetOptimalColWidth(short, short, OutputDevice*, double, double, Fraction const&, Fraction const&, bool, ScMarkData const*, ScColWidthParam const*) at sc/source/core/data/document.cxx:4242:30 (instdir/program/../program/libsclo.so +0xd18b457) > #3 in ScDocShell::ConvertFrom(SfxMedium&) at sc/source/ui/docshell/docsh.cxx:1614:53 (instdir/program/../program/libsclo.so +0x110b9ad4) > #4 in SfxObjectShell::DoLoad(SfxMedium*) at sfx2/source/doc/objstor.cxx:768:23 (instdir/program/libsfxlo.so +0x49d934a) [...] where nWidth = 5336 and nPPTX = 0.0647688. Given csv/fdo40680-1.csv has rather much text in the 17th column, these values do not look completely implausible ---which of course begs the question whether sal_uInt16 is an appropriate data type here. But assuming sal_uInt16 is a useful choice, just clamp the calculated width accordingly. Change-Id: I9629b45183354d148d572a0850314c9a00548311 Reviewed-on: https://gerrit.libreoffice.org/73273 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2019-05-31crash-testing fdo86059-1.xlsxNoel Grandin
blind fix since I can't reproduce. But I can see from the reported threads that two different threads are entering SfxItemPool::Put and consequently the debug runtime throws an iterator exception. Change-Id: Idaa6a93b134edc49bda8cd7876bb216d5aec7037 Reviewed-on: https://gerrit.libreoffice.org/73272 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-05-31Avoid overflow when scaling column widthStephan Bergmann
With -fsanitize=float-cast-overflow, `--convert-to pdf csv/fdo40053-1.csv` with csv/fdo40053-1.csv as obtained by bin/get-bugzilla-attachments-by-mimetype (i.e., the attachment at <https://bugs.documentfoundation.org/show_bug.cgi?id=40053#c0>) fails with > sc/source/core/data/fillinfo.cxx:445:65: runtime error: 88326.7 is outside the range of representable values of type 'unsigned short' > #0 in ScDocument::FillInfo(ScTableInfo&, short, int, short, int, short, double, double, bool, bool, ScMarkData const*) at sc/source/core/data/fillinfo.cxx:445:65 (instdir/program/../program/libsclo.so +0xdb7913d) > #1 in ScPrintFunc::PrintArea(short, int, short, int, long, long, bool, bool, bool, bool) at sc/source/ui/view/printfun.cxx:1597:11 (instdir/program/../program/libsclo.so +0x130c0f91) > #2 in ScPrintFunc::PrintPage(long, short, int, short, int, bool, ScPreviewLocationData*) at sc/source/ui/view/printfun.cxx:2284:9 (instdir/program/../program/libsclo.so +0x130dbf41) > #3 in ScPrintFunc::DoPrint(MultiSelection const&, long, long, bool, ScPreviewLocationData*) at sc/source/ui/view/printfun.cxx:2702:29 (instdir/program/../program/libsclo.so +0x130e8cde) > #4 in ScModelObj::render(int, com::sun::star::uno::Any const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at sc/source/ui/unoobj/docuno.cxx:2064:23 (instdir/program/../program/libsclo.so +0x124fea63) > #5 in PDFExport::ExportSelection(vcl::PDFWriter&, com::sun::star::uno::Reference<com::sun::star::view::XRenderable> const&, com::sun::star::uno::Any const&, StringRangeEnumerator const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue>&, int) at filter/source/pdf/pdfexport.cxx:227:34 (instdir/program/../program/libpdffilterlo.so +0x2db3b6) > #6 in PDFExport::Export(rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at filter/source/pdf/pdfexport.cxx:939:28 (instdir/program/../program/libpdffilterlo.so +0x2f3751) > #7 in PDFFilter::implExport(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at filter/source/pdf/pdffilter.cxx:155:24 (instdir/program/../program/libpdffilterlo.so +0x33d7df) > #8 in PDFFilter::filter(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at filter/source/pdf/pdffilter.cxx:216:23 (instdir/program/../program/libpdffilterlo.so +0x33e64f) > #9 in SfxObjectShell::ExportTo(SfxMedium&) at sfx2/source/doc/objstor.cxx:2422:25 (instdir/program/libsfxlo.so +0x4a03623) [...] where nX = 2, nTab = 0, GetColWidth(0,2) = 50075, and fColScale = 1.76389. Given csv/fdo40053-1.csv has rather much text in the third column, these values do not look completely implausible (whatever the column width unit of measure is, though)---which of course begs the question whether sal_uInt16 is an appropriate data type here. But assuming sal_uInt16 is a useful choice, just clamp the calculated width accordingly. (Using std::clamp, we can get rid of the following lines that ensure nThisWidth >= 1.) Change-Id: Ifa7a666abedc2a2f0a335f4da0ea74961f33870c Reviewed-on: https://gerrit.libreoffice.org/73267 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-05-31drop unneeded includesCaolán McNamara
Change-Id: Ie0f52bb1d6866075d0b664bfc3ddc47c02e4f81b Reviewed-on: https://gerrit.libreoffice.org/73169 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-31tdf#66765 - FILESAVE: saving sheet with some queries in it takes foreverNoel Grandin
This takes the save time from 5m30 to 1s. We were firing up the editeng stuff for every single style entry, when most of the style entries share the same cell. Change-Id: Id11af0b7f5646ff7ccdf1b85014fa384b0465054 Reviewed-on: https://gerrit.libreoffice.org/73239 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-05-29weld SfxDocumentInfoDialogCaolán McNamara
Change-Id: I79d5d8973a19c0e639081ec61ac596620518d0b5 Reviewed-on: https://gerrit.libreoffice.org/73145 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-29weld ScDocStatPageCaolán McNamara
Change-Id: I24d264f6318adfd9f67303d95b3b8fe0987f928a Reviewed-on: https://gerrit.libreoffice.org/73144 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-28ScNumberFormatControl uses an SfxUInt16ItemStephan Bergmann
...not an SfxInt16Item. Probably a typo introduced when adding the class with bf3f3a6bfb08c2d1a2c95f1c1cf62117e0002235 "notebookbar: working number format listbox". (Found with -fsanitize=vptr when switching Calc to "View - User Interface - Tabbed Compact".) Change-Id: I6142b20750872037767e1857edeae83b1b2fa849 Reviewed-on: https://gerrit.libreoffice.org/73089 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-05-27tdf#42949 Fix IWYU warnings in include/svx/[sS][a-h]*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I84fc75e06e61e5391aef6e237c36daad95dedb84 Reviewed-on: https://gerrit.libreoffice.org/72550 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-05-26Resolves: rhbz#1713827 protect against null ViewShellCaolán McNamara
like SfxHintId::ScAccCursorChanged does Change-Id: I75ab2da866a345d817e39536ac966d3edf24b90a Reviewed-on: https://gerrit.libreoffice.org/72979 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit (git 2.34.1) at 2025-02-04 13:42:33 +0000