summaryrefslogtreecommitdiff
path: root/sc/source
AgeCommit message (Collapse)Author
2016-01-25tdf#96910 : Calc crashes while using "Insert Column Left" for large DocumentsYogesh
Change-Id: I6e813b7525a3d9b1db131db9f08fc20f7320345f Reviewed-on: https://gerrit.libreoffice.org/21661 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-01-25InterfaceContainer2 with vector instead of SequenceNoel Grandin
create an InterfaceContainer2 class to replace InterfaceContainer. It uses a std::vector instead of a Sequence for the mutable listener list, which provides far better performance. Switch all our internal use-sites to the new class. Change-Id: I6b56cfa511ded2395faa22e68fab3b2f16c3cb88
2016-01-24tdf#74667 interchange slope and intercept for power regressionTomaž Vajngerl
Change-Id: I9da7edeabcc9f963ac19d26114fa101d4b5ce98f
2016-01-23tdf#97308: fix logic with conditional "ends with"Julien Nabet
Change-Id: Ib9f9ed627dc37b11d8c3911aa4fe62141ff471c2 Reviewed-on: https://gerrit.libreoffice.org/21723 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2016-01-23sc lokit: update zoom values to graphic and text selectionHenry Castro
Change-Id: I750f31c5698d9dc5ed589a1812a6993991915dc5 Reviewed-on: https://gerrit.libreoffice.org/21724 Reviewed-by: Henry Castro <hcastro@collabora.com> Tested-by: Henry Castro <hcastro@collabora.com>
2016-01-22editeng: ImpEditView::mbTiledRendering is never readMiklos Vajna
Change-Id: Ie8e33d075f0cedbb9f7148717c4318f4494ed419
2016-01-22Move sc/source/ui/dbgui/validate.cxx from scui to scStephan Bergmann
8d1a24dae03690b576310e3539369916f31ac475 "Make virtual ~ScValidationDlg non-inline" caused the RTTI for ScValidationDlg to only be emitted in library scui instead of (weakly) wherever needed. That causes UBSan to fail when it uses the RTTI in ScValidityRefChildWin::ScValidityRefChildWin (sc/source/ui/view/reffact.cxx, in library sc, to check that operations on VclPtr<ScValidationDlg> pDlg indeed operate on an ScValidationDlg object). The cleanest fix appears to be to move ScValidationDlg from scui to sc. As Moggi put it on IRC, "that dialog should be in sc as it is a modeless dialog; no idea why it works for that dialog but all other modeless calc dialogs have to be in sc to avoid linker problems." One remaining question is whether it is save nowadays in ScCellShell::ExecuteDB (sc/source/ui/view/cellsh2.cxx) to clean up the ScValidationDlg pointed to by pDlg when that VclPtr<ScValidationDlg> variable goes out of scope, instead of doing the PostUserEvent(... DelayDeleteAbstractDialog) dance that was there before because "after end execute from !IsModalInputMode, it is safer to delay deleting." Lets see. Change-Id: I3ecfd4fafc7b37b2f30e75974ece9b0a23311ef4
2016-01-21tdf#34873 : Show autofilter row count in status barDennis Francis
Change-Id: I91aa637d654c1f4d828832f2e43ad21f03036ad0 Reviewed-on: https://gerrit.libreoffice.org/20134 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-01-21IMHO " : " doesn't need to be localizable, tdf#95878 follow-upEike Rathke
Removing STR_FUNCTIONS_NAMEDESCS from resident strings, what should poor localizers translate it to anyway? Change-Id: I333f3e48332a0796112c28c230be20529e2241c4
2016-01-21sc lok: Implement unit test for .uno:{Insert,Name,Remove} for sheets.Jan Holesovsky
And fix indexing when at that - the inserting is 1-based, so let's be consistent in the .uno:Name and .uno:Remove too. Change-Id: Ib854e81551ae0a39d3ba7c68512e81ea227e9eb1
2016-01-21sc lok: Fix .uno:Remove (removing sheets) to accept a parameter.Jan Holesovsky
.sdi annouces that, but it was never implemented... Change-Id: I7abfbdc88f055eeb993617a5a51371af0f825d34
2016-01-21sc lok: Fix .uno:Name (renaming sheets) to really accept parameters.Jan Holesovsky
The code handles them, but they were unusable, because .sdi did not announce them. Change-Id: I35bd3009d092eb48a36aee2ffed3964dc61946e2
2016-01-21loplugin: unused return valuesNoel Grandin
Change-Id: I4eb1f0c9245c04058fd5e47046f043f8840a79c7 Reviewed-on: https://gerrit.libreoffice.org/21628 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-01-21vcl: rename Font::GetFamily to Font::GetFamilyTypeChris Sherlock
Change-Id: Ie427a43bd126dcdd89c6f66582736e67130f2254 Reviewed-on: https://gerrit.libreoffice.org/21633 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-01-20there's no reason to be sparing with new linesEike Rathke
Change-Id: Id8334694aec17ec61490460b0917514beebd94a3
2016-01-20tdf#97247 Keep focus on merged cell at top-left cornerTakeshi Abe
... when typing either UP or LEFT key. Change-Id: I7bc0e7eb0cba322bcc26c35d0474ea558d3bdd6e Reviewed-on: https://gerrit.libreoffice.org/21599 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-01-20nitpicks, tdf#96822 follow-upEike Rathke
Change-Id: Ic745433a870c70c09afa953a4ebef86f4363f9f4
2016-01-20tdf#96822 : Make cell contents left align when number formatting is textYogesh Desai
Change-Id: I9754db93f4cf71a6001d5b3f39ee2bc2b01889cc Reviewed-on: https://gerrit.libreoffice.org/21134 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-01-19sc lokit: the visible row/column must be 0, when loading a documentHenry Castro
Change-Id: Ie980e0bb0726dd8bc4215d5b23ac6e1d2c9e2719 Reviewed-on: https://gerrit.libreoffice.org/21611 Reviewed-by: Henry Castro <hcastro@collabora.com> Tested-by: Henry Castro <hcastro@collabora.com>
2016-01-19follow-up of tdf#89031Winfried Donkers
No function name hints or autocompletion when character right of caret is '$' Change-Id: I4fcfa6e29e5671e97743c7fc520953721d0bda24 Reviewed-on: https://gerrit.libreoffice.org/21577 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-01-19loplugin:unusedmethods in sc/Noel Grandin
Change-Id: I2c24d06d9fad26c65fa13cdcaa2c3f908971106c
2016-01-19Make virtual ~ScValidationDlg non-inlineStephan Bergmann
...otherwise, GCC 6 would aggressively inline ScValidationDlg destruction of the VclPtr<ScValidationDlg> in ScValidityRefChildWin::ScValidityRefChildWin (sc/source/ui/view/reffact.cxx, in sc library), checking whether the vtable points at ~ScValidationDlg (instead of a derived class dtor) to directly inline the ~ScValidationDlg code, which requires the ScValidateionDlg vtable (to store it in the object's vtable during destruction), which requires the code of inline virtual ScValidationDlg::dispose and ScValidationDlg::Close, which in turn need the addresses of (non-inline) ScValidationDlg::RemoveRefDlg and ScTPValidationValue::RemoveRefDlg, both defined in the scui library and not exported from there. Change-Id: I7eb96f42deb5edd844d91e999aa5511679302c01
2016-01-19-Werror=address (GCC 6)Stephan Bergmann
"the compiler can assume that the address of ‘rItem’ will never be NULL" Change-Id: I90a8a3074c2dab427b4bc6345ec4a824eb2ac249
2016-01-19-Werror=maybe-uninitialized (GCC 6)Stephan Bergmann
...so take the same "= -1" approach in ScTable::CopyColHidden as was alreday taken in ScTable::CopyRowHidden Change-Id: I0155965f142bd33706a303fb154d46776e40ec62
2016-01-19tdf#88737 handle temporary array formula matrix circular referenceEike Rathke
This does not solve the difference in how Excel seems to handle the arguments and calculation, but some corner case. See bug comment 6. Change-Id: Ifa331e8552587c40e1486a08093ed0df92a9d245
2016-01-18loplugin:defaultparamsStephan Bergmann
Change-Id: If9ba7298804bff9140d9122c257a859c19e7a69d
2016-01-18use nullptr, tdf#95878 follow-upEike Rathke
Change-Id: Iaaedde4e2adfa74442736d4a5e4bf1729ca19f3c
2016-01-18tdf#95878 made more useful function suggestion system in formula editingKeigo Kawamura
I made function list suggestion and description tip in libreoffice calc. This change give us a nice function suggestion and easy function input. For example if I write "=i" then calc suggests "[if], iferror, ifna, and 50 more". You should only choice the function you would write with Ctrl-Tab and Ctrl-Shift-Tab, and then type Enter. Also there is a description of suggesting function, so even if you do not know the true name of the function you want to write, you can find the function. This change also give us a description of arguments of selected function. If I write "=i" and push enter key, then calc show "=if()" and a description of arguments of function "if()". Change-Id: Icd5ad04ea092fa39f27bb2776fd9e93649896baf Reviewed-on: https://gerrit.libreoffice.org/20035 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-01-18loplugin:unreffunStephan Bergmann
Change-Id: I1008a51abb3834a65aabfdf05370d9515a18c1e2
2016-01-18vcl: change Font::SetName() to Font::SetFamilyName()Chris Sherlock
Change-Id: I9b7bd1ec25955981ebcb9085579cbb9fbaa802d5 Reviewed-on: https://gerrit.libreoffice.org/21560 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-01-17vcl: rename Font::GetName to Font::GetFamilyNameChris Sherlock
Change-Id: Ie20871a3078bf875c1782b7761d60591a9c9704f Reviewed-on: https://gerrit.libreoffice.org/21529 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-01-17cppcheck: fix 2 variableScope reports in scJulien Nabet
Change-Id: Iea1f8b851d3d9b5c9b22165f1a33e124212d8e80 Reviewed-on: https://gerrit.libreoffice.org/21535 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2016-01-16revert vcl patch series that brok Mac and WindowsNorbert Thiebaud
revert: 9bc2f3de8672e812f3a67541c6d7069b434a7e42 vcl: add comment about ImplFontMetric::{Get|Set}LineHeight() 26371f105bc44e04469ec03fc5bb12505e651c6b vcl: FontAttributes::GetSlantType() -> FontAttributes::GetItalic() 2dd0b4317372b8022efe3911b38b4fa02956d8b9 vcl: font.hxx and metric.hxx cleanup, make ctors explicit and the dtor virtual 5ab13bf3ead3539e4ad847656da81e7eb6029652 vcl: tabify font.hxx f99550dae55e40e49bf9c9875053fe2abb4c71ca vcl: change Font::SetName() to Font::SetFamilyName() 2b297116cb6bb1061c43e5714e2609c8ee9f57d2 vcl: rename Font::GetName to Font::GetFamilyName Change-Id: I23f38921187d66b970ca815eb30dda4222a2da62
2016-01-16vcl: change Font::SetName() to Font::SetFamilyName()Chris Sherlock
Change-Id: I54a4036544c680c4a49607677af776aa7a433fbc Reviewed-on: https://gerrit.libreoffice.org/21510 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-01-16vcl: rename Font::GetName to Font::GetFamilyNameChris Sherlock
Change-Id: I83927e0992dfe0a2a79d139818a9f45d3761aae5 Reviewed-on: https://gerrit.libreoffice.org/21509 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-01-15oox: move enum DocumentType out of drawingml.hxxMichael Stahl
... which has nasty dependencies. Change-Id: I84ba0302142ade6e15291b782453dbe3bac753dd
2016-01-15-Werror=unused-but-set-variableNoel Grandin
Change-Id: I18a3a72dce0d4bd42c11bd0836858125c13e02f4
2016-01-15sc tiled rendering: it's pointless to send selection changes during search allMiklos Vajna
Change-Id: I787cd1760bca0bf7fbc3132579b569882ec25ae2
2016-01-15loplugin:unusedmethods unused return value in scNoel Grandin
Change-Id: I3ccc98d2e042120093e2e8508518681588692393
2016-01-15loplugin:unusedmethods unused return value in scNoel Grandin
Change-Id: Ic0b4d7efb2679f735892806d66258af231cda3fe
2016-01-14-Werror=misleading-indentation (GCC 6)Stephan Bergmann
Change-Id: Ie583f5158fdc764c10981244efea204558219465
2016-01-14editeng: handle SdrModel::isTiledSearching()Miklos Vajna
Given that the edit/outliner views can come and go, avoid the lifecycle problems with just passing a pointer to the sdr model to editeng, and then it'll always have the up to date "are we searching" information. editeng can't depend on svx, so provide an interface class SdrModel can implement. Change-Id: I3b98011593b00ac0fab05b6b9c591dd20d94c579
2016-01-13resolve TODO, remove SVVERB_SHOWMichael Stahl
Change-Id: I10148330f1a356dbd423af98267c25d7128c3a86
2016-01-13vcl: Create accessor and mutator for int and ext leading in FontMetricChris Sherlock
Accessor and mutator created for external and internal leading space in FontMetric. See commit description in 8bfccd3a71d911b6d ("vcl: Create accessor and mutator for font scaling in FontMetric") for reasoning behind patch. Unit tests - check to ensure that can set external and leading space - check equality operator on FontMetric after setting both external and internal leading space - enhanced tests to also check the inequality operator Change-Id: I973970dd0b0631c5eca3e89039dce57ac3a3eb63 Reviewed-on: https://gerrit.libreoffice.org/21454 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-01-13sc: remove last ptr_map includesMichael Stahl
Change-Id: Ia834a8e78160b1456f98aa5d01c470673b352d0b
2016-01-13sc: replace boost::ptr_map with std::map<std::unique_ptr>Michael Stahl
Change-Id: I2dbb399a5fb368b0c197c0cf48c0834a4cadde0c
2016-01-13sc: replace boost::ptr_map with std::map<std::unique_ptr>Michael Stahl
Change-Id: Ia051a8f0d20a6f718395e1420d7f409099607156
2016-01-13sc: replace boost::ptr_map with std::map<std::unique_ptr>Michael Stahl
Change-Id: I303b58ab25e0a5e369d7269cf30e8bd565e6e4c4
2016-01-13sc: replace boost::ptr_map with std::map<std::unique_ptr>Michael Stahl
Change-Id: Ib97ddc8871774eb5faca35a8b4193599dc6f25ef
2016-01-13sc: replace boost::ptr_map with std::mapMichael Stahl
Change-Id: I21fbba963e595377a0f6e9151e5510c660d8ca5f