summaryrefslogtreecommitdiff
path: root/sc/source
AgeCommit message (Collapse)Author
2021-08-30make this more readableCaolán McNamara
Change-Id: I031054d3a6929c48b796ce527448d2c5a5099a8b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121319 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-30ofz: MemorySanitizer: use-of-uninitialized-valueCaolán McNamara
Change-Id: Ic00ecbb8e482b8e666f27db73539d65e54ec7c51 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121264 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-30ofz: MemorySanitizer: use-of-uninitialized-valueCaolán McNamara
Change-Id: I7e52d33f0e94f4bad03e9e3881b54e90172e12a7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121263 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-30LOK: avoid writing freeze pans data to file if not setPranam Lashkari
Change-Id: I9bc4023ae1673a2ae68db584357fb6c6643342a3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121065 Tested-by: Jenkins Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
2021-08-30ofz: MemorySanitizer: use-of-uninitialized-valueCaolán McNamara
Change-Id: Ife47559f456e17175eccf4bb6509688b61972d7d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121235 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-30ofz: MemorySanitizer: use-of-uninitialized-valueCaolán McNamara
Change-Id: If76fdb6d83d1d2d71baee5f892cd239806a6fd61 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121236 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-30Add Swap Rows Transformation.tushar
Entries of given rows are swapped after applying transformation. Change-Id: Iac9da1b15781656b4127bf74f6a95e8cb82fa3d0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120556 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Jenkins
2021-08-30ofz: MemorySanitizer: use-of-uninitialized-valueCaolán McNamara
Change-Id: I941bb60c1d06189491964004fb98d0d21fc75c49 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121237 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-29Resolves: tdf#117868 CSV: support sep=; and "sep=;" separator settingEike Rathke
When reading CSV the separator (any BMP character) is taken from an initial sep=; or "sep=;" single field if that is the only row content. The quoted form is preserved as (unquoted) cell content, of the unquoted form the separator is discarded as contextually it is a real field separator. When writing CSV an existing single top left cell's content if that is the only cell in the row is adapted to the current separator (any BMP character) in the quoted form "sep=;" (if quotes / text delimiters aren't set empty ...) and always uses the ASCII '"' double quote character. Change-Id: I854477bd0f9d1cafaa51a2130b616292347519cf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121232 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2021-08-29ofz: MemorySanitizer: use-of-uninitialized-valueCaolán McNamara
Change-Id: Ic2179724b182262c01b9e5993234b1d89ccbe49f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121224 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-29be a little more readableCaolán McNamara
Change-Id: Ic0f7dd5ead93aa7e3178dcc5128df615d1d7a4e2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121218 Tested-by: Jenkins Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-29ofz: MemorySanitizer: use-of-uninitialized-valueCaolán McNamara
Change-Id: I8422da20656626f2512a63a8a4282b2f09c79e37 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121217 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-29ofz: MemorySanitizer: use-of-uninitialized-valueCaolán McNamara
Change-Id: I649e8b8fa0d1752f0f4b0b6b688cea8ae945bb87 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121186 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-29ofz: MemorySanitizer: use-of-uninitialized-valueCaolán McNamara
Change-Id: I136816837eddcb1bf81c23b6f4fcfa65e9335629 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121187 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-28Fix typosAndrea Gelmini
Change-Id: Ie4e2ef5a884b51250863d3384d5e703232f31258 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121179 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-08-27tdf#59820 - Search for the longest substring in a multiline stringAndreas Heinisch
In order to determine the optimal column width of imported ASCII files in the simple text mode, search for the longest substring in a multiline string which is determined by a line break. Change-Id: I2c606dd97549455009b9f8fad2b8ec4386b7b7db Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120772 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2021-08-27tdf#143940: the style index might be -1Xisco Fauli
Similar to 52aebe6986bcec07071adb3f94d6c09fea147044 < tdf#138466 Crash when creating different scenarios > ExportColumns calls GetStyleNameIndex which might return -1 so check the index is different than -1 as it's already done when calling ScFormatRangeStyles::GetStyleNameByIndex Also move fix for tdf#138466 down the stack to be consistent Debug builds will still assert, see coverity#1438402 Since 5e777f23fd0118f6649f0d9e30eb77a72f1099e4 < loplugin:useuniqueptr in ScColumnRowStylesBase > where the nIndex < 0 check in ScColumnRowStylesBase::GetStyleNameByIndex was removed Change-Id: I084bfa04c39f37cb325c3b3df76801b3abdea994 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121128 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-26tdf#142307 - Upgrade SSE2 sum to AVX512 sum with Neumaier 1dante
This part focuses on allowing it on replacing arrayfunctor By thefault it will try AVX512F (1,17%) If not available will use AVX (94,77%) Use of AVX2 (82,28%) has been avoided even if the code could been more compact Source of hardware statistics: https://store.steampowered.com/hwsurvey Change-Id: Iae737a565379e82c5f84f3fdee6321ac74f59d40 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115675 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-08-25tdf#143929: chain XMLTextExportPropertySetMapper to sc's shape exportMike Kaganski
This allows to export editengine columns to ODS. Alternatively, we could re-introduce chaining text attributes in XMLShapeExport ctor, which was commented out in commit d5b1e4827f8e6e0661563ec856cd80d926ba7b58 without explanation; but that would affect export from other modules as well (e.g., SdXMLExport::setSourceDocument sets up respective chaining in sd), so to be on the safe side, I do it only for ScXMLShapeExport. Change-Id: Iafee77b2b57e95031cfe1bbd2d43d7361a3e8469 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120958 Tested-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-08-25osl::Mutex->std::mutex in ResourceListenerNoel Grandin
Change-Id: Ide7073273be3405a1d78687a2d6dd12369dd226d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120955 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-24ofz: Out-of-memory, reduce max row allowed for TableOp when fuzzingCaolán McNamara
Change-Id: I6268a9974591f86c5918d1171bd8c5ae0a25a538 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120952 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-24move variables declaration to their useCaolán McNamara
Change-Id: I95deffd6db252f6c2635c13814a07fa604b64789 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120950 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-24ofz: MemorySanitizer: use-of-uninitialized-valueCaolán McNamara
Change-Id: Ia7ceb0278117df6e140c04232bcfd366fbba3dd0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120919 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-23tdf#144022: make sure to create missing columns if neededMike Kaganski
Change-Id: I1a0771fbe8023859ab29d8114303b62f6a3d539c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120731 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-08-23cid#1490403: fix wrong initial flag bFoundDennis Francis
Change-Id: I502653985e54c82198034534bb878d06787f8c94 Signed-off-by: Dennis Francis <dennis.francis@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120730 Tested-by: Jenkins
2021-08-20New loplugin:unusedcapturedefaultStephan Bergmann
In sc/qa/unit/ucalc_formula.cxx, dropping the capture-default from the lExpectedinF lambda revealed that MSVC in C++17 mode (i.e., when building without --with-latest-c++) requires ROW_RANGE (a local const int variable from the enclosing TestFormula::testTdf97369) to be captured, even though all uses of that variable within the lambda body are constant expressions. That is still true at least for the latest Visual Studio 2019 version 16.11.1. (This is not an issue for the lExpectedinH and lExpectedinI lambdas a few lines further down, as they, in addition to using that ROW_RANGE, also use the local const double variables SHIFT1 and SHIFT2, whose uses are not constant expressions, so they are implicitly captured and loplugin:unusedcapturedefault does not suggest dropping those lambdas' capture-defaults in the first place.) Change-Id: Iee7efb485187cbe8eba6a2d470afca4993eb1816 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120693 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-08-19Revert "tdf#59820 - Adjust column width of imported ASCII files"Andreas Heinisch
This reverts commit aaabfc644afd57577980998c83f94a271f633c02. Reason for revert: Large csv files will not open in a reasonable amount of time. Change-Id: I7d3d3bf0341bcb83f86be88e8911879de13918ad Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120720 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2021-08-19Make the logic more logical.., tdf#102846 follow-upEike Rathke
Same functionality better readable. Change-Id: Idb891a6e2f0a35528d6a1862e5743a22772eec11 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120754 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2021-08-19Resolves: tdf#102846 CSV: Detect separator, limit preview line concatenationsEike Rathke
In CSV import preview, if a line starts with a quote character and none of the remembered last field separators used occur in data in conjunction with a closing quote, then reading data tried to concatenate line by line to form a data field to be presented in the preview, worst case the entire file.. For the preview, detect one possible not yet selected separator if used with a quoted field (similar to commit c807e7ea7a0725a4d8375eda07d6f70870e0d50a for tdf#56910 space separator) and limit the number of source lines that are tried to be concatenated if no separator was encountered after a possibly closing field quote. Change-Id: Iefd37a8301161e72cb607cea88d4faadad47b4ae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120690 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2021-08-19tdf#143890: Show preview of diagonal borders / CalcBayram Çiçek
- in "Properties sidebar > Cell Appearance", Calc shows preview of the selected cell borders. (preview is at the bottom of "Background" text) - this feature doesn't work for diagonal borders. - diagonal borders preview is now shown with this patch. Change-Id: I9d98b045ccef5e8469cc38f08e5f14c3199d027c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120519 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2021-08-19reduce visibility of some symbolsNoel Grandin
Change-Id: I16b6be2217f56e5961e1352201a8ee4e2b033e97 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120658 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-19ofz#37300 Direct-leakCaolán McNamara
since... commit eec42f0dbcc79a4c9f456ce97fa1066b8031ea28 Date: Sun Aug 15 17:35:58 2021 +0200 pass OutlinerParaObject around by value Change-Id: I9e28844226184ba2f54d11888b020d080e9b57ee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120631 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-19Drop GetSdrObjectFromXShape and use SdrObject::getSdrObjectFromXShapeMike Kaganski
Change-Id: I0d233878ee49fcdc1338ec3bd700e5482d558163 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120694 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-08-19tdf#142264: make sure to load potentially unloaded objects when savingMike Kaganski
Commit 574eec9036c5f185b3572ba1e0ca9d111eb361dc happened to reveal a pre-existing problem that XLSX export only saved those OLE objects that were kept loaded in the OLE object cache, subject to thevalue of org.openoffice.Office.Common/Cache/DrawingEngine/OLE_Objects. Before that change, the imported charts were marked modified on load, and that prevented them from unloading in OLEObjCache::UnloadCheckHdl, because SdrOle2Obj::CanUnloadRunningObj returned false. After the mentioned change, the charts started to load without the wrong "modified" state, which allowed them to be properly managed by the cache, and the export filter implementation error surfaced. It's likely that commit 692878e3bb83c0fc104c5cca946c25ccf2d84ab2 tried to workaround the same underlying problem for charts that for some reason / at some point in time didn't get marked modified on load, and that commit converted an error shown in Excel into silently missing charts. This change makes sure that whenever a reference to chart document is requested from XclExpChartObj, it is actually loaded and ready for reading data. Possibly something could be done on the level of old reference that becomes non-functional (although valid) as the result of unloading, so that it would automatically reload on following use. That would make operating on the references robust. I didn't find an obvious way to do that. It is interesting to investigate, it the heizenbug related to images disappearing from documents, as users keep reporting without robust reproducers, might possibly be caused by a similar problem. Change-Id: I45fcdc98254157d805c7519340b5265526f27166 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120688 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-08-19Do not count pages for initial page breaks, tdf#124983 follow-upEike Rathke
Use a loaded page size or leave it. Otherwise the previous implementation could had lead to tremendous waiting time blocking everything on large data without. See source code comment. Also trigger updating page breaks only for one grid window, not multiple repeating everything all over. Remove bSetup parameter that does nothing but either doing something or nothing, check in caller instead. Move member variables to where they belong. Change-Id: I5efc321e5bc5af075a77631aa9d94b0c50ae6b6b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120689 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2021-08-18loplugin:constparamsNoel Grandin
Change-Id: Ic7410f836e584df45101e78e345c8b3c8d355e09 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120680 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-18tdf#118470: sc oox: recover escaped unicode chars in strings importDennis Francis
according to OOX open spec 2.1.1742 Part 1 Section 22.9.2.19, ST_Xstring (Escaped String). In this implementation, some restrictions mentioned in this spec are not kept for simplicity. Change-Id: If27797a9625d49be54c600c8a864965f1101ceb1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120665 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2021-08-18loplugin:passstuffbyrefNoel Grandin
Change-Id: I4f01eb3842ef198f02af274f54afb2760c820a4b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120655 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-18undo changes to TextAlignCaolán McNamara
revert commit 8689bd5490b473a7ffb149bbe5f7f0683f679c72 Author: Caolán McNamara <caolanm@redhat.com> Date: Thu Jul 29 20:49:29 2021 +0100 convert TextAlign to scoped enum lets leave this as it always was Change-Id: Id4d2a5644974cdd2b0ed6d361d5c52629674d057 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120626 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-18tdf#59820 - Adjust column width of imported ASCII filesAndreas Heinisch
Don't adjust the optimal column width of imported ASCII files in Calc by using the simple text mode. In the simple text mode, the length of a column is determined solely by the length of a text and not by the actually needed size. Change-Id: I02a1e0fbfad88a31bd474124c2f4367b660bdfdb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120514 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2021-08-17Add Delete Row Transformation.tushar
Rows having specific value in a column will be deleted. Change-Id: I0b39e1127215c59062db11351a656e75d71a04aa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120296 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2021-08-16Resolves: tdf#96561 Include embedded null-characters while assembling CSV lineEike Rathke
... instead of prematurely ending analysis and skipping the remainder that is still part of data read. Change-Id: I8f34bc9672e37f9c1c1ae81ddeba464360add7c2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120555 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2021-08-16tdf#143896: FILESAVE XLS(X) 1001+ rows are lost after saving new fileJulien Nabet
Regression from: https://cgit.freedesktop.org/libreoffice/core/commit/?id=2bf3e0d00e3bccb5b250642ee0d3fdbe6cae8ecc tdf#104502 sc: skip hidden columns at printing pages Page calculation counted the hidden columns, resulted printing blank pages by accident. Extend GetPrintArea() and GetTableArea() to count pages without the hidden columns, too. Change-Id: I77e7d6d893967a3ddac4c7c4e225769b38b44649 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120552 Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-08-16tdf#126879 - Drop obsolete DOCTYPE HTML 4.0Andreas Heinisch
and use the HTML5 DOCTYPE declaration Change-Id: I00a769f2c8da876fd9435343c72f4d7685bc0cb3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120378 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2021-08-16Drop tools::Rectangle::getX/getY, which are just duplicates of Left/TopMike Kaganski
The change allowed to simplify many places where previously this API was used, to avoid inefficient calculations (e.g., moving rectangle keeping its size, and then immediately changing the size). Change-Id: Ica2dc594d91cae83e2c2740c1f4fb23f44998916 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120461 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-08-16sc: lok: avoid selection jumps with multiple usersDennis Francis
In LOK case, avoid spurious "leavingwindow" mouse move events which has negative coordinates. We later use these coordinates to compute the cell address corresponding to the event to extend the selection which will be wrong in this case. Such spurious events occur for some reason when a user is selecting a range, (even when not leaving the view area) with one or more other viewers in that sheet. The root cause of these bad coordinates seems to be in vcl in winproc.cxx, ImplHandleMouseEvent() in the code block starting ``` // test for mouseleave and mouseenter VclPtr<vcl::Window> pMouseMoveWin = pWinFrameData->mpMouseMoveWin; if ( pChild != pMouseMoveWin ) { if ( pMouseMoveWin ) { Point aLeaveMousePos = pMouseMoveWin->ImplFrameToOutput( aMousePos ); ``` This needs more investigation. Meanwhile this interim patch fixes the issue of selection jump by avoiding those unhelpful mouse events. Conflicts: sc/source/ui/view/gridwin.cxx Change-Id: I01fb3ae6a3903ada2a44a8b3d2b4a46b0122326b Signed-off-by: Dennis Francis <dennis.francis@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120317 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Mert Tumer <mert.tumer@collabora.com> (cherry picked from commit 7eb8a1d6c5697fd89ff75d3b116bbbf6c2de6950) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120443 Tested-by: Jenkins
2021-08-16pass OutlinerParaObject around by valueNoel Grandin
since it uses o3tl::cow_wrapper, so it is really just a wrapper around a pointer, no point in allocating it on the heap Remove assert in SdrText::SetOutlinerParaObject, which was bogus anyhow, because it was comparing pointers, not deep equality. And since we are now being more efficient and avoiding copying of the internal data in OutlinerParaObject, we hit this assert. Change-Id: I6dbfaab5ee2ca05b2001baf63110041e469df9c5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120510 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-13split SvNumberFormatter into it's own headerNoel Grandin
so I can make changes without running into cyclic dependencies between header files Change-Id: I98a91c7cc66002ba745cdb8239e5cc267922a45c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120412 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-12tdf#95549 speed up xls openNoel Grandin
Remove the m_wThis field, and instead just check the ref count to know if we are being called from our own destructor. Also re-order ScCellRangesBase::Notify so we do the cheap checks first. This shaves 2% off the load time Change-Id: Ie95a4ff46bacba583ec4b3a934f98a9aac3551b9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120385 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-12tdf#95549 speed up navigator tree loadNoel Grandin
(*) inline the load loop (*) remove Refresh call from ScNavigatorDlg constructor, the SetListMode call at the bottom will trigger a load of the tree content Change-Id: I27f1d1bde89d8dcb5cc111ae132fbb05abc2fc7b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120383 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2025-02-21 20:19:42 +0000