summaryrefslogtreecommitdiff
path: root/sc/source
AgeCommit message (Collapse)Author
4 hoursSimplify the nullptr checks, as below in ScPatternAttr::areSameMike Kaganski
Change-Id: Ie7547a79a1367f849fa5a6769d5ed262dc174926 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185166 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
28 hourstdf#163015 FILEOPEN: Opening specific XLSX file takes long timeNoel Grandin
we spend most of our time inserting into the output sorted_vector, which ends up needing a lot of data movement when the output vector becomes large. Re-arrange the data structures so we can do this in one pass, and instead of inserting into the output vector, we can just append to it. Change-Id: If729e8ca1f2e6b5cf546c17331f1f3716674f2cb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185099 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
28 hoursreduce some data copyingNoel Grandin
Change-Id: I9f6bb99df4505dd0c5bbfd8b40d9642864a9fb07 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185100 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
45 hourstdf#117436 - Set text cell to accommodate potential multiline cellsAndreas Heinisch
Set text cell to accommodate potential multline cells during the copy and paste process of a table from Base to Calc. Change-Id: I8032627aee8190b0956be80d64144dc4d7fb07e6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185092 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
46 hourstdf#165742 Step 4.3: Establish a narrow export path for chartexknordback
This is a subtask of tdf#165742: Chartex charts are lost on input from OOXML and re-export. Fix various aspects of input and output for chartex (and specifically for funnel charts). This now allows for loading and re-exporting a very basic funnel chart, with the result that MS Office successfully loads the exported chart, and it looks similar (though not quite identical) to the original. Change-Id: I6eeb277e31250031604f7cdd21b80848a9c642ca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184758 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Jenkins
2 dayscrash on null pattern de-refCaolán McNamara
#5 0x00007fc235921b20 in ScPatternAttr::GetItem (nWhichP=145, this=0x0) at sc/inc/patattr.hxx:164 #6 ScPatternAttr::GetItem<ScMergeFlagAttr> (nWhich=..., this=0x0) at sc/inc/patattr.hxx:167 #7 ScGridWindow::UpdateCursorOverlay (this=0x0, this@entry=0x39eb3d30) at sc/source/ui/view/gridwin.cxx:6610 #8 0x00007fc235922c0d in ScGridWindow::CursorChanged (this=0x39eb3d30) at sc/source/ui/view/gridwin.cxx:6259 #9 0x00007fc2359c6860 in ScTabView::ShowAllCursors (this=this@entry=0x356a9c68) at include/rtl/ref.hxx:203 #10 0x00007fc2359c2586 in ScTabView::PaintBlock (this=this@entry=0x356a9c68, bReset=bReset@entry=true) at sc/source/ui/view/tabview2.cxx:1286 #11 0x00007fc2359c271f in ScTabView::DoneBlockMode (this=0x356a9c68, bContinue=bContinue@entry=false) at sc/source/ui/view/tabview2.cxx:658 #12 0x00007fc2359c2779 in ScTabView::DoneBlockMode (this=this@entry=0x356a9c68, bContinue=bContinue@entry=false) at sc/source/ui/view/tabview2.cxx:666 #13 0x00007fc2359ce0ca in ScTabView::SetTabNo (this=0x356a9c68, nTab=3, bNew=<optimized out>, bExtendSelection=false, bSameTabButMoved=<optimized out>) at sc/source/ui/view/tabview3.cxx:1965 #14 0x00007fc2359e851d in ScTabViewShell::Notify (this=0x356a9a60, rBC=..., rHint=...) at sc/source/ui/view/tabvwsh5.cxx:202 #15 0x00007fc245e6f935 in __gnu_cxx::__normal_iterator<SvtListener**, std::vector<SvtListener*, std::allocator<SvtListener*> > >::__normal_iterator ( __i=<optimized out>, this=<optimized out>) at /opt/rh/devtoolset-12/root/usr/include/c++/12/bits/stl_iterator.h:1073 #16 std::vector<SvtListener*, std::allocator<SvtListener*> >::end (this=<optimized out>) at /opt/rh/devtoolset-12/root/usr/include/c++/12/bits/stl_vector.h:889 #17 SvtBroadcaster::SvtBroadcaster (this=0x2b, rBC=...) at svl/source/notify/broadcast.cxx:180 #18 0x00007ffdb455a730 in ?? () #19 0x0000000000000003 in ?? () #20 0x0000000002476c90 in ?? () #21 0x00007fc244207e01 in avmedia::MediaFloater::setURL (this=0x331fc030, rURL=..., rReferer=..., bPlayImmediately=<optimized out>) at /opt/rh/devtoolset-12/root/usr/include/c++/12/bits/unique_ptr.h:191 #22 0x00007fc2498f32e0 in com::sun::star::xml::sax::cppu_detail_getUnoType(com::sun::star::xml::sax::XAttributeList const*)::the_type () from /opt/collaboraoffice/program/libmergedlo.so Change-Id: I7d62f67a840fe6c27b7bcf80fdaf66dff8c270c3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185088 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2 daystdf#117436 - Adjust row height to accommodate potential multiline cellsAndreas Heinisch
Using drag and drop to copy a table from Base to Calc adapts the row height of the imported content in order to accomodate potential multiline cells in the Base table. Change-Id: Ifadf3f9034a5440385cea7b35ce4e28f206b744d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185066 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2 daystdf#150866: Add support for TEXTSPLIT functionXisco Fauli
Change-Id: I918b46c29791f865e841eb967b2799f7986538bc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185027 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
3 daysFix typoAndrea Gelmini
Change-Id: I3e7d2b34ef2f48c6ba6743e77a8c93d889a467e7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185030 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
3 daysRemove "StandardDir"Samuel Mehrbrodt
This was supposed to set some kind of "default directory" for file pickers. It was never implemented for anything except the "gen" vcl plugin - and is also not really needed. Change-Id: I94c6ff04984fc7b1d600530dc26bd8a7672646cd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184064 Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de> Tested-by: Jenkins
3 daystdf#166481 sc shapes edit view: fix wrong draw view shellBalazs Varga
was created when an object was in rotation drag mode and we enter into the shape to text edit mode. We only need to switch to draw shell if we have not already created a text shell for text edit mode. TODO: unit/UI tests would be useful for the original enhancement. (c628a26cd3f763b39a2e2441fc766dabf04ed492) Follow-up commit of c628a26cd3f763b39a2e2441fc766dabf04ed492 677e40c8b83b06ded8e06b6151f71686baf5f6b5 Regression from commit: c628a26cd3f763b39a2e2441fc766dabf04ed492 (tdf#90293 switch draw selection to rotate mode) Change-Id: Ib857673b1f5469d6502736ecad84fe046f8c967e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185031 Tested-by: Jenkins Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de> Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
4 daysapparent use-after-free of ScLOKProxyObjectContact::mpScDrawViewCaolán McNamara
#0 std::vector<std::unique_ptr<SdrPageWindow, std::default_delete<SdrPageWindow> >, std::allocator<std::unique_ptr<SdrPageWindow, std::default_delete<SdrPageWindow> > > >::size (this=<optimized out>) at /opt/rh/devtoolset-12/root/usr/include/c++/12/bits/stl_vector.h:987 #1 SdrPageView::PageWindowCount (this=<optimized out>) at include/svx/svdpagv.hxx:89 #2 (anonymous namespace)::ScLOKProxyObjectContact::calculateGridOffsetForViewObjectContact (this=<optimized out>, rTarget=..., rClient=...) at sc/source/ui/view/gridwin4.cxx:1467 #3 0x00007fe8eae62e05 in sdr::contact::ViewObjectContact::getGridOffset (this=this@entry=0x364bdc60) at include/svx/sdr/contact/viewobjectcontact.hxx:95 #4 0x00007fe8eae642fe in sdr::contact::ViewObjectContact::getPrimitive2DSequence (this=this@entry=0x364bdc60, rDisplayInfo=...) at svx/source/sdr/contact/viewobjectcontact.cxx:487 #5 0x00007fe8eae645b1 in sdr::contact::ViewObjectContact::getObjectRange (this=this@entry=0x364bdc60) at svx/source/sdr/contact/viewobjectcontact.cxx:209 #6 0x00007fe8eae64832 in sdr::contact::ViewObjectContact::triggerLazyInvalidate (this=0x364bdc60) at svx/source/sdr/contact/viewobjectcontact.cxx:273 #7 0x00007fe8eae65415 in sdr::contact::ObjectContactOfPageView::Invoke (this=0x7fe8a8103ff0) at svx/source/sdr/contact/objectcontactofpageview.cxx:105 #8 0x00007fe8ebb2b30b in Scheduler::CallbackTaskScheduling () at vcl/source/app/scheduler.cxx:579 #9 0x00007fe8ebceb21b in SvpSalInstance::StartTimer (nMS=<optimized out>, this=0x2e01000000000000) Change-Id: Icb71083eb77e528d9025aa7a591892dcdfc2ba89 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185020 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
4 dayssc/source/ui/view/tabview3.cxx: Switch DBG_ASSERT to assertJulien Nabet
This fixes Windows/MSVC build errors like the one reported in https://ci.libreoffice.org/view/tb%20platform%20status/job/lo_tb_master_win_analyze/1135/console C:/cygwin/home/tdf/lode/jenkins/workspace/lo_tb_master_win_analyze/sc/source/ui/view/tabview3.cxx(2335): error C2220: the following warning is treated as an error C:\cygwin\home\tdf\lode\jenkins\workspace\lo_tb_master_win_analyze\sc\source\ui\view\tabview3.cxx(2313) : warning C6011: Dereferencing NULL pointer 'pEditView'. : Lines: 2300, 2302, 2303, 2304, 2309, 2310, 2313 C:\cygwin\home\tdf\lode\jenkins\workspace\lo_tb_master_win_analyze\sc\source\ui\view\tabview3.cxx(2359) : warning C6011: Dereferencing NULL pointer 'pEditView'. : Lines: 2353, 2354, 2355, 2358, 2359 C:\cygwin\home\tdf\lode\jenkins\workspace\lo_tb_master_win_analyze\sc\source\ui\view\tabview3.cxx(2458) : warning C6011: Dereferencing NULL pointer 'pEditView'. : Lines: 2440, 2443, 2444, 2445, 2449, 2452, 2458 Change-Id: I324adb67b207075a420b51726a8211d53257d3f9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185016 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
4 daysCEOO: CellEditOnOverlayArmin Le Grand (Collabora)
Instead of using EditView's Paint directly to Window I changed this now to using the Overlay that is available in all applications. This allows to have less repaints of the Calc View since the Overlay has a copy of the area it is working overlayed. It also allows to get away from one of the last areas where XOR selection was used since EditView/EditEngine have no better way to do this. Selection is now visualized using the OS'es choosen SelectionColor, as in all other apps. I could also get rid of the flush() of the OverlayManager that was needed before and caused some problems (see tdf#165621 and associated tasks). A failing UnitTest showed that OverlayManagerBuffered needs to be aware when no CompleteRedraw was done yet and thus no background data exists and refresh makes no sense. This may happen when there is no redraw/UI e.g. UnitTests, but still an OverlayManager is used and together with a Reschedule (many possible reasons) that refresh might be triggered. Made access to EditView in OverlayObject no longer dependent on ActiveView, that is not always the one with the EditView. Now using a combination of ScTabView and ScSplitPos for accesses. Asserting now if no EditView -> is mandatory. Continuing going through CppunitTest_sc_tiledrendering UTs, one more identified. Have to re-activate EditViewInvalidate rect forwarding since the Invalidate is needed for sc tiled rendering tests, but not for sd tiled rendering tests. Added that to the impl of EditViewCallbacks using LibreOfficeKit::isActive(). Change-Id: I41f5448bfbabfaae4858c7617478771053c2cd77 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184830 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
4 daysnull-deref on doc teardownCaolán McNamara
#0 std::__uniq_ptr_impl<ScDragData, std::default_delete<ScDragData> >::_M_ptr (this=0xae8) at /opt/rh/devtoolset-12/root/usr/include/c++/12/bits/unique_ptr.h:191 #1 std::unique_ptr<ScDragData, std::default_delete<ScDragData> >::get (this=0xae8) at /opt/rh/devtoolset-12/root/usr/include/c++/12/bits/unique_ptr.h:462 #2 std::unique_ptr<ScDragData, std::default_delete<ScDragData> >::operator* (this=0xae8) at /opt/rh/devtoolset-12/root/usr/include/c++/12/bits/unique_ptr.h:445 #3 ScTabViewShell::GetDragData (this=0x0) at sc/source/ui/inc/tabvwsh.hxx:470 #4 ScModule::GetDragData (this=this@entry=0x4f2dacd0) at sc/source/ui/app/scmod.cxx:632 #5 0x00007e73ef1b3584 in ScDrawTransferObj::~ScDrawTransferObj (this=0x5a10c1c0, __in_chrg=<optimized out>) at sc/source/ui/app/drwtrans.cxx:219 #6 0x00007e73ef1b381d in ScDrawTransferObj::~ScDrawTransferObj (this=0x5a10c1c0, __in_chrg=<optimized out>) at sc/source/ui/app/drwtrans.cxx:233 #7 0x00007e74010d80b9 in com::sun::star::uno::Reference<com::sun::star::datatransfer::XTransferable>::~Reference ( this=0x40a2d160, __in_chrg=<optimized out>) at include/com/sun/star/uno/Reference.hxx:114 #8 vcl::(anonymous namespace)::GenericDragSource::~GenericDragSource (this=0x40a2d110, __in_chrg=<optimized out>, __vtt_parm=<optimized out>) Change-Id: Ibce052c40972576e149d643a4dbbe4f9e89d9a8d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184992 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
5 daysapparent null-deref of pPattern seenCaolán McNamara
Change-Id: Iabab952deb36ab86cce009f4f0b4f82b5d469efd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184994 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
6 daystdf#166407: fix help page for the VALUE functionJulien Nabet
Change-Id: I44e080cc190f8fa726b9c2f7f35e55c0bcc2b275 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184960 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
9 daystdf#47479: Do not modify range of sheet / column / row in notificationsMike Kaganski
Change-Id: I2c5afa5397e3a98806908a2f73f8d654e83fb890 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184889 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
9 daysScInsertCellDlg: pass ScViewData from callerXisco Fauli
Change-Id: Ic059f4c964f761f9d1b2c0734f8b6908501fd5d4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184898 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
9 daysScConflictsDlg: pass ScViewData by refXisco Fauli
and other related changes Change-Id: I13f8c81e5715d9adea05e4d89443ec6ef8faf24a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184899 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
9 dayscool#11475 lok: sc: correctly export frozen/split pane informationAron Budea
As 7b4802070ac6fb930255536bf3ed2c52428b4181 noted, online only supports freeze panes, but preserves splits when saving. However, files could also end up with mixed frozen/split panes. In addition, even a single split was treated like two, with the other split being at the first row/column, which was incorrect. Change-Id: I974690b8877ad6d4eca1e046c3c352359a199706 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184421 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184854 Tested-by: Jenkins Reviewed-by: Aron Budea <aron.budea@collabora.com>
10 daystdf166413 sc: escape quotes in XLSX cond. formatting fixed formulaAron Budea
...during export, otherwise Excel fails to open file Change-Id: I50bc16ff4064a84ae3601cfa539d7b90f5441607 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184852 Tested-by: Jenkins Reviewed-by: Aron Budea <aron.budea@collabora.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
10 dayssc a11y: Make GetBoundingBoxOnScreen::GetBoundingBox{,OnScreen} non-constMichael Weghorn
These methods are almost exclusively used to implement the non-const OAccessibleCompomentHelper::implGetBounds and OAccessibleComponentHelper::getLocationOnScreen overrides. Making them non-const allows dropping some const_casts in some of the subclass implementations. Change-Id: Ia26858c1211629c4a336919c8e9d4d0c70e73097 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184831 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
11 daysScAcceptChgDlg: pass ScViewData by refXisco Fauli
to ensure it's not nullptr Change-Id: I462633d583c7be3f249427f103215bc76d1c0d45 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184821 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins
11 daysScNavigatorDlg: simplify a bitXisco Fauli
not need to have pViewData member Change-Id: Ia697f80421ffbbec36514c60a04087a55383d349 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184801 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
11 daystdf#164954 rename German abbreviation "Koeff" to English "Coeff" in vars, funcsSimon Chenery
The German word "Koeffizient" translates to "Coefficient" in English. Change-Id: I38cbb327df085a607cb6922003fa3f07e27eca8e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184663 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
11 daysScDrawView: pass ScViewData by refXisco Fauli
Change-Id: I499c44ebc3f3eaf5310788dbf110b8a00d8a8035 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184799 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
12 dayssc a11y: Use ref instead of pointer in ScChild{Gone,New}Michael Weghorn
Change-Id: I28a314c2d07e402decb5a7e9cae1ac59b6e8dc3a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184792 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
12 dayssc a11y: Switch ScNotesChildren::mpAccDoc to refMichael Weghorn
Use a reference instead of a pointer, to make clearer this is always non-null. This also allows to drop a null check in ScNotesChildren::DataChanged. Change-Id: Ief02eaafa7cd67a1ceb9562bf0a62435e4b877a2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184791 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
12 daysScQueryItem: no need to store a ScViewData pointerXisco Fauli
it can be passed by reference, like the other dialogs do Change-Id: I79abd717835012af8bcf8d4e135bd7e79f36ac35 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184783 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins
12 daystdf#164954 replace German variable nBreite with English nWidth in op.cxxSimon Chenery
Change-Id: I286b15f178a76118189d4a57dfbe61ce641f38c3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184667 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
12 dayscool#11739 lok: sc: change dialog units per userJaume Pujantell
On lok different users might have different locales so they need different field units in their dialogues. Right now the metric used is always the one stored in the ScModule's AppOptions for all users. With this change, for lok SfxModule::GetFieldUnit is used because it already has the correct metric per lok user. Change-Id: If2b047874a26deecc7c43936ab267b75eae101e3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184567 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com> (cherry picked from commit d01737cb12654f488bb88235cdc562d3cf68d7db) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184741 Reviewed-by: Jaume Pujantell <jaume.pujantell@collabora.com> Tested-by: Jenkins
13 daysFix comment "last 3 bites" to "last 3 bits" in op.cxxSimon Chenery
Change-Id: I3f99bcb542bf025a009b3299d36c660fb3b431a0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184688 Tested-by: Jenkins Reviewed-by: David Gilbert <freedesktop@treblig.org>
2025-04-27Remove obsolete fw declarations from sc/Gabor Kelemen
found with bin/find-unneeded-includes --fwdecl Change-Id: I04083a33ce1e7d85980da91f72c2dd85777b594d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183897 Tested-by: Jenkins Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
2025-04-26ApplyAutoFilter: pass ScViewData by refXisco Fauli
Change-Id: Ie65b3347fcfad7ba3be2af48dc73e06c027231dc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184659 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2025-04-26ScShareDocumentDlg: pass ScViewData by refXisco Fauli
Change-Id: I6308802006c957a693db88746692a8dc63e53026 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184658 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2025-04-26ScCornerButton: pass ScViewData by refXisco Fauli
Change-Id: Id76186f6eb1d59f101273dc3d97fde1265c3e0ec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184654 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2025-04-25ScOutlineWindow: pass ScViewData by refXisco Fauli
Change-Id: Iea4da0879bfc281cdb430bec3285a1a5c2da4bba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184633 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2025-04-25ScQueryItem: always pass ScViewData from callerXisco Fauli
Change-Id: I02c061ecf4316907a020e1324c606ea53da7b8a1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184630 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2025-04-25sc: pass ScViewData by ref here tooXisco Fauli
Change-Id: Id21b9e901502dc2c589ef6ee22105e883b3c5f80 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184634 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2025-04-25ScPrintFunc::DrawToDev: pass ScViewData by refXisco Fauli
Change-Id: Ia7e0b8e4c56ecfc9525ac45bfdb3d4304877e4c1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184632 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins
2025-04-25ScSortItem: always pass ScViewData from callerXisco Fauli
Change-Id: I95b273bebed032a3acb0bdca0e1ae30d0e98600d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184631 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2025-04-25ConditionalFormatEasyDialog: pass ScViewData by refXisco Fauli
Change-Id: I38db0341403c0e2fbf147d57dfbe956938e7f8de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184628 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2025-04-25ScPrintAreasDlg: pass ScViewData from the callerXisco Fauli
like the other dialogs do Change-Id: I584a2dc7e347a31c4b627d97277b9ab0207b7ee8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184627 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2025-04-25sc: pass ScViewData by ref in some placesXisco Fauli
it's always non-null. Change-Id: I0ac888c6d4e40a9de59c8b6136dd3be8c3ec3770 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184624 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins
2025-04-24[API CHANGE] a11y: Return string for XAccessibleExtendedAttributesMichael Weghorn
All XAccessibleExtendedAttributes::getExtendedAttributes implementations return a OUString wrapped in an Any (or an empty Any), and all consumers also expect that. Therefore, change the return type from Any to OUString to make that clearer and simpler. Change-Id: Ic6af692f72fd072c4039996f31208ac2098d2750 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184514 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2025-04-22tdf#166177 Fixes unintended switch to rotate modeOliver Specht
Fixes switch to rotate mode after inserting or moving a shape. Change-Id: I4e8ce8b5891a08c6c3f20a9c29fa4bef4428eb84 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184141 Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de> Tested-by: Jenkins Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
2025-04-21cid#1646578 Logically dead codeCaolán McNamara
Change-Id: I590d2cf930421de0319dfb705af5b80f793a524a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184408 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2025-04-19speed up EvalMatrixNoel Grandin
by (a) using the iterator instead of doing an index lookup for each iteration and (b) switching the loop so we work with the natural data layout Change-Id: I35bca868f72657c279c33e221deafd672272c8aa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184358 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2025-04-18tdf#163872 speed up IfJump operationNoel Grandin
shaves 10% off the load time here by moving the loop of the operation down into the matrix code where we can iterate direcltly over the data. Change-Id: I88f66d0ab3c7fc9e09ccffb96c0fd335daf62169 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184343 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
generated by cgit (git 2.34.1) at 2025-05-11 10:26:38 +0000