summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)Author
2020-04-15add an IsEmpty method to tools::Size and use itNoel Grandin
Change-Id: I7f5201e2ea6c74329336e16bf219630e38ff92cf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92264 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-15uitest: wrong filenameXisco Fauli
Change-Id: I06b3586519b8b58410ffb4e08822af53e252ecbe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92262 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-04-15tdf#131170: Add UItestXisco Fauli
Change-Id: I3d881803014d80cd3e8b3ed2f3cc2e84fdc1b3b6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92261 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-04-14tdf#130960: Add UItestXisco Fauli
Change-Id: I41f5bd8c8b9183138b673a5f40d8a29abe9874df Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92218 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-04-14uitest: improve tests in trackedChanges.pyXisco Fauli
Change-Id: I644a6e64ab7da002915a43745a35517a144b6cf5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92217 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-04-13tdf#113621: Add unittestXisco Fauli
Change-Id: Id733bfb64cd750f80a13b36e1937137354282787 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92109 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-04-13tdf#112936: Add unittestXisco Fauli
Change-Id: I9c2f21491ef97f9a1b82f43cdb9b0b978689f70b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92110 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-04-12tdf#41722: Add unittestXisco Fauli
Change-Id: I95ff8794addcce6a73d32f49222adffd7d824255 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92090 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-04-12lok: get the formula input bar focused after inserting '='Marco Cecchetti
Change-Id: I7f86ea7135fcb4071cc0162c233c63be6c9485bd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92083 Tested-by: Jenkins Reviewed-by: Marco Cecchetti <marco.cecchetti@collabora.com>
2020-04-12tdf#105272: Add unittestXisco Fauli
Change-Id: I80aa192651595a719a5ac9a06423d2cf80aa7a3d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92078 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-04-12improve fastparser loggingNoel Grandin
so we print out the full namespace, which is quite handy when tracking down attributes that are not being parsed. Change-Id: I085d39b365d43c1a53a7c176b633ea38e6a7fb45 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92064 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-11tdf#131907 Crash: reject/clear formattingNoel Grandin
regression from commit 0ef5c47547bec6319b853326603f3b807407fe78 sc: rowcol: tdf#50916 convert core/tool Change-Id: Ib8207f60d34e4257fc9a854f4e4d358951e24718 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92062 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-11rename vcl::Window::Update to PaintImmediatelyNoel Grandin
To make the code easier to read. Change-Id: Iebc648150391939fba5d1cd815c72dbcf02ceec6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90378 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-10tdf#55417: Add unittestXisco Fauli
Change-Id: I1cf633ea0be39c58bf38026d5ea73ad89bec72bc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92052 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-04-10tdf#73063: Add unittestXisco Fauli
Change-Id: I69beef7f6014af1940cd89749f1712a40c74e543 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92053 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-04-09GetObjectShell() can return nullSamuel Mehrbrodt
Change-Id: Ie410688c124d6653fc58fa9e63bd5dd3b46bf8ff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91979 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins
2020-04-09Move is*Locked methods to object shellSamuel Mehrbrodt
They depend on the model, not the view. Follow-up to 523922ee9d033fd304d2b50a72b76853ddcfbcdf Change-Id: I429bc25b8dd4f04ebf62eddd5ef455b5161e925d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91867 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2020-04-09tdf#95425 follow-up: enable "Source format" checkbox of data labelBalazs Varga
settings after file opening, if its value is true in the opened ODF or OOXML document, instead of always showing disabled state. Testing notes: double click on a data label during chart editing of unit test document testAreaChartNumberFormat.docx of commit e57d90cd4e51a1353eafc87bb29cfe6076704a7c (tdf#129173 tdf#129175 Fix number format of data labels) to see the Data Labels for Data Series... window. On the page "Data Labels...", click on the Number format... button to see the enabled checkbox "Source format" (that was disabled previously). Change-Id: I2845e6f462db273f21c47bb286bed56046f8cf21 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91038 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-04-08tdf#122331: Add unittestXisco Fauli
Change-Id: I5c104f225b0d3fd060c36db6b3cef34f46534c61 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91906 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-04-08Make SalInstance::CreateClipboard return a single instance in the non-LOK caseStephan Bergmann
I came across this when seeing UITest_calc_tests2's tdf118189.tdf118189.test_tdf118189 fail on Linux with SAL_USE_VCLPLUGIN=gen and also on Windows, see the mailing list thread starting at <https://lists.freedesktop.org/archives/libreoffice/2020-April/084822.html> "Linux SAL_USE_VCLPLUGIN=svp and the clipboard". That email thread clarified that the codified behavior of that non-LOK test was wrong. (While the LOK test ScTiledRenderingTest::testMultiViewCopyPaste in sc/qa/unit/tiledrendering/tiledrendering.cxx keeps working as intended.) I did not find documentation for what arguments CreateClipboard shall support, but things seem to work if anything but empty arguments is rejected with an IllegalArgumentException. Change-Id: I1918254cc15878ad43b8aa22aff7eb1c4bea73fe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91869 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-04-08cid#1461387 Uncaught exceptionCaolán McNamara
Change-Id: Ifcd9d3043bf51df6eb6a030481c63758f8501a0b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91872 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-08Resolves: tdf#131442 Sort must not contain matrix formula except 1x1 arrayEike Rathke
Change-Id: Idc7a9646a70c59fceee0b36426f38a938cf073ce Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91858 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2020-04-07Fix typoAndrea Gelmini
Change-Id: Iaeafd85b5d1becbafba644bb873dd7f676707cb6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91805 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-04-07Resolves: tdf#131170 columns tagged as delimiter not columnCaolán McNamara
Change-Id: I889c3ba38776a63587a68c7827956b6747c08e38 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91784 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-06loplugin:unusedvariableplus in scNoel Grandin
Change-Id: I163b0cd5a8dc381322b0113aca23faae29b1b859 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91755 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-06unset dest dnd row highlight after dropCaolán McNamara
Change-Id: Id9b70b247351a5c12b6540c828e2c34f9fb31c11 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91750 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-06lok: introduce QueryControlState functionHenry Castro
The sidebar usually executes UNO commands to the core framework, however the controls already have formatted the text that is useful in Online client side. For example the units conversion. The QueryControlState method will retrieve the current formatted text of the sidebar control to be used in Client Side. Change-Id: I0b3e3a1462d4391ac911352f35808a5e5d9f9ffb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91237 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Henry Castro <hcastro@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91577 Tested-by: Jenkins
2020-04-03split up polypolygonprimitive2d.hxx into separate filesTomaž Vajngerl
This patch splits the polypolygonprimitive2d.hxx into: - PolyPolygonColorPrimitive2D.hxx - PolyPolygonGradientPrimitive2D.hxx - PolyPolygonGraphicPrimitive2D.hxx - PolyPolygonHairlinePrimitive2D.hxx - PolyPolygonHatchPrimitive2D.hxx - PolyPolygonMarkerPrimitive2D.hxx - PolyPolygonSelectionPrimitive2D.hxx - PolyPolygonStrokePrimitive2D.hxx ... and fixes the include files and pre-compiled headers Change-Id: I23982e0c81e8992f69e14cbac8e86858266b9999 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91603 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-04-03uicalc: no need to use an empty documentXisco Fauli
Change-Id: Id1c42b7c4f0f406d2979334d7b71fc20d7ff8620 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91615 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-04-03use mdds position hint (tdf#131716)Luboš Luňák
Otherwise this is the usual case of possible quadratic mdds slowness. Change-Id: I5b33df65e127702c011517d79b9cd41a7e820ca0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91553 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-04-03Turn defines into constexprsMike Kaganski
This allows to see actual values of the WhichIds in IDE easier Change-Id: I31106459cd262000444175d082eb349ff937488d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91513 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-04-02cid#1460967 Division or modulo by float zeroCaolán McNamara
Change-Id: I2322ac1abec040d14fbffaf495c83cf3303fee92 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91547 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-03-31tdf#131372: Add unittestXisco Fauli
Change-Id: I7dbed0c28206ffd6a95ecedec74fdac044fe79cc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91432 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-03-31convert enum to scoped in SvBaseLinkNoel Grandin
Change-Id: Ief399381ac27764fce95ee053c322571a07b671c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91366 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-31Resolves: tdf#131372 Write "error cell" formula to OOXMLEike Rathke
Change-Id: Iedbe0912ff28e6203bec0104c59b1102cf97daf9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91382 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2020-03-30FrameLineColor - add Color parameter, and share code for color params.Michael Meeks
Change-Id: I50483228221e817eb1a1d049d3c1ddf55a9c91d8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91354 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2020-03-29tdf#130981:Simplify uses of sal_math_Doublejames
Change-Id: I2cac5d7c2efc9dbf4c4fc7ca5d88e9044d875edc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91203 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-03-27Resolves: tdf#131096 Handle argument error and propagateEike Rathke
For etsPIAdd and etsPIMult also check if the fPILevel parameter was actually specified (explicitly or missing/omitted) and do not pop the 3rd parameter if not. GetDoubleWithDefault() can't handle that as apparently was erroneously assumed. Use IllegalArgument error instead of IllegalParameter in most cases (the parameter is fine but the argument value is not). Actually propagate ScETSForecastCalculation::mnErrorValue if set as PushMatrix() does not, on purpose. Change-Id: Ia2db5b0a7a388f0f40b73c6a4f66debbedec41e8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91232 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2020-03-27tdf#131380: Add unittestXisco Fauli
Change-Id: I9111c82919b9e30200fbb265143e072f7f3b3363 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91205 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-03-27tdf#43157 Clean up OSL_ASSERTJens Carl
Change-Id: I23da49e2395a76eaa97c98757db16289e200a828 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89407 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2020-03-26tdf#131380 crash on loading specific xlsx documentCaolán McNamara
mpPerIdx is null, because bEDS is true, assume 0 in this case Change-Id: I44c2433b0de57a28cece6b9b01ba543bdc3cb8d3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91145 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2020-03-26Fix one more get_url_for_data_fileStephan Bergmann
Change-Id: I07e11cd83443f40fd520088c18647f0992ccae82 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91139 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-03-26tdf#131593 ScOutputData::GetMergeOrigin: Handle cells outside own areaMichael Weghorn
Rendering the bugdoc had regressed at commit 9113f17e65b1dafbc178fd269e2967c1e2632f0e ("LOK: fast tile rendering (text only)", 2016-06-04), which had changed the area covered by the ScTableInfo in use from the document's whole rendering area to that covered by the bounding rows and columns for the tile being rendered. For the bug doc, it was e.g. no longer detected that cell A10 (nX=0, nY=9) is merged to A1 when processing the "second tile in the second row of tiles" in ScOutputData::DrawEdit. Change-Id: I60c3ad43ad816d2186547486116f63e27ed3a166 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91094 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2020-03-26Extend loplugin:cstylecast to certain function-style castsStephan Bergmann
...that are equivalent to const_cast or reinterpret_cast, and should arguably better be written that way for clarity. Drawing inspiration from <https://reviews.llvm.org/D76572> "Replace `T(x)` with `reinterpret_cast<T>(x)` everywhere it means reinterpret_cast. No functional change". Change-Id: I27b8f70d324d32ecba658db4d1c2db03e10d5d3e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91086 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-03-25tdf#127113: Allow to fill any two numeric fields in Fill Series dialogSarper Akdemir
Added m_nSelectHeight and m_nSelectWidth to ScFillSeriesDlg class for deriving missing box if other two boxes are full. CheckValues() mimics behaviour of previous check functions with added functionality of calculating missing start or increment values (end value was already handled in previous check functions) in linear fill mode if it is possible to calculate them from other two values. Change-Id: If30d96f1b5f7e1bb88f473d7c0c5c2802ba6f225 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87841 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2020-03-25tdf#101181: add sidebar panel for Glow effectMike Kaganski
... in Writer, Calc, Draw and Impress for CustomShapes. The artifacts that become apparent using the controls, e.g. remnants of the effect when decreasing radius (in Impress), or glow not drawn until reload after enabled or radius set to 0, should be fixed in a separate commit. Change-Id: I6107597161bc67ae8c3e62c260ef6ad241c7dedf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91056 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-03-25lokit: Mark document as modified on chart insert/edit...Dennis Francis
immediately at least in the case when LOKit is active. This is to allow prompt emission of .uno:ModifiedStatus=true statechange message from lokit to the client. Without this, in online the chart insert/modify related changes may not get saved on client exit. Change-Id: I8c38a37cc455f74a70d43b6aaa3e5035b283d47f (cherry picked from commit 75adb624dfff4659e6f3099a1720fbd697560f9c) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91036 Tested-by: Jenkins Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
2020-03-25Remove unused using declarations in oox...xmlsecurityGabor Kelemen
Found by: run-clang-tidy-10 -checks=-*,misc-unused-using-decls Change-Id: I3e95791e223ef01e140a6217e29a9efae428a784 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90876 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-03-24weld writer navigatorCaolán McNamara
GtkToggleToolButton are much wider than vcl equivalents. Split the bottom toolbar into two toolbars. Rearrange their contents so the layout of each level visually match. Notes: Master documents have two modes, master content tree and the normal content tree. You can drag entries from the content tree into the document, drag mode drop down controls whether its a link or a copy etc that's dropped in. Documents can be dropped into the content and global trees. If outline tracking isn't active, then when content changes the tree is cleared and refilled, typically an effort is made to reselect the same entry that was previously selected. Additionally, if the amount of content didn't change an effort is made to scroll back to the location the scrollbar was at before the clear. Change-Id: I00c015145eac5b1acc3398d3c40861d830e4264a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89725 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-03-24tdf#131296: get numeric value with its data type in StepLOADNCAndreas Heinisch
In order to load numeric values, generate SbiOpcode::NUMBER_ opcodes including the numeric value and its data type instead of SbiOpcode::CONST_. The numeric value and its data type will be restored in SbiRuntime::StepLOADNC. When the new compiled code is stored in documents, e.g. password-protected libraries, leagcy LO versions will just read up to non-numeric characters, thus correctly obtaining number value and ignoring the type, so the change is backward-compatible. To interpret legacy compiled code, old treatment of SbiRuntime::StepLOADI is restored, reverting commit 0b4f8bf571baf2ccd5a8aafdc4deb41867420be3. This change reimplements the fix for tdf#129596. Change-Id: I46ebfc77f9bea69479968950c0fb7264e4a7ab27 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90858 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
generated by cgit (git 2.34.1) at 2025-02-15 23:51:44 +0000