summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)Author
2020-11-02drop the SvXMLExport::EndElement method..Noel
in favour of just using the endFastElement() method Change-Id: Id95abb0b9e78bc44278c5e9e3cc8dee15185e2e2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105175 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-02drop the SvXMLExport::Characters method..Noel
in favour of just using the characters() method Change-Id: Iecb2773d488fcf4fa3c2202d0e889015a288fe2a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105174 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-02tdf#137620 support surrounding text for calc commentsCaolán McNamara
Change-Id: I362a8ec6cd5de8602863fd2e520c8bd1a3706f00 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105171 Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Jenkins
2020-11-02make SvXMLImport capable of mixing fast- and slow- contexts adhocNoel
so I can convert even *ImportContext subclasses in the middle of a context stack, and thus break the cyclic dependency nature of the writer import. and adjust the xmlimport loplugin for the new rules. As a consequence of the loplugin:xmlimport's checking, we remove a bunch of now unnecessary overrides of startFastElement. Change-Id: I97464522ede8ec5e345e928cdafa4b18364b1b80 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104730 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-01use officecfg for ShowLinkWarningDialogNoel Grandin
Change-Id: I92a42eb2ff48bff4e635f1a37a25c8ecb9ac1347 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105153 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-01Resolves: tdf#135108 Allow link updates if loaded document so far had noneEike Rathke
It is the current user who'll add external references, not the creator of the loaded document. Change-Id: I59a6d0b8600a9b299aa54a1efeedfccc16ad69d7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105152 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2020-11-01use officecfg for Experimental flagNoel Grandin
move IsShowOutlineContentVisibilityButton out of header to avoid having to add extra include paths to all the unit test makefiles. Change-Id: I2763390e07cd85b8f09b6f2ad7702039daecb22f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105100 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-01Fix typoAndrea Gelmini
Change-Id: If2f4e9af927be2f335bdbbf0d81f8a89cc8b9019 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105127 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-10-31Enquote sheet name if necessary, tdf#137896 follow-upEike Rathke
Change-Id: I9ebdc30bf0b8b1531d57da299146fda9871442ed Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105126 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2020-10-31Use ScDocument::GetSheetSeparator()Eike Rathke
Change-Id: Ib83e66f2184b32f98e01e3deae5600c2e0f2045f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105125 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2020-10-31Resolves: tdf#137896 Paste sheet-local names with sheet name prefixEike Rathke
Change-Id: Ib1779bb42c8b26a825899f8a93bc22b7ee441637 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105124 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2020-10-31Implement ScDocument::GetSheetSeparator()Eike Rathke
That can be reused. Change-Id: I4805fefa7585ddee026073e3b647020f8a993ab2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105123 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2020-10-31tdf#137897 scRetypePassInputDlg: re-allow password removalJustin Luth
This weld-conversion logic error caused a LO 6.1 regression in commit 0e4f93e88bfae3489d2de84fc2febed100880628. - m_pPasswordGrid->Disable(); + m_xPasswordGrid->set_sensitive(false); //disable == false - m_pBtnOk->Enable(); + m_xBtnOk->set_sensitive(false); //enable == true The result is that attempting to remove the password did not enable the OK button, so it was impossible. Change-Id: I4067b2ec6b89e86b21968d33c8850cca6d067e71 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105101 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-31Constructing ScCompiler is unnecessary hereEike Rathke
The sheet separator can be obtained from the AddressConvention extracted from the document's FormulaGrammar. Change-Id: Ieec8f49f1d338c29665192fc73320f76b8fa1484 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105106 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2020-10-31rename to NotifyContainsEmbeddedFontCaolán McNamara
to indicate better what its users do with this notification. This reflects better the reality that while the embedded font has been read at this point, vcl hasn't been informed of its existence yet. Change-Id: I87f4d0a0361192dac972f6146d3721a69e11ac27 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105086 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-31Improve 'resize with cell' handlingRegina Henschel
The patch contains a larger rework of RecalcPos and connected areas and covers several bugs. Essentials in short: Move initialization from RecalcPos to own method and use it in ScXMLImport::endDocument Do not change hidden objects, which includes not setting width or height to zero, and be consistent in using object visibility. Special handling of vertical flipped customshapes. Repair anchor on import of line and measure line. ODF conformance: Create logical rectangle from anchor instead using size. Details: tdf#137044 ScDrawLayer::SetPageSize is called several times while loading a document. It includes a call to ScDrawLayer::RecalcPos for all cell anchored objects. An object gets initialized with the first call. Problem was, that the row heights were not finished at that time and anchor cells and offsets were partly calculated based on default cell height. That results in wrong height and offset of objects. The solution separates initialization from RecalcPos and puts it into an own method ScDrawLayer::InitializeCellAnchoredObj. This is then called from ScXMLImport::endDocument when row height settings are finished. The call to RecalcPos is not totally removed from SetPageSize but only excluded while loading, because it is needed for size changes after the document is loaded. tdf#137576 partly For measure lines and ordinary lines, which were anchored 'To cell (resize with cell)', LibreOffice has written wrong end-cell info to file. So reopening results in wrong lines. The geometry of lines is based on two points. Fortunatelly the combination of position of the cell, which contains the shape, and start and end points gives correct absolute position of these points. Solution is, to regenerate the initial ScDrawObjData infos from these points and do not use the stored end-cell info. For a total fix implementation of NbcSetSnapRect for SdrMeasureObj is needed, which is not included here. tdf#137020 Cell anchored shapes are contained in a cell in file. To determine size and position of the shape a rectangle is used, so defined, that after applying transformation you get the desired shape. In case of custom shapes, a vertical flip is not contained in the transformation but it is an attribute inside the shape and flip is done at the shape center and will not change the rectangle. This rectangle determines start and end addresses and offsets in ScDrawObjData in rNoRotatedAnchor. The info is used directly in XML export. It is correctly build while loading the file. But in case of vertical flipped custom shapes the logical rectangle of the shape has an additional 180deg rotation. Changing that behavior is currently out of scope. Therefore special handling of vertical flipped custom shapes was added. tdf#99549 ODF specifies that in case of existence of end-cell attribute, size attributes have to be ignored. But LO has based the logical rectangle on size. In addition it has written zero width and height in case of hidden row and cols. Result was, that objects are 'lost' on opening although they still exists in the file. With the patch the object size is recalculated from anchor on opening. tdf#137355, tdf#137044, tdf#115655 The old solution has recalculated the snap rectangle based on current state of hidden row or column. That has produced shapes of zero width or height and loss of offset in case start or end cell of the shape was hidden. In running LO it was partly offset by using cached infos in ScDrawObjData. That failed in case of save and reload. Solution is, to only change visible shapes. It is enough to adapt the shape when it becomes visible. That is introduced in RecalcPos and SetCellAnchoredFromPosition. tdf#137216 Shapes anchored to cell were not hidden, if the column of its anchor was hidden, and undo of hiding an image in a cell by hiding its column didn't work. Reason was, that the shapes were not set to hidden in the shapes geometry. Solution is to copy a similar part from SetRowHidden to SetColHidden. without bugreport, but detected while debugging LO has used a cell reference with bHiddenAsZero as true in shape export. That has resulted in wrong offsets. Unittest changes: Test::testGraphicsInGroup() ScShapeTest::testCustomShapeCellAnchoredRotatedShape() Set expected values so, that they correspond to anchor in file. ScFiltersTest::testLegacyCellAnchoredRotatedShape() FIXME is solved now and the test is adaped to reflect that. XSheetAnnotationShapeSupplier::testGetAnnotationShape() Expected value is adapted to the fact, that now annotation shape gets its position after optimal row height is applied. Change-Id: Iffee996054ebf79e04044da5520f8d1a8a48b7c1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104643 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2020-10-31Support external names in INDIRECT()Eike Rathke
Works with external global names, external sheet-local names are not supported by ScExternalRefManager / ScExternalRefCache. Change-Id: I59ecc9444268a14eee67439db5ed99181a716151 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105092 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2020-10-31Resolves: tdf#100818 Support sheet-local scoped names in INDIRECT()Eike Rathke
Change-Id: Iae1ef07bf735b5886e391dced9984acee617f051 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105091 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2020-10-31Let INDIRECT() bail out early on empty stringEike Rathke
e.g. if obtained from yet empty cell. Change-Id: I18597b86b37d5d216213f9a101e8b84b307b2a34 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105090 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2020-10-31Pass ExternalInfo up to caller from lcl_ScAddress_Parse_OOo()Eike Rathke
... if external and sheet name was detected but a reference not completely parsed, which may indicate an external sheet-local name. This then in ScCompiler::IsSingleReference() is used to reset mnCurrentSheetEndPos and mnCurrentSheetTab, which without before was not done and may have lead to the external sheet-local name being taken as a sheet-local name in the current document if there was an identical one. External sheet-local names so far are not supported at all. The ExternalInfo is filled only if pSheetEndPos was passed but then could be used by the caller to obtain a name later. ExternalInfo::maTabName is filled only if a sheet name separator was encountered. Change-Id: I2414655a90a961af0e8ac2367cde7bdc4dcbb4c6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105089 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2020-10-31Reintroduce ScGlobal::FindUnquoted() nStart parameterEike Rathke
That got removed early as unused but will be needed. Change-Id: I71c028bb92f337b10366b3eac44d3eacbf1e1355 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105088 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2020-10-30tdf#137620 add explicit SurroundingText support to ScGridWindowCaolán McNamara
Change-Id: I51cf18d635c7a32e88c4afd4c59756ef93fc9c4d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105076 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-30Fix typoAndrea Gelmini
Change-Id: I6cef71ff511088572c07a893e41c7e1a8ee9b079 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104940 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-10-30tdf#137625 sc: autofill user list sequences in merged cellsAttila Szűcs
Improve FillAuto, FillAnalyse to continue linear sequences of user list values in merged cells. (User lists are special string lists with values like day names Monday, Tuesday, ...) If values are user list values, but not in linear sequence, then the autofill will just fill with FILL_SIMPLE (pattern repeat). Note: the unit test depends on English system locale settings, check it in Tools->Options->LibreOffice Calc->Sort list, otherwise extend Sort list with English day names for manual testing. Co-authored-by: Tibor Nagy (NISZ) Change-Id: I7a1da5e82a18ba8ebd24af7e4b89c7651f3ec24a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104690 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-10-30NB tabbed update writer and calc arrangementandreas kainz
Change-Id: Id9a0306a661dcc0dafd6b75776da775af9dc4565 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105032 Tested-by: Jenkins Reviewed-by: Andreas Kainz <kainz.a@gmail.com>
2020-10-30tdf#84874 XLSX export: truncate validation textTibor Nagy
Maximum length allowed in Excel is 255 characters for title and message of validation input and error, so truncate them, otherwise Excel throws away the whole message. Co-authored-by: Attila Szűcs (NISZ) Change-Id: Id4576f167ab8a39e0cd943bc07c2e465a77ba665 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104547 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-10-30convert some tools::Long->sal_Int32Noel
in places where it is obvious we only need a sal_Int32, because we are dealing with rows and columns, and not even calc needs more than 32 bits for that. Change-Id: I114417e639c224d45bfd9fc6838122ab195eefa3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104584 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-29calc: clear the spell-checking cache on tab switch.Michael Meeks
Change-Id: I187b5ff65c951e088e403f1a7a833bee248229fc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104852 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-28tdf#136694 - share spelling context across all ScGridWindows.Michael Meeks
Adding new ScGridWindows later (as we do for split panes) didn't call EnableAutoSpell on them; also duplicating the spell-checking cache looks wasteful, so share it. Change-Id: Ieb67bb292590a097bb5a59d369416a094c54c954 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104706 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-28convert some more long -> tools::LongNoel
Change-Id: Ide9811c1a7582454b3fcf655b70ea106ed56509a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104914 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-28tdf#tdf#137726: sc: Add UItestXisco Fauli
Change-Id: I67bcafb3155b991dc8b1515f224675906e0a5955 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104897 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-10-28Improve spell checking performance and impl. in several ways:Dennis Francis
* do synchronous spell checking, avoiding an idle handler * avoid continuous invalidations caused per-cell by spell-checking * cache spell-checking information for a given SharedString to avoid repeated checking of frequently recurring strings. Change-Id: Ie251f263a8932465297dd8bd66dfc4aa10984947 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104705 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-28Extend loplugin:elidestringvar to OStringStephan Bergmann
(In VisitVarDecl, filtering out AbstractConditionalOperator avoids an unhelpful > ~/lo/core/vcl/source/pdf/XmpMetadata.cxx:63:32: error: replace single use of literal 'rtl::OString' variable with a literal [loplugin:elidestringvar] > aXmlWriter.content(sPdfConformance); > ^~~~~~~~~~~~~~~ > ~/lo/core/vcl/source/pdf/XmpMetadata.cxx:52:21: note: literal 'rtl::OString' variable defined here [loplugin:elidestringvar] > OString sPdfConformance = (mnPDF_A == 1) ? "A" : "B"; > ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ) Change-Id: I7d0410f04827d79b4b526752917c37d33cad2671 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104911 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-10-28convert some more long -> tools::LongNoel
grepping for stuff in template params this time Change-Id: Ia37bfd85480b3a72c3c465489581d56ad8dde851 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104855 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-27avoid warning on set_active(0) on empty GtkComboBoxCaolán McNamara
i.e. gtk_tree_view_scroll_to_cell: assertion 'tree_view->priv->tree != NULL Change-Id: I48e7d015ec02ece407c732afebebb43c9c6fed48 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104896 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-27tdf#137726 hide pivot table dlg so its not a candidate as error dlg parentCaolán McNamara
because this pivot table dialog is going to disappear on response and the error dialog is not run in its own event loop but instead async so will end up as a parent of a dialog that doesn't exist Change-Id: I78302428a246612e3107d2907ffffb97a2d25ea2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104895 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-27uitest: move all calc tests to sc/qa/uitestXisco Fauli
and remove a few duplicated ones Change-Id: I409ca78dcd7a67e993f6b3a1493ffa6fefd127b3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104864 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-10-27Resolves: tdf#137617 Use document address convention to create namesEike Rathke
... from selection. Change-Id: I0b170f36cfdb592e7cebae0246fba12c0180e2c2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104854 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2020-10-26Clean-up of commit: 0d193c12a673fade8ece9d84cc4024fafdf52c9bAttila Szűcs
https://gerrit.libreoffice.org/c/core/+/104049 Change-Id: I9c7fd094f0301a81e8c86e10e62f4f619d6ec2f8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104533 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-10-26tdf#137621 sc: autofill bool sequences in merged cellsAttila Szűcs
Fixed FillAnalyse to not discover booleans as number sequences, rather as a pattern that can be repeated. Co-authored-by: Tibor Nagy (NISZ) Change-Id: I0a32e756461eb4101b77724129b745e23a658b1d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104655 Tested-by: Jenkins Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-10-26uitest: sc: move data folder to the root uitest folderXisco Fauli
Change-Id: I65e81bb3cc25283e882b4a63661c0959b297a76e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104802 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-10-26std::unique_ptr -> std::optionalNoel
Change-Id: Ib3a901c26874bb6e6b7deacca359cefacbb0a3e6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104798 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-26std::unique_ptr -> std::optionalNoel
Change-Id: I25f8b337a3f9cecb4d7785c18d91dae89ba20799 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104797 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-26tdf#129969 XLSX export: file URLs need IURI encodingTünde Tóth
External hyperlinks with # in directory name didn't work after XLSX export. Change-Id: Ibdf4fcbb65d0c580841d24c1721454164e341424 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104272 Tested-by: Jenkins Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-10-25tdf#137713 GetEditView must be called unconditionally in PaintCaolán McNamara
Change-Id: I9593b263c71ff2a169754ff272198965f4e0e277 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104758 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-25tdf#115588 write autoDataStyles for master-slidesTomaž Vajngerl
If we don't trigger this, then the numeric styles won't be written to the auto-styles and the style.xml will refer to styles, that don't exists. In particular a reference to "N2", where "N2" number-style wouldn't be defined. Flat ODS, that writes all into one document, was unaffected by this (because we trigger the autoDataStyles funtion in when also exporting the content. Change-Id: Iddfc264756d828b098ca8a351299c961b7e63dab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104760 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-10-24tdf#137713 don't crash if there is no m_xEditViewCaolán McNamara
Change-Id: I8b35459c7d5a704d9e2c0e2bfa4fce1aef152846 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104757 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-24uitest: sc: get_url_for_data_file -> pathlib.PathXisco Fauli
Change-Id: Iea16b30e74a5bbc5fe155f1265d5c05bf104995c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104729 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-10-24tdf#104378: sc: Add UItestXisco Fauli
Change-Id: I2258de72c3aae6b7d9aaa2c65c8c551384d84024 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104736 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-10-24simplify a bitMike Kaganski
Change-Id: I46473789828ea38aaec2c738aa57ec18b30e7c1a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104734 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>