summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)Author
2014-12-15sc: Use appropriate OUString functions on string constantsStephan Bergmann
Change-Id: Ib4c0df8d7637bff7d7a45d24482fff4342169fae
2014-12-14fix indentationMarkus Mohrhard
Change-Id: I7a06920cfc170a06ab5bbb69480a4bdcb3ab5c9f Reviewed-on: https://gerrit.libreoffice.org/13473 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2014-12-14fdo#39440 eliminate redundant conditionMichael Weghorn
addresses the following cppcheck "redundantCondition" warning: "Redundant condition: If n > 0, the comparison n != -1 is always true." Change-Id: I879b1e3a07b56560dd635a399b6079f9bd2f9590 Reviewed-on: https://gerrit.libreoffice.org/13461 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-12-12rhbz#1116534 crash when pasting over a formulaDavid Tardon
When pasting CSV data into existing document, we cannot use the ScImportExport optimization for insertion, because the cells can already have content (a grouped formula in this case). So use appropriate ScDocument functions, even if that means the import is slower. This is a regression from commit 93959db4d8846cfdfb87ab647c4d457fb09bb869 "use DocumentImport for csv import, related fdo#69006". Change-Id: I92f70abca0542d796e3aa674b28a31053fff00d0
2014-12-12Resolves: fdo#87245 crash because clip doc doesn't own DocumentPoolCaolán McNamara
multiple documents sharing the same doc pool so can't unset its secondary here. Here the assumption is that SharePooledResources has always been called on Clip or Undo docs (otherwise persumably need a flag which SharePooledResources toggles on) Change-Id: Ibcdbe5f698102dc683c290d3bd581c31e214765f
2014-12-12resolved fdo#86809 connect filter conditions correctlyEike Rathke
Maybe since 0960ec3e1b7b0d872d1f84d2d56f480a4df08b21 all conditions of a single filter stack were OR connected, regardless whether filter-and was given in the file. Change-Id: Ifb423ccc7deb42bb6bba0bfc810607633f2c342c
2014-12-12fix typo, thanks to MatteoCaolán McNamara
Change-Id: I6fd3f69cc56672fe2639ee575f9ed0cdf45490bd
2014-12-12coverity#1242775 Use of untrusted scalar valueCaolán McNamara
Change-Id: Iaaf92c4be9b41c5824a1b1474fbce19a1afa49ae
2014-12-12coverity#1242895 Untrusted loop boundCaolán McNamara
Change-Id: If01f0edecca8988087386507717ea8222058bab8
2014-12-12coverity#1242728 Use of untrusted scalar valueCaolán McNamara
and coverity#1242836 Use of untrusted scalar value coverity#1242927 Use of untrusted scalar value coverity#1242937 Use of untrusted scalar value coverity#1242942 Use of untrusted scalar value Change-Id: I66b602c27ee78ba80baab74dfb49ae90df45cbdc
2014-12-12coverity#1257735 Logically dead codeCaolán McNamara
Change-Id: Ia96d9b4ead01e6ba68d97e933cae7c97a75efdf1
2014-12-12remove operator>> and operator<< methodsNoel Grandin
in favour of ReadXXX/WriteXXX methods Change-Id: I69eebee3a8ce5b40301db7940a1d85915c0bf6f4
2014-12-11fdo#86572: Write test for this.Kohei Yoshida
Change-Id: I00c3eaac473f0464e923e785cc50ad6769c78d41
2014-12-11fdo#86572: Increment row position *only when* the row ref is relative.Kohei Yoshida
This is just a simple oversight. Change-Id: I024777c46641cce3410a20f40c48f47ad6a5dade
2014-12-11WaE: implicit conversion (IntegralToFloating) from bool to 'const double'Tor Lillqvist
Kohei says it is intentional, i.e. 1.0 or 0.0 should be passed, so say so explicitly to avoid warning. Change-Id: Ieff79d35f2b0770ea9de02b83d117ac90009f7d5
2014-12-11fdo#87155: Avoid negative scaling (and assertion failures further on)Tor Lillqvist
Change-Id: I4a1a96b785ced4364a325ac19975d29771afe122 Reviewed-on: https://gerrit.libreoffice.org/13396 Reviewed-by: Kohei Yoshida <libreoffice@kohei.us> Tested-by: Kohei Yoshida <libreoffice@kohei.us>
2014-12-11coverity#1242939 Untrusted value as argumentCaolán McNamara
Change-Id: I7d93f9ef4a0821ee3ab9526abd90b8aefe895ded
2014-12-11coverity#1257741 Uninitialized scalar fieldCaolán McNamara
Change-Id: I8b977766e694ab449d612322138f5baa23fef29b
2014-12-11unit test for matrix comparison error propagation, fdo#87237Eike Rathke
Change-Id: Id02f169b111945673a16d0c852940c805aa89319
2014-12-11resolved fdo#87237 propagate error values through matrix comparisonsEike Rathke
Apparently introduced with 8e8b43a03e77dd251876c1de0ac06eeeb09192cd the comparison results were stored as boolean values, effectively discarding any infinite double values and error values encoded as NaN values. Change-Id: I1fb6f46894a0bee02a37e28b7e6cc84f8c051f28
2014-12-11coverity#703983 Unchecked return valueCaolán McNamara
Change-Id: I83fe85a50e6e98da02a7c46a9e0c07a043244d56
2014-12-11document 704272 Logically dead codeCaolán McNamara
Change-Id: Ib0b2225bc0b09c910c6f47c36c3e118b8c999df8
2014-12-11Remove resizable:False property from dialogs containing GtkEntry.Jan Holesovsky
As agreed with Adolfo (and others) at the Design hangout on 2014-12-10. Change-Id: Ibe0e8075566523e746866b9d2c15c348c345d2df
2014-12-11fdo#81286 : Instant updates in SUM/AVERAGE in status barDeena Francis
Change-Id: I86ec7c73090b93cf080ced2bd5e24d98e2b3ac0e
2014-12-11java: reduce visibility of fields and methodsNoel Grandin
found by PMD Change-Id: Id6737916b68ccbdbdeec5d314747a38410923ac6 Reviewed-on: https://gerrit.libreoffice.org/13409 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2014-12-10Deteremine the script type of source cell during paste replication.Kohei Yoshida
Doing this ahead of time eliminates the need to update script types of all replicated cells after the paste. This makes significant performance impact. Change-Id: Ic4f7d7b2fe152bd5640ddb1dae01cc2ed757657e
2014-12-11fdo#86215 pool new ScPatternAttr if source and destination are different docsEike Rathke
Change-Id: Icdb68af83a0b208f9a427ee61ae18020c8835a41
2014-12-10Typo: postion(s)=>position(s)Julien Nabet
Change-Id: Id2957f1cb68fc4b2fef9966abeb6745b548bcb75
2014-12-10paste from system from the top left of selectionDavid Tardon
For example, 1. echo -e "5,6\n7,8" 2. select the lines and copy them to clipboard 3. select an area in Calc, starting from bottom right 4. paste 5. select comma as data separator in the CSV import dialog I think most people would expect the data to appear in the selected area, but currently it would be inserted starting from active cell (which is the bottom right cell of the selection). Change-Id: Ief0e05deda18928a832dca2a261f8493ac9a03a9 Reviewed-on: https://gerrit.libreoffice.org/13410 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2014-12-10Globally disable threading for these for now.Kohei Yoshida
It doesn't win us much performance-wise (as it turned out), and causes weird crashers with large documents. Change-Id: I0566ce850b8f6656e6f9821c653b7a825a7874a3
2014-12-10be a bit more relaxed about that conditionMarkus Mohrhard
Change-Id: I794042c78723a0d40de8054084b27805cba6cfee
2014-12-10Make some dialogs resizable again.Jan Holesovsky
As discussed in http://listarchives.libreoffice.org/global/design/msg06845.html Change-Id: I9e9ada1b2bee6023ee7f79d28cf4de2765c5daa0
2014-12-10java: remove some comment noiseNoel Grandin
Change-Id: I4d15a0e606f468346bc5d2f43af2e14bcc758e13 Reviewed-on: https://gerrit.libreoffice.org/13405 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-12-09Revert "move RID_APPTITLE to desktop where its used"Caolán McNamara
this seems to have been re-committed as a conflict fixup, but it had been removed on purpose by commit 8c041824b67caa53d3f7f96803b7a69ced6614b5 Author: Caolán McNamara <caolanm@redhat.com> Date: Tue Nov 25 13:39:28 2014 +0000 all these ids and their associated resources were unnecessary Change-Id: I3f538668c9c5f1727b8cf49ab72fd5879e12f156 This reverts commit f43162b09c4876cec317b83e2d6c1afbd8576001. Change-Id: I57514dcc9cd48c841620d4cb20d049ea8c55254e
2014-12-09Resolves: fdo#86786 take of a copy of the MarkDataCaolán McNamara
so macros that trigger on changed data don't change invalidate interators into them behind our back Change-Id: Ib7e626b4ec3eea3bd0b1f57f17280a008bb4060e
2014-12-09remove now unused BROADCAST_ALL_POSITIONS caseEike Rathke
Change-Id: I4e6b362f31d93964567fe9ca394cd96568981746
2014-12-09WaE: set but not usedCaolán McNamara
since commit 19b7dc3b1ef8b77d509f46dca96fb0f797abe38c Date: Wed Nov 5 09:08:02 2014 +0000 changed timers to idles I'll try and keep the apparent original code intent to have a shorter time out if there is known pending work, but that there is much difference between VCL_IDLE_PRIORITY_LOW of 100 and VCL_IDLE_PRIORITY_LOWEST of 400 in comparison with the original SC_IDLE_MAX of 3000 Change-Id: If87743e24380b6840c67580f246a5e698b6f31a1
2014-12-09coverity#1242895 Untrusted loop boundCaolán McNamara
Change-Id: I057f81785972106b10c8c5a7992b2b1ec1dc145e
2014-12-09coverity#1242793 Untrusted value as argumentCaolán McNamara
and coverity#1242945 Untrusted value as argument Change-Id: Ie35f7ca0967366a7854bfc26085f84ce7624559f
2014-12-09No need to use a macro here.Jan Holesovsky
2014-12-09introduce BroadcastBroadcasters() to speedup BroadcastCells()Eike Rathke
Iterating over a range and attempting to get a broadcaster for each cell position is a performance bottle neck. Take advantage of the column's existing maBroadcasters structure instead. Change-Id: I5467a64ee3c0b5f430be1f0c4b940d3f71874827
2014-12-09add a comment about side effects and whether we want them or notEike Rathke
Change-Id: I9cebe8f7979fd0b502fb23e7048b24a5b9ceb5d4
2014-12-09fdo#82312 - Excel chart has a wrong sizeNoel Grandin
bug introduced in commit 0c7f35277575fee8594737f5b2842dfac2c6d04f "remove SvStream::operator>> methods" Change-Id: I72a1c05b3a4a3f3a250055775eb2d35b3114406d Reviewed-on: https://gerrit.libreoffice.org/13151 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2014-12-09fdo#73695 prevent use of invalidated iterator due to re-entranceEike Rathke
... through the UNO backdoor.. While charts are updated there can be chart data listeners in BASIC that in turn modify things such that charts are inserted/removed from the listener chain, invalidating the iterator. If that happens break and bail out instead of crashing. Not ideal, but.. Change-Id: Iefb33d3a96d79caed0ee4e19b73e8f811ef3d937
2014-12-09fdo#39468 Translate German Comments - sc/source/core/data/documen2.cxxChristian M. Heller
Change-Id: I9a426f40f8cdce1f1ebe207dd9ada8154d8fde46 Reviewed-on: https://gerrit.libreoffice.org/12195 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> merge fixes Change-Id: Ibca73c7099739790e1659a24841f168a2c06b71e
2014-12-09changed timers to idleJennifer Liebel
Change-Id: I5846940cc45781f4a0264047107dbb568604d543
2014-12-09changed timers to idlesJennifer Liebel
Change-Id: Iebde351b3bfca907a7730b7af379efb040cbeae2
2014-12-09We now only need one bit of information hereCaolán McNamara
whether there *is* an id, or whether there is not an id. An id of 0 seems to be used as a flag that an interface is some sort of superclass which can be subclassed by something else and have its toolbars etc reused. Convert this to a bool so we don't need an a resource id for each one and just drop the third arg for the normal "final" case and use a different define for the inheritable case Change-Id: I98380f03d73d57bf8cba02d339097e384518abaa
2014-12-09move RID_APPTITLE to desktop where its usedCaolán McNamara
rename the other ones and remove the unused ones Change-Id: I0e636cd5d1799e0f9cb815a4bfa20b16039ecb3f
2014-12-09removed unused timeout definesTobias Madl
Change-Id: I1ebada7b06657e0ac294e60bca5d6dd5b45e9d04
generated by cgit (git 2.34.1) at 2025-01-26 23:42:51 +0000