summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)Author
2016-09-24we shouldn't need explicit lt_rtl_OUString, etc things anymoreCaolán McNamara
Change-Id: Ibeec3fcc353e07e61fb2c838b318e0a04081ce2c
2016-09-23convert formula error codes to scoped enumNoel Grandin
Change-Id: I5ff214bf1ec9031e30344bc125bc99916fd11bfb Reviewed-on: https://gerrit.libreoffice.org/28897 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-09-23perf: eliminate SfxSimpleHint and move to SfxHint, tdf#87101 relatedEike Rathke
There were over 150 places in *::Notify() functions that did some dynamic_cast<SfxSimpleHint*> of which ~98% were unnecessary because the base class SfxHint passed was an SfxSimpleHint anyway. dynamic_cast operations come with quite some cost, so avoid if possible. Specifically for ScFormulaCell::Notify() that created a bottleneck in scenarios where cells were notified that already handled a previous notification. In mass operations doing the dynamic_cast before it could be decided whether having to act on it or not this made 2/3 of all time spent in the Notify() call. To get rid of that rename/move SfxSimpleHint to SfxHint and let classes derive from SfxHint instead of SfxSimpleHint. This comes only with a slight cost that an additional sal_uInt32 is transported in such hints, initialized to 0, but this is neglectable compared to the huge gain. For the rare cases where a Notify() actually expects both, an SfxHint (formerly SfxSimpleHint) and a derived hint, this changed order of the dynamic_cast involved so the simple SfxHint::GetId() is handled last. Modules using such combinations can further optimize by treating the simple SfxHint::GetId() first once verified that none of the other derived hints use an ID not equal to zero respectively none of the ID values the simple hint uses. Change-Id: I9fcf723e3a4487ceb92336189d23a62c344cf0ce Reviewed-on: https://gerrit.libreoffice.org/29205 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-09-23tdf#102216: move row overflow check after EoF check (CSV import)Aron Budea
With the check in the original place, importing exactly 1048576 rows gave a warning. Change-Id: Iae98c07f638168d8537436045423ae6274ef7f64 Reviewed-on: https://gerrit.libreoffice.org/29159 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-09-23Factor out common ScInterpreter::GetInt32() codeMaarten Bosmans
This might also be slightly more efficient because for GetInt32WithDefault() when the value is missing, the default value is not converted to and from double anymore. Change-Id: I0a234265273086824f749b04aba022dd5cef322f Reviewed-on: https://gerrit.libreoffice.org/29203 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2016-09-23cid#1373353 uninitialized membersMiklos Vajna
Change-Id: I88ae046866c616cc7de226e85eaab1a0e76eb59e
2016-09-22attempt to fix build, ScImportExport( ScDocument*, const OUString& )Eike Rathke
... is not unused but only in ifdef _WIN32 commit c4cd079b8f613084a99a83b95c3968b65cbd8900 Date: Thu Sep 22 15:08:42 2016 +0200 loplugin:unusedmethods in sc..vcl Change-Id: I36c8d57fddfffe8c99cf40ae514270f445388d08
2016-09-22loplugin:unusedmethods in sc..vclNoel Grandin
Change-Id: I70fcf95dfd3db05b4fd6e5cee37866f673d3afa8 Reviewed-on: https://gerrit.libreoffice.org/29183 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-22add GAMMA test caseZdeněk Crhonek
Change-Id: If8778c62ec7c88e036c86ea7cb1fb018c251235e Reviewed-on: https://gerrit.libreoffice.org/29147 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-09-22add VLOOKUP test caseZdeněk Crhonek
Change-Id: Ia185cbf7b72ffe014b0f2a3f99bf21c0a33cee06 Reviewed-on: https://gerrit.libreoffice.org/29153 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-09-22rename GetId() to GetTablesHintId() and GetIndexHintId()Eike Rathke
In preparation of moving SfxSimpleHint that has GetId() to SfxHint. Change-Id: If781ba9578931d9543875ee288ce37c727bfba10
2016-09-22Notebookbar: separate .ui files settings for each moduleSzymon Kłos
* each module have own list of implementations * deleted placeholder .ui files from Calc and Impress Change-Id: Ib7d4cafbb332447e769ca753003d31e9f3025f0a Reviewed-on: https://gerrit.libreoffice.org/29143 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-09-22tdf#101894 Copying a single sheet with a chart on it garbles the chartNoel Grandin
..on the new sheet Bug introduced with commit 86e9ef21a06a9babefb778dfc3e02118d371d70d Author: Noel Grandin <noelgrandin@gmail.com> Date: Tue Mar 8 20:41:21 2016 +0200 sequence->vector in sc Change-Id: I7a6539005f42c7a7036c60b12a9ff2f77f71ba6b
2016-09-22sc-perf: tdf#87101 add bulk scope for BroadcastRecalcOnRefMove() callsEike Rathke
Bulk scope prevents repeated broadcast/notify/track cycles of identical areas during mass broadcasts. Brings insertion time of tdf#87101 bugdoc from 3min30 down to 2min30 Change-Id: I360fd52b622a8a327cdede47ed398260b7e8b4f6
2016-09-22tdf#87101 Revert "fdo#83067 also volatile cells need to listen to all refe"...Eike Rathke
This reverts commit 0792aef9010007d5738723d8930990028bef2f9e. It created a bottleneck with massive use of OFFSET() functions mixed with other references, see tdf#87101 bugdoc. Will have to come up with a different approach to solve the "broadcast cell move" problem. Additionally, the unit test for tdf#83067 and the original problem still work with the reverted change, so we seem to generally have fixed something else in the meantime.. Conflicts: sc/source/core/data/formulacell.cxx Change-Id: Ida2e26398f99ff5878d43ffb46035bc4441dfff6
2016-09-21reorg of code can drop the special msvc warnings handlingCaolán McNamara
no logic change intended Change-Id: I84f7e3fd60a49f7c3b898c7dda37a92701a8ef68 Reviewed-on: https://gerrit.libreoffice.org/29151 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-09-21ASan/UBSan reports read of uninitialized bHasStandardStylesStephan Bergmann
...during CppunitTest_sc_subsequent_filters_test, where 7911f21cd3e0deb6c1966dc97b8a5e5cf994d3af "Add to a method to check if stlpool already has standard styles" apparently forgot to initialize it Change-Id: I66c6ccb8f3a3ec38ed326ccf35f3a82711c4ef6f
2016-09-21add SHEET test caseZdeněk Crhonek
Change-Id: I0b968bef2e9dba00879868e7b63865ac5531ba7c Reviewed-on: https://gerrit.libreoffice.org/29103 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-09-21convert SfxItemPresentation to scoped enumNoel Grandin
Change-Id: Ibf605706a9f804ab509ac4f92f5f88fcf3daebc1 Reviewed-on: https://gerrit.libreoffice.org/29131 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-20sc-perf: tdf#79023 do not call SvNumberFormatter also for numbers in OOXMLEike Rathke
Change-Id: Ib565687bff2205da0213f6d523dd2bc42c96ad47
2016-09-20sc-perf: tdf#79023 for ODFF do not call SvNumberFormatter to determine numericEike Rathke
Speedup of this particular function and callees by factor 33 ... 1000 calls for =12345.6789 and =123.456 alternating: Before: Ir Irpc Callee 9859177 9859 ScCompiler::IsValue 6246858 6246 SvNumberFormatter::IsNumberFormat 3496261 3496 SvNumberFormatter::GetStandardIndex After: 298000 298 ScCompiler::IsValue 248000 248 rtl_math_uStringToDouble Change-Id: I36eac8c5fe1b1cbf34dfb480c9e7ca6607769364
2016-09-21Improve warnings in pivot table codeTamás Zolnai
Change-Id: I5230bcb4abbc720cc2177e26f8fa5b8969039624
2016-09-20sc draw: emit LOK_CALLBACK_GRAPHIC_VIEW_SELECTION when view is createdHenry Castro
In multiple view environment, when a new view is created ensure to notify other views graphic view selections. Change-Id: If75f9525af6e851e096b6d273957b94882c441cf Reviewed-on: https://gerrit.libreoffice.org/29094 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-09-20Fix "ubsan: 9 is not a valid value for type ´SvxNumType´" once againStephan Bergmann
...after 1658bd231bc662504a072097dc614c29fe2e116d "loplugin:unusedenumvalues" broke it again after 992fba98f4d0b6ff0d20c15b0ddff09edd37847c "ubsan: 9 is not a valid value for type ´SvxNumType´" had fixed it the last time. This time, acknowledge that SvxNumType can apparently take on rather arbitrary sal_Int16 values from the css::style::NumberingTypes constants, and make it an alias for sal_Int16 (whether or not keeping such a trivial alias is good or bad overall). Or is the bug elsewhere, and values of type SvxNumType should really only take on the restricted set of values originally encoded by the enum? At least the below UBSan backtrace (from CppunitTest_sw_rtfexport) suggests otherwise, but then again there's also an SvxExtNumType enum (include/editeng/svxenum.hxx), encompassing more parts of css::style::NumberingTypes. Oh, my. > svx/source/items/pageitem.cxx:49:25: runtime error: load of value 9, which is not a valid value for type 'SvxNumType' > #0 0x2aafdaebe669 in SvxPageItem::SvxPageItem(SvxPageItem const&) svx/source/items/pageitem.cxx:49:25 > #1 0x2aafdaebf194 in SvxPageItem::Clone(SfxItemPool*) const svx/source/items/pageitem.cxx:59:16 > #2 0x2aaf7fab9b7c in SfxItemPool::Put(SfxPoolItem const&, unsigned short) svl/source/items/itempool.cxx:632:40 > #3 0x2aaf7fc4794a in SfxItemSet::Put(SfxPoolItem const&, unsigned short) svl/source/items/itemset.cxx:467:56 > #4 0x2aaf7fb96635 in SfxItemSet::Put(SfxPoolItem const&) include/svl/itemset.hxx:131:42 > #5 0x2aaf7fb89539 in SfxItemPropertySet::setPropertyValue(SfxItemPropertySimpleEntry const&, com::sun::star::uno::Any const&, SfxItemSet&) const svl/source/items/itemprop.cxx:256:14 > #6 0x2aaf9ef1a5d4 in void SwXStyle::SetPropertyValue<(unsigned short)1>(SfxItemPropertySimpleEntry const&, SfxItemPropertySet const&, com::sun::star::uno::Any const&, SwStyleBase_Impl&) sw/source/core/unocore/unostyle.cxx:1596:14 > #7 0x2aaf9ef3c72f in SwXStyle::SetStyleProperty(SfxItemPropertySimpleEntry const&, SfxItemPropertySet const&, com::sun::star::uno::Any const&, SwStyleBase_Impl&) sw/source/core/unocore/unostyle.cxx:2013:9 > #8 0x2aaf9ef8103d in SwXPageStyle::SetPropertyValues_Impl(com::sun::star::uno::Sequence<rtl::OUString> const&, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&) sw/source/core/unocore/unostyle.cxx:3025:17 > #9 0x2aaf9ef821ee in SwXPageStyle::setPropertyValues(com::sun::star::uno::Sequence<rtl::OUString> const&, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&) sw/source/core/unocore/unostyle.cxx:3053:9 > #10 0x2ab00730d08b in writerfilter::dmapper::SectionPropertyMap::ApplyProperties_(com::sun::star::uno::Reference<com::sun::star::beans::XPropertySet> const&) writerfilter/source/dmapper/PropertyMap.cxx:1489:24 > #11 0x2ab00731cede in writerfilter::dmapper::SectionPropertyMap::CloseSectionGroup(writerfilter::dmapper::DomainMapper_Impl&) writerfilter/source/dmapper/PropertyMap.cxx:1331:13 > #12 0x2ab006b9ede2 in writerfilter::dmapper::DomainMapper::lcl_endSectionGroup() writerfilter/source/dmapper/DomainMapper.cxx:2823:30 > #13 0x2ab0071db9f9 in writerfilter::LoggedStream::endSectionGroup() writerfilter/source/dmapper/LoggedResources.cxx:101:5 > #14 0x2ab006712a3b in writerfilter::rtftok::RTFDocumentImpl::sectBreak(bool) writerfilter/source/rtftok/rtfdocumentimpl.cxx:633:18 > #15 0x2ab0067a8c13 in writerfilter::rtftok::RTFDocumentImpl::popState() writerfilter/source/rtftok/rtfdocumentimpl.cxx:2789:13 > #16 0x2ab006a26134 in writerfilter::rtftok::RTFTokenizer::resolveParse() writerfilter/source/rtftok/rtftokenizer.cxx:105:33 > #17 0x2ab0067194f9 in writerfilter::rtftok::RTFDocumentImpl::resolve(writerfilter::Stream&) writerfilter/source/rtftok/rtfdocumentimpl.cxx:740:27 > #18 0x2ab0075ebae7 in RtfFilter::filter(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) writerfilter/source/filter/RtfFilter.cxx:147:20 > #19 0x2aafcf2873a5 in SfxObjectShell::ImportFrom(SfxMedium&, com::sun::star::uno::Reference<com::sun::star::text::XTextRange> const&) sfx2/source/doc/objstor.cxx:2261:30 > #20 0x2aafcf22d4d2 in SfxObjectShell::DoLoad(SfxMedium*) sfx2/source/doc/objstor.cxx:764:23 > #21 0x2aafcf4a4d09 in SfxBaseModel::load(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) sfx2/source/doc/sfxbasemodel.cxx:1841:36 > #22 0x2aafcfde31b3 in (anonymous namespace)::SfxFrameLoader_Impl::load(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, com::sun::star::uno::Reference<com::sun::star::frame::XFrame> const&) sfx2/source/view/frmload.cxx:698:28 > #23 0x2aaffef07028 in framework::LoadEnv::impl_loadContent() framework/source/loadenv/loadenv.cxx:1110:37 > #24 0x2aaffeeead5a in framework::LoadEnv::startLoading() framework/source/loadenv/loadenv.cxx:379:20 > #25 0x2aaffeee3919 in framework::LoadEnv::loadComponentFromURL(com::sun::star::uno::Reference<com::sun::star::frame::XComponentLoader> const&, com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&, rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) framework/source/loadenv/loadenv.cxx:165:14 > #26 0x2aafff10ddac in framework::Desktop::loadComponentFromURL(rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) framework/source/services/desktop.cxx:596:12 > #27 0x2aafff10e11a in non-virtual thunk to framework::Desktop::loadComponentFromURL(rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) framework/source/services/desktop.cxx:582:64 > #28 0x2aafab4c3938 in unotest::MacrosTest::loadFromDesktop(rtl::OUString const&, rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) unotest/source/cpp/macros_test.cxx:50:60 > #29 0x2aaf90aee900 in SwModelTestBase::loadURL(rtl::OUString const&, char const*) sw/qa/extras/inc/swmodeltestbase.hxx:621:23 > #30 0x2aaf90aed267 in SwModelTestBase::load(char const*, char const*) sw/qa/extras/inc/swmodeltestbase.hxx:610:16 > #31 0x2aaf90aec404 in SwModelTestBase::executeImportTest(char const*) sw/qa/extras/inc/swmodeltestbase.hxx:222:13 > #32 0x2aaf90cf4d31 in testTdf65642::Import() sw/qa/extras/rtfexport/rtfexport.cxx:1013:1 > #33 0x2aaf90cf62af in CppUnit::TestCaller<testTdf65642>::runTest() workdir/UnpackedTarball/cppunit/include/cppunit/TestCaller.h:166:6 > #34 0x2aaf4ee5d7dd in CppUnit::TestCaseMethodFunctor::operator()() const workdir/UnpackedTarball/cppunit/src/cppunit/TestCase.cpp:32:5 > #35 0x2aaf680c4cd6 in (anonymous namespace)::Protector::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) test/source/vclbootstrapprotector.cxx:36:14 > #36 0x2aaf4ee17a87 in CppUnit::ProtectorChain::ProtectFunctor::operator()() const workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20:25 > #37 0x2aaf5ea4a8a6 in (anonymous namespace)::Prot::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) unotest/source/cpp/unobootstrapprotector/unobootstrapprotector.cxx:89:12 > #38 0x2aaf4ee17a87 in CppUnit::ProtectorChain::ProtectFunctor::operator()() const workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20:25 > #39 0x2aaf5abd5ef4 in (anonymous namespace)::Prot::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) unotest/source/cpp/unoexceptionprotector/unoexceptionprotector.cxx:65:16 > #40 0x2aaf4ee17a87 in CppUnit::ProtectorChain::ProtectFunctor::operator()() const workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20:25 > #41 0x2aaf4ed8c2ef in CppUnit::DefaultProtector::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) workdir/UnpackedTarball/cppunit/src/cppunit/DefaultProtector.cpp:15:12 > #42 0x2aaf4ee17a87 in CppUnit::ProtectorChain::ProtectFunctor::operator()() const workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20:25 > #43 0x2aaf4ee14101 in CppUnit::ProtectorChain::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:77:18 > #44 0x2aaf4eede065 in CppUnit::TestResult::protect(CppUnit::Functor const&, CppUnit::Test*, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) workdir/UnpackedTarball/cppunit/src/cppunit/TestResult.cpp:181:28 > #45 0x2aaf4ee5a929 in CppUnit::TestCase::run(CppUnit::TestResult*) workdir/UnpackedTarball/cppunit/src/cppunit/TestCase.cpp:91:13 > #46 0x2aaf4ee60ad3 in CppUnit::TestComposite::doRunChildTests(CppUnit::TestResult*) workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:64:30 > #47 0x2aaf4ee5fa3d in CppUnit::TestComposite::run(CppUnit::TestResult*) workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:23:3 > #48 0x2aaf4ee60ad3 in CppUnit::TestComposite::doRunChildTests(CppUnit::TestResult*) workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:64:30 > #49 0x2aaf4ee5fa3d in CppUnit::TestComposite::run(CppUnit::TestResult*) workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:23:3 > #50 0x2aaf4ef1eeb6 in CppUnit::TestRunner::WrappingSuite::run(CppUnit::TestResult*) workdir/UnpackedTarball/cppunit/src/cppunit/TestRunner.cpp:47:27 > #51 0x2aaf4eedbe79 in CppUnit::TestResult::runTest(CppUnit::Test*) workdir/UnpackedTarball/cppunit/src/cppunit/TestResult.cpp:148:9 > #52 0x2aaf4ef20440 in CppUnit::TestRunner::run(CppUnit::TestResult&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) workdir/UnpackedTarball/cppunit/src/cppunit/TestRunner.cpp:96:14 > #53 0x52b642 in (anonymous namespace)::ProtectedFixtureFunctor::run() const sal/cppunittester/cppunittester.cxx:305:20 > #54 0x52604d in sal_main() sal/cppunittester/cppunittester.cxx:455:20 > #55 0x524192 in main sal/cppunittester/cppunittester.cxx:362:1 > #56 0x2aaf50b3c730 in __libc_start_main (/lib64/libc.so.6+0x20730) > #57 0x437658 in _start (workdir/LinkTarget/Executable/cppunittester+0x437658) Change-Id: Id170860cbff9f4cae5c87cb5cfc70ffe3bc8c9c5
2016-09-20loplugin:unusedfieldsNoel Grandin
Change-Id: I852e98b16fdcb88b04e39d11e3101d502c918c24 Reviewed-on: https://gerrit.libreoffice.org/29078 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-20Related cid#1371287: Improve code to not depend on missing move assignmentStephan Bergmann
Change-Id: I0397812ed7b728e03199d64929c42292fc9b1502
2016-09-20adapt aMsgItemInfo to 5b8c22379Markus Mohrhard
Change-Id: If5fd822f3f90b204d2661cf7b4446cb925ee6f3b
2016-09-19try to generate more excel compliant files, tdf#41722Markus Mohrhard
§18.3.1.10 says for the operator attribute: "The operator in a "cell value is" conditional formatting rule. This attribute is ignored if type is not equal to cellIs" but checking §18.18.15 there are at least 4 attribute values that are not related to cellIs. I have added them now but need to test that this really helps. Change-Id: Id15efc7e0148b4e3b54404d1ffd911adc56b11ec
2016-09-19in GetInt...() check !isFinite() instead of isNan()Eike Rathke
... and propagate coded double error instead of setting errIllegalArgument. Change-Id: I28456c3b0320181a80fe255e875a0bd78216c279
2016-09-19Resolves: tdf#100409 do not return coded double error for single matrix valueEike Rathke
Change-Id: I94477bf64ee7972e9822921a8a15d935cb01e53b
2016-09-19tdf#100393, handle copying one cell to multiple cols with cond formatMarkus Mohrhard
The same fix has been applied for rows already. Change-Id: I77300680a657fb874d07641fbae928eb6c210acd
2016-09-19tdf#96453, tdf#100793 rework transfer of data between cond format dlgsMarkus Mohrhard
The xml based transfer of information was a bad idea from the start. It can obviously not transport the temporary conditional format information from the manager dialog. Therefore the whole handling here was completely broken and deleted formats came back, changed formats were not saved and added formats got applied directly to the document. Now the document fornat list and the one from the manager are indepedent again and as long as the manager has not been closed with ok nothing is written to the document. Change-Id: I9802be11cd15c2d2d877e55c91d836735fe0e0ff Reviewed-on: https://gerrit.libreoffice.org/28995 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-09-19add BETA.DIST test caseZdeněk Crhonek
Change-Id: I514e06585fac3c16a40318f8d51d389fd13c9c5a Reviewed-on: https://gerrit.libreoffice.org/28997 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-09-19add FTEST test caseZdeněk Crhonek
Change-Id: Icae9ed5dee0f9b230e4629b47d9a3eaff0328534 Reviewed-on: https://gerrit.libreoffice.org/28988 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-09-19Use localized name for pivot groups created via APITamás Zolnai
Same string used in ScDBFunc::GroupDataPilot() method. Change-Id: I5b4d1b32af039caee76121fc534418a05a0882e0
2016-09-18extract the code to get the max key id to own methodMarkus Mohrhard
Change-Id: I56bd53e03a7ea97b15895528ec02a09a73d877b6 Reviewed-on: https://gerrit.libreoffice.org/28994 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-09-18fix indentationMarkus Mohrhard
Change-Id: Iab226c47b63253bc8d0876af861e3e4731ff1ce2 Reviewed-on: https://gerrit.libreoffice.org/28993 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-09-18make sure that we are not trying to load the filter lib in ucalcMarkus Mohrhard
This casues crashes on exit as the ucalc lib loads the filter lib which is linked against the sclo lib. The sclo lib is statically linked into the ucalc code so that this causes the symbols to be two times in the program. Change-Id: I93e5a9b4dffa7c4b797ffef91b91f5f29f65348e
2016-09-18place the calc default style file in the share folderMarkus Mohrhard
Change-Id: I1b8bfee1abf82c5a55cbfc5c1674b115cdfe63b8
2016-09-18Enable cell alignment test in orcus interfaceJaskaran Singh
Change-Id: I1078e29d6fa0c51a4457b43806340eaf10096a92
2016-09-18Add test for cell align in orcus interface(currently disabled)Jaskaran Singh
Change-Id: Icbb139cc520e4afd84986d245fab5f157431fc4e
2016-09-18Correct initial values for cell align in orcus interfaceJaskaran Singh
Change-Id: I54b7def1d1d1a5b518abc6774495dd371a928ef3
2016-09-18Add test for strikeout in orcus interfaceJaskaran Singh
Change-Id: I72e917934919ddf5cc2cdd188a692c3fba94433e
2016-09-18Add test for font in orcus interfaceJaskaran Singh
Change-Id: Ibe2b5ef344a8f1ca27d3b59be9ac53e2c6f5b3b0
2016-09-18Add test for cell protection in orcus interfaceJaskaran Singh
Change-Id: I952b5897bf3f728d103c43d93cadeffb92d1c3a9
2016-09-18Add diagonal border test for orcus interfaceJaskaran Singh
Change-Id: I762e3b5f634b96664a3687e89b1a117895265bee
2016-09-18Fix a bug in border import in orcus interfaceJaskaran Singh
Change-Id: Ic058787b1779f7731c0fe60d73b221011abe2b6c
2016-09-18Fix a typo in border style import in orcus interfaceJaskaran Singh
Change-Id: Ib8dcf0cb031ed39987b14706026f658bbea0a080
2016-09-18Initialize border attributes in orcus interfaceJaskaran Singh
Change-Id: I99994147830e96bea07f52fc6f2575f05cb0a40f
2016-09-18Disable printing default protection in imported stylesJaskaran Singh
Change-Id: Iba85a8a401542496f2313af576344d8ffdf768fe
generated by cgit (git 2.34.1) at 2025-01-27 12:18:14 +0000