summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)Author
2021-04-07ScDocShell::GetActiveDialogParent instead of Application::GetDefDialogParentCaolán McNamara
which is more likely to be the relevant calc window Change-Id: I7c939c42752e103494a1df7154b3318643d5206c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113705 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-07tdf#141467 xmloff,sc,sw: ODF export: reorder flys' ZOrder/z-index harderMichael Stahl
Also keep the control layer distinct from the foreground, as a follow-up to tdf#133487. Try to improve the detection of already sorted indexes a bit to avoid unnecessary sorting. Hilariously the test docs require adding 3 additional items to the extension schema. Change-Id: I629d5b09294f679717677b9d89537d905ac4c404 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113696 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-04-07rtl::Static -> function local staticNoel Grandin
Change-Id: I2071c27bdf074403ec24e67f9278ac27f9491303 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113698 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-07lok: draw bgcolor lines for covering client grid...Dennis Francis
... that are over merged cells area. This is needed as client has no information about merged cells. Change-Id: I625d64cc3abd0ee1e60a8af9469a152286f25fd0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113145 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> (cherry picked from commit e3fa896aa14c03165190f0fef304ff0e8074d619) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113632 Tested-by: Jenkins Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
2021-04-07Related: tdf#128334 Make VBA Range getFormula(R1C1) work not only by accidentEike Rathke
i.e. if document native grammar was very similar to the API grammar (English UI function names, English locale and separators, address convention). Also alloc and init second string and conversion only if necessary. These Formula and FormulaR1C1 properties still behave like FormulaLocal and FormulaR1C1Local, which is wrong, see https://bugs.documentfoundation.org/show_bug.cgi?id=128334#c12 Change-Id: I589b36c2cd51d5bbba767a309ccf61bd051928a4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113711 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2021-04-07Resolves: tdf#128334 Reset mnCurrentSheetEndPos, mnCurrentSheetTab in all casesEike Rathke
Encountered for a single decimal separator not being a value either, but could be for any condition within IsReference() returning false up to the IsSingleReference() call. Change-Id: I6222adf2a2d06904001175da8798b2ba9fdef99c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113697 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2021-04-06remove Application::GetDefDialogParent call in editengCaolán McNamara
and pass in an explicit parent to use Change-Id: I1aa768ec5ac13b2097b78499f964a3590a0ac14e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113695 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-06ExecuteSpellPopup never called with a null spelling callbackCaolán McNamara
Change-Id: Id03001541ccfd8503a7b8181598bad9811542b4e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113694 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-06improve scopingCaolán McNamara
Change-Id: Ifb34ca678e019ded44af98b18a72f81206168b8f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113672 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-06skip intermediate vcl::WindowCaolán McNamara
Change-Id: I2eefba4a61455d39ec3411a0c3e74d0f09d59f38 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113670 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-06block is protected by pActiveViewSh != nullptrCaolán McNamara
so pActiveViewSh cannot be null within it Change-Id: I6db768bc78e0c3f097c6f97b5a7cfbe848ccbb8a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113669 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-06skip intermediate vcl::WindowCaolán McNamara
Change-Id: Iabf0e476d1f4be422e71feefb98145d57abc908d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113654 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-06expand used-once ScCellShell::GetFrameWin methodCaolán McNamara
Change-Id: Id6b9098a9c9cd26dfbdf6bdc418a02b744ff2ab4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113653 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-06cid#1474130 silence Untrusted loop boundCaolán McNamara
Change-Id: I62c8bba9666bcad2513d465063a0d2ec6e72119e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113656 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-05cid#1474256 silence Untrusted loop boundCaolán McNamara
Change-Id: Ibcd59331f16f348209e9b043694cd721a94210c4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113575 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-05Use std algorithms hereMike Kaganski
Change-Id: Ib7bb92cca1f52067f9030b6c6fdc088409ca10ef Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113601 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-04-02ofz: Segv on unknown addressCaolán McNamara
Change-Id: I6c69375a89781fc0b87230203335c861efb562f9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113518 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-02tdf#139786 partial revert tdf#106181 XLSX export: output form controlsJustin Luth
Not every export is going to be to OOXML format, so don't just set ooxmlexport to true and remove the "if" clause (especially when leaving the comment that this is for DOCX only). This is a partial revert to 7.1 (and backported to 6.4.5) commit 577dd32b1c4eb0a4cff574fbabca987cb52b831b. Change-Id: If7ea32a236715ec779cac302773c4c9da19865a0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113399 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2021-04-02Simplify some static variable initializationsMike Kaganski
Change-Id: I6cdd44aa66b9597ccc51fc3fd69b57485ccb3230 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113515 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-04-02Fix typoAndrea Gelmini
Change-Id: I4e67b2f5380b699cd63d15367f4401e6cb6ca135 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113211 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-04-02vcl: remove GetBitCount and GetColorCount from Bitmap{Ex}Tomaž Vajngerl
We can cast the PixelFormat enum to int for the same information and we can use the enum to reduce ambiguity when possible. Change-Id: I6ea648139465568cdeb12e5f5f75c7b609365bf4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113188 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-04-02Work around assert() in circular reference within group calc, tdf#141146Eike Rathke
Triggered by crash test loading document of wget 'https://bz.apache.org/ooo/attachment.cgi?id=71756' -O ooo114587-1.ods after commit 042dbf83122b14fd1dd32705c8f8b7d65c22f21b CommitDate: Thu Mar 25 16:31:29 2021 +0100 Resolves: tdf#141146 Fix LOOKUP in array with result scalar / single reference Though could happen any time whenever a shared formula group calc attempts to obtain a result from an already running cell. Change-Id: Id668b31a8d81389c593c6fd2191fd444efcdb70f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113494 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2021-04-01cid#1473732 Untrusted loop boundCaolán McNamara
and cid#1474044 Untrusted loop bound Change-Id: If30dc454d60adca11fd1a53ecf472555e328bd42 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113441 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-31cid#1242892 silence Untrusted loop boundCaolán McNamara
Change-Id: If7d1106e8cc5a5f5767df8ae6bfb6b1bfdb28f82 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113401 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-31Related: tdf#137577 Update Name Box range name list on sheet renameEike Rathke
... for sheet-local names that include the sheet name. Introduce SfxHintId::ScTablesRenamed for this as the existing ScTablesChanged is fired quite too often. Change-Id: I94c3479bba4d4cc8b75905e3fa4f35d9a8737870 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113391 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2021-03-30Related: tdf#137577 Be able to select a global named range from Name BoxEike Rathke
... if an identical sheet-local name exists. Change-Id: I6d92a7ed93e81da64f60c26fd81eb6775582b053 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113384 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2021-03-30ScDocument::GetRangeAtBlock() name is always passed, so use referenceEike Rathke
Change-Id: I1dec40b6da2375b292ba4c9912c4736fcd7ca551 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113348 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2021-03-30Related: tdf#137577 Display (sheetname) with sheet-local names in Name BoxEike Rathke
... if current cell selection matches a sheet-local name, so it can be differentiated from an identically named global name. Which is already the case when listing and picking a name from the list. Made it necessary to adapt an UI test checking for Name Box content. Change-Id: Ia90b8961c3ae213cf7bb53f3b610a65805bba6b9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113330 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2021-03-30tdf#99913 XLSX import: set filtered flag for rowsTünde Tóth
hidden by AutoFilter to support copying the result of filtering. Unlike ODS and XLS, XLSX doesn't differentiates filtered and manually hidden rows, and without this fix, copy of the unupdated data of the loaded filtering contained the hidden rows, too. Change-Id: I390d1a84b9bf275f3d3782756553b2f236487758 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113040 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2021-03-30cid#1473732 Untrusted loop boundCaolán McNamara
Change-Id: I0d0585f8d379fc0586ee76527f96e50c92953d13 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113338 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-30Sheet names can contain parentheses and blanksEike Rathke
... so search for the very first occurrence of " (" and not the last, and also not any ")" but it has to be the last character in the Name Box UI representation of sheet-local scope names so check just that. Change-Id: I0b63688432f891ee779e3e32017def78b021e470 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113327 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2021-03-29tdf#141146: sc_ucalc: fix incorrect test nameXisco Fauli
Change-Id: Ifd66f27a8ce688064216c88b6228b8f7f8df1c6a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113322 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-03-29tdf#138646 - consider the document's address conventionAndreas Heinisch
When accessing a named range using getCellRangeByName, consider the document's address convention. Otherwise, an exception is raised, when the formula syntax is EXCEL R1C1 or EXCEL A1. Change-Id: I5df2546f1c3fd00ff30cb057dcf47f6bb01d501d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112602 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2021-03-29expand COp to its only useCaolán McNamara
Change-Id: Ic353adf44c7aa60cedc2c61e3814d3135e0d55ac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113310 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-29TEmptyRes is always doubleCaolán McNamara
Change-Id: Ie1d2ce048aecb98f16a407bd2e708b64db46aadd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113309 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-29TRet is always doubleCaolán McNamara
Change-Id: Id1cb4cb9f0a7725a2990efb174a4e9e66bac2435 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113308 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-29improve scopingCaolán McNamara
Change-Id: I579ab896f9694e95b10fac35263f9d13779c46e3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113305 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-29improve scopingCaolán McNamara
Change-Id: I4638f35b99803ed8b46ffbf9e396b3fed65790e1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113304 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-29cid#1473732 Untrusted loop boundCaolán McNamara
Change-Id: I92d10d08bbbb8b7bcf57ddf2a300893c139c8c3a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113303 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-29cid#1242796 Untrusted loop boundCaolán McNamara
Change-Id: I0ad070da424f7ce98a78104f017be26c411364a5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113302 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-29cid#1473817 Untrusted value as argumentCaolán McNamara
etc. Change-Id: Ie815b51b9c1d85a5c96adc3707b740b84f6a1096 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113301 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-29improve scopingCaolán McNamara
Change-Id: Ib41052e099defd691d2a864fb7da6390e3a49425 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113300 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-29tdf#36466 sc: update status bar at Select Visible RowsTünde Tóth
Using Edit->Select->Select Visible Rows (Columns) Only option, update status bar to show the selected rows (in the case of Autofilter), or nothing (no AutoFilter), instead of the outdated value with the not selected hidden rows (columns). Change-Id: Ib31ea1d0cc15e57f883f5492104da490391117a6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112676 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2021-03-29Fix typoAndrea Gelmini
Change-Id: I0b4fed7c631f0d2a3d988bc92f39986601c7e4b6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113258 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2021-03-28cid#1474024 Untrusted loop boundCaolán McNamara
Change-Id: Ib646c3e55358442d4d5490e0c20564b35c7fb7d7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113236 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-26cid#1474320 silence Untrusted allocation sizeCaolán McNamara
Change-Id: I919e7dad4f03e9c9b4edce1959717c344c6e6134 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113170 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-26cid#1242796 Untrusted loop boundCaolán McNamara
Change-Id: I04e5df04747b764d4bfe035662b07a450ae0e5c7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113168 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-26drop unused argumentCaolán McNamara
Change-Id: I4df204cd26046e7b767adf5b5e9ab568a4f8501c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113159 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-26loplugin:flattenNoel
Change-Id: Ib7a895fba66f8dc9b6501e61631c02694053b7fc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113157 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-03-26tdf#116216: sc_ucalc: Add unittestXisco Fauli
Change-Id: I07237a491e3018b1d54794ac8456ea0fce3ae07d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113153 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
generated by cgit (git 2.34.1) at 2025-03-10 04:01:56 +0000