Age | Commit message (Collapse) | Author |
|
Wrong offset and count constants caused properties' string array out-of-bounds
access.
|
|
The old way was that an error cell was evaulated as having a value of 0.
The error cell also showed up as blank in the popup. Using the error
string is much more intuitive (and some users apparently want this
behavior).
|
|
We were supported to convert XML chart data range representations
with a hard-coded ';' as the range union operators, but incorrectly
using UI configurable range separators. This caused charts with
series that consisted of multiple ranges to be imported correctly in
locales where the range separator (which re-uses the function argument
separator) was something other than ';'.
BTW I plan to remove this "always use Calc A1 syntax" restriction in
future versions.
|
|
documents open
During Paint() in ScMultiTextWnd::InitEditEngine(),
ScTabViewShell::GetActiveViewShell() may return a view shell that does not
correspond with the document to be repainted if another document was opened or
when switching between documents. Prevent creating an EditEngine with wrong
SfxItemPool.
|
|
This patch fixzex bug fdo43586, more room needed for localized strings in named range dialog.
|
|
Otherwise we would fail to import the cell contents of those documents
that don't include table styles at all. Some hand-crafted ods documents
don't provide table styles, which 3.4 imported just fine.
|
|
Some parameters don't work with external references, however, such
as PROTECT, PREFIX and WIDTH.
|
|
Otherwise that method will set #REF! to the cell when it sees the tab
index being -1. We don't use that index in that code, so it's safe to
do this.
|
|
Older releases stored a few function names not defined by ODFF, namely
EASTERSUNDAY instead of ORG.OPENOFFICE.EASTERSUNDAY, TDIST instead of
LEGACY.TDIST and B instead of BINOM.DIST.RANGE.
Since OOo/LibO 3.3 the proper function names can be read, additionally to the
"wrong" names. Now it's time to write the proper names and still accept the
incorrect ones.
Test cases are attached to AOOo issues:
ORG.OPENOFFICE.EASTERSUNDAY
https://issues.apache.org/ooo/show_bug.cgi?id=112882
LEGACY.TDIST and BINOM.DIST.RANGE
https://issues.apache.org/ooo/show_bug.cgi?id=110229
Note that the FALSE in A2 and A3 is a result of the string comparison of the
actual formula, that differs in separators (, vs ;) only.
|
|
This is also another unfortunate bug due to the logic change caused
by the DECLARE_LIST removal. There was one crasher due to out-of-bound
array access, plus one incorrect behavior concerning cell content
placement. Both are now fixed.
|
|
For now, only COL and ROW are supported. More on the way. Note that
we can't support all the information types that we do for internal
references.
|
|
|
|
gsoc input bar now (should) snuggly wrap the text when collapsed, if multilines exist then scrolling with the keys should be clean and no spill from upper or lower lines visible. Removed some strange ( pseudo padding ) apparently for taking into account the window border and reorganized the resize logic so the padding is added ( and commented why ) in just one place.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
Another unfortunate logic change introduced via DECLARE_LIST removal.
Reverting the logic to the original one.
|
|
Some places in the code assumed that if the stack is empty a null pointer is
returned by top() (or old Pop()), this doesn't work anymore with ::std::stack
that instead has undefined behavior in that case, so check !stack.empty()
first before accessing top.
|
|
For cell-anchored drawing objects. Failing to do so would result in
either one of
1) write error during file save,
2) drawing object disappearing upon reload, or
3) drawing object relocated to a wrong sheet, with wrong position
and size upon reload.
|
|
only for newly created documents
# HG changeset patch
# User Christian Lippka ORACLE <christian.lippka@oracle.com>
# Date 1299763312 -3600
# Node ID 6b1140cdac81a77836e5be80033f328a0956c94a
# Parent 8edc33ef50a3b6ebbc4e88d574b6b1ba57b1dbaa
impress210: #i117133# put new drawing layer fill and stroke styles in pool only for newly created documents
|
|
so that it can be used in templates in strict C++98.
C++11 allows local types (i.e. without linkage) to be used in templates.
|
|
Do the tempfile handling in SdrMediaObj, not in the window;
this has the advantage that it works even in the presence of clipboard
documents without SfxBaseModels and thus without storage (sc, sw).
The SdrMediaObj instances share ownership of a temp file.
|
|
Otherwise setting data area to e.g. the entire sheet, or even just
entire columns would freeze Calc as it tries to parse the entire data
range faithfully.
|
|
|
|
It's not very obvious from the code alone.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
These ref tokens are only read, not modified. Taking a const reference
is sufficient.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
This patch removes the option Large Handles everywhere and makes LibO use the larger 9px handles always.
|
|
|
|
share test between all services which share the implementation in
ScCellRangesBase
|
|
create one test suite per implementation class:
move xcellrangesquery into ScCellRangesBase
|