summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)Author
2016-12-13Calc tests - move statistical functions to new directoryZdeněk Crhonek
Change-Id: I38f9816a2d91eaa5825907a66ba99d98212b91ec Reviewed-on: https://gerrit.libreoffice.org/31958 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-12-13OSL_TRACE->SAL in avmedia..canvasNoel Grandin
Change-Id: Id9077ea29e7028c12f40abfd4c57756c863e3cd9
2016-12-13OSL_TRACE->SAL in sc..scriptingNoel Grandin
Change-Id: I389d8cb733a5ee24d3119a1ebac5a5b70daff04e Reviewed-on: https://gerrit.libreoffice.org/31900 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-12Calc function tests - move text function to new dirZdeněk Crhonek
Change-Id: I3a47c0e90e93050419326303c175cdc2adef6796 Reviewed-on: https://gerrit.libreoffice.org/31925 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-12-12tdf104532 handle constraints for NEGBINOM.DIST correctly.Winfried Donkers
Also changed variable names for easier understanding of their meaning. Change-Id: Iab558d7d1d9533f2a0c42e3d5f4acecead2e818e Reviewed-on: https://gerrit.libreoffice.org/31807 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-12-12loplugin:stringconstantTor Lillqvist
Change-Id: I5bf8adf86da9d2e9c53341cdbc94aba05557abfc
2016-12-12unwind RID_OUTLINEBITMAPS imagelistCaolán McNamara
Change-Id: I44a03f557d7a7aafeb17e5d662797203f975672f
2016-12-12manage OutlineBitmap imagelist directly in its owner userCaolán McNamara
Change-Id: I4437484192016db7ce72614ae07c5a7d1bd9ec5b
2016-12-12tdf#63593: revert 88f91adf266f19659014df22e09ce6c6761fb6f1Mike Kaganski
This patch caused a regression that on creation of a new sheet while there's an unfinished edit of a cell, by using "+" in bottom left corner, that edit is committed to newly created sheet instead of that in which it was performed. Also, fixing original problem (tdf#42432), it forced the pending edit on deleted page to go to an existing page, which could overwrite existing data without being noticed (dataloss). Reverting the patch does not reintroduce the original problem that it intended to fix (a crash) in master. Change-Id: I696a85ec9d08ebb3621ebdbce4d9f71eadcdb2c2 Reviewed-on: https://gerrit.libreoffice.org/31843 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-12-11Implement CSVDataProvider and perform some cleanup on itJaskaran Singh
Change-Id: Ic409bd4977fdf610294bd13b7ea83ef9a4c48667 Reviewed-on: https://gerrit.libreoffice.org/31750 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jaskaran singh <jvsg1303@gmail.com>
2016-12-10add NORM.DIST test caseZdeněk Crhonek
Change-Id: I6ee179f5a4418bd6d03694e26ff24b8e0264a795 Reviewed-on: https://gerrit.libreoffice.org/31828 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-12-10add NORM.INV test caseZdeněk Crhonek
Change-Id: Ic62fdcaf358031df87076373fedd3b2cf71943ba Reviewed-on: https://gerrit.libreoffice.org/31829 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-12-10Calc test case - move mathematical functions to new directoryZdeněk Crhonek
Change-Id: I0ca06b8d11b23d6a225026e8fd01622d4180201e Reviewed-on: https://gerrit.libreoffice.org/31831 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-12-10Calc tests - move spreadsheet tests to new directoryZdeněk Crhonek
Change-Id: Iae68359bb0e17412300db74ffdceed4341c5288e Reviewed-on: https://gerrit.libreoffice.org/31835 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-12-10add SUBSTITUTE test caseZdeněk Crhonek
Change-Id: I290710ee5242e33c4ce7b46a44068fcd54c245a8 Reviewed-on: https://gerrit.libreoffice.org/31840 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-12-10rename to RegisterDefinedStyleNames() to clarify, tdf#104097 follow-upEike Rathke
Change-Id: Iecb64ab1e25913180bcb53a133f9dd6777ffb17b
2016-12-09Resolves: tdf#104097 register reserved cell style names for auto stylesEike Rathke
SvXMLAutoStylePoolP_Impl re-starts with a clean XMLAutoStyleFamily::maReservedNameSet, so reserving the names in ScXMLExport::ExportStyles_() is not enough and needs to be redone in ScXMLExport::ExportAutoStyles_() In the bug scenario that lead to cell styles with duplicated names for different styles of which when reloading only the first was taken. Additionally, a style must be registered after SvXMLAutoStylePoolP::AddNamed() to prevent duplicated styles with different names. Change-Id: If3491eb89ab1741887d9a36ecf904a216fb1368e
2016-12-09fix indentationMarkus Mohrhard
Change-Id: I5a721b2b55c003c34e24d83b9b5e09a88dde684b
2016-12-09fix compile errorsMarkus Mohrhard
Change-Id: I840b28f419137d2ead44dc649a14d742055fb3b9
2016-12-09Add support classes for dataproviderJaskaran Singh
Change-Id: I9aa8c807714f32ba5896a9308f36fcc8ab462a3d Reviewed-on: https://gerrit.libreoffice.org/31749 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jaskaran singh <jvsg1303@gmail.com>
2016-12-08tdf#104446: there can only be 1 condition for SUMIFJulien Nabet
Change-Id: I10b1e3880e79794b7f748882606d5c4101811d75 Reviewed-on: https://gerrit.libreoffice.org/31739 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Winfried Donkers <winfrieddonkers@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2016-12-08convert SFX_HINT to scoped enumNoel Grandin
Notes (*) In SC, BULK_DATACHANGED was or'ed into the hint id. Replaced with a dynamic_cast check. (*) In SC, removed the hint id field from ScIndexHint, no point in storing the hint id twice (*) Fold the SfxStyleSheetHintId enum into the new SfxHintId enum, no point in storing two different hint ids (*) In some cases, multiple #define's used to map to the same SFX_HINT value (notably the SFX_HINT_USER* values). I made all of those separate values. Change-Id: I990e2fb587335ebc51c9005588c6a44f768d9de5 Reviewed-on: https://gerrit.libreoffice.org/31751 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-08Sigh, MSVC randomly doesn't like '= default' hereStephan Bergmann
Change-Id: I069838ac529335c7abc02d3a9f0deb6ff545f92a
2016-12-08Replace manual acquire/release calls with rtl::ReferenceStephan Bergmann
...which also removes the need for a user-declared ScHeaderFooterTextCursor copy ctor Change-Id: Ida4ad4b3aef0865b40535f1fbf220ce5c44f2d47
2016-12-08Avoid using uninitialized nCol, nRowStephan Bergmann
...when aIter.GetNext returned null; found by Valgrind'ing JunitTest_sc_unoapi_4 Change-Id: Ia94928f78d0512755ee6d788b0470dea34b2a9a7
2016-12-08sc-perf: avoid calling GetRowHeight() twice or thriceEike Rathke
It needs to be called once anyway so do it beforehand, but a second call for the previous row is only necessary if no other condition to add a row was met. A third call is superfluous. Change-Id: Id104cb608893f4d09a92733cf19342e3cb280dfd
2016-12-08sc-perf: call RowHidden() only once, tdf#98106 follow-upEike Rathke
Though it was only called twice if no other condition led to the row being added, but at least once anyway, so we can call it beforehand. Change-Id: Iff8dfa926b840d58b92ffec296febe4c2da8e5a9
2016-12-07sc-perf: possibly halve the iterations to find the most used XF indexEike Rathke
Iterate only 513 equally attributed cells instead of 1024, per row. This could be further enhanced if we remembered in advance in which column the last attribution is located and use empty/default for the rest, or use spans. Change-Id: Id6172bd6c350a92fda4f1b637e70ff4f19d59c5a
2016-12-07tdf#104434 tdf#104451 Revert "tdf#46738 Fix exporting .xlsx of coloured em"...Eike Rathke
This reverts commit 5239cefff56875c7bb45c046977f1724aace0cfb. That lead to including / looping through all formatted rows, which easily happens if an entire column is formatted. Also when printing it would print all formatted rows and printing a million empty coloured rows certainly is not desired, only one sheet of paper maybe. Which was the original intention of SC_VISATTR_STOP and as the name GetLastVisibleAttr() suggests the function is for visible attribution.
2016-12-07stab at the sick "units in character width of the standard font", tdf#101363Eike Rathke
Which gave problems in the unit test on tinderbox build machines, apparently because they don't have not even the resulting fallback font installed. Specifically here digit '1' was slightly wider (123) than digit '0' (122), which the import accounts for but the export didn't, so widths were divided by 122 instead of 123 hence resulted in 24.23 instead of 24, for example. Change-Id: If8a04383632de674ae2a15a79608661e434aeb54
2016-12-07Fix typo in comments: et -> edTakeshi Abe
Change-Id: I447c46cc3d66c7f482314626826dd708bf1c01c4
2016-12-07convert VCLEVENT constants to scoped enumNoel Grandin
Change-Id: Ic8ccb0a9715ec05182dacddab2c015b0de6a0fba Reviewed-on: https://gerrit.libreoffice.org/31675 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-06Revert "attempt to fix Linux-rpm_deb-x86_71-TDF tinderbox build for 5-2, ↵Eike Rathke
tdf#101363" This reverts commit 39aa5c2c653f36393416a6aadd6e599051bbfe7b. Turns out the cause is something completely different..
2016-12-06Revert "try a volatile"Eike Rathke
This reverts commit 8a460cfa1b1ce01c7a479ce2e7f21a92a2c50de3. Turns out the cause is something completely different..
2016-12-06Change Read/Write access to Scoped Read/Write accessMark Page
Change-Id: Idbe8e393b64f2a151e20c1851d7c14fa161acf97 Reviewed-on: https://gerrit.libreoffice.org/31635 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-06loplugin:unnecessaryoverrideStephan Bergmann
Change-Id: Iac074bd6f59d2fc890459b45801d0a6143c3eb9e
2016-12-06tdf#71409: Let's not crash the function wizard dialog.Kohei Yoshida
It's a long story, but here is a short summary: When the function wizard dialog launches, it uses an edit engine instance to process text input, and that edit engine instance comes from the input window (for whatever reason). And, we are supposed to get ScTextWnd::MakeDialogEditView() called to instantiate such edit engine instance for the function wizard dialog. My previous change, however, changed this and ScTextWnd::InitEditEngine() ended up getting called to instantiate the edit engine instance. These two functions create edit engine instances with different settings intended for different use cases... The crash we saw is just one manifestation of such differences. Change-Id: I7fd84c1b1eca2351b9ecc87e325c2fd3787369eb Reviewed-on: https://gerrit.libreoffice.org/31664 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2016-12-06try a volatileEike Rathke
Change-Id: Iadaeb1cdf8a73cac3308e82caa2e65db07ec0fc1
2016-12-06use IncCol() IncRow()Eike Rathke
Change-Id: Ibae425df118ad222db2740b51040d7a6c65b2aa6
2016-12-05attempt to fix Linux-rpm_deb-x86_71-TDF tinderbox build for 5-2, tdf#101363Eike Rathke
See http://tinderbox.libreoffice.org/cgi-bin/gunzip.cgi?tree=libreoffice-5-2&brief-log=1480964401.32227 (as long as it is there) Change-Id: If119a19e2f5dbe53298f0b30b5749997d99bf884
2016-12-05unwind sc RID_STYLEFAMILY_IMAGELIST imagelistCaolán McNamara
Change-Id: I22bc4a615295bf43110633e22b5884b511777c2b
2016-12-05convert FSysStyle to o3tl::typed_flagsNoel Grandin
Change-Id: I58a63a0e6f619442f21827064644ecd8ca57b8ff
2016-12-05convert DecodeMechanism to scoped enumNoel Grandin
Change-Id: I5c56634b1bca8e37fa73d02d2428645301b6c547
2016-12-05convert INetURLObject::EncodeMechanism to scoped enumNoel Grandin
Change-Id: I50ea17c7779c7b5cacddf548f1773fd7d6c8bade
2016-12-05tdf#91475 Fix column width during .xlsx exportBartosz Kosiorek
With commit 16726a1b37df8bdcae02b3c7699df814977222bd the new import algorithm was introduced. Unfortunately it looks like that some specific column width are improved, but for other widths it is worse. More information is available at: https://bugs.documentfoundation.org/show_bug.cgi?id=91475#c29 In this commit I added unit tests which prooves proper working of old algorithm and I have switched to old algorithm. Unit test which was done: 1. After resave .xlsx file, the column width values did not change 2. After export .ods to .xlsx displayed column width did not change 3. After save .xlsx to .ods displayed column width did not change This commit resolve column width after exporting to .xlsx, and correctly preserve column width for LibreOffice. Change-Id: I26d074b203d08a4bf4e9e31e52dbfd7ca7d3beb1 Reviewed-on: https://gerrit.libreoffice.org/27943 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-12-05loplugin:unnecessaryoverride (dtors) in scStephan Bergmann
Change-Id: Ifc44a22738cbd0ebbd81fae5caf1d9792e7746cf
2016-12-03Calc test - Financial and Logical functions. move to new directoryZdeněk Crhonek
Change-Id: Ie94c190f53904372aebfa15749b65c807052fcc7 Reviewed-on: https://gerrit.libreoffice.org/31589 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-12-03Calc functions tests - move datetime functions to new directoryZdeněk Crhonek
Change-Id: I5b2c9455da5f700d0c4da59ee3d48e5aba486a55 Reviewed-on: https://gerrit.libreoffice.org/31583 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-12-03sc tests files - move array functions to the new directoryZdeněk Crhonek
Change-Id: Ia701f2b0a3c21e19b2de95c8012cc5a37ed88359 Reviewed-on: https://gerrit.libreoffice.org/31580 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-12-03Remove unnecessary indirections.Kohei Yoshida
Especially in the oox code there are many... Change-Id: I16915cc207c274e5bcdb5d1f4f8708db5a0479a1 Reviewed-on: https://gerrit.libreoffice.org/31578 Reviewed-by: Kohei Yoshida <libreoffice@kohei.us> Tested-by: Kohei Yoshida <libreoffice@kohei.us>
generated by cgit (git 2.34.1) at 2025-02-07 14:05:52 +0000