summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)Author
2015-01-10only delete cell content for CELLTYPE_NONE, fdo#88200Markus Mohrhard
Change-Id: I43463b56cabfea4c9ee2b98445f7fb522221197d
2015-01-10sc: fix use-after-free race in ScCellRangesBaseMichael Stahl
Probably 03cca068ed901d1862c440a6f414d17609785974 was not sufficient, because the ~ScCellRangesBase may access a deleted ScDocument after the early return. READ of size 8 at 0x61b000191cb0 thread T7 (cppu_threadpool) #0 0x2b3c8fd7c8b3 in ScDocument::RemoveUnoObject(SfxListener&) sc/source/core/data/documen3.cxx:863:9 #1 0x2b3c94517824 in ScCellRangesBase::~ScCellRangesBase() sc/source/ui/unoobj/cellsuno.cxx:1467:9 #2 0x2b3c9459cf98 in ScCellRangeObj::~ScCellRangeObj() sc/source/ui/unoobj/cellsuno.cxx:4786:1 #3 0x2b3c945eca28 in ScCellObj::~ScCellObj() sc/source/ui/unoobj/cellsuno.cxx:6088:1 #4 0x2b3c945ecef1 in ScCellObj::~ScCellObj() sc/source/ui/unoobj/cellsuno.cxx:6087:1 #5 0x2b3c945ed093 in non-virtual thunk to ScCellObj::~ScCellObj() sc/source/ui/unoobj/cellsuno.cxx:6088:1 #6 0x2b3c56cb35ec in cppu::OWeakObject::release() cppuhelper/source/weak.cxx:205:9 #7 0x2b3c94523d63 in ScCellRangesBase::release() sc/source/ui/unoobj/cellsuno.cxx:1772:5 #8 0x2b3c945a77ec in ScCellRangeObj::release() sc/source/ui/unoobj/cellsuno.cxx:4835:5 #9 0x2b3c945f842c in ScCellObj::release() sc/source/ui/unoobj/cellsuno.cxx:6128:5 #10 0x2b3c945fb953 in non-virtual thunk to ScCellObj::release() sc/source/ui/unoobj/cellsuno.cxx:6129:1 #11 0x2b3c7f305faa in bridges::cpp_uno::shared::freeUnoInterfaceProxy(_uno_ExtEnvironment*, void*) bridges/source/cpp_uno/shared/unointerfaceproxy.cxx:42:5 freed by thread T14 (cppu_threadpool) here: #0 0x43436b in operator delete(void*) (/data/lo/build_clang/instdir/program/soffice.bin+0x43436b) #1 0x2b3c9382462e in ScDocShell::~ScDocShell() sc/source/ui/docshell/docsh.cxx:2722:1 #2 0x2b3c93824d46 in virtual thunk to ScDocShell::~ScDocShell() sc/source/ui/docshell/docsh.cxx:2755:1 #3 0x2b3c58e2058a in SvRefBase::ReleaseRef() include/tools/ref.hxx:194:29 #4 0x2b3c58e12726 in tools::SvRef<SfxObjectShell>::~SvRef() include/tools/ref.hxx:52:24 #5 0x2b3c5a8a8f99 in IMPL_SfxBaseModel_DataContainer::~IMPL_SfxBaseModel_DataContainer() sfx2/source/doc/sfxbasemodel.cxx:247:5 #6 0x2b3c5a8a9141 in IMPL_SfxBaseModel_DataContainer::~IMPL_SfxBaseModel_DataContainer() sfx2/source/doc/sfxbasemodel.cxx:246:5 #7 0x2b3c5a7b1905 in SfxBaseModel::dispose() sfx2/source/doc/sfxbasemodel.cxx:795:5 #8 0x2b3c5a7c8146 in SfxBaseModel::close(unsigned char) sfx2/source/doc/sfxbasemodel.cxx:1418:5 Change-Id: Ia041dc6596d1b0b6b979a20fa93e1490c657e15b
2015-01-09Resolves: fdo#85617 always store fully encoded external document nameEike Rathke
Also OOXML calls these API functions, this is the central place to handle it.
2015-01-09do not drop entire external reference, fdo#85617 relatedEike Rathke
If there are no matching tab names for a FileId, preserve at least the known reference parts. In case of 2D references the sheet name is in the token if for example read from .xlsx, only for 3D references the second sheet name would be needed. The underlying makeExternalRefStr() and its subroutines handle the missing tabname elements gracefully. Still this situation is worth an assertion.
2015-01-09write externalLink Relationship Target IURI encoded, fdo#85617 relatedEike Rathke
Change-Id: I3df065af8e4ef44734f468fd455c3b7c93d7fbc6
2015-01-09Revert "NO_DECODE breaks non-ascii urls, fdo#85617"Eike Rathke
This reverts commit 808b0bf831d4a4fdb60c01865d0a7dd36cf9d521. This is not the right fix, it cures a symptom but probably will break other cases. See also my comment on https://gerrit.libreoffice.org/13670 Change-Id: I5bb661ba2bcbd387a69aacf08cb13b503315c5b1
2015-01-09fdo#85818: rename KumZinsZ to CumIpmtLaurent Charrière
Rename OcKumZinsZ to ocCumIpmt, SC_OPCODE_KUM_ZINS_Z to SC_OPCODE_IPMT, ScInterpreter::ScKumZinsZ() to ScInterpreter::ScCumIpmt(). Change-Id: I7a062374fa0dad375c9277ca7e1c23f6d6855013 Reviewed-on: https://gerrit.libreoffice.org/13816 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-01-09fdo#85818: rename Kapz to PpmtLaurent Charrière
Rename OcKapz to OcPpmt, SC_OPCODE_KAPZ to SC_OPCODE_PPMT ScInterpreter::ScKapz() to ScInterpreter::ScPpmt(). Change-Id: I5bc556e086970ea487e14b4663a9b3d2aaf9bb66 Reviewed-on: https://gerrit.libreoffice.org/13815 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-01-09fdo#85818: rename Kombin, Kombin2, Variationen, Variationen2Laurent Charrière
Rename OcKombin to OcCombin, SC_OPCODE_KOMBIN to SC_OPCODE_COMBIN, ScInterpreter::ScKombin() to ScInterpreter::ScCombin(), OpKombin to OpCombin. Rename OcKombin2 to OcCombinA, SC_OPCODE_KOMBIN_2 to SC_OPCODE_COMBIN_A, ScInterpreter::ScKombin2() to ScInterpreter::ScCombinA(), OpKombin2 to OpCombinA. Rename OcVariationen to OcPermut, SC_OPCODE_VARIATIONEN to SC_OPCODE_PERMUT, ScInterpreter::ScVariationen() to ScInterpreter::ScPermut(), OpVariationen to OpPermut. Rename OcVariationen2 to OcPermutationA, SC_OPCODE_VARIATIONEN_2 to SC_OPCODE_PERMUTATION_A, ScInterpreter::ScVariationen2() to ScInterpreter::ScPermutationA(), OpVariationen2 to OpPermutationA. Change-Id: I2efa01e9b160e98058879d08e2e2313284a5ec91 Reviewed-on: https://gerrit.libreoffice.org/13814 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-01-09fdo#85818: rename ZinsZ enum name, constant, function to IpmtLaurent Charrière
Rename OcZinsZ to OcIpmt, SC_OPCODE_ZINS_Z to SC_OPCODE_IPMT, ScInterpreter::ScZinsZ() to ScInterpreter::ScIpmt() Change-Id: I6ed671aff85b7d2ec06dd66cd7ec9390776008b1 Reviewed-on: https://gerrit.libreoffice.org/13813 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-01-09override the overloading of "overload" to decrease cognitive (over-)loadMichael Stahl
Change-Id: I4d0e1de89d0bbdbea23bc5a46bf75ae0ce4e2796
2015-01-09translate all remaining abuses of "ueberladen"Michael Stahl
It is scary how many barely educated C++ programmers can't tell their inclusion polymorphism from their ad-hoc polymorphism. Change-Id: Id4df7d168ba5257eff522a7f131c841c1ddcbccd
2015-01-08Revert "Don't assume that the ZOrder property of shapes is an enumeration"David Tardon
This reverts commit 66c7dbbf7dfba8cfab63f8d1df72ace87e5bf7ca. See https://gerrit.libreoffice.org/#/c/13554/ . Conflicts: include/xmloff/shapeexport.hxx reportdesign/source/filter/xml/xmlExport.cxx sc/source/filter/xml/xmlexprt.cxx xmloff/source/draw/shapeexport.cxx Change-Id: I14fed9ad043a756a9e2d390c76fa907c349c3a2e
2015-01-08Use a more boring value of piTor Lillqvist
Innovativeness is good but perhaps not for mathematical constants. Change-Id: Icef93802ce9123120c8527f3fa07e524b6e067d0
2015-01-08Bin obsolete conditional compilationTor Lillqvist
UNROLLING_FACTOR (or UNROLLING) has been defined since November 2013. No need to keep old code around inside ifdefs. We have this thing called version control. Change-Id: I1f10f205df95014f8c223bd7a8716757577eade0
2015-01-08Bin obsolete conditional compilationTor Lillqvist
USE_FMIN_FMAX has been defined a long time. There is no information in any comment or in the commit that introduced it why one would not want to use the OpenCL fmin() and fmax() built-in functions (intrinsics). Keeping such stuff in the source code (and in the generated OpenCL code) is pointless and just makes it harder to read. Change-Id: Ibc0b950c0f16872867eb5eff089b33b00cb95028
2015-01-08Bin obsolete conditional compilationTor Lillqvist
MD5_KERNEL has been defined always for a long time, and I don't see why we wouldn't want that functionality. Change-Id: I7ee220ac3354fb8e5f6556259147675847aab68d
2015-01-08Bin obsolete conditional compilationTor Lillqvist
NO_FALLBACK_TO_SWINTERP has been undefined for a long time. I doubt anybody knows any more what it means, and in what situations it might perhaps make sense to define it. Should it be a compile-time choice anyway, in that case, or a run-time one? What is a "TDD run"? Test-Driven Development? But we have our unit test mechanism for that. Change-Id: If3e21e958ebeb689a8aac8eb7393c02f7143401c
2015-01-08sc: ODF import of data pilot:Michael Stahl
Revert part of 8e417a8fed528034e946bd25e66ce346c1b5384d that looks unnecessary: this is used in ScXMLDataPilotMembersContext::CreateChildContext() which is below table:data-pilot-level which actually uses the data-pilot-member element, whereas the data-pilot-group element occurs below table:data-pilot-groups. Change-Id: I7a3183bd3dbfa98b3bdf5e581b700910025af965
2015-01-08brute-force find-and-remove of unused #define constants.Noel Grandin
Change-Id: I7223530ae37297a76654cd00cc1fedb56dbe3adb
2015-01-07This is not needed.Kohei Yoshida
Change-Id: I5efce14f275ebc3cb64f452591ef50ce39c19e19
2015-01-07coverity#1261766 Uninitialized pointer fieldCaolán McNamara
Change-Id: Ibc9f367a0fd845a647170bdfa2d44303e8048063
2015-01-07Resolves: fdo#87003 - Kill BOOST_FOREACHPieter Adriaensen
Conflicts: avmedia/source/framework/modeltools.cxx basic/source/sbx/sbxbase.cxx sd/source/filter/eppt/pptx-epptooxml.cxx svx/qa/unit/svdraw/test_SdrTextObject.cxx sw/qa/core/uwriter.cxx sw/source/core/doc/CntntIdxStore.cxx sw/source/core/doc/DocumentLinksAdministrationManager.cxx sw/source/core/doc/docnew.cxx sw/source/core/doc/gctable.cxx sw/source/core/doc/htmltbl.cxx sw/source/core/doc/sortopt.cxx sw/source/core/doc/tblcpy.cxx sw/source/core/doc/tblrwcl.cxx sw/source/core/docnode/ndcopy.cxx sw/source/core/docnode/ndtbl.cxx sw/source/core/docnode/ndtbl1.cxx sw/source/core/frmedt/tblsel.cxx sw/source/core/text/itratr.cxx sw/source/core/tox/ToxLinkProcessor.cxx sw/source/filter/xml/xmltble.cxx Change-Id: Id176d4e052c719c9afdf91ed450de84d8d2bc486 Reviewed-on: https://gerrit.libreoffice.org/13575 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-01-07glew depends on OpenCL, for tests tooDouglas Mencken
Change-Id: Ib591b4328589982cda762ce2b1a688345b1665b0 Reviewed-on: https://gerrit.libreoffice.org/13652 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-01-07Revert "Check number of cells referenced by group instead of group size"Tor Lillqvist
This reverts commit cc4dbc0c4613b169045341d1f02bc4c47a407fa0.
2015-01-07Revert "Let's try a higher limit"Tor Lillqvist
This reverts commit 13fca3c98df4722031902da3d443962bb9453542.
2015-01-07Let's try a higher limitTor Lillqvist
Probably the overhead in copmpiling an OpenCL kernel is relatively high, so require a larger data size for OpenCL to be used. Change-Id: I34a3ade98dbd10e7daeddf4a55cfdb2a49a8cf09
2015-01-07fdo#84938: convert STREAM_ #defines to 'enum class'Noel Grandin
Change-Id: Ibbf14c7e9a5c1883c1311d4c86f948f74f8e473e
2015-01-07fdo#84938: convert VCL_INPUT_ #defines to 'enum class'Noel Grandin
Change-Id: I155e45f58974a2b946c4a7703b350bcbfbad342e
2015-01-07UNO API test for conditional formatsMatúš Kukan
Change-Id: I45d4b9652f35174eaf59c8868d593764c2ef2ebf
2015-01-07fdo#82014: Remove old conditional formats when setting new one by UNO APIMatúš Kukan
Change-Id: I76488045eba281227124041da505e38c4c3d31c1
2015-01-07fix invalid string accessMarkus Mohrhard
Change-Id: I758ee4a53a80d89662bc081f435b01bc6f9c3087
2015-01-07fdo#85818: rename 'Zins' enum name, constant, function to RateLaurent Charrière
Rename OcZins to OcRate, SC_OPCODE_ZINS to SC_OPCODE_RATE, ScInterpreter::ScZins() to ScInterpreter::ScRate() (partial fix for fdo#85818, more constants remain to be renamed) Change-Id: Icd5d0df14f2583da7ebd0308dc660abd07f326a4 Reviewed-on: https://gerrit.libreoffice.org/13777 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2015-01-06Better fix for fdo#87558: Duplication in Last Used Functions sidebar listJulien Nabet
Advantage compared to previous fix: in sidebar, last used function is put at the top Still function from menu is sorted, the pb is we use InsertEntry, see 0 ImplEntryList::InsertEntry (this=0x32d0910, nPos=2147483647, pNewEntry=0x326f620, bSort=true) at /home/julien/compile-libreoffice/libreoffice/vcl/source/control/ilstbox.cxx:144 1 0x00002aaab1b2444e in ImplListBoxWindow::InsertEntry (this=0x3287358, nPos=2147483647, pNewEntry=0x326f620) at /home/julien/compile-libreoffice/libreoffice/vcl/source/control/ilstbox.cxx:750 2 0x00002aaab1b2a138 in ImplListBox::InsertEntry (this=0x3287100, nPos=2147483647, rStr="ACOT") at /home/julien/compile-libreoffice/libreoffice/vcl/source/control/ilstbox.cxx:2182 3 0x00002aaab1b47d51 in ListBox::InsertEntry (this=0x32e9ca0, rStr="ACOT", nPos=2147483647) at /home/julien/compile-libreoffice/libreoffice/vcl/source/control/lstbox.cxx:1001 4 0x00002aaad0c05d84 in formula::FuncPage::UpdateFunctionList (this=0x3217110) at /home/julien/compile-libreoffice/libreoffice/formula/source/ui/dlg/funcpage.cxx:153 should we create a new InsertEntry to force bSort=false? Change-Id: Iba1b020aeea09951dead30f6781b24993aac98e0 Reviewed-on: https://gerrit.libreoffice.org/13725 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2015-01-06fdo#84938: convert CTRL_STATE_ #defines to 'enum class'Noel Grandin
Change-Id: I1451180d258315a310a048b27510b4b58fa9145c
2015-01-06fdo#84938: convert SEF_EXPORT_ #defines to 'enum class'Noel Grandin
Change-Id: I7165d0f1b6b4af4de5e5b39a21f36d726a1b0e30
2015-01-06fdo#84938: convert EXPORT_ #defines to 'enum class'Noel Grandin
Change-Id: I2ed239fa073b5fa8fb56c1af9d4b0bac89acfacf
2015-01-06fdo#84938: convert XML_EXPORT_FLAG_ to 'enum class'Noel Grandin
Change-Id: I43d778e0eee19a56ea37898ec1c4309d3407775e
2015-01-06fdo#84938: convert IMPORT_ constants to 'enum class'Noel Grandin
Change-Id: Idaa8f07c62b3ba93c27ca5fe286720254baac10d
2015-01-05Extend the Calc UNO API for the conditions whether to use OpenCL for a formulaTor Lillqvist
Setters/getters for the flag whether to restrict OpenCL to formulas that use a subset of opcodes, and the lower limit on number of cells a fomula should refer to in order for OpenCL to be considered. Change-Id: Ifeb11d4e4003f13e392fe03f1ce2f89147f46e38
2015-01-05sc-calcoptionsdlg.hxx: add definition guards (HAVE_FEATURE_OPENCL)Douglas Mencken
fixes "error: 'OpenCLConfig' does not name a type" when building without OpenCL support Change-Id: I21b05ca2ea5b197029af0de9b049a3a14b00f714 Reviewed-on: https://gerrit.libreoffice.org/13667 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-01-05Some loplugin:revisibility clean-upStephan Bergmann
Stumbled across such redundant visibility re-specifications when looking at the odd case of cppu_unsatisfied_iquery_msg declared CPPU_DLLPUBLIC in cppu/source/cppu/cppu_opt.cxx and used in inline code in include/com/sun/star/uno/Reference.hxx with only a declaration lacking CPPU_DLLPUBLIC visible, and wondering how that actually works on Windows. However, this plugin is probably not worth it being run all the time, so committing it to compilerplugins/clang/store/. Change-Id: Ibc3c4e7499213de1b419ce7eb85455cb832e1510
2015-01-05fdo#84938: replace NUMBERFORMAT_INT_ constants with 'enum class'Noel Grandin
Change-Id: I9c67de31f5571b282adc132d973b79bccb35fdc9
2015-01-05loplugin:unreffunStephan Bergmann
class OptionString unused since e224c9cb929cd744674b5d4d265cfb4680c82a2b "Refactor OpenCL settings dialog" Change-Id: I14e6adebaa7ea9d4e733b65ef4ca90e6fe6dbce2
2015-01-05fdo#67343 Arrange Help button in a secondary groupAdolfo Jayme Barrientos
This helps de-clutter action button groups and eases visual scanning. This patch also contains little layout tweaks where needed to separate the Help button from its neighbors when the dialog is too small. Change-Id: I56aafdaf2a5351bd7bcb4db693e520fd5c5166ce Reviewed-on: https://gerrit.libreoffice.org/13427 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-01-05Refactor OpenCL settings dialogOlivier Hallot
Convert listbox entries into independent widgets Some code left as the dialog and the settings are been worked ATM. Add help button (fdo#86637) HIG-ification of widgets Change-Id: Ieef1abb0502171e7f46695f40445af6cfa059a04 Reviewed-on: https://gerrit.libreoffice.org/13703 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-01-05Resolves fdo#87863: Calc tooltip text for hyperlink wrong on OSXJulien Nabet
I copied pasted the Writer way, with "follow" and "link" instead of "open" and "hyperlink" There are still the management of ":" + space (which could be different according to i10n) Change-Id: Ic8516c667b1882030d527add228a98e1081f608f Reviewed-on: https://gerrit.libreoffice.org/13712 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-01-05Resolves: fdo#87003 Kill BOOST_FOREACH on masterNathan Yee
use C++11s range-based for() loops instead Conflicts: sd/source/filter/eppt/pptx-epptooxml.cxx Change-Id: I0868eb345932c05b7e40b087035da252b99bf0b9 Reviewed-on: https://gerrit.libreoffice.org/13714 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-01-05java: unnecessary importsNoel Grandin
found by CodePro Change-Id: If1b75e43f81d70984422e437147048a491395b66
2015-01-04boost::unordered_set->std::unordered_setCaolán McNamara
Change-Id: I0a8ecc3aa26ffc56f216a6a0e078e158b03a4a02
generated by cgit (git 2.34.1) at 2025-03-06 13:07:55 +0000